159560 2016-07-08 09:18:37 -0700 Regression(r201805): Crash with <use> resource that has Vary header 2016-07-08 10:12:32 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned beidson cdumez commit-queue japhet webkit-bug-importer oldest_to_newest 1209129 0 koivisto 2016-07-08 09:18:37 -0700 0 com.apple.WebCore 0x1075573b9 WebCore::FrameLoader::outgoingReferrer() const + 9 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/loader/FrameLoader.cpp:927) 1 com.apple.WebCore 0x10780be84 WebCore::addAdditionalRequestHeadersToRequest(WebCore::ResourceRequest&, WebCore::CachedResourceLoader const&) + 756 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/loader/cache/CachedResource.cpp:196) 2 com.apple.WebCore 0x10780cd7b WebCore::CachedResource::varyHeaderValuesMatch(WebCore::ResourceRequest const&, WebCore::CachedResourceLoader const&) + 555 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/loader/cache/CachedResource.cpp:783) 3 com.apple.WebCore 0x10780fb5f WebCore::CachedResourceLoader::determineRevalidationPolicy(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&, WebCore::CachedResource*) const + 111 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/loader/cache/CachedResourceLoader.cpp:756) 4 com.apple.WebCore 0x10751a28b WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&) + 2171 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/loader/cache/CachedResourceLoader.cpp:606) 5 com.apple.WebCore 0x10780ee15 WebCore::CachedResourceLoader::requestSVGDocument(WebCore::CachedResourceRequest&) + 37 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/loader/cache/CachedResourceLoader.cpp:263) 6 com.apple.WebCore 0x1085079fa WebCore::SVGUseElement::updateExternalDocument() + 1402 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/svg/SVGUseElement.cpp:575) 7 com.apple.WebCore 0x108507430 WebCore::SVGUseElement::insertedInto(WebCore::ContainerNode&) + 80 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/svg/SVGUseElement.cpp:110) 8 com.apple.WebCore 0x10786221a WebCore::notifyNodeInsertedIntoDocument(WebCore::ContainerNode&, WebCore::Node&, WTF::Vector<WTF::Ref<WebCore::Node>, 11ul, WTF::CrashOnOverflow, 16ul>&) + 42 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.37/dom/ContainerNodeAlgorithms.cpp:72) 1209130 1 koivisto 2016-07-08 09:18:53 -0700 <rdar://problem/27034208> 1209138 2 283170 koivisto 2016-07-08 09:29:27 -0700 Created attachment 283170 Patch 1209142 3 283170 cdumez 2016-07-08 09:31:56 -0700 Comment on attachment 283170 Patch r=me 1209174 4 koivisto 2016-07-08 10:12:32 -0700 https://trac.webkit.org/r202985 283170 2016-07-08 09:29:27 -0700 2016-07-08 09:31:56 -0700 Patch vary-null-frame.patch text/plain 6570 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjk4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTA3LTA4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMDE4MDUp OiBDcmFzaCB3aXRoIDx1c2U+IHJlc291cmNlIHRoYXQgaGFzIFZhcnkgaGVhZGVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1NjAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI3MDM0MjA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluIHNvbWUgc2l0dWF0aW9ucyAoU1ZHIDx1c2U+IGVsZW1lbnQg Zm9yIGV4YW1wbGUpIHdlIG1heSB0cnkgdG8gbG9hZCByZXNvdXJjZXMgZnJvbSBmcmFtZWxlc3Mg ZG9jdW1lbnRzLgorICAgICAgICBTdWNoIGxvYWRzIGFsd2F5cyBmYWlsLiBUaGUgbmV3IHZhcnkg aGVhZGVyIHZlcmlmaWNhdGlvbiBjb2RlIHBhdGggdHJpZWQgdG8gYWNjZXNzIHRoZSBmcmFtZSBl YXJsaWVyIHdpdGhvdXQKKyAgICAgICAgbnVsbCBjaGVjay4KKworICAgICAgICBUZXN0OiBodHRw L3Rlc3RzL2NhY2hlL3ZhcnktZnJhbWVsZXNzLWRvY3VtZW50Lmh0bWwKKworICAgICAgICAqIGxv YWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRS ZXNvdXJjZTo6ZmFpbEJlZm9yZVN0YXJ0aW5nKToKKyAgICAgICAgKFdlYkNvcmU6OmFkZEFkZGl0 aW9uYWxSZXF1ZXN0SGVhZGVyc1RvUmVxdWVzdCk6CisKKyAgICAgICAgICAgIE51bGwgY2hlY2sg ZnJhbWUuCisgICAgICAgICAgICBBbHNvIG1vdmUgdGhlIHJlc291cmNlIHR5cGUgY2hlY2sgaGVy ZSBzbyBhbGwgY2FsbGVycyBnZXQgdGhlIHNhbWUgYmVoYXZpb3IuCisKKyAgICAgICAgKFdlYkNv cmU6OkNhY2hlZFJlc291cmNlOjphZGRBZGRpdGlvbmFsUmVxdWVzdEhlYWRlcnMpOgorICAgICAg ICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2U6OmxvYWQpOgorICAgICAgICAoV2ViQ29yZTo6Q2Fj aGVkUmVzb3VyY2U6OnZhcnlIZWFkZXJWYWx1ZXNNYXRjaCk6CisKIDIwMTYtMDctMDggIE5hZWwg T3VlZHJhb2dvICA8bmFlbC5vdWVkcmFvZ29AY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIEV4ZWNT dGF0ZSBzaG91bGQgYmUgcGFzc2VkIGJ5IHJlZmVyZW5jZSBpbiBKUyBiaW5kaW5ncyBnZW5lcmF0 b3IgZm9yIGN1c3RvbSBjb25zdHJ1Y3RvcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAkocmV2aXNpb24gMjAyNzU5KQorKysgU291cmNl L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTgzLDEyICsxODMsMTggQEAgdm9pZCBDYWNoZWRSZXNvdXJjZTo6ZmFpbEJlZm9yZVN0YXJ0 aW5nKAogICAgIGVycm9yKENhY2hlZFJlc291cmNlOjpMb2FkRXJyb3IpOwogfQogCi1zdGF0aWMg dm9pZCBhZGRBZGRpdGlvbmFsUmVxdWVzdEhlYWRlcnNUb1JlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0 JiByZXF1ZXN0LCBjb25zdCBDYWNoZWRSZXNvdXJjZUxvYWRlciYgY2FjaGVkUmVzb3VyY2VMb2Fk ZXIpCitzdGF0aWMgdm9pZCBhZGRBZGRpdGlvbmFsUmVxdWVzdEhlYWRlcnNUb1JlcXVlc3QoUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBDYWNoZWRSZXNvdXJjZUxvYWRlciYgY2FjaGVk UmVzb3VyY2VMb2FkZXIsIENhY2hlZFJlc291cmNlOjpUeXBlIHR5cGUpCiB7CisgICAgaWYgKHR5 cGUgPT0gQ2FjaGVkUmVzb3VyY2U6Ok1haW5SZXNvdXJjZSkKKyAgICAgICAgcmV0dXJuOworICAg IC8vIEluIHNvbWUgY2FzZXMgd2UgbWF5IHRyeSB0byBsb2FkIHJlc291cmNlcyBpbiBmcmFtZWxl c3MgZG9jdW1lbnRzLiBTdWNoIGxvYWRzIGFsd2F5cyBmYWlsLgorICAgIC8vIEZJWE1FOiBXZSBz aG91bGRuJ3QgZ2V0IHRoaXMgZmFyLgorICAgIGlmICghY2FjaGVkUmVzb3VyY2VMb2FkZXIuZnJh bWUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gTm90ZTogV2Ugc2tpcCB0aGUgQ29udGVu dC1TZWN1cml0eS1Qb2xpY3kgY2hlY2sgaGVyZSBiZWNhdXNlIHdlIGNoZWNrCiAgICAgLy8gdGhl IENvbnRlbnQtU2VjdXJpdHktUG9saWN5IGF0IHRoZSBDYWNoZWRSZXNvdXJjZUxvYWRlciBsYXll ciBzbyB3ZSBjYW4KICAgICAvLyBoYW5kbGUgZGlmZmVyZW50IHJlc291cmNlIHR5cGVzIGRpZmZl cmVudGx5LgotCiAgICAgRnJhbWVMb2FkZXImIGZyYW1lTG9hZGVyID0gY2FjaGVkUmVzb3VyY2VM b2FkZXIuZnJhbWUoKS0+bG9hZGVyKCk7CiAgICAgU3RyaW5nIG91dGdvaW5nUmVmZXJyZXI7CiAg ICAgU3RyaW5nIG91dGdvaW5nT3JpZ2luOwpAQCAtMjEzLDcgKzIxOSw3IEBAIHN0YXRpYyB2b2lk IGFkZEFkZGl0aW9uYWxSZXF1ZXN0SGVhZGVyc1QKIAogdm9pZCBDYWNoZWRSZXNvdXJjZTo6YWRk QWRkaXRpb25hbFJlcXVlc3RIZWFkZXJzKENhY2hlZFJlc291cmNlTG9hZGVyJiBjYWNoZWRSZXNv dXJjZUxvYWRlcikKIHsKLSAgICBhZGRBZGRpdGlvbmFsUmVxdWVzdEhlYWRlcnNUb1JlcXVlc3Qo bV9yZXNvdXJjZVJlcXVlc3QsIGNhY2hlZFJlc291cmNlTG9hZGVyKTsKKyAgICBhZGRBZGRpdGlv bmFsUmVxdWVzdEhlYWRlcnNUb1JlcXVlc3QobV9yZXNvdXJjZVJlcXVlc3QsIGNhY2hlZFJlc291 cmNlTG9hZGVyLCB0eXBlKCkpOwogfQogCiB2b2lkIENhY2hlZFJlc291cmNlOjpsb2FkKENhY2hl ZFJlc291cmNlTG9hZGVyJiBjYWNoZWRSZXNvdXJjZUxvYWRlciwgY29uc3QgUmVzb3VyY2VMb2Fk ZXJPcHRpb25zJiBvcHRpb25zKQpAQCAtMjc1LDggKzI4MSw3IEBAIHZvaWQgQ2FjaGVkUmVzb3Vy Y2U6OmxvYWQoQ2FjaGVkUmVzb3VyY2UKICNlbmRpZgogICAgIG1fcmVzb3VyY2VSZXF1ZXN0LnNl dFByaW9yaXR5KGxvYWRQcmlvcml0eSgpKTsKIAotICAgIGlmICh0eXBlKCkgIT0gTWFpblJlc291 cmNlKQotICAgICAgICBhZGRBZGRpdGlvbmFsUmVxdWVzdEhlYWRlcnMoY2FjaGVkUmVzb3VyY2VM b2FkZXIpOworICAgIGFkZEFkZGl0aW9uYWxSZXF1ZXN0SGVhZGVycyhjYWNoZWRSZXNvdXJjZUxv YWRlcik7CiAKICAgICAvLyBGSVhNRTogSXQncyB1bmZvcnR1bmF0ZSB0aGF0IHRoZSBjYWNoZSBs YXllciBhbmQgYmVsb3cgZ2V0IHRvIGtub3cgYW55dGhpbmcgYWJvdXQgZnJhZ21lbnQgaWRlbnRp ZmllcnMuCiAgICAgLy8gV2Ugc2hvdWxkIGxvb2sgaW50byByZW1vdmluZyB0aGUgZXhwZWN0YXRp b24gb2YgdGhhdCBrbm93bGVkZ2UgZnJvbSB0aGUgcGxhdGZvcm0gbmV0d29yayBzdGFja3MuCkBA IC03ODAsNyArNzg1LDggQEAgYm9vbCBDYWNoZWRSZXNvdXJjZTo6dmFyeUhlYWRlclZhbHVlc01h dAogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIFJlc291cmNlUmVxdWVzdCByZXF1ZXN0V2l0 aEZ1bGxIZWFkZXJzKHJlcXVlc3QpOwotICAgIGFkZEFkZGl0aW9uYWxSZXF1ZXN0SGVhZGVyc1Rv UmVxdWVzdChyZXF1ZXN0V2l0aEZ1bGxIZWFkZXJzLCBjYWNoZWRSZXNvdXJjZUxvYWRlcik7CisK KyAgICBhZGRBZGRpdGlvbmFsUmVxdWVzdEhlYWRlcnNUb1JlcXVlc3QocmVxdWVzdFdpdGhGdWxs SGVhZGVycywgY2FjaGVkUmVzb3VyY2VMb2FkZXIsIHR5cGUoKSk7CiAKICAgICByZXR1cm4gdmVy aWZ5VmFyeWluZ1JlcXVlc3RIZWFkZXJzKG1fdmFyeWluZ0hlYWRlclZhbHVlcywgcmVxdWVzdFdp dGhGdWxsSGVhZGVycywgbV9zZXNzaW9uSUQpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNzU5 KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDctMDggIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAg ICAgIFJlZ3Jlc3Npb24ocjIwMTgwNSk6IENyYXNoIHdpdGggPHVzZT4gcmVzb3VyY2UgdGhhdCBo YXMgVmFyeSBoZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1OTU2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjcwMzQyMDg+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2Nh Y2hlL3Jlc291cmNlcy9zdmctZGVmcy12YXJ5LnBocDogQWRkZWQuCisgICAgICAgICogaHR0cC90 ZXN0cy9jYWNoZS92YXJ5LWZyYW1lbGVzcy1kb2N1bWVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGh0dHAvdGVzdHMvY2FjaGUvdmFyeS1mcmFtZWxlc3MtZG9jdW1lbnQuaHRtbDog QWRkZWQuCisKIDIwMTYtMDctMDEgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFJlbW92ZSBmYWlsdXJlIGV4cGVjdGF0aW9uIGZvciBtYXRobWwvcHJlc2VudGF0 aW9uL2J1Zzk3OTkwLmh0bWwgb24gaW9zLXNpbXVsYXRvcgpJbmRleDogTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9jYWNoZS92YXJ5LWZyYW1lbGVzcy1kb2N1bWVudC1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS92YXJ5LWZyYW1lbGVzcy1kb2N1 bWVudC1leHBlY3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9jYWNoZS92YXJ5LWZyYW1lbGVzcy1kb2N1bWVudC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLiAK SW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvdmFyeS1mcmFtZWxlc3MtZG9jdW1l bnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3Zhcnkt ZnJhbWVsZXNzLWRvY3VtZW50Lmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9jYWNoZS92YXJ5LWZyYW1lbGVzcy1kb2N1bWVudC5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMTkgQEAKKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKwordmFyIHN2Z0RvY3VtZW50U3RyaW5n ID0gJzxzdmc+PHVzZSB4PSI1MCIgeT0iMTAiIHhsaW5rOmhyZWY9InJlc291cmNlcy9zdmctZGVm cy12YXJ5LnBocCNjaXJjbGUiIC8+PC9zdmc+JzsKK2Z1bmN0aW9uIG1ha2VEb2N1bWVudCgpIHsK KyAgICB2YXIgZG9jID0gZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlSFRNTERvY3VtZW50 KCcnKTsKKyAgICBkb2Mub3BlbigpOworICAgIGRvYy53cml0ZShzdmdEb2N1bWVudFN0cmluZyk7 CisgICAgZG9jLmNsb3NlKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0i bWFrZURvY3VtZW50KCkiPgorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLgor PHNjcmlwdD4KK2RvY3VtZW50LndyaXRlKHN2Z0RvY3VtZW50U3RyaW5nKTsKKzwvc2NyaXB0PgpJ bmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvc3ZnLWRlZnMtdmFy eS5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJj ZXMvc3ZnLWRlZnMtdmFyeS5waHAJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9jYWNoZS9yZXNvdXJjZXMvc3ZnLWRlZnMtdmFyeS5waHAJKHdvcmtpbmcgY29weSkKQEAg LTAsMCArMSwxMiBAQAorPD9waHAKK2hlYWRlcigiQ29udGVudC1UeXBlOiBpbWFnZS9qcGciKTsK K2hlYWRlcigiVmFyeTogQ29va2llIik7CitoZWFkZXIoIkNhY2hlLUNvbnRyb2w6IG1heC1hZ2U9 MzE1MzYwMDAiKTsKKz8+Cis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIg eG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPgorPGRlZnM+Cis8ZyBp ZD0iY2lyY2xlIj4KKzxjaXJjbGUgc3R5bGU9ImZpbGw6Z3JlZW4iIHI9IjEwIi8+Cis8L2c+Cis8 L2RlZnM+Cis8L3N2Zz4K