159551 2016-07-08 03:52:44 -0700 REGRESSION(r202273): [GTK] Redirected X window is resized to the previous size on size allocate 2016-07-13 23:35:03 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue gustavo mcatanzaro mrobinson zan oldest_to_newest 1209043 0 cgarcia 2016-07-08 03:52:44 -0700 In r202273 I added webkitWebViewBaseResizeRedirectedWindow() helper to remove duplicated code in all places where we were resizing the redirected window to the current drawing area size. But on size allocate, we were updating the redirected window first, and then the drawing area, to ensure that when the drawing area notifies the web process the redirected window is already at the new size. This regression doesn't have any visual effect, because we are ensure the right size always before rendering, but there's a small extra resize in this case. 1209044 1 283133 cgarcia 2016-07-08 03:54:21 -0700 Created attachment 283133 Patch 1209045 2 commit-queue 2016-07-08 03:55:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1210890 3 cgarcia 2016-07-13 23:35:03 -0700 Committed r203215: <http://trac.webkit.org/changeset/203215> 283133 2016-07-08 03:54:21 -0700 2016-07-09 14:36:52 -0700 Patch wk2-redirected-window-resize.diff text/plain 2524 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZjllYTNkLi5iMTJkMjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTYtMDctMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjIwMjI3Myk6IFtHVEtdIFJlZGlyZWN0ZWQgWCB3aW5k b3cgaXMgcmVzaXplZCB0byB0aGUgcHJldmlvdXMgc2l6ZSBvbiBzaXplIGFsbG9jYXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1NTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjAyMjczIEkg YWRkZWQgd2Via2l0V2ViVmlld0Jhc2VSZXNpemVSZWRpcmVjdGVkV2luZG93KCkgaGVscGVyIHRv IHJlbW92ZSBkdXBsaWNhdGVkIGNvZGUgaW4gYWxsIHBsYWNlcworICAgICAgICB3aGVyZSB3ZSB3 ZXJlIHJlc2l6aW5nIHRoZSByZWRpcmVjdGVkIHdpbmRvdyB0byB0aGUgY3VycmVudCBkcmF3aW5n IGFyZWEgc2l6ZS4gQnV0IG9uIHNpemUgYWxsb2NhdGUsIHdlIHdlcmUKKyAgICAgICAgdXBkYXRp bmcgdGhlIHJlZGlyZWN0ZWQgd2luZG93IGZpcnN0LCBhbmQgdGhlbiB0aGUgZHJhd2luZyBhcmVh LCB0byBlbnN1cmUgdGhhdCB3aGVuIHRoZSBkcmF3aW5nIGFyZWEgbm90aWZpZXMKKyAgICAgICAg dGhlIHdlYiBwcm9jZXNzIHRoZSByZWRpcmVjdGVkIHdpbmRvdyBpcyBhbHJlYWR5IGF0IHRoZSBu ZXcgc2l6ZS4gVGhpcyByZWdyZXNzaW9uIGRvZXNuJ3QgaGF2ZSBhbnkgdmlzdWFsCisgICAgICAg IGVmZmVjdCwgYmVjYXVzZSB3ZSBhcmUgZW5zdXJlIHRoZSByaWdodCBzaXplIGFsd2F5cyBiZWZv cmUgcmVuZGVyaW5nLCBidXQgdGhlcmUncyBhIHNtYWxsIGV4dHJhIHJlc2l6ZSBpbiB0aGlzIGNh c2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6 CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVNpemVBbGxvY2F0ZSk6IFJlc2l6ZSB0aGUgcmVk aXJlY3RlZCB3aW5kb3cgYmVmb3JlIHVwZGF0aW5nIHRoZSBkcmF3aW5nIGFyZWEgc2l6ZS4KKwog MjAxNi0wNy0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS11bVGhyZWFkZWQgQ29tcG9zaXRvcl0gV2ViIHZpZXcgYmFja2dyb3VuZCBj b2xvcnMgZG9uJ3Qgd29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IGJjY2FlZDQuLmVmODQ4NGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHAKQEAgLTcyMCw4ICs3MjAsMTMgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jh c2VTaXplQWxsb2NhdGUoR3RrV2lkZ2V0KiB3aWRnZXQsIEd0a0FsbG9jYXRpb24qIGFsbG8KIAog CiAjaWYgVVNFKFJFRElSRUNURURfWENPTVBPU0lURV9XSU5ET1cpCi0gICAgaWYgKHByaXYtPnJl ZGlyZWN0ZWRXaW5kb3cgJiYgZHJhd2luZ0FyZWEtPmlzSW5BY2NlbGVyYXRlZENvbXBvc2l0aW5n TW9kZSgpKQotICAgICAgICB3ZWJraXRXZWJWaWV3QmFzZVJlc2l6ZVJlZGlyZWN0ZWRXaW5kb3co d2ViVmlld0Jhc2UpOworICAgIGlmIChwcml2LT5yZWRpcmVjdGVkV2luZG93ICYmIGRyYXdpbmdB cmVhLT5pc0luQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoKSkgeworICAgICAgICAvLyBXZSBk b24ndCB1c2Ugd2Via2l0V2ViVmlld0Jhc2VSZXNpemVSZWRpcmVjdGVkV2luZG93IGhlcmUsIGJl Y2F1c2Ugd2Ugd2FudCB0byB1cGRhdGUgdGhlCisgICAgICAgIC8vIHJlZGlyZWN0ZWQgd2luZG93 IHNpemUgYmVmb3JlIHRoZSBkcmF3aW5nIGFyZWEsIGJlY2F1c2Ugb24gcmVzaXplIHRoZSBkcmF3 aW5nIGFyZWEgc2VuZHMKKyAgICAgICAgLy8gdGhlIFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlIG1l c3NhZ2UgdG8gdGhlIHdlYiBwcm9jZXNzIGFuZCB3YWl0cyBmb3IgaXRzIHJlcGx5LiBXZSB3YW50 CisgICAgICAgIC8vIHRoZSB3ZWIgcHJvY2VzcyB0byB1c2UgdGhlIG5ldyB4d2luZG93IHNpemUg d2hlbiBVcGRhdGVCYWNraW5nU3RvcmVTdGF0ZSBtZXNzYWdlIGFycml2ZXMuCisgICAgICAgIHBy aXYtPnJlZGlyZWN0ZWRXaW5kb3ctPnJlc2l6ZSh2aWV3UmVjdC5zaXplKCkpOworICAgIH0KICNl bmRpZgogCiAgICAgZHJhd2luZ0FyZWEtPnNldFNpemUodmlld1JlY3Quc2l6ZSgpLCBJbnRTaXpl KCksIEludFNpemUoKSk7Cg==