159541 2016-07-07 20:05:59 -0700 [JSC] String.prototype[Symbol.iterator] needs a name 2016-07-07 21:10:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1208945 0 benjamin 2016-07-07 20:05:59 -0700 [JSC] String.prototype[Symbol.iterator] needs a name 1208946 1 283102 benjamin 2016-07-07 20:07:00 -0700 Created attachment 283102 Patch 1208952 2 283102 ysuzuki 2016-07-07 20:18:10 -0700 Comment on attachment 283102 Patch r=me, nice catch. 1208957 3 283102 benjamin 2016-07-07 20:50:11 -0700 Comment on attachment 283102 Patch Thanks for the review Yusuke. 1208958 4 283102 commit-queue 2016-07-07 21:10:38 -0700 Comment on attachment 283102 Patch Clearing flags on attachment: 283102 Committed r202956: <http://trac.webkit.org/changeset/202956> 1208959 5 commit-queue 2016-07-07 21:10:42 -0700 All reviewed patches have been landed. Closing bug. 283102 2016-07-07 20:07:00 -0700 2016-07-07 21:10:38 -0700 Patch bug-159541-20160707200626.patch text/plain 7083 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZTM5OGRjY2QxNDI2NDM3NGNmZmIzNjZkNmZjYWQ2ZTc1YWMyMjYwLi4yODkyMmNkYzkyYTc0MTU4 ODgyMDRmN2FjM2U2NGZmNDlkOWUwM2U1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNi0wNy0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CiAKKyAgICAgICAgW0pTQ10gU3RyaW5nLnByb3RvdHlwZVtTeW1ib2wuaXRlcmF0b3Jd IG5lZWRzIGEgbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU5NTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQSBtYW4gbmVlZHMgYSBuYW1lLgorICAgICAgICBTcGVjOiBodHRwczovL3RjMzkuZ2l0 aHViLmlvL2VjbWEyNjIvI3NlYy1zdHJpbmcucHJvdG90eXBlLUBAaXRlcmF0b3IKKworICAgICAg ICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6U3RyaW5nUHJv dG90eXBlOjpmaW5pc2hDcmVhdGlvbik6CisKKzIwMTYtMDctMDcgIEJlbmphbWluIFBvdWxhaW4g IDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCiAgICAgICAgIFtKU0NdIEFycmF5LnByb3RvdHlwZVtT eW1ib2wudW5zY29wYWJsZXNdIHNob3VsZCBoYXZlIHRoZSAiaW5jbHVkZXMiIHByb3BlcnR5CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1MDQKIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBl LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAK aW5kZXggOGRhNTllNDQxMmNhZGQyMGJhNDIzODEwNjY1ZGIyZjg5YTEyMTg5NS4uY2M2ZjE0OWU4 YzQzYjBmZTM3OTllN2Q5MjY4NGZhMGZlMTRlOTQ3NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCkBAIC0xNzQsMTAgKzE3NCwxMSBA QCB2b2lkIFN0cmluZ1Byb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtLCBKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0LCBKU1N0cgogICAgIEpTQ19OQVRJVkVfRlVOQ1RJT05fV0lUSE9V VF9UUkFOU0lUSU9OKCJlbmRzV2l0aCIsIHN0cmluZ1Byb3RvRnVuY0VuZHNXaXRoLCBEb250RW51 bSwgMSk7CiAgICAgSlNDX05BVElWRV9GVU5DVElPTl9XSVRIT1VUX1RSQU5TSVRJT04oImluY2x1 ZGVzIiwgc3RyaW5nUHJvdG9GdW5jSW5jbHVkZXMsIERvbnRFbnVtLCAxKTsKICAgICBKU0NfTkFU SVZFX0ZVTkNUSU9OX1dJVEhPVVRfVFJBTlNJVElPTigibm9ybWFsaXplIiwgc3RyaW5nUHJvdG9G dW5jTm9ybWFsaXplLCBEb250RW51bSwgMCk7Ci0gICAgSlNDX05BVElWRV9GVU5DVElPTl9XSVRI T1VUX1RSQU5TSVRJT04odm0ucHJvcGVydHlOYW1lcy0+aXRlcmF0b3JTeW1ib2wsIHN0cmluZ1By b3RvRnVuY0l0ZXJhdG9yLCBEb250RW51bSwgMCk7Ci0KICAgICBKU0NfTkFUSVZFX0lOVFJJTlNJ Q19GVU5DVElPTl9XSVRIT1VUX1RSQU5TSVRJT04odm0ucHJvcGVydHlOYW1lcy0+YnVpbHRpbk5h bWVzKCkuY2hhckNvZGVBdFByaXZhdGVOYW1lKCksIHN0cmluZ1Byb3RvRnVuY0NoYXJDb2RlQXQs IERvbnRFbnVtLCAxLCBDaGFyQ29kZUF0SW50cmluc2ljKTsKIAorICAgIEpTRnVuY3Rpb24qIGl0 ZXJhdG9yRnVuY3Rpb24gPSBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCwgMCwg QVNDSUlMaXRlcmFsKCJbU3ltYm9sLml0ZXJhdG9yXSIpLCBzdHJpbmdQcm90b0Z1bmNJdGVyYXRv ciwgTm9JbnRyaW5zaWMpOworICAgIHB1dERpcmVjdFdpdGhvdXRUcmFuc2l0aW9uKHZtLCB2bS5w cm9wZXJ0eU5hbWVzLT5pdGVyYXRvclN5bWJvbCwgaXRlcmF0b3JGdW5jdGlvbiwgRG9udEVudW0p OworCiAgICAgLy8gVGhlIGNvbnN0cnVjdG9yIHdpbGwgYmUgYWRkZWQgbGF0ZXIsIGFmdGVyIFN0 cmluZ0NvbnN0cnVjdG9yIGhhcyBiZWVuIGJ1aWx0CiAgICAgcHV0RGlyZWN0V2l0aG91dFRyYW5z aXRpb24odm0sIHZtLnByb3BlcnR5TmFtZXMtPmxlbmd0aCwganNOdW1iZXIoMCksIERvbnREZWxl dGUgfCBSZWFkT25seSB8IERvbnRFbnVtKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3NjgzNWExNDU5ZTFkYzI5OGQz YzYzYTM5ZDAzZWIzYWJhNWJkY2E4Li40MWNiN2Y5YWNlNWIwMGE4MWQ3ZmY2NTIwYmE0OWY2M2Iy NDRiODdlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTYtMDctMDcgIEJlbmphbWluIFBvdWxh aW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCisgICAgICAgIFtKU0NdIFN0cmluZy5wcm90b3R5 cGVbU3ltYm9sLml0ZXJhdG9yXSBuZWVkcyBhIG5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTU0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL3N0cmluZy1pdGVyYXRv ci5qczogQWRkZWQuCisgICAgICAgICoganMvc3RyaW5nLWl0ZXJhdG9yLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICoganMvc3RyaW5nLWl0ZXJhdG9yLmh0bWw6IEFkZGVkLgorCisyMDE2 LTA3LTA3ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKwogICAgICAg ICBbSlNDXSBBcnJheS5wcm90b3R5cGVbU3ltYm9sLnVuc2NvcGFibGVzXSBzaG91bGQgaGF2ZSB0 aGUgImluY2x1ZGVzIiBwcm9wZXJ0eQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU5NTA0CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3Njcmlw dC10ZXN0cy9zdHJpbmctaXRlcmF0b3IuanMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMv c3RyaW5nLWl0ZXJhdG9yLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjllZWQ5YjA3NjY1MTdlODY3OWNkMmU3NzU1 M2U2Njc2ZGU2NWE3NzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQt dGVzdHMvc3RyaW5nLWl0ZXJhdG9yLmpzCkBAIC0wLDAgKzEsNDEgQEAKKyJ1c2Ugc3RyaWN0Igor CitkZXNjcmlwdGlvbigiVmVyaWZ5IHRoZSB2YXJpb3VzIHByb3BlcnRpZXMgb2YgU3RyaW5nLnBy b3RvdHlwZVtTeW1ib2wuaXRlcmF0b3JdIik7CisKKworZGVidWcoIkl0ZXJhdG9yIG9iamVjdCBw cm9wZXJ0aWVzIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoInR5cGVvZiBTdHJpbmcucHJvdG90 eXBlW1N5bWJvbC5pdGVyYXRvcl0iLCAiZnVuY3Rpb24iKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmlu ZygiU3RyaW5nLnByb3RvdHlwZVtTeW1ib2wuaXRlcmF0b3JdLm5hbWUiLCAiW1N5bWJvbC5pdGVy YXRvcl0iKTsKK3Nob3VsZEJlKCJTdHJpbmcucHJvdG90eXBlW1N5bWJvbC5pdGVyYXRvcl0ubGVu Z3RoIiwgIjAiKTsKK3Nob3VsZEJlVHJ1ZSgiT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRv cihTdHJpbmcucHJvdG90eXBlLCBTeW1ib2wuaXRlcmF0b3IpLmNvbmZpZ3VyYWJsZSIpOworc2hv dWxkQmVGYWxzZSgiT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihTdHJpbmcucHJvdG90 eXBlLCBTeW1ib2wuaXRlcmF0b3IpLmVudW1lcmFibGUiKTsKK3Nob3VsZEJlVHJ1ZSgiT2JqZWN0 LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihTdHJpbmcucHJvdG90eXBlLCBTeW1ib2wuaXRlcmF0 b3IpLndyaXRhYmxlIik7CitzaG91bGRCZUZhbHNlKCJTdHJpbmcucHJvdG90eXBlW1N5bWJvbC5p dGVyYXRvcl0oKSA9PT0gU3RyaW5nLnByb3RvdHlwZVtTeW1ib2wuaXRlcmF0b3JdKCkiKTsKKwor ZGVidWcoIkl0ZXJhdGluZyBhIHNpbXBsZSBzdHJpbmcuIik7CitsZXQgaXRlcmF0b3IgPSAiV2Vi S2l0IltTeW1ib2wuaXRlcmF0b3JdKCk7CisKK2xldCBuZXh0ID0gaXRlcmF0b3IubmV4dCgpOwor c2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJuZXh0LnZhbHVlIiwgIlciKTsKK3Nob3VsZEJlRmFsc2Uo Im5leHQuZG9uZSIpOworbmV4dCA9IGl0ZXJhdG9yLm5leHQoKTsKK3Nob3VsZEJlRXF1YWxUb1N0 cmluZygibmV4dC52YWx1ZSIsICJlIik7CitzaG91bGRCZUZhbHNlKCJuZXh0LmRvbmUiKTsKK25l eHQgPSBpdGVyYXRvci5uZXh0KCk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoIm5leHQudmFsdWUi LCAiYiIpOworc2hvdWxkQmVGYWxzZSgibmV4dC5kb25lIik7CituZXh0ID0gaXRlcmF0b3IubmV4 dCgpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJuZXh0LnZhbHVlIiwgIksiKTsKK3Nob3VsZEJl RmFsc2UoIm5leHQuZG9uZSIpOworbmV4dCA9IGl0ZXJhdG9yLm5leHQoKTsKK3Nob3VsZEJlRXF1 YWxUb1N0cmluZygibmV4dC52YWx1ZSIsICJpIik7CitzaG91bGRCZUZhbHNlKCJuZXh0LmRvbmUi KTsKK25leHQgPSBpdGVyYXRvci5uZXh0KCk7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoIm5leHQu dmFsdWUiLCAidCIpOworc2hvdWxkQmVGYWxzZSgibmV4dC5kb25lIik7CituZXh0ID0gaXRlcmF0 b3IubmV4dCgpOworc2hvdWxkQmUoIm5leHQudmFsdWUiLCAidW5kZWZpbmVkIik7CitzaG91bGRC ZVRydWUoIm5leHQuZG9uZSIpOworbmV4dCA9IGl0ZXJhdG9yLm5leHQoKTsKK3Nob3VsZEJlKCJu ZXh0LnZhbHVlIiwgInVuZGVmaW5lZCIpOworc2hvdWxkQmVUcnVlKCJuZXh0LmRvbmUiKTsKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3N0cmluZy1pdGVyYXRvci1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9qcy9zdHJpbmctaXRlcmF0b3ItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhh ZTkzNGVhOWYxYWU1Y2RmMWQyMTk0M2RkMGI5YTMxM2U3NWMzZTUKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9qcy9zdHJpbmctaXRlcmF0b3ItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs MzQgQEAKK1ZlcmlmeSB0aGUgdmFyaW91cyBwcm9wZXJ0aWVzIG9mIFN0cmluZy5wcm90b3R5cGVb U3ltYm9sLml0ZXJhdG9yXQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworSXRlcmF0 b3Igb2JqZWN0IHByb3BlcnRpZXMKK1BBU1MgdHlwZW9mIFN0cmluZy5wcm90b3R5cGVbU3ltYm9s Lml0ZXJhdG9yXSBpcyAiZnVuY3Rpb24iCitQQVNTIFN0cmluZy5wcm90b3R5cGVbU3ltYm9sLml0 ZXJhdG9yXS5uYW1lIGlzICJbU3ltYm9sLml0ZXJhdG9yXSIKK1BBU1MgU3RyaW5nLnByb3RvdHlw ZVtTeW1ib2wuaXRlcmF0b3JdLmxlbmd0aCBpcyAwCitQQVNTIE9iamVjdC5nZXRPd25Qcm9wZXJ0 eURlc2NyaXB0b3IoU3RyaW5nLnByb3RvdHlwZSwgU3ltYm9sLml0ZXJhdG9yKS5jb25maWd1cmFi bGUgaXMgdHJ1ZQorUEFTUyBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKFN0cmluZy5w cm90b3R5cGUsIFN5bWJvbC5pdGVyYXRvcikuZW51bWVyYWJsZSBpcyBmYWxzZQorUEFTUyBPYmpl Y3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKFN0cmluZy5wcm90b3R5cGUsIFN5bWJvbC5pdGVy YXRvcikud3JpdGFibGUgaXMgdHJ1ZQorUEFTUyBTdHJpbmcucHJvdG90eXBlW1N5bWJvbC5pdGVy YXRvcl0oKSA9PT0gU3RyaW5nLnByb3RvdHlwZVtTeW1ib2wuaXRlcmF0b3JdKCkgaXMgZmFsc2UK K0l0ZXJhdGluZyBhIHNpbXBsZSBzdHJpbmcuCitQQVNTIG5leHQudmFsdWUgaXMgIlciCitQQVNT IG5leHQuZG9uZSBpcyBmYWxzZQorUEFTUyBuZXh0LnZhbHVlIGlzICJlIgorUEFTUyBuZXh0LmRv bmUgaXMgZmFsc2UKK1BBU1MgbmV4dC52YWx1ZSBpcyAiYiIKK1BBU1MgbmV4dC5kb25lIGlzIGZh bHNlCitQQVNTIG5leHQudmFsdWUgaXMgIksiCitQQVNTIG5leHQuZG9uZSBpcyBmYWxzZQorUEFT UyBuZXh0LnZhbHVlIGlzICJpIgorUEFTUyBuZXh0LmRvbmUgaXMgZmFsc2UKK1BBU1MgbmV4dC52 YWx1ZSBpcyAidCIKK1BBU1MgbmV4dC5kb25lIGlzIGZhbHNlCitQQVNTIG5leHQudmFsdWUgaXMg dW5kZWZpbmVkCitQQVNTIG5leHQuZG9uZSBpcyB0cnVlCitQQVNTIG5leHQudmFsdWUgaXMgdW5k ZWZpbmVkCitQQVNTIG5leHQuZG9uZSBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvc3Ry aW5nLWl0ZXJhdG9yLmh0bWwgYi9MYXlvdXRUZXN0cy9qcy9zdHJpbmctaXRlcmF0b3IuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4yNThmNjA5NDE4NzRlODg5NDMxNWExMmU0MGRmNGQyYWY3YmQ2M2RjCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvanMvc3RyaW5nLWl0ZXJhdG9yLmh0bWwKQEAgLTAs MCArMSwxMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9 Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvc3RyaW5nLWl0ZXJhdG9yLmpzIj48L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwv Ym9keT4KKzwvaHRtbD4K