159533 2016-07-07 15:59:50 -0700 REGRESSION (r202918): LayoutTest media/video-main-content-allow-then-deny.html is flaky, failing almost every time on El Capitan 2016-07-14 00:55:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159437 P2 Normal --- 1 ryanhaddad jer.noble ap commit-queue eric.carlson jer.noble jonlee oldest_to_newest 1208858 0 ryanhaddad 2016-07-07 15:59:50 -0700 LayoutTest media/video-main-content-allow-then-deny.html failing https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r202936%20(7445)/results.html --- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/video-main-content-allow-then-deny-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/video-main-content-allow-then-deny-actual.txt @@ -2,6 +2,6 @@ EVENT(canplaythrough) EVENT(playing) RUN(video.style.visibility = "hidden") -EVENT(pause) +FAIL: did not end fast enough END OF TEST 1208864 1 ryanhaddad 2016-07-07 16:02:29 -0700 Marked as failing in <https://trac.webkit.org/r202941> 1210158 2 ap 2016-07-12 14:35:11 -0700 It fails almost every time on El Capitan, and it sometimes fails on Yosemite. Looks like a regression from <http://trac.webkit.org/r202918>. Jer, could you please take a look? 1210220 3 jer.noble 2016-07-12 16:00:41 -0700 Sure thing. 1210269 4 jer.noble 2016-07-12 17:23:47 -0700 This test will time out if a pause event is not fired within 500ms of hiding the <video> element. For a first pass, lets see if increasing this timeout to 1s doesn't fix this issue. 1210273 5 jer.noble 2016-07-12 17:38:41 -0700 Nope, that's not the issue. The problem is that the MediaElementSession's m_isMainContent is (now) being modified outside the m_mainContentCheckTimer. Have a fix. 1210276 6 283478 jer.noble 2016-07-12 17:43:56 -0700 Created attachment 283478 Patch 1210924 7 283478 commit-queue 2016-07-14 00:55:10 -0700 Comment on attachment 283478 Patch Clearing flags on attachment: 283478 Committed r203219: <http://trac.webkit.org/changeset/203219> 1210925 8 commit-queue 2016-07-14 00:55:14 -0700 All reviewed patches have been landed. Closing bug. 283478 2016-07-12 17:43:56 -0700 2016-07-14 00:55:10 -0700 Patch bug-159533-20160712174311.patch text/plain 3469 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJhNmIzMGFmOTg0ZTll YTAxNWEyMmNkMGJiOGVkMjE4MjNhYzUxOS4uZWQ0NWJjNDgxNGI1N2EyNTQxN2QwNWY0YTUxYmM4 NGUxYzc5ZDEzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTEyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDI5 MTgpOiBMYXlvdXRUZXN0IG1lZGlhL3ZpZGVvLW1haW4tY29udGVudC1hbGxvdy10aGVuLWRlbnku aHRtbCBpcyBmbGFreSwgZmFpbGluZyBhbG1vc3QgZXZlcnkgdGltZSBvbiBFbCBDYXBpdGFuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1MzMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIHRoZSBj b250ZW50cyBvZiBtYWluQ29udGVudENoZWNrVGltZXJGaXJlZCgpIGludG8gdXBkYXRlSXNNYWlu Q29udGVudCgpIHNvIHRoYXQgdGhlCisgICAgICAgIHJlc3VsdHMgb2YgY2hhbmdpbmcgdGhlIG1f aXNNYWluQ29udGVudCBpdmFyIGFyZSBhY3RlZCB1cG9uIG5vIG1hdHRlciB3aHkgbV9pc01haW5D b250ZW50CisgICAgICAgIGNoYW5nZXMuCisKKyAgICAgICAgKiBodG1sL01lZGlhRWxlbWVudFNl c3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vzc2lvbjo6bWFpbkNv bnRlbnRDaGVja1RpbWVyRmlyZWQpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vz c2lvbjo6dXBkYXRlSXNNYWluQ29udGVudCk6CisKIDIwMTYtMDctMTEgIERlYW4gSmFja3NvbiAg PGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKDIwMjY5NCk6IEF1ZGlvIGFu ZCBWaWRlbyBwbGF5YmFjayBjb250cm9sczogQ2Fubm90IGZpbmQgYSBwb3NpdGlvbiBzbGlkZXIg dG8gYWRqdXN0IHBsYXliYWNrIHBvc2l0aW9uIHVzaW5nIFZPLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKaW5kZXggZTlkZGI0MWU1ZTUzNTE4NWI3MDNiMjll YTk3ZTdjYzE0ZmRjZTY4Yi4uYWY2MmY5NTk4MWQwMjg4YzZkZDU4ZDAxZTA2NzVjYjhhMGFlYjlm ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCkBAIC02 MDQsMTYgKzYwNCwxOCBAQCB2b2lkIE1lZGlhRWxlbWVudFNlc3Npb246Om1haW5Db250ZW50Q2hl Y2tUaW1lckZpcmVkKCkKICAgICBpZiAoIWhhc0JlaGF2aW9yUmVzdHJpY3Rpb24oT3ZlcnJpZGVV c2VyR2VzdHVyZVJlcXVpcmVtZW50Rm9yTWFpbkNvbnRlbnQpKQogICAgICAgICByZXR1cm47CiAK KyAgICB1cGRhdGVJc01haW5Db250ZW50KCk7Cit9CisKK2Jvb2wgTWVkaWFFbGVtZW50U2Vzc2lv bjo6dXBkYXRlSXNNYWluQ29udGVudCgpIGNvbnN0Cit7CiAgICAgYm9vbCB3YXNNYWluQ29udGVu dCA9IG1faXNNYWluQ29udGVudDsKICAgICBtX2lzTWFpbkNvbnRlbnQgPSBpc01haW5Db250ZW50 KG1fZWxlbWVudCk7CiAKICAgICBpZiAobV9pc01haW5Db250ZW50ICE9IHdhc01haW5Db250ZW50 KQogICAgICAgICBtX2VsZW1lbnQudXBkYXRlU2hvdWxkUGxheSgpOwotfQogCi1ib29sIE1lZGlh RWxlbWVudFNlc3Npb246OnVwZGF0ZUlzTWFpbkNvbnRlbnQoKSBjb25zdAotewotICAgIHJldHVy biBtX2lzTWFpbkNvbnRlbnQgPSBpc01haW5Db250ZW50KG1fZWxlbWVudCk7CisgICAgcmV0dXJu IG1faXNNYWluQ29udGVudDsKIH0KIAogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4NjgyYWY3NzZlZWIwM2ZkZjA0YThm YzE1NGI0ZmI3YTQyZWRkOGUuLmJkYzRhMDllMDZmYjI5MTA3NDRiMjg2NTI5M2EzOGRmZTE0YzQx MDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0wNy0xMiAgSmVyIE5vYmxlICA8amVyLm5v YmxlQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjAyOTE4KTogTGF5b3V0VGVz dCBtZWRpYS92aWRlby1tYWluLWNvbnRlbnQtYWxsb3ctdGhlbi1kZW55Lmh0bWwgaXMgZmxha3ks IGZhaWxpbmcgYWxtb3N0IGV2ZXJ5IHRpbWUgb24gRWwgQ2FwaXRhbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NTMzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9uczoKKwogMjAxNi0wNy0xMiAgSm9oYW4gSy4gSmVuc2VuICA8am9oYW5famVuc2VuQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFUjogQ29weSBhcyBjVVJMCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQ2YWRlZGZhMmU4MTNm MTFiOWIwZWU2NDQ1YmNkNmYwYjhlMTBhNTEuLmM3ODVjNDAyNDNjYjg3OTcxNWU0ZDI5YWYzYjA0 ZjI3N2IwMWVkNTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z CkBAIC0xNDM3LDggKzE0MzcsNiBAQCB3ZWJraXQub3JnL2IvMTU4NzQ3IFsgRWxDYXBpdGFuIF0g bWVkaWEvcmVzdG9yZS1mcm9tLXBhZ2UtY2FjaGUuaHRtbCBbIFBhc3MgRmFpbAogIyByZGFyOi8v cHJvYmxlbS8yNzE4NzAxMwogWyBTaWVycmErIF0gZmFzdC9ibG9jay9mbG9hdC9vdmVyaGFuZ2lu Zy10YWxsLWJsb2NrLmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE1OTUzMyBbIEVs Q2FwaXRhbisgXSBtZWRpYS92aWRlby1tYWluLWNvbnRlbnQtYWxsb3ctdGhlbi1kZW55Lmh0bWwg WyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE1MTI4NyBbIEVsQ2FwaXRhbiBdIG1lZGlhL2Nv bnRyb2xzL2lubGluZS1lbGVtZW50cy1kcm9wb2ZmLW9yZGVyLmh0bWwgWyBGYWlsdXJlIF0KIAog d2Via2l0Lm9yZy9iLzE1OTY4MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNo L2FwaS9yZXF1ZXN0L3JlcXVlc3QtY2FjaGUuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCg==