159528 2016-07-07 15:31:06 -0700 Use Array.forEach in Headers built-in constructor 2017-10-14 16:50:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159296 1 youennf youennf mark.lam oldest_to_newest 1208833 0 youennf 2016-07-07 15:31:06 -0700 Array.forEach can be used if it is shielded from public scripts. 1208837 1 283068 youennf 2016-07-07 15:33:52 -0700 Created attachment 283068 Patch 1209763 2 283068 mark.lam 2016-07-11 13:02:52 -0700 Comment on attachment 283068 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283068&action=review > Source/WebCore/Modules/fetch/FetchHeaders.js:44 > + @Array.prototype.@forEach.@call(headersInit, (header) => { Is this required by the spec? If not, is there a perf implication to this change? 1209770 3 youennf 2016-07-11 13:14:08 -0700 (In reply to comment #2) > Comment on attachment 283068 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283068&action=review > > > Source/WebCore/Modules/fetch/FetchHeaders.js:44 > > + @Array.prototype.@forEach.@call(headersInit, (header) => { > > Is this required by the spec? If not, is there a perf implication to this > change? No, it is not required and I do not think this makes any perf improvement since Array.forEach is using a for loop as well. This just makes the code smaller here. 1209813 4 283068 mark.lam 2016-07-11 14:39:46 -0700 Comment on attachment 283068 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283068&action=review >>> Source/WebCore/Modules/fetch/FetchHeaders.js:44 >>> + @Array.prototype.@forEach.@call(headersInit, (header) => { >> >> Is this required by the spec? If not, is there a perf implication to this change? > > No, it is not required and I do not think this makes any perf improvement since Array.forEach is using a for loop as well. > This just makes the code smaller here. My concern is that it makes the code slower because you're adding a call to forEach which is not free, and it doesn't appear to be that much smaller. But maybe it's not such a big deal here. Just thought I'd ask. 1209986 5 youennf 2016-07-12 03:00:20 -0700 Values iterator with a for-of loop seems a bit less expensive but it is still creating an iterator object. Maybe this is not worth it. 1360502 6 youennf 2017-10-14 16:50:45 -0700 We no longer use builtins for creating headers thanks to improvement in the binding generator. 283068 2016-07-07 15:33:52 -0700 2016-07-07 15:33:52 -0700 Patch bug-159528-20160708003317.patch text/plain 1970 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI3ZjZlYmVlYzJiNjQz ZTU0Zjg1NWEzZTQ2MTZjOGI4YjA4NDM4Zi4uYjZmODNhMTYxMzYwYzUxYjcwNzZkODI4N2JlMGZl NzFjZTAyYTBjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTA3LTA3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBVc2UgQXJyYXkuZm9yRWFj aCBpbiBIZWFkZXJzIGJ1aWx0LWluIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1MjgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAg ICAgKiBNb2R1bGVzL2ZldGNoL0ZldGNoSGVhZGVycy5qczoKKyAgICAgICAgKGluaXRpYWxpemVG ZXRjaEhlYWRlcnMpOiBNYWtpbmcgdXNlIG9mIEBBcnJheSBAZm9yRWFjaCBtZXRob2QuCisKKzIw MTYtMDctMDcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCiAgICAgICAgIERP TSB2YWx1ZSBpdGVyYWJsZSBpbnRlcmZhY2VzIHNob3VsZCB1c2UgQXJyYXkgcHJvdG90eXBlIG1l dGhvZHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 OTI5NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNoSGVh ZGVycy5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gvRmV0Y2hIZWFkZXJzLmpzCmlu ZGV4IDdjMzUwMTQxOTIxZWRlZDgwZmViZWFkOTczYzQ0NjljNzYzYmFmODYuLjMyNTM4NWM3NWMx ZDlhZjgyOTcyMGIyZTQ3NmZkODI2MGQ5YjE1YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvZmV0Y2gvRmV0Y2hIZWFkZXJzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvZmV0Y2gvRmV0Y2hIZWFkZXJzLmpzCkBAIC00MSwyMCArNDEsMTcgQEAgZnVuY3Rpb24gaW5p dGlhbGl6ZUZldGNoSGVhZGVycyhoZWFkZXJzSW5pdCkKICAgICB9CiAKICAgICBpZiAoQGlzQXJy YXkoaGVhZGVyc0luaXQpKSB7Ci0gICAgICAgIGZvciAobGV0IGkgPSAwOyBpIDwgaGVhZGVyc0lu aXQubGVuZ3RoOyBpKyspIHsKLSAgICAgICAgICAgIGxldCBoZWFkZXIgPSBoZWFkZXJzSW5pdFtp XTsKKyAgICAgICAgQEFycmF5LnByb3RvdHlwZS5AZm9yRWFjaC5AY2FsbChoZWFkZXJzSW5pdCwg KGhlYWRlcikgPT4gewogICAgICAgICAgICAgaWYgKGhlYWRlci5sZW5ndGggIT09IDIpCiAgICAg ICAgICAgICAgICAgdGhyb3cgbmV3IEBUeXBlRXJyb3IoImhlYWRlcnNJbml0IHNlcXVlbmNlIGl0 ZW1zIHNob3VsZCBjb250YWluIHR3byB2YWx1ZXMiKTsKICAgICAgICAgICAgIHRoaXMuQGFwcGVu ZEZyb21KUyhoZWFkZXJbMF0sIGhlYWRlclsxXSk7Ci0gICAgICAgIH0KKyAgICAgICAgfSk7CiAg ICAgICAgIHJldHVybiB0aGlzOwogICAgIH0KIAotICAgIGxldCBwcm9wZXJ0eU5hbWVzID0gQE9i amVjdC5AZ2V0T3duUHJvcGVydHlOYW1lcyhoZWFkZXJzSW5pdCk7Ci0gICAgZm9yIChsZXQgaSA9 IDA7IGkgPCBwcm9wZXJ0eU5hbWVzLmxlbmd0aDsgKytpKSB7Ci0gICAgICAgIGxldCBuYW1lID0g cHJvcGVydHlOYW1lc1tpXTsKKyAgICBAQXJyYXkucHJvdG90eXBlLkBmb3JFYWNoLkBjYWxsKEBP YmplY3QuQGdldE93blByb3BlcnR5TmFtZXMoaGVhZGVyc0luaXQpLCAobmFtZSkgPT4gewogICAg ICAgICB0aGlzLkBhcHBlbmRGcm9tSlMobmFtZSwgaGVhZGVyc0luaXRbbmFtZV0pOwotICAgIH0K KyAgICB9KTsKIAogICAgIHJldHVybiB0aGlzOwogfQo=