159526 2016-07-07 15:22:20 -0700 Fix crash when sending failure message to closed WebProcess 2016-09-01 12:59:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159739 https://bugs.webkit.org/show_bug.cgi?id=159691 https://bugs.webkit.org/show_bug.cgi?id=161494 P2 Normal --- 1 achristensen achristensen cdumez oldest_to_newest 1208825 0 achristensen 2016-07-07 15:22:20 -0700 Fix crash when sending failure message to closed WebProcess 1208827 1 283064 achristensen 2016-07-07 15:23:19 -0700 Created attachment 283064 Patch 1208830 2 283064 beidson 2016-07-07 15:28:24 -0700 Comment on attachment 283064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283064&action=review Please explain how this could be testable if we had HTTP tests in TestWebKitAPI > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:409 > + } else if (messageSenderConnection()) > + messageSenderConnection()->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0); } else if (auto* connection = messageSenderConnection()) connection->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0); 1208848 3 achristensen 2016-07-07 15:43:34 -0700 https://trac.webkit.org/changeset/202939 1208860 4 achristensen 2016-07-07 16:00:45 -0700 Followed up in https://trac.webkit.org/changeset/202940 1210734 5 283064 cdumez 2016-07-13 14:57:38 -0700 Comment on attachment 283064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283064&action=review >> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:409 >> + messageSenderConnection()->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0); > > } else if (auto* connection = messageSenderConnection()) > connection->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0); I don't think messageSenderConnection() can return null unless |this| has been destroyed. 1210741 6 283064 cdumez 2016-07-13 15:02:17 -0700 Comment on attachment 283064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283064&action=review >>> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:409 >>> + messageSenderConnection()->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0); >> >> } else if (auto* connection = messageSenderConnection()) >> connection->send(Messages::WebResourceLoader::DidFailResourceLoad(error), 0, 0); > > I don't think messageSenderConnection() can return null unless |this| has been destroyed. My bet is that we were getting here with a destroyed NetworkResourceLoader because of https://bugs.webkit.org/show_bug.cgi?id=159691 283064 2016-07-07 15:23:19 -0700 2016-07-07 15:28:24 -0700 Patch bug-159526-20160707152246.patch text/plain 1556 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjkzNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA3LTA3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNyYXNo IHdoZW4gc2VuZGluZyBmYWlsdXJlIG1lc3NhZ2UgdG8gY2xvc2VkIFdlYlByb2Nlc3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTUyNgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjY3NjcwMzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZEZhaWxM b2FkaW5nKToKKyAgICAgICAgQ2hlY2sgdG8gc2VlIGlmIHRoZXJlIGlzIGEgY29ubmVjdGlvbiBi ZWZvcmUgdXNpbmcgaXQgdG8gc2VuZCBhIG1lc3NhZ2UuCisgICAgICAgIFNvbWV0aW1lcyBpdCB3 YXMgbnVsbC4KKwogMjAxNi0wNy0wNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBTb2NrZXRQcm92aWRlciB0byBjcmVhdGUgV2ViU29j a2V0Q2hhbm5lbHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtS ZXNvdXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAkocmV2aXNpb24gMjAyODY5KQorKysgU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDA1LDggKzQwNSw4IEBAIHZvaWQgTmV0d29ya1Jlc291cmNlTG9hZGVy OjpkaWRGYWlsTG9hZGkKICAgICBpZiAoaXNTeW5jaHJvbm91cygpKSB7CiAgICAgICAgIG1fc3lu Y2hyb25vdXNMb2FkRGF0YS0+ZXJyb3IgPSBlcnJvcjsKICAgICAgICAgc2VuZFJlcGx5VG9TeW5j aHJvbm91c1JlcXVlc3QoKm1fc3luY2hyb25vdXNMb2FkRGF0YSwgbnVsbHB0cik7Ci0gICAgfSBl bHNlCi0gICAgICAgIHNlbmQoTWVzc2FnZXM6OldlYlJlc291cmNlTG9hZGVyOjpEaWRGYWlsUmVz b3VyY2VMb2FkKGVycm9yKSk7CisgICAgfSBlbHNlIGlmIChtZXNzYWdlU2VuZGVyQ29ubmVjdGlv bigpKQorICAgICAgICBtZXNzYWdlU2VuZGVyQ29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpX ZWJSZXNvdXJjZUxvYWRlcjo6RGlkRmFpbFJlc291cmNlTG9hZChlcnJvciksIDAsIDApOwogCiAg ICAgY2xlYW51cCgpOwogfQo=