<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>159524</bug_id>
          
          <creation_ts>2016-07-07 14:55:41 -0700</creation_ts>
          <short_desc>Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.</short_desc>
          <delta_ts>2016-07-11 10:06:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>159442</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>glenn</cc>
    
    <cc>keith_miller</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1208802</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-07-07 14:55:41 -0700</bug_when>
    <thetext>Let&apos;s force all tests to run with a smaller JS stack size than the default 4M.  This will help stack overflow tests to run faster.

The actual size to use is TBD.  Currently, it&apos;s looking like 384KB.  Continuing to test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1209277</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-07-08 15:03:02 -0700</bug_when>
    <thetext>I end up going with 1.5M and fixing some tests to behave better.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1209279</commentid>
    <comment_count>2</comment_count>
      <attachid>283202</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-07-08 15:08:53 -0700</bug_when>
    <thetext>Created attachment 283202
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1209280</commentid>
    <comment_count>3</comment_count>
      <attachid>283202</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2016-07-08 15:16:09 -0700</bug_when>
    <thetext>Comment on attachment 283202
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=283202&amp;action=review

r=me
Did you check 1.5M stack on all the platforms you can test on?

&gt; LayoutTests/js/script-tests/stack-overflow-arrity-catch.js:8
&gt;  function funcWith20Args(arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8,
&gt;                          arg9, arg10, arg11, arg12, arg13, arg14, arg15,
&gt; -                        arg16, arg17, arg18, arg19, arg20)
&gt; +                        arg16, arg17, arg18, arg19, arg20,
&gt; +                        arg21, arg22, arg23, arg24, arg25, arg26, arg27, arg28,
&gt; +                        arg29, arg30, arg31, arg32, arg33, arg34, arg35,
&gt; +                        arg36, arg37, arg38, arg39, arg40)

You should change the name of the function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1209285</commentid>
    <comment_count>4</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-07-08 15:34:08 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Comment on attachment 283202 [details]
&gt; proposed patch.
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=283202&amp;action=review
&gt; 
&gt; r=me
&gt; Did you check 1.5M stack on all the platforms you can test on?

I only tested on x86_64, but I think the 1.5M size should be reasonable.  I wasn&apos;t cutting it too close.  I&apos;ll wait till Monday morning before landing so that we can see what the bots say, and respond accordingly.
 
&gt; &gt; LayoutTests/js/script-tests/stack-overflow-arrity-catch.js:8
&gt; &gt;  function funcWith20Args(arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8,
&gt; &gt;                          arg9, arg10, arg11, arg12, arg13, arg14, arg15,
&gt; &gt; -                        arg16, arg17, arg18, arg19, arg20)
&gt; &gt; +                        arg16, arg17, arg18, arg19, arg20,
&gt; &gt; +                        arg21, arg22, arg23, arg24, arg25, arg26, arg27, arg28,
&gt; &gt; +                        arg29, arg30, arg31, arg32, arg33, arg34, arg35,
&gt; &gt; +                        arg36, arg37, arg38, arg39, arg40)
&gt; 
&gt; You should change the name of the function.

Fixed.  Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1209287</commentid>
    <comment_count>5</comment_count>
      <attachid>283206</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-07-08 15:36:12 -0700</bug_when>
    <thetext>Created attachment 283206
patch for landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1209688</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-07-11 10:06:15 -0700</bug_when>
    <thetext>Landed in r203067: &lt;http://trac.webkit.org/r203067&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>283202</attachid>
            <date>2016-07-08 15:08:53 -0700</date>
            <delta_ts>2016-07-08 15:36:12 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-159524.patch</filename>
            <type>text/plain</type>
            <size>5748</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIwMzAwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE2LTA3LTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor
ICAgICAgICBDaGFuZ2UgcnVuLXdlYmtpdC10ZXN0cy5weSBhbmQgcnVuLWpzYy1zdHJlc3MtdGVz
dHMgdG8gdXNlIGEgc21hbGxlciBKUyBzdGFjayBzaXplIGZvciB0ZXN0aW5nLgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NTI0CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yY2VkIHRlc3RzIHRvIHJ1
biB3aXRoIG9ubHkgYSAxLjVNIEpTIHN0YWNrIHNpemUgaW5zdGVhZCBvZiB0aGUgZGVmYXVsdCA0
TS4KKyAgICAgICAgQWxzbyBmaXhlZCB1cCBzb21lIHRlc3RzIHRvIGJlaGF2ZSBiZXR0ZXIgdG8g
d29yayB3aXRoIHRoaXMgbmV3IGxpbWl0LiAgVGhpcworICAgICAgICBzaG91bGQgbWFrZSBzdGFj
ayBvdmVyZmxvdyB0ZXN0cyBjb21wbGV0ZSBzb29uZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1
bi1qc2Mtc3RyZXNzLXRlc3RzOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl
c3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChtYWluKToKKwogMjAxNi0wNy0wOCAg
QW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvbnRlbnQgRmlsdGVy
aW5nXSBMb2FkIGJsb2NrZWQgcGFnZXMgbW9yZSBsaWtlIG90aGVyIGVycm9yIHBhZ2VzIGFyZSBs
b2FkZWQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNpb24gMjAyOTI5
KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2luZyBjb3B5KQpA
QCAtMSw2ICsxLDYgQEAKICMhL3Vzci9iaW4vZW52IHJ1YnkKIAotIyBDb3B5cmlnaHQgKEMpIDIw
MTMtMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykg
MjAxMy0yMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmli
dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0
CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp
bmcgY29uZGl0aW9ucwpAQCAtNDI2LDcgKzQyNiw4IEBAIGVuZAogJG51bUZhaWx1cmVzID0gMAog
JG51bVBhc3NlcyA9IDAKIAotQkFTRV9PUFRJT05TID0gWyItLXVzZUZUTEpJVD1mYWxzZSIsICIt
LXVzZUZ1bmN0aW9uRG90QXJndW1lbnRzPXRydWUiXQorIyBXZSBmb3JjZSBhbGwgdGVzdHMgdG8g
dXNlIGEgc21hbGxlciAoMS41TSkgc3RhY2sgc28gdGhhdCBzdGFjayBvdmVyZmxvdyB0ZXN0cyBj
YW4gcnVuIGZhc3Rlci4KK0JBU0VfT1BUSU9OUyA9IFsiLS11c2VGVExKSVQ9ZmFsc2UiLCAiLS11
c2VGdW5jdGlvbkRvdEFyZ3VtZW50cz10cnVlIiwgIi0tbWF4UGVyVGhyZWFkU3RhY2tVc2FnZT0x
NTcyODY0Il0KIEVBR0VSX09QVElPTlMgPSBbIi0tdGhyZXNob2xkRm9ySklUQWZ0ZXJXYXJtVXA9
MTAiLCAiLS10aHJlc2hvbGRGb3JKSVRTb29uPTEwIiwgIi0tdGhyZXNob2xkRm9yT3B0aW1pemVB
ZnRlcldhcm1VcD0yMCIsICItLXRocmVzaG9sZEZvck9wdGltaXplQWZ0ZXJMb25nV2FybVVwPTIw
IiwgIi0tdGhyZXNob2xkRm9yT3B0aW1pemVTb29uPTIwIiwgIi0tdGhyZXNob2xkRm9yRlRMT3B0
aW1pemVBZnRlcldhcm1VcD0yMCIsICItLXRocmVzaG9sZEZvckZUTE9wdGltaXplU29vbj0yMCIs
ICItLW1heGltdW1FdmFsQ2FjaGVhYmxlU291cmNlTGVuZ3RoPTE1MDAwMCJdCiBOT19DSklUX09Q
VElPTlMgPSBbIi0tdXNlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLXRocmVzaG9sZEZvckpJVEFm
dGVyV2FybVVwPTEwMCJdCiBGVExfT1BUSU9OUyA9IFsiLS11c2VGVExKSVQ9dHJ1ZSJdCkluZGV4
OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93
ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDIwMjkyOSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTEs
NiArMSw2IEBACiAjIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJl
c2VydmVkLgogIyBDb3B5cmlnaHQgKEMpIDIwMTAgR2Fib3IgUmFwY3NhbnlpIChyZ2Fib3JAaW5m
LnUtc3plZ2VkLmh1KSwgVW5pdmVyc2l0eSBvZiBTemVnZWQKLSMgQ29weXJpZ2h0IChDKSAyMDEx
IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDExLCAy
MDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24g
YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1v
ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u
ZGl0aW9ucyBhcmUKQEAgLTc0LDYgKzc0LDEwIEBAIGRlZiBtYWluKGFyZ3YsIHN0ZG91dCwgc3Rk
ZXJyKToKICAgICAgICAgcmV0dXJuIEVYQ0VQVElPTkFMX0VYSVRfU1RBVFVTCiAKICAgICB0cnk6
CisgICAgICAgICMgRm9yY2UgYWxsIHRlc3RzIHRvIHVzZSBhIHNtYWxsZXIgc3RhY2sgc28gdGhh
dCBzdGFjayBvdmVyZmxvdyB0ZXN0cyBjYW4gcnVuIGZhc3Rlci4KKyAgICAgICAgc3RhY2tTaXpl
SW5CeXRlcyA9IDEuNSAqIDEwMjQgKiAxMDI0CisgICAgICAgIG9wdGlvbnMuYWRkaXRpb25hbF9l
bnZfdmFyLmFwcGVuZCgnSlNDX21heFBlclRocmVhZFN0YWNrVXNhZ2U9JyArIHN0cihzdGFja1Np
emVJbkJ5dGVzKSkKKyAgICAgICAgb3B0aW9ucy5hZGRpdGlvbmFsX2Vudl92YXIuYXBwZW5kKCdf
X1hQQ19KU0NfbWF4UGVyVGhyZWFkU3RhY2tVc2FnZT0nICsgc3RyKHN0YWNrU2l6ZUluQnl0ZXMp
KQogICAgICAgICBydW5fZGV0YWlscyA9IHJ1bihwb3J0LCBvcHRpb25zLCBhcmdzLCBzdGRlcnIp
CiAgICAgICAgIGlmIHJ1bl9kZXRhaWxzLmV4aXRfY29kZSAhPSAtMSBhbmQgbm90IHJ1bl9kZXRh
aWxzLmluaXRpYWxfcmVzdWx0cy5rZXlib2FyZF9pbnRlcnJ1cHRlZDoKICAgICAgICAgICAgIGJv
dF9wcmludGVyID0gYnVpbGRib3RfcmVzdWx0cy5CdWlsZEJvdFByaW50ZXIoc3Rkb3V0LCBvcHRp
b25zLmRlYnVnX3J3dF9sb2dnaW5nKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyOTI5KQorKysgTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYt
MDctMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBy
dW4td2Via2l0LXRlc3RzLnB5IGFuZCBydW4tanNjLXN0cmVzcy10ZXN0cyB0byB1c2UgYSBzbWFs
bGVyIEpTIHN0YWNrIHNpemUgZm9yIHRlc3RpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL2RvbS9kZWVwLXJlY3Vyc2lvbi10ZXN0Lmh0bWw6
CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL3N0YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC5q
czoKKyAgICAgICAgKGZ1bmNXaXRoMjBBcmdzKToKKwogMjAxNi0wNy0wNyAgQ29tbWl0IFF1ZXVl
ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu
ZyBvdXQgcjIwMjkwNSBhbmQgcjIwMjkxMS4KSW5kZXg6IExheW91dFRlc3RzL2pzL2RvbS9kZWVw
LXJlY3Vyc2lvbi10ZXN0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvZG9tL2Rl
ZXAtcmVjdXJzaW9uLXRlc3QuaHRtbAkocmV2aXNpb24gMjAyOTI5KQorKysgTGF5b3V0VGVzdHMv
anMvZG9tL2RlZXAtcmVjdXJzaW9uLXRlc3QuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTMsNyAr
MTMsNyBAQAogICAgIH0KIAogICAgIHRyeSB7Ci0gICAgICAgIHNpbXBsZVJlY3Vyc2lvbigxNzQ3
Mik7CisgICAgICAgIHNpbXBsZVJlY3Vyc2lvbigxMDAwMCk7CiAgICAgfSBjYXRjaCAoZXgpIHsK
ICAgICAgICAgZGVidWcoIkZBSUw6ICIgKyBleCk7CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMv
anMvc2NyaXB0LXRlc3RzL3N0YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC5qcwo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvc3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNh
dGNoLmpzCShyZXZpc2lvbiAyMDI5MjkpCisrKyBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMv
c3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNhdGNoLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yLDkgKzIs
MTIgQEAgZGVzY3JpcHRpb24oJ1Rlc3QgdGhhdCBpZiBhbiBhcnJpdHkgY2hlYwogCiBmdW5jdGlv
biBmdW5jV2l0aDIwQXJncyhhcmcxLCBhcmcyLCBhcmczLCBhcmc0LCBhcmc1LCBhcmc2LCBhcmc3
LCBhcmc4LAogICAgICAgICAgICAgICAgICAgICAgICAgYXJnOSwgYXJnMTAsIGFyZzExLCBhcmcx
MiwgYXJnMTMsIGFyZzE0LCBhcmcxNSwKLSAgICAgICAgICAgICAgICAgICAgICAgIGFyZzE2LCBh
cmcxNywgYXJnMTgsIGFyZzE5LCBhcmcyMCkKKyAgICAgICAgICAgICAgICAgICAgICAgIGFyZzE2
LCBhcmcxNywgYXJnMTgsIGFyZzE5LCBhcmcyMCwKKyAgICAgICAgICAgICAgICAgICAgICAgIGFy
ZzIxLCBhcmcyMiwgYXJnMjMsIGFyZzI0LCBhcmcyNSwgYXJnMjYsIGFyZzI3LCBhcmcyOCwKKyAg
ICAgICAgICAgICAgICAgICAgICAgIGFyZzI5LCBhcmczMCwgYXJnMzEsIGFyZzMyLCBhcmczMywg
YXJnMzQsIGFyZzM1LAorICAgICAgICAgICAgICAgICAgICAgICAgYXJnMzYsIGFyZzM3LCBhcmcz
OCwgYXJnMzksIGFyZzQwKQogewotICAgIGRlYnVnKCJFUlJPUjogU2hvdWxkbid0IGFycml2ZSBp
biAyMCBhcmcgZnVuY3Rpb24hIik7CisgICAgZGVidWcoIkVSUk9SOiBTaG91bGRuJ3QgYXJyaXZl
IGluIDQwIGFyZyBmdW5jdGlvbiEiKTsKIH0KIAogdmFyIGdvdFJpZ2h0Q2F0Y2ggPSBmYWxzZSwg
Z290V3JvbmdDYXRjaDEgPSBmYWxzZSwgZ290V3JvbmdDYXRjaDIgPSBmYWxzZTsK
</data>
<flag name="review"
          id="306914"
          type_id="1"
          status="+"
          setter="msaboff"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>283206</attachid>
            <date>2016-07-08 15:36:12 -0700</date>
            <delta_ts>2016-07-08 15:36:24 -0700</delta_ts>
            <desc>patch for landing.</desc>
            <filename>bug-159524.patch</filename>
            <type>text/plain</type>
            <size>6454</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIwMzAwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE2LTA3LTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor
ICAgICAgICBDaGFuZ2UgcnVuLXdlYmtpdC10ZXN0cy5weSBhbmQgcnVuLWpzYy1zdHJlc3MtdGVz
dHMgdG8gdXNlIGEgc21hbGxlciBKUyBzdGFjayBzaXplIGZvciB0ZXN0aW5nLgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NTI0CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTWljaGFlbCBTYWJvZmYuCisKKyAgICAgICAgRm9yY2VkIHRlc3RzIHRvIHJ1
biB3aXRoIG9ubHkgYSAxLjVNIEpTIHN0YWNrIHNpemUgaW5zdGVhZCBvZiB0aGUgZGVmYXVsdCA0
TS4KKyAgICAgICAgQWxzbyBmaXhlZCB1cCBzb21lIHRlc3RzIHRvIGJlaGF2ZSBiZXR0ZXIgdG8g
d29yayB3aXRoIHRoaXMgbmV3IGxpbWl0LiAgVGhpcworICAgICAgICBzaG91bGQgbWFrZSBzdGFj
ayBvdmVyZmxvdyB0ZXN0cyBjb21wbGV0ZSBzb29uZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1
bi1qc2Mtc3RyZXNzLXRlc3RzOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl
c3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChtYWluKToKKwogMjAxNi0wNy0wOCAg
QW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvbnRlbnQgRmlsdGVy
aW5nXSBMb2FkIGJsb2NrZWQgcGFnZXMgbW9yZSBsaWtlIG90aGVyIGVycm9yIHBhZ2VzIGFyZSBs
b2FkZWQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNpb24gMjAyOTI5
KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2luZyBjb3B5KQpA
QCAtMSw2ICsxLDYgQEAKICMhL3Vzci9iaW4vZW52IHJ1YnkKIAotIyBDb3B5cmlnaHQgKEMpIDIw
MTMtMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykg
MjAxMy0yMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmli
dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0
CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp
bmcgY29uZGl0aW9ucwpAQCAtNDI2LDcgKzQyNiw4IEBAIGVuZAogJG51bUZhaWx1cmVzID0gMAog
JG51bVBhc3NlcyA9IDAKIAotQkFTRV9PUFRJT05TID0gWyItLXVzZUZUTEpJVD1mYWxzZSIsICIt
LXVzZUZ1bmN0aW9uRG90QXJndW1lbnRzPXRydWUiXQorIyBXZSBmb3JjZSBhbGwgdGVzdHMgdG8g
dXNlIGEgc21hbGxlciAoMS41TSkgc3RhY2sgc28gdGhhdCBzdGFjayBvdmVyZmxvdyB0ZXN0cyBj
YW4gcnVuIGZhc3Rlci4KK0JBU0VfT1BUSU9OUyA9IFsiLS11c2VGVExKSVQ9ZmFsc2UiLCAiLS11
c2VGdW5jdGlvbkRvdEFyZ3VtZW50cz10cnVlIiwgIi0tbWF4UGVyVGhyZWFkU3RhY2tVc2FnZT0x
NTcyODY0Il0KIEVBR0VSX09QVElPTlMgPSBbIi0tdGhyZXNob2xkRm9ySklUQWZ0ZXJXYXJtVXA9
MTAiLCAiLS10aHJlc2hvbGRGb3JKSVRTb29uPTEwIiwgIi0tdGhyZXNob2xkRm9yT3B0aW1pemVB
ZnRlcldhcm1VcD0yMCIsICItLXRocmVzaG9sZEZvck9wdGltaXplQWZ0ZXJMb25nV2FybVVwPTIw
IiwgIi0tdGhyZXNob2xkRm9yT3B0aW1pemVTb29uPTIwIiwgIi0tdGhyZXNob2xkRm9yRlRMT3B0
aW1pemVBZnRlcldhcm1VcD0yMCIsICItLXRocmVzaG9sZEZvckZUTE9wdGltaXplU29vbj0yMCIs
ICItLW1heGltdW1FdmFsQ2FjaGVhYmxlU291cmNlTGVuZ3RoPTE1MDAwMCJdCiBOT19DSklUX09Q
VElPTlMgPSBbIi0tdXNlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLXRocmVzaG9sZEZvckpJVEFm
dGVyV2FybVVwPTEwMCJdCiBGVExfT1BUSU9OUyA9IFsiLS11c2VGVExKSVQ9dHJ1ZSJdCkluZGV4
OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93
ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDIwMjkyOSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTEs
NiArMSw2IEBACiAjIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJl
c2VydmVkLgogIyBDb3B5cmlnaHQgKEMpIDIwMTAgR2Fib3IgUmFwY3NhbnlpIChyZ2Fib3JAaW5m
LnUtc3plZ2VkLmh1KSwgVW5pdmVyc2l0eSBvZiBTemVnZWQKLSMgQ29weXJpZ2h0IChDKSAyMDEx
IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDExLCAy
MDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24g
YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1v
ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u
ZGl0aW9ucyBhcmUKQEAgLTc0LDYgKzc0LDEwIEBAIGRlZiBtYWluKGFyZ3YsIHN0ZG91dCwgc3Rk
ZXJyKToKICAgICAgICAgcmV0dXJuIEVYQ0VQVElPTkFMX0VYSVRfU1RBVFVTCiAKICAgICB0cnk6
CisgICAgICAgICMgRm9yY2UgYWxsIHRlc3RzIHRvIHVzZSBhIHNtYWxsZXIgc3RhY2sgc28gdGhh
dCBzdGFjayBvdmVyZmxvdyB0ZXN0cyBjYW4gcnVuIGZhc3Rlci4KKyAgICAgICAgc3RhY2tTaXpl
SW5CeXRlcyA9IDEuNSAqIDEwMjQgKiAxMDI0CisgICAgICAgIG9wdGlvbnMuYWRkaXRpb25hbF9l
bnZfdmFyLmFwcGVuZCgnSlNDX21heFBlclRocmVhZFN0YWNrVXNhZ2U9JyArIHN0cihzdGFja1Np
emVJbkJ5dGVzKSkKKyAgICAgICAgb3B0aW9ucy5hZGRpdGlvbmFsX2Vudl92YXIuYXBwZW5kKCdf
X1hQQ19KU0NfbWF4UGVyVGhyZWFkU3RhY2tVc2FnZT0nICsgc3RyKHN0YWNrU2l6ZUluQnl0ZXMp
KQogICAgICAgICBydW5fZGV0YWlscyA9IHJ1bihwb3J0LCBvcHRpb25zLCBhcmdzLCBzdGRlcnIp
CiAgICAgICAgIGlmIHJ1bl9kZXRhaWxzLmV4aXRfY29kZSAhPSAtMSBhbmQgbm90IHJ1bl9kZXRh
aWxzLmluaXRpYWxfcmVzdWx0cy5rZXlib2FyZF9pbnRlcnJ1cHRlZDoKICAgICAgICAgICAgIGJv
dF9wcmludGVyID0gYnVpbGRib3RfcmVzdWx0cy5CdWlsZEJvdFByaW50ZXIoc3Rkb3V0LCBvcHRp
b25zLmRlYnVnX3J3dF9sb2dnaW5nKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyOTI5KQorKysgTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYt
MDctMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBy
dW4td2Via2l0LXRlc3RzLnB5IGFuZCBydW4tanNjLXN0cmVzcy10ZXN0cyB0byB1c2UgYSBzbWFs
bGVyIEpTIHN0YWNrIHNpemUgZm9yIHRlc3RpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1MjQKKworICAgICAgICBSZXZpZXdlZCBieSBNaWNo
YWVsIFNhYm9mZi4KKworICAgICAgICAqIGpzL2RvbS9kZWVwLXJlY3Vyc2lvbi10ZXN0Lmh0bWw6
CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL3N0YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC5q
czoKKyAgICAgICAgKGZ1bmNXaXRoMjBBcmdzKToKKwogMjAxNi0wNy0wNyAgQ29tbWl0IFF1ZXVl
ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu
ZyBvdXQgcjIwMjkwNSBhbmQgcjIwMjkxMS4KSW5kZXg6IExheW91dFRlc3RzL2pzL2RvbS9kZWVw
LXJlY3Vyc2lvbi10ZXN0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvZG9tL2Rl
ZXAtcmVjdXJzaW9uLXRlc3QuaHRtbAkocmV2aXNpb24gMjAyOTI5KQorKysgTGF5b3V0VGVzdHMv
anMvZG9tL2RlZXAtcmVjdXJzaW9uLXRlc3QuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTMsNyAr
MTMsNyBAQAogICAgIH0KIAogICAgIHRyeSB7Ci0gICAgICAgIHNpbXBsZVJlY3Vyc2lvbigxNzQ3
Mik7CisgICAgICAgIHNpbXBsZVJlY3Vyc2lvbigxMDAwMCk7CiAgICAgfSBjYXRjaCAoZXgpIHsK
ICAgICAgICAgZGVidWcoIkZBSUw6ICIgKyBleCk7CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMv
anMvc2NyaXB0LXRlc3RzL3N0YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaC5qcwo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvc3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNh
dGNoLmpzCShyZXZpc2lvbiAyMDI5MjkpCisrKyBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMv
c3RhY2stb3ZlcmZsb3ctYXJyaXR5LWNhdGNoLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDEwICsx
LDEzIEBACiBkZXNjcmlwdGlvbignVGVzdCB0aGF0IGlmIGFuIGFycml0eSBjaGVjayBjYXVzZXMg
YSBzdGFjayBvdmVyZmxvdywgdGhlIGV4Y2VwdGlvbiBnb2VzIHRvIHRoZSByaWdodCBjYXRjaCcp
OwogCi1mdW5jdGlvbiBmdW5jV2l0aDIwQXJncyhhcmcxLCBhcmcyLCBhcmczLCBhcmc0LCBhcmc1
LCBhcmc2LCBhcmc3LCBhcmc4LAorZnVuY3Rpb24gZnVuY1dpdGg0MEFyZ3MoYXJnMSwgYXJnMiwg
YXJnMywgYXJnNCwgYXJnNSwgYXJnNiwgYXJnNywgYXJnOCwKICAgICAgICAgICAgICAgICAgICAg
ICAgIGFyZzksIGFyZzEwLCBhcmcxMSwgYXJnMTIsIGFyZzEzLCBhcmcxNCwgYXJnMTUsCi0gICAg
ICAgICAgICAgICAgICAgICAgICBhcmcxNiwgYXJnMTcsIGFyZzE4LCBhcmcxOSwgYXJnMjApCisg
ICAgICAgICAgICAgICAgICAgICAgICBhcmcxNiwgYXJnMTcsIGFyZzE4LCBhcmcxOSwgYXJnMjAs
CisgICAgICAgICAgICAgICAgICAgICAgICBhcmcyMSwgYXJnMjIsIGFyZzIzLCBhcmcyNCwgYXJn
MjUsIGFyZzI2LCBhcmcyNywgYXJnMjgsCisgICAgICAgICAgICAgICAgICAgICAgICBhcmcyOSwg
YXJnMzAsIGFyZzMxLCBhcmczMiwgYXJnMzMsIGFyZzM0LCBhcmczNSwKKyAgICAgICAgICAgICAg
ICAgICAgICAgIGFyZzM2LCBhcmczNywgYXJnMzgsIGFyZzM5LCBhcmc0MCkKIHsKLSAgICBkZWJ1
ZygiRVJST1I6IFNob3VsZG4ndCBhcnJpdmUgaW4gMjAgYXJnIGZ1bmN0aW9uISIpOworICAgIGRl
YnVnKCJFUlJPUjogU2hvdWxkbid0IGFycml2ZSBpbiA0MCBhcmcgZnVuY3Rpb24hIik7CiB9CiAK
IHZhciBnb3RSaWdodENhdGNoID0gZmFsc2UsIGdvdFdyb25nQ2F0Y2gxID0gZmFsc2UsIGdvdFdy
b25nQ2F0Y2gyID0gZmFsc2U7CkBAIC0yMyw3ICsyNiw3IEBAIGZ1bmN0aW9uIHRlc3QxKCkKICAg
ICAgICAgfQogICAgICAgICAKICAgICAgICAgdHJ5IHsKLSAgICAgICAgICAgIGZ1bmNXaXRoMjBB
cmdzKDEsIDIsIDMpOworICAgICAgICAgICAgZnVuY1dpdGg0MEFyZ3MoMSwgMiwgMyk7CiAgICAg
ICAgIH0gY2F0Y2ggKGVycjIpIHsKICAgICAgICAgICAgIGdvdFJpZ2h0Q2F0Y2ggPSB0cnVlOwog
ICAgICAgICB9CkBAIC00NCw3ICs0Nyw3IEBAIGZ1bmN0aW9uIHRlc3QyKCkKICAgICAgICAgLy8g
U2hvdWxkIGdldCBoZXJlIGJlY2F1c2Ugb2Ygc3RhY2sgb3ZlcmZsb3csCiAgICAgICAgIC8vIG5v
dyBjYXVzZSBhIHN0YWNrIG92ZXJmbG93IGV4Y2VwdGlvbiBkdWUgdG8gYXJyaXR5IHByb2Nlc3Np
bmcKICAgICAgICAgdHJ5IHsKLSAgICAgICAgICAgIGZ1bmNXaXRoMjBBcmdzKDEsIDIsIDMsIDQs
IDUsIDYpOworICAgICAgICAgICAgZnVuY1dpdGg0MEFyZ3MoMSwgMiwgMywgNCwgNSwgNik7CiAg
ICAgICAgIH0gY2F0Y2ggKGVycjIpIHsKICAgICAgICAgICAgIGdvdFJpZ2h0Q2F0Y2ggPSB0cnVl
OwogICAgICAgICB9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>