159512 2016-07-07 08:30:42 -0700 [GTK] White page when loaded tab is visited until it's hovered when AC mode is always on 2016-07-21 00:36:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159803 Gtk P2 Normal --- 159455 154066 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro yoon zan oldest_to_newest 1208621 0 cgarcia 2016-07-07 08:30:42 -0700 This happens in ephy at startup when restoring tabs from a previous session. Tabs that are loaded in the background, are fully white when visited the first time, until a redrawn is forced, for example, moving the mouse over the view, or resizing the window. It doesn't always happen, so it looks like a sync issue between web and ui processes. When using the threaded compositor it happens more often. When AC is not forced to be always enabled, it never happens. It happens with 2.12 branch too, so it's not a recent regression, I think it has always happened. 1209040 1 cgarcia 2016-07-08 03:39:28 -0700 The problem is that for some reason we are failing to pre-render pages, so even if drawing area schedules renderings before the widget is mapped, only the white background is rendered by the web process, so that's what we render on map. In non-compositing mode we have the page correctly pre-rendered in a bitmap image, ready to be rendered on map. 1209056 2 cgarcia 2016-07-08 04:30:36 -0700 Something similar happens when not using the redirected x window, so it's doesn't seem to be a problem of the redirected window. 1211363 3 cgarcia 2016-07-15 01:52:33 -0700 With the patch attached to bug #159803 we can reproduce this issue using MiniBrowser: 1 - Open MiniBrowser with AC mode forced, and several tabs: WEBKIT_FORCE_COMPOSITING_MODE=1 bin/MiniBrowser http://www.webkitgtk.org http://www.igalia.com http://www.gnome.org You can use any websites, but it's important that the sites don't have animations or anything that requires accelerated compositing. 2 - Wait until all tabs are loaded. 3 - Visit the secondary tabs, by clicking on the tab and without moving the mouse out of the tab. Most of the times, the first time tabs are visited, web view is just full white, when moving the mouse over the view, or visiting it again, the actual contents appear. 1212313 4 cgarcia 2016-07-19 02:29:45 -0700 *** Bug 155572 has been marked as a duplicate of this bug. *** 1212317 5 283989 cgarcia 2016-07-19 03:00:40 -0700 Created attachment 283989 Patch 1212318 6 cgarcia 2016-07-19 03:01:21 -0700 This depends on patch attached to bug #159455 1212321 7 283990 cgarcia 2016-07-19 03:39:11 -0700 Created attachment 283990 Patch 1212976 8 283990 mcatanzaro 2016-07-20 17:43:20 -0700 Comment on attachment 283990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283990&action=review > Source/WebKit2/ChangeLog:15 > + initialize to avoid artifacts when the web process hasn't render anyting yet. That initialization is actually rendered anything 1213078 9 cgarcia 2016-07-21 00:36:57 -0700 Committed r203500: <http://trac.webkit.org/changeset/203500> 283989 2016-07-19 03:00:40 -0700 2016-07-19 03:39:11 -0700 Patch wk2-ac-mode-white-tabs.diff text/plain 7964 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NzhkM2Y1Li44ZTQxYzA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzgg QEAKKzIwMTYtMDctMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdoaXRlIHBhZ2Ugd2hlbiBsb2FkZWQgdGFiIGlzIHZpc2l0ZWQg dW50aWwgaXQncyBob3ZlcmVkIHdoZW4gQUMgbW9kZSBpcyBhbHdheXMgb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTUxMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSByZWRpcmVjdGVkIHdpbmRv dyBpcyBhbHdheXMgbWFwcGVkLCBidXQgb2Zmc2NyZWVuLCB0byBlbnN1cmUgdGhhdCB0aGUgd2Vi IHByb2Nlc3MgY2FuIGFsd2F5cyByZW5kZXIKKyAgICAgICAgdGhlcmUuIFdoZW4gdGhlIHdlYiBw cm9jZXNzIHJlbmRlcnMgc29tZXRoaW5nIGludG8gdGhlIG9mZnNjcmVlbiB3aW5kb3csIHdlIHJl Y2VpdmUgYSBkYW1hZ2UgZXZlbnQgaW4gdGhlIFVJCisgICAgICAgIHByb2Nlc3MgYW5kIHF1ZXVl IGEgcmVkcmF3IG9mIHRoZSB3ZWIgdmlldy4gSG93ZXZlciwgd2hlbiB0aGUgd2ViIHZpZXcgaXMg bm90IG1hcHBlZCwgZXZlbiBpZiB3ZSBzdGlsbCByZWNlaXZlCisgICAgICAgIHRoZSBkYW1hZ2Ug ZXZlbnRzLCB0aGUgd2ViIHZpZXcgcmVkcmF3cyBhcmUgaWdub3JlZCB1bnRpbCB0aGUgdmlldyBp cyBtYXBwZWQgYWdhaW4gKGd0a193aWRnZXRfcXVldWVfZHJhdygpCisgICAgICAgIHJldHVybnMg ZWFybHkgd2hlbiB0aGUgd2lkZ2V0IGlzIG5vdCB2aXNpYmxlKS4gVGhlIHJlZGlyZWN0ZWQgd2lu ZG93IHVwZGF0ZXMgaXRzIHBpeG1hcCBvbiBkZW1hbmQgd2hlbiB0aGUKKyAgICAgICAgc3VyZmFj ZSBpcyByZXF1ZXN0ZWQsIHdoaWNoIGhhcHBlbnMgd2hlbiB0aGUgd2ViIHZpZXcgZHJhd3MgaXRz IGNvbnRlbnRzLiBTbyB3aGVuIHRoZSB3ZWIgdmlldyBiZWNhbWVzIHZpc2libGUsCisgICAgICAg IHRoZSByZWRpcmVjdGVkIHdpbmRvdyBjcmVhdGVzIGEgbmV3IHBpeG1hcCBhbmQgc3VyZmFjZSAo dGhlIGZpcnN0IHRpbWUgb3IgaWYgdGhlIHdlYiB2aWV3IHdhcyByZXNpemVkKSwgdGhhdCB3ZQor ICAgICAgICBpbml0aWFsaXplIHRvIGF2b2lkIGFydGlmYWN0cyB3aGVuIHRoZSB3ZWIgcHJvY2Vz cyBoYXNuJ3QgcmVuZGVyIGFueXRpbmcgeWV0LiBUaGF0IGluaXRpYWxpemF0aW9uIGlzIGFjdHVh bGx5CisgICAgICAgIG92ZXJ3cml0aW5nIGFueXRoaW5nIHJlbmRlcmVkIGludG8gdGhlIHJlZGly ZWN0ZWQgd2luZG93IHdoaWxlIHRoZSB2aWV3IHdhcyB1bm1hcHBlZC4gVGhhdCdzIHdoeSBzZWUg d2hpdGUgcGFnZXMKKyAgICAgICAgdGhlIGZpcnN0IHRpbWUsIGFuZCBwcmV2aW91cyBjb250ZW50 cyBhZnRlciBhIHJlc2l6ZSwgYW5kIHdlIGRvbid0IHNlZSB0aGUgYWN0dWFsIGNvbnRlbnRzIHVu dGlsIHRoZSB3ZWIgcHJvY2VzcworICAgICAgICByZW5kZXJzIGFnYWluIGFuZCB3ZSByZXVzZSB0 aGUgZXhpc3RpbmcgcGl4bWFwLiBUaGUgd2hpdGUgcGFnZSBkaWRuJ3QgaGFwcGVuIGZvciB0YWJz IHdpdGggYWNjZWxlcmF0ZWQgY29udGVudCwKKyAgICAgICAgYmVjYXVzZSBpbiB0aG9zZSBjYXNl cyB0aGUgd2ViIHByb2Nlc3Mgd2FzIHJlbmRlcmluZyBhIG5ldyBmcmFtZSBldmVyeSAxNm1zLCBi dXQgaW5zdGVhZCB0aGVyZSB3YXMgYSBmbGlja2VyaW5nCisgICAgICAgIGVmZmVjdCBkdWUgdG8g dGhlIGN1cnJlbnQgZnJhbWUgYmVpbmcgb3ZlcndyaXR0ZW4gd2hlbiB0aGUgdmlldyBpcyBtYXBw ZWQgdW50aWwgdGhlIG5leHQgZnJhbWUuCisgICAgICAgIFNvLCBpbnN0ZWFkIG9mIGxhemlseSBj cmVhdGUgYW5kIGluaXRpYWxpemUgdGhlIHJlZGlyZWN0ZWQgd2luZG93IHBpeG1hcCBhbmQgc3Vy ZmFjZSwgd2Ugc2hvdWxkIGFsd2F5cyBjcmVhdGUKKyAgICAgICAgdGhlIG5ldyBwaXhtYXAgYXMg c29vbiBhcyB0aGUgd2luZG93IGlzIGNyZWF0ZWQgb3IgcmVzaXplZCAoYW5kIG5vdCBlbXB0eSks IGFuZCBvbmx5IGluaXRpYWxpemUgdGhlIHBpeG1hcCBmb3IKKyAgICAgICAgbmV3IHdpbmRvd3Ms IGJlY2F1c2Ugb24gcmVzaXplIHdlIGtlZXAgcmVuZGVyaW5nIHRoZSBwcmV2aW91cyBvbmUgdW50 aWwgdGhlIG5ldyBvbmUgaXMgcmVhZHkuIFRoaXMgZml4ZXMgdGhlCisgICAgICAgIGlzc3VlcyBi dXQgYWxzbyBtYWtlcyByZXNpemluZyB0aGUgd2luZG93IGEgYml0IHNtb290aGVyIHdoZW4gQUMg bW9kZSBpcyBlbmFibGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9SZWRpcmVjdGVkWENv bXBvc2l0ZVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJlZGlyZWN0ZWRYQ29tcG9zaXRl V2luZG93OjpSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdyk6IENyZWF0ZSB0aGUgcGl4bWFwIGFu ZCBzdXJmYWNlIGlmIHRoZSB3aW5kb3cgaXMKKyAgICAgICAgbm90IGVtcHR5LgorICAgICAgICAo V2ViS2l0OjpSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6cmVzaXplKTogRGl0dG8uCisgICAg ICAgIChXZWJLaXQ6OlJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpjcmVhdGVOZXdQaXhhbXBB bmRQaXhhbXBTdXJmYWNlKTogQ3JlYXRlIHRoZSBwaXhtYXAgYW5kIHN1cmZhY2UgYW5kCisgICAg ICAgIGluaXRpYWxpemUgdGhlIHN1cmZhY2UgaWYgaXQncyB0aGUgZmlyc3QgdGltZS4KKyAgICAg ICAgKFdlYktpdDo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OnN1cmZhY2UpOiBEZWxldGVk LgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuaDoK KyAgICAgICAgKFdlYktpdDo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OnN1cmZhY2UpOgor CiAyMDE2LTA3LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXVtUaHJlYWRlZCBDb21wb3NpdG9yXSBXZWIgdmlldyBiYWNrZ3JvdW5k IGNvbG9ycyBkb24ndCB3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwCmluZGV4IDM3ZDgyOWMuLjhm OTEyYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvUmVkaXJlY3Rl ZFhDb21wb3NpdGVXaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwCkBAIC0yMDQsNiArMjA0LDggQEAgUmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3c6OlJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93KFdlYlBhZ2VQ cm94eSYgd2ViUGFnZSwgY28KICAgICB9CiAgICAgWFNlbGVjdElucHV0KG1fZGlzcGxheSwgbV93 aW5kb3cuZ2V0KCksIE5vRXZlbnRNYXNrKTsKICAgICBYQ29tcG9zaXRlUmVkaXJlY3RXaW5kb3co bV9kaXNwbGF5LCBtX3dpbmRvdy5nZXQoKSwgQ29tcG9zaXRlUmVkaXJlY3RNYW51YWwpOworICAg IGlmICghbV9zaXplLmlzRW1wdHkoKSkKKyAgICAgICAgY3JlYXRlTmV3UGl4YW1wQW5kUGl4YW1w U3VyZmFjZSgpOwogICAgIG1fZGFtYWdlID0gWERhbWFnZUNyZWF0ZShtX2Rpc3BsYXksIG1fd2lu ZG93LmdldCgpLCBYRGFtYWdlUmVwb3J0Tm9uRW1wdHkpOwogfQogCkBAIC0yMzQsOSArMjM2LDEw IEBAIHZvaWQgUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OnJlc2l6ZShjb25zdCBJbnRTaXpl JiBzaXplKQogICAgIFhGbHVzaChtX2Rpc3BsYXkpOwogCiAgICAgbV9zaXplID0gc2NhbGVkU2l6 ZTsKLSAgICBtX25lZWRzTmV3UGl4bWFwQWZ0ZXJSZXNpemUgPSB0cnVlOwogICAgIGlmIChtX3Np emUuaXNFbXB0eSgpKQogICAgICAgICBjbGVhbnVwUGl4bWFwQW5kUGl4bWFwU3VyZmFjZSgpOwor ICAgIGVsc2UKKyAgICAgICAgY3JlYXRlTmV3UGl4YW1wQW5kUGl4YW1wU3VyZmFjZSgpOwogfQog CiB2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpjbGVhbnVwUGl4bWFwQW5kUGl4bWFw U3VyZmFjZSgpCkBAIC0yNDgsNTIgKzI1MSwzOCBAQCB2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRl V2luZG93OjpjbGVhbnVwUGl4bWFwQW5kUGl4bWFwU3VyZmFjZSgpCiAgICAgbV9waXhtYXAucmVz ZXQoKTsKIH0KIAotY2Fpcm9fc3VyZmFjZV90KiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6 c3VyZmFjZSgpCit2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpjcmVhdGVOZXdQaXhh bXBBbmRQaXhhbXBTdXJmYWNlKCkKIHsKICAgICAvLyBUaGlzIHNob3VsZCBuZXZlciBiZSBjYWxs ZWQgd2l0aCBhbiBlbXB0eSBzaXplIChub3QgaW4gQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmcgbW9k ZSkuCiAgICAgQVNTRVJUKCFtX3NpemUuaXNFbXB0eSgpKTsKLQotICAgIGlmICghbV9uZWVkc05l d1BpeG1hcEFmdGVyUmVzaXplICYmIG1fc3VyZmFjZSkKLSAgICAgICAgcmV0dXJuIG1fc3VyZmFj ZS5nZXQoKTsKLQotICAgIG1fbmVlZHNOZXdQaXhtYXBBZnRlclJlc2l6ZSA9IGZhbHNlOwotCiAg ICAgWFVuaXF1ZVBpeG1hcCBuZXdQaXhtYXAoWENvbXBvc2l0ZU5hbWVXaW5kb3dQaXhtYXAobV9k aXNwbGF5LCBtX3dpbmRvdy5nZXQoKSkpOwogICAgIGlmICghbmV3UGl4bWFwKSB7CiAgICAgICAg IGNsZWFudXBQaXhtYXBBbmRQaXhtYXBTdXJmYWNlKCk7Ci0gICAgICAgIHJldHVybiBudWxscHRy OworICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgWFdpbmRvd0F0dHJpYnV0ZXMgd2luZG93 QXR0cmlidXRlczsKICAgICBpZiAoIVhHZXRXaW5kb3dBdHRyaWJ1dGVzKG1fZGlzcGxheSwgbV93 aW5kb3cuZ2V0KCksICZ3aW5kb3dBdHRyaWJ1dGVzKSkgewogICAgICAgICBjbGVhbnVwUGl4bWFw QW5kUGl4bWFwU3VyZmFjZSgpOwotICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICAgICAgcmV0 dXJuOwogICAgIH0KIAogICAgIFJlZlB0cjxjYWlyb19zdXJmYWNlX3Q+IG5ld1N1cmZhY2UgPSBh ZG9wdFJlZihjYWlyb194bGliX3N1cmZhY2VfY3JlYXRlKG1fZGlzcGxheSwgbmV3UGl4bWFwLmdl dCgpLCB3aW5kb3dBdHRyaWJ1dGVzLnZpc3VhbCwgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWln aHQoKSkpOwogICAgIGNhaXJvU3VyZmFjZVNldERldmljZVNjYWxlKG5ld1N1cmZhY2UuZ2V0KCks IG1fd2ViUGFnZS5kZXZpY2VTY2FsZUZhY3RvcigpLCBtX3dlYlBhZ2UuZGV2aWNlU2NhbGVGYWN0 b3IoKSk7Ci0KLSAgICBSZWZQdHI8Y2Fpcm9fdD4gY3IgPSBhZG9wdFJlZihjYWlyb19jcmVhdGUo bmV3U3VyZmFjZS5nZXQoKSkpOwotICAgIGlmICghbV93ZWJQYWdlLmRyYXdzQmFja2dyb3VuZCgp KQotICAgICAgICBjYWlyb19zZXRfb3BlcmF0b3IoY3IuZ2V0KCksIENBSVJPX09QRVJBVE9SX0NM RUFSKTsKLSAgICBlbHNlCi0gICAgICAgIHNldFNvdXJjZVJHQkFGcm9tQ29sb3IoY3IuZ2V0KCks IG1fd2ViUGFnZS5iYWNrZ3JvdW5kQ29sb3IoKSk7Ci0gICAgY2Fpcm9fcGFpbnQoY3IuZ2V0KCkp OwotCi0gICAgLy8gTnZpZGlhIGRyaXZlcnMgc2VlbSB0byBwcmVwYXJlIHRoZWlyIHJlZGlyZWN0 ZWQgd2luZG93IHBpeG1hcCBhc3luY2hyb25vdXNseSwgc28gZm9yIGEgZmV3IGZyYWN0aW9ucwot ICAgIC8vIG9mIGEgc2Vjb25kIGFmdGVyIGVhY2ggcmVzaXplLCB3aGlsZSBkb2luZyBjb250aW51 b3VzIHJlc2l6aW5nICh3aGljaCBjb25zdGFudGx5IGRlc3Ryb3lzIGFuZCBjcmVhdGVzCi0gICAg Ly8gcGl4bWFwIHdpbmRvdy1iYWNraW5ncyksIHRoZSBwaXhtYXAgbWVtb3J5IGlzIHVuaW5pdGlh bGl6ZWQuIFRvIHdvcmsgYXJvdW5kIHRoaXMgaXNzdWUsIHBhaW50IHRoZSBvbGQKLSAgICAvLyBw aXhtYXAgdG8gdGhlIG5ldyBvbmUgdG8gcHJvcGVybHkgaW5pdGlhbGl6ZSBpdC4KLSAgICBpZiAo bV9zdXJmYWNlKSB7Ci0gICAgICAgIGNhaXJvX3NldF9vcGVyYXRvcihjci5nZXQoKSwgQ0FJUk9f T1BFUkFUT1JfT1ZFUik7Ci0gICAgICAgIGNhaXJvX3NldF9zb3VyY2Vfc3VyZmFjZShjci5nZXQo KSwgbV9zdXJmYWNlLmdldCgpLCAwLCAwKTsKKyAgICAvLyBXaGVuIGNyZWF0aW5nIHRoZSBzdXJm YWNlIGZvciB0aGUgZmlyc3QgdGltZSwgd2UgaW5pdGlhbGl6ZSBpdCB0byBlbnN1cmUgd2UgZG9u J3QgcmVuZGVyIGdhcmJhZ2UgYmVjYXVzZSBvZiB0aGUKKyAgICAvLyB1bmludGlhbGl6ZWQgcGl4 bWFwIGJlZm9yZSB0aGUgd2ViIHByb2Nlc3MgcmVuZGVycyBzb21ldGhpbmcgZm9yIHRoZSBmaXJz dCB0aW1lLgorICAgIGlmICghbV9waXhtYXApIHsKKyAgICAgICAgUmVmUHRyPGNhaXJvX3Q+IGNy ID0gYWRvcHRSZWYoY2Fpcm9fY3JlYXRlKG5ld1N1cmZhY2UuZ2V0KCkpKTsKKyAgICAgICAgaWYg KCFtX3dlYlBhZ2UuZHJhd3NCYWNrZ3JvdW5kKCkpCisgICAgICAgICAgICBjYWlyb19zZXRfb3Bl cmF0b3IoY3IuZ2V0KCksIENBSVJPX09QRVJBVE9SX0NMRUFSKTsKKyAgICAgICAgZWxzZQorICAg ICAgICAgICAgc2V0U291cmNlUkdCQUZyb21Db2xvcihjci5nZXQoKSwgbV93ZWJQYWdlLmJhY2tn cm91bmRDb2xvcigpKTsKICAgICAgICAgY2Fpcm9fcGFpbnQoY3IuZ2V0KCkpOwogICAgIH0KIAog ICAgIGNsZWFudXBQaXhtYXBBbmRQaXhtYXBTdXJmYWNlKCk7CiAgICAgbV9waXhtYXAgPSBXVEZN b3ZlKG5ld1BpeG1hcCk7Ci0gICAgbV9zdXJmYWNlID0gbmV3U3VyZmFjZTsKLSAgICByZXR1cm4g bV9zdXJmYWNlLmdldCgpOworICAgIG1fc3VyZmFjZSA9IFdURk1vdmUobmV3U3VyZmFjZSk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuaAppbmRleCBjYmVlZGQ2 Li4xNjJiMmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1JlZGly ZWN0ZWRYQ29tcG9zaXRlV2luZG93LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0 ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5oCkBAIC01MCwxMCArNTAsMTEgQEAgcHVibGlj OgogCiAgICAgV2luZG93IHdpbmRvd0lEKCkgY29uc3QgeyByZXR1cm4gbV93aW5kb3cuZ2V0KCk7 IH0KICAgICB2b2lkIHJlc2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7Ci0gICAgY2Fpcm9f c3VyZmFjZV90KiBzdXJmYWNlKCk7CisgICAgY2Fpcm9fc3VyZmFjZV90KiBzdXJmYWNlKCkgY29u c3QgeyByZXR1cm4gbV9zdXJmYWNlLmdldCgpOyB9OwogCiBwcml2YXRlOgogICAgIFJlZGlyZWN0 ZWRYQ29tcG9zaXRlV2luZG93KFdlYlBhZ2VQcm94eSYsIGNvbnN0IFdlYkNvcmU6OkludFNpemUm LCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+JiYgZGFtYWdlTm90aWZ5KTsKKyAgICB2b2lkIGNyZWF0 ZU5ld1BpeGFtcEFuZFBpeGFtcFN1cmZhY2UoKTsKICAgICB2b2lkIGNsZWFudXBQaXhtYXBBbmRQ aXhtYXBTdXJmYWNlKCk7CiAKICAgICBXZWJQYWdlUHJveHkmIG1fd2ViUGFnZTsKQEAgLTY0LDcg KzY1LDYgQEAgcHJpdmF0ZToKICAgICBXZWJDb3JlOjpYVW5pcXVlUGl4bWFwIG1fcGl4bWFwOwog ICAgIFdlYkNvcmU6OlhVbmlxdWVEYW1hZ2UgbV9kYW1hZ2U7CiAgICAgUmVmUHRyPGNhaXJvX3N1 cmZhY2VfdD4gbV9zdXJmYWNlOwotICAgIGJvb2wgbV9uZWVkc05ld1BpeG1hcEFmdGVyUmVzaXpl IHsgZmFsc2UgfTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 283990 2016-07-19 03:39:11 -0700 2016-07-20 17:43:20 -0700 Patch wk2-ac-mode-white-tabs.diff text/plain 6370 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2MjZhNmJkLi4zZDE3MzdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzYg QEAKKzIwMTYtMDctMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdoaXRlIHBhZ2Ugd2hlbiBsb2FkZWQgdGFiIGlzIHZpc2l0ZWQg dW50aWwgaXQncyBob3ZlcmVkIHdoZW4gQUMgbW9kZSBpcyBhbHdheXMgb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTUxMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSByZWRpcmVjdGVkIHdpbmRv dyBpcyBhbHdheXMgbWFwcGVkLCBidXQgb2Zmc2NyZWVuLCB0byBlbnN1cmUgdGhhdCB0aGUgd2Vi IHByb2Nlc3MgY2FuIGFsd2F5cyByZW5kZXIKKyAgICAgICAgdGhlcmUuIFdoZW4gdGhlIHdlYiBw cm9jZXNzIHJlbmRlcnMgc29tZXRoaW5nIGludG8gdGhlIG9mZnNjcmVlbiB3aW5kb3csIHdlIHJl Y2VpdmUgYSBkYW1hZ2UgZXZlbnQgaW4gdGhlIFVJCisgICAgICAgIHByb2Nlc3MgYW5kIHF1ZXVl IGEgcmVkcmF3IG9mIHRoZSB3ZWIgdmlldy4gSG93ZXZlciwgd2hlbiB0aGUgd2ViIHZpZXcgaXMg bm90IG1hcHBlZCwgZXZlbiBpZiB3ZSBzdGlsbCByZWNlaXZlCisgICAgICAgIHRoZSBkYW1hZ2Ug ZXZlbnRzLCB0aGUgd2ViIHZpZXcgcmVkcmF3cyBhcmUgaWdub3JlZCB1bnRpbCB0aGUgdmlldyBp cyBtYXBwZWQgYWdhaW4gKGd0a193aWRnZXRfcXVldWVfZHJhdygpCisgICAgICAgIHJldHVybnMg ZWFybHkgd2hlbiB0aGUgd2lkZ2V0IGlzIG5vdCB2aXNpYmxlKS4gVGhlIHJlZGlyZWN0ZWQgd2lu ZG93IHVwZGF0ZXMgaXRzIHBpeG1hcCBvbiBkZW1hbmQgd2hlbiB0aGUKKyAgICAgICAgc3VyZmFj ZSBpcyByZXF1ZXN0ZWQsIHdoaWNoIGhhcHBlbnMgd2hlbiB0aGUgd2ViIHZpZXcgZHJhd3MgaXRz IGNvbnRlbnRzLiBTbyB3aGVuIHRoZSB3ZWIgdmlldyBiZWNhbWVzIHZpc2libGUsCisgICAgICAg IHRoZSByZWRpcmVjdGVkIHdpbmRvdyBjcmVhdGVzIGEgbmV3IHBpeG1hcCBhbmQgc3VyZmFjZSAo dGhlIGZpcnN0IHRpbWUgb3IgaWYgdGhlIHdlYiB2aWV3IHdhcyByZXNpemVkKSwgdGhhdCB3ZQor ICAgICAgICBpbml0aWFsaXplIHRvIGF2b2lkIGFydGlmYWN0cyB3aGVuIHRoZSB3ZWIgcHJvY2Vz cyBoYXNuJ3QgcmVuZGVyIGFueXRpbmcgeWV0LiBUaGF0IGluaXRpYWxpemF0aW9uIGlzIGFjdHVh bGx5CisgICAgICAgIG92ZXJ3cml0aW5nIGFueXRoaW5nIHJlbmRlcmVkIGludG8gdGhlIHJlZGly ZWN0ZWQgd2luZG93IHdoaWxlIHRoZSB2aWV3IHdhcyB1bm1hcHBlZC4gVGhhdCdzIHdoeSBzZWUg d2hpdGUgcGFnZXMKKyAgICAgICAgdGhlIGZpcnN0IHRpbWUsIGFuZCBwcmV2aW91cyBjb250ZW50 cyBhZnRlciBhIHJlc2l6ZSwgYW5kIHdlIGRvbid0IHNlZSB0aGUgYWN0dWFsIGNvbnRlbnRzIHVu dGlsIHRoZSB3ZWIgcHJvY2VzcworICAgICAgICByZW5kZXJzIGFnYWluIGFuZCB3ZSByZXVzZSB0 aGUgZXhpc3RpbmcgcGl4bWFwLiBUaGUgd2hpdGUgcGFnZSBkaWRuJ3QgaGFwcGVuIGZvciB0YWJz IHdpdGggYWNjZWxlcmF0ZWQgY29udGVudCwKKyAgICAgICAgYmVjYXVzZSBpbiB0aG9zZSBjYXNl cyB0aGUgd2ViIHByb2Nlc3Mgd2FzIHJlbmRlcmluZyBhIG5ldyBmcmFtZSBldmVyeSAxNm1zLCBi dXQgaW5zdGVhZCB0aGVyZSB3YXMgYSBmbGlja2VyaW5nCisgICAgICAgIGVmZmVjdCBkdWUgdG8g dGhlIGN1cnJlbnQgZnJhbWUgYmVpbmcgb3ZlcndyaXR0ZW4gd2hlbiB0aGUgdmlldyBpcyBtYXBw ZWQgdW50aWwgdGhlIG5leHQgZnJhbWUuCisgICAgICAgIFNvLCBpbnN0ZWFkIG9mIGxhemlseSBj cmVhdGUgYW5kIGluaXRpYWxpemUgdGhlIHJlZGlyZWN0ZWQgd2luZG93IHBpeG1hcCBhbmQgc3Vy ZmFjZSwgd2Ugc2hvdWxkIGFsd2F5cyBjcmVhdGUKKyAgICAgICAgdGhlIG5ldyBwaXhtYXAgYXMg c29vbiBhcyB0aGUgd2luZG93IGlzIGNyZWF0ZWQgb3IgcmVzaXplZCAoYW5kIG5vdCBlbXB0eSkg VGhpcyBmaXhlcyB0aGUgaXNzdWVzIGJ1dCBhbHNvIG1ha2VzCisgICAgICAgIHJlc2l6aW5nIHRo ZSB3aW5kb3cgYSBiaXQgc21vb3RoZXIgd2hlbiBBQyBtb2RlIGlzIGVuYWJsZWQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OlJlZGlyZWN0ZWRYQ29tcG9z aXRlV2luZG93KTogQ3JlYXRlIHRoZSBwaXhtYXAgYW5kIHN1cmZhY2UgaWYgdGhlIHdpbmRvdyBp cworICAgICAgICBub3QgZW1wdHkuCisgICAgICAgIChXZWJLaXQ6OlJlZGlyZWN0ZWRYQ29tcG9z aXRlV2luZG93OjpyZXNpemUpOiBEaXR0by4KKyAgICAgICAgKFdlYktpdDo6UmVkaXJlY3RlZFhD b21wb3NpdGVXaW5kb3c6OmNyZWF0ZU5ld1BpeGFtcEFuZFBpeGFtcFN1cmZhY2UpOiBDcmVhdGUg dGhlIHBpeG1hcCBhbmQgc3VyZmFjZS4KKyAgICAgICAgKFdlYktpdDo6UmVkaXJlY3RlZFhDb21w b3NpdGVXaW5kb3c6OnN1cmZhY2UpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsv UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuaDoKKyAgICAgICAgKFdlYktpdDo6UmVkaXJlY3Rl ZFhDb21wb3NpdGVXaW5kb3c6OnN1cmZhY2UpOgorCiAyMDE2LTA3LTA3ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtUaHJlYWRlZCBD b21wb3NpdG9yXSBXZWIgdmlldyBiYWNrZ3JvdW5kIGNvbG9ycyBkb24ndCB3b3JrCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2lu ZG93LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3Np dGVXaW5kb3cuY3BwCmluZGV4IDM3ZDgyOWMuLjZhZjcyOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cu Y3BwCkBAIC0yMDQsNiArMjA0LDggQEAgUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OlJlZGly ZWN0ZWRYQ29tcG9zaXRlV2luZG93KFdlYlBhZ2VQcm94eSYgd2ViUGFnZSwgY28KICAgICB9CiAg ICAgWFNlbGVjdElucHV0KG1fZGlzcGxheSwgbV93aW5kb3cuZ2V0KCksIE5vRXZlbnRNYXNrKTsK ICAgICBYQ29tcG9zaXRlUmVkaXJlY3RXaW5kb3cobV9kaXNwbGF5LCBtX3dpbmRvdy5nZXQoKSwg Q29tcG9zaXRlUmVkaXJlY3RNYW51YWwpOworICAgIGlmICghbV9zaXplLmlzRW1wdHkoKSkKKyAg ICAgICAgY3JlYXRlTmV3UGl4YW1wQW5kUGl4YW1wU3VyZmFjZSgpOwogICAgIG1fZGFtYWdlID0g WERhbWFnZUNyZWF0ZShtX2Rpc3BsYXksIG1fd2luZG93LmdldCgpLCBYRGFtYWdlUmVwb3J0Tm9u RW1wdHkpOwogfQogCkBAIC0yMzQsOSArMjM2LDEwIEBAIHZvaWQgUmVkaXJlY3RlZFhDb21wb3Np dGVXaW5kb3c6OnJlc2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQogICAgIFhGbHVzaChtX2Rpc3Bs YXkpOwogCiAgICAgbV9zaXplID0gc2NhbGVkU2l6ZTsKLSAgICBtX25lZWRzTmV3UGl4bWFwQWZ0 ZXJSZXNpemUgPSB0cnVlOwogICAgIGlmIChtX3NpemUuaXNFbXB0eSgpKQogICAgICAgICBjbGVh bnVwUGl4bWFwQW5kUGl4bWFwU3VyZmFjZSgpOworICAgIGVsc2UKKyAgICAgICAgY3JlYXRlTmV3 UGl4YW1wQW5kUGl4YW1wU3VyZmFjZSgpOwogfQogCiB2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRl V2luZG93OjpjbGVhbnVwUGl4bWFwQW5kUGl4bWFwU3VyZmFjZSgpCkBAIC0yNDgsMjYgKzI1MSwy MCBAQCB2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpjbGVhbnVwUGl4bWFwQW5kUGl4 bWFwU3VyZmFjZSgpCiAgICAgbV9waXhtYXAucmVzZXQoKTsKIH0KIAotY2Fpcm9fc3VyZmFjZV90 KiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6c3VyZmFjZSgpCit2b2lkIFJlZGlyZWN0ZWRY Q29tcG9zaXRlV2luZG93OjpjcmVhdGVOZXdQaXhhbXBBbmRQaXhhbXBTdXJmYWNlKCkKIHsKICAg ICAvLyBUaGlzIHNob3VsZCBuZXZlciBiZSBjYWxsZWQgd2l0aCBhbiBlbXB0eSBzaXplIChub3Qg aW4gQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmcgbW9kZSkuCiAgICAgQVNTRVJUKCFtX3NpemUuaXNF bXB0eSgpKTsKLQotICAgIGlmICghbV9uZWVkc05ld1BpeG1hcEFmdGVyUmVzaXplICYmIG1fc3Vy ZmFjZSkKLSAgICAgICAgcmV0dXJuIG1fc3VyZmFjZS5nZXQoKTsKLQotICAgIG1fbmVlZHNOZXdQ aXhtYXBBZnRlclJlc2l6ZSA9IGZhbHNlOwotCiAgICAgWFVuaXF1ZVBpeG1hcCBuZXdQaXhtYXAo WENvbXBvc2l0ZU5hbWVXaW5kb3dQaXhtYXAobV9kaXNwbGF5LCBtX3dpbmRvdy5nZXQoKSkpOwog ICAgIGlmICghbmV3UGl4bWFwKSB7CiAgICAgICAgIGNsZWFudXBQaXhtYXBBbmRQaXhtYXBTdXJm YWNlKCk7Ci0gICAgICAgIHJldHVybiBudWxscHRyOworICAgICAgICByZXR1cm47CiAgICAgfQog CiAgICAgWFdpbmRvd0F0dHJpYnV0ZXMgd2luZG93QXR0cmlidXRlczsKICAgICBpZiAoIVhHZXRX aW5kb3dBdHRyaWJ1dGVzKG1fZGlzcGxheSwgbV93aW5kb3cuZ2V0KCksICZ3aW5kb3dBdHRyaWJ1 dGVzKSkgewogICAgICAgICBjbGVhbnVwUGl4bWFwQW5kUGl4bWFwU3VyZmFjZSgpOwotICAgICAg ICByZXR1cm4gbnVsbHB0cjsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIFJlZlB0cjxj YWlyb19zdXJmYWNlX3Q+IG5ld1N1cmZhY2UgPSBhZG9wdFJlZihjYWlyb194bGliX3N1cmZhY2Vf Y3JlYXRlKG1fZGlzcGxheSwgbmV3UGl4bWFwLmdldCgpLCB3aW5kb3dBdHRyaWJ1dGVzLnZpc3Vh bCwgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWlnaHQoKSkpOwpAQCAtMjkyLDggKzI4OSw3IEBA IGNhaXJvX3N1cmZhY2VfdCogUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OnN1cmZhY2UoKQog CiAgICAgY2xlYW51cFBpeG1hcEFuZFBpeG1hcFN1cmZhY2UoKTsKICAgICBtX3BpeG1hcCA9IFdU Rk1vdmUobmV3UGl4bWFwKTsKLSAgICBtX3N1cmZhY2UgPSBuZXdTdXJmYWNlOwotICAgIHJldHVy biBtX3N1cmZhY2UuZ2V0KCk7CisgICAgbV9zdXJmYWNlID0gV1RGTW92ZShuZXdTdXJmYWNlKTsK IH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5oIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5oCmluZGV4IGNiZWVk ZDYuLjE2MmIyZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvUmVk aXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmgKQEAgLTUwLDEwICs1MCwxMSBAQCBwdWJs aWM6CiAKICAgICBXaW5kb3cgd2luZG93SUQoKSBjb25zdCB7IHJldHVybiBtX3dpbmRvdy5nZXQo KTsgfQogICAgIHZvaWQgcmVzaXplKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKLSAgICBjYWly b19zdXJmYWNlX3QqIHN1cmZhY2UoKTsKKyAgICBjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UoKSBj b25zdCB7IHJldHVybiBtX3N1cmZhY2UuZ2V0KCk7IH07CiAKIHByaXZhdGU6CiAgICAgUmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3coV2ViUGFnZVByb3h5JiwgY29uc3QgV2ViQ29yZTo6SW50U2l6 ZSYsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4mJiBkYW1hZ2VOb3RpZnkpOworICAgIHZvaWQgY3Jl YXRlTmV3UGl4YW1wQW5kUGl4YW1wU3VyZmFjZSgpOwogICAgIHZvaWQgY2xlYW51cFBpeG1hcEFu ZFBpeG1hcFN1cmZhY2UoKTsKIAogICAgIFdlYlBhZ2VQcm94eSYgbV93ZWJQYWdlOwpAQCAtNjQs NyArNjUsNiBAQCBwcml2YXRlOgogICAgIFdlYkNvcmU6OlhVbmlxdWVQaXhtYXAgbV9waXhtYXA7 CiAgICAgV2ViQ29yZTo6WFVuaXF1ZURhbWFnZSBtX2RhbWFnZTsKICAgICBSZWZQdHI8Y2Fpcm9f c3VyZmFjZV90PiBtX3N1cmZhY2U7Ci0gICAgYm9vbCBtX25lZWRzTmV3UGl4bWFwQWZ0ZXJSZXNp emUgeyBmYWxzZSB9OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==