159510 2016-07-07 02:57:18 -0700 [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing. 2017-08-03 09:02:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 159556 1 pvollan pvollan achristensen bfulgham buildbot commit-queue dbates lforschler mkwst webkit-bug-importer oldest_to_newest 1208588 0 pvollan 2016-07-07 02:57:18 -0700 We need to allow any https certificate in DumpRenderTree. 1208650 1 283019 pvollan 2016-07-07 09:38:33 -0700 Created attachment 283019 Patch 1208675 2 283019 bfulgham 2016-07-07 10:58:19 -0700 Comment on attachment 283019 Patch r=me 1208730 3 pvollan 2016-07-07 12:55:59 -0700 (In reply to comment #2) > Comment on attachment 283019 [details] > Patch > > r=me Thanks for reviewing! 1208980 4 pvollan 2016-07-07 23:32:40 -0700 Committed r202967: <https://trac.webkit.org/changeset/202967> 1209061 5 commit-queue 2016-07-08 05:19:51 -0700 Re-opened since this is blocked by bug 159556 1334323 6 316979 pvollan 2017-08-02 11:35:57 -0700 Created attachment 316979 Patch 1334497 7 316979 dbates 2017-08-02 17:01:17 -0700 Comment on attachment 316979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316979&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1214 > + request->setAllowsAnyHTTPSCertificate(); OK. Although it is unlikely that DumpRenderTree would be used to load an arbitrary URL (and would be an error if run-webkit-test ever invoked with a non-file, non-localhost URL) it would be good practice to take a similar approach as in Mac DumpRenderTree/WebKitTestRunner and only allow any HTTPS certificate for localhost and 127.0.0.1. 1334787 8 pvollan 2017-08-03 08:31:30 -0700 (In reply to Daniel Bates from comment #7) > Comment on attachment 316979 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316979&action=review > > > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1214 > > + request->setAllowsAnyHTTPSCertificate(); > > OK. Although it is unlikely that DumpRenderTree would be used to load an > arbitrary URL (and would be an error if run-webkit-test ever invoked with a > non-file, non-localhost URL) it would be good practice to take a similar > approach as in Mac DumpRenderTree/WebKitTestRunner and only allow any HTTPS > certificate for localhost and 127.0.0.1. Thanks for reviewing! I will add a host check in a follow-up patch. 1334794 9 316979 commit-queue 2017-08-03 09:01:57 -0700 Comment on attachment 316979 Patch Clearing flags on attachment: 316979 Committed r220206: <http://trac.webkit.org/changeset/220206> 1334795 10 commit-queue 2017-08-03 09:01:59 -0700 All reviewed patches have been landed. Closing bug. 1334796 11 webkit-bug-importer 2017-08-03 09:02:57 -0700 <rdar://problem/33700981> 283019 2016-07-07 09:38:33 -0700 2017-08-02 11:35:56 -0700 Patch bug-159510-20160707093856.patch text/plain 3026 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA3LTA3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBUaGUgdGVzdCBo dHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS91cGdyYWRlLWluc2VjdXJl LXJlcXVlc3RzL2Jhc2ljLXVwZ3JhZGUuaHR0cHMuaHRtbCBpcyBmYWlsaW5nLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NTEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gV2luZG93cywgdmFsaWRh dGUgY2VydGlmaWNhdGUgY2hhaW4gZXZlbiB3aGVuIGFueSBodHRwcyBjZXJ0aWZpY2F0ZSBpcyBh bGxvd2VkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNG TmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpjcmVhdGVDRlVSTENv bm5lY3Rpb24pOgorCiAyMDE2LTA3LTA2ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBIb2xkIFJlZlB0cjw+J3MgdG8gVW5pcXVlSURCRGF0YWJhc2VzIHdoaWxl IHBlcmZvcm1pbmcgdXNlciBkZWxldGUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAJKHJldmlz aW9uIDIwMjg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3Vy Y2VIYW5kbGVDRk5ldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Myw3ICsxNzMsOSBAQCB2b2lk IFJlc291cmNlSGFuZGxlOjpjcmVhdGVDRlVSTENvbm5lY3RpCiAgICAgICAgIENGRGljdGlvbmFy eUFkZFZhbHVlKHNzbFByb3BzLmdldCgpLCBrQ0ZTdHJlYW1TU0xBbGxvd3NBbnlSb290LCBrQ0ZC b29sZWFuVHJ1ZSk7CiAgICAgICAgIENGRGljdGlvbmFyeUFkZFZhbHVlKHNzbFByb3BzLmdldCgp LCBrQ0ZTdHJlYW1TU0xBbGxvd3NFeHBpcmVkUm9vdHMsIGtDRkJvb2xlYW5UcnVlKTsKICAgICAg ICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoc3NsUHJvcHMuZ2V0KCksIGtDRlN0cmVhbVNTTEFsbG93 c0V4cGlyZWRDZXJ0aWZpY2F0ZXMsIGtDRkJvb2xlYW5UcnVlKTsKKyNpZiAhUExBVEZPUk0oV0lO KSAvLyBSZW1vdmUgcGxhdGZvcm0gI2lmZGVmIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzI2NzY4MDc3 PiBpcyBmaXhlZC4KICAgICAgICAgQ0ZEaWN0aW9uYXJ5QWRkVmFsdWUoc3NsUHJvcHMuZ2V0KCks IGtDRlN0cmVhbVNTTFZhbGlkYXRlc0NlcnRpZmljYXRlQ2hhaW4sIGtDRkJvb2xlYW5GYWxzZSk7 CisjZW5kaWYKICAgICB9CiAKICAgICBhdXRvIGNsaWVudENlcnQgPSBjbGllbnRDZXJ0aWZpY2F0 ZXMoKS5maW5kKGZpcnN0UmVxdWVzdCgpLnVybCgpLmhvc3QoKSk7CkluZGV4OiBUb29scy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDI4OTkpCisr KyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNi0w Ny0wNyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dp bl0gVGhlIHRlc3QgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvdXBn cmFkZS1pbnNlY3VyZS1yZXF1ZXN0cy9iYXNpYy11cGdyYWRlLmh0dHBzLmh0bWwgaXMgZmFpbGlu Zy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTUx MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93 IGFueSBodHRwcyBjZXJ0aWZpY2F0ZSB3aGVuIHJ1bm5pbmcgdGVzdHMuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocnVuVGVzdCk6 CisKIDIwMTYtMDctMDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRW1haWwgZnJvbSBKdW5lIDFzdCBjb250YWluaW5nIHRleHQgJ1RvZGF5IEAgNzox MFBNJyBpcyBsaW5raWZpZWQsIGJ1dCBzaG91bGRuJ3QgYmUKSW5kZXg6IFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2aXNpb24gMjAyODYwKQorKysgVG9v bHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTEzOCw2ICsxMTM4LDcgQEAgc3RhdGljIHZvaWQgcnVuVGVzdChjb25zdCBzdHJpbmcmIGlu cHV0TAogCiAgICAgcmVxdWVzdC0+aW5pdFdpdGhVUkwodXJsQlN0ciwgV2ViVVJMUmVxdWVzdFVz ZVByb3RvY29sQ2FjaGVQb2xpY3ksIDYwKTsKICAgICByZXF1ZXN0LT5zZXRIVFRQTWV0aG9kKG1l dGhvZEJTdHIpOworICAgIHJlcXVlc3QtPnNldEFsbG93c0FueUhUVFBTQ2VydGlmaWNhdGUoKTsK ICAgICBmcmFtZS0+bG9hZFJlcXVlc3QocmVxdWVzdC5nZXQoKSk7CiAKICAgICB3aGlsZSAodHJ1 ZSkgewo= 316979 2017-08-02 11:35:57 -0700 2017-08-03 09:01:57 -0700 Patch bug-159510-20170802113644.patch text/plain 1269 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDE0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA4LTAyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBUaGUgdGVzdCBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRT ZWN1cml0eVBvbGljeS91cGdyYWRlLWluc2VjdXJlLXJlcXVlc3RzL2Jhc2ljLXVwZ3JhZGUuaHR0 cHMuaHRtbCBpcyBmYWlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU5NTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWxsb3cgYW55IGh0dHBzIGNlcnRpZmljYXRlIHdoZW4gcnVubmluZyB0ZXN0 cy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6Cisg ICAgICAgIChydW5UZXN0KToKKwogMjAxNy0wOC0wMiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFp bkBhcHBsZS5jb20+CiAKICAgICAgICAgSW50ZXJtaXR0ZW50IGV4Y2VwdGlvbiBpbiBidWlsZFBh Z2VVUkxGb3JJdGVyYXRpb24gZm9yIEJ1aWxkYm90IDAuOSBkYXNoYm9hcmQKSW5kZXg6IFRvb2xz L0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2aXNpb24gMjIwMTQ2 KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTIxMSw2ICsxMjExLDcgQEAgc3RhdGljIHZvaWQgcnVuVGVzdChjb25zdCBz dHJpbmcmIGlucHV0TAogCiAgICAgcmVxdWVzdC0+aW5pdFdpdGhVUkwodXJsQlN0ciwgV2ViVVJM UmVxdWVzdFVzZVByb3RvY29sQ2FjaGVQb2xpY3ksIDYwKTsKICAgICByZXF1ZXN0LT5zZXRIVFRQ TWV0aG9kKG1ldGhvZEJTdHIpOworICAgIHJlcXVlc3QtPnNldEFsbG93c0FueUhUVFBTQ2VydGlm aWNhdGUoKTsKICAgICBmcmFtZS0+bG9hZFJlcXVlc3QocmVxdWVzdC5nZXQoKSk7CiAKICAgICB3 aGlsZSAoIWRvbmUpIHsK