15951 2007-11-12 03:06:02 -0800 REGRESSION: assertion failure in regexp match() when running JS tests 2007-11-12 16:25:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 ap darin darin ggaren oldest_to_newest 60975 0 ap 2007-11-12 03:06:02 -0800 Running r27689 or r27710 debug build, not sure when this started or which test causes this. Thread 0 Crashed: 0 match(unsigned short const*, unsigned char const*, int, match_data*) + 31087 (pcre_exec.cpp:1878) 1 jsRegExpExecute(JSRegExp const*, unsigned short const*, int, int, int*, int) + 1705 (pcre_exec.cpp:2272) 2 KJS::RegExp::match(KJS::UString const&, int, WTF::OwnArrayPtr<int>*) + 275 (regexp.cpp:105) 3 KJS::RegExpObjectImp::performMatch(KJS::RegExp*, KJS::UString const&, int, int&, int&, int**) + 64 (regexp_object.cpp:305) 4 KJS::StringProtoFuncSearch::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 395 (string_object.cpp:611) 5 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 220 (object.cpp:95) 61008 1 darin 2007-11-12 12:26:36 -0800 Geoff was showing this to me today. Should be easy to fix. 61012 2 17209 ggaren 2007-11-12 13:20:58 -0800 Created attachment 17209 Reduction 61013 3 ggaren 2007-11-12 13:21:28 -0800 This ASSERT fires only with > 100 parens. <= 100 parens won't do it. 61024 4 17213 darin 2007-11-12 14:25:48 -0800 Created attachment 17213 patch 61029 5 17213 sam 2007-11-12 15:33:54 -0800 Comment on attachment 17213 patch Looks good. r=me. 61033 6 darin 2007-11-12 16:25:26 -0800 Committed revision 27733. 17209 2007-11-12 13:20:58 -0800 2007-11-12 13:20:58 -0800 Reduction scratch.js text/plain 206 ggaren dmFyIGNvdW50ID0gMTAxOwoKdmFyIHJlZ2V4cCA9ICIiOwpmb3IgKHZhciBpID0gMDsgaSA8IGNv dW50OyArK2kpCiAgICByZWdleHAgKz0gIigiOwpyZWdleHAgKz0gImhlbGxvIjsKZm9yICh2YXIg aSA9IDA7IGkgPCBjb3VudDsgKytpKQogICAgcmVnZXhwICs9ICIpIjsKCnZhciByZSA9IG5ldyBS ZWdFeHAocmVnZXhwKTsKImhlbGxvIi5zZWFyY2gocmUpOwo= 17213 2007-11-12 14:25:48 -0800 2007-11-12 15:33:54 -0800 patch BraNumberPatch.txt text/plain 4451 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NzI4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMTEtMTIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU5NTEKKyAgICAgICAgICBSRUdSRVNTSU9OOiBhc3NlcnRpb24gZmFpbHVyZSBpbiByZWdleHAg bWF0Y2goKSB3aGVuIHJ1bm5pbmcgSlMgdGVzdHMKKworICAgICAgICBUZXN0OiBmYXN0L2pzL3Jl Z2V4cC1tYW55LWJyYWNrZXRzLmh0bWwKKworICAgICAgICAqIHBjcmUvcGNyZV9leGVjLmNwcDog KG1hdGNoKTogQWRkZWQgYmFjayBhY2NpZGVudGFsbHktcmVtb3ZlZCBjYXNlIGZvcgorICAgICAg ICB0aGUgQlJBTlVNQkVSIG9wY29kZS4KKwogMjAwNy0xMS0xMiAgQWRhbSBSb2JlbiAgPGFyb2Jl bkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9w Y3JlL3BjcmVfZXhlYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcGNyZS9wY3Jl X2V4ZWMuY3BwCShyZXZpc2lvbiAyNzcyMSkKKysrIEphdmFTY3JpcHRDb3JlL3BjcmUvcGNyZV9l eGVjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQ0LDYgKzQ0NCwxMiBAQCBmb3IgKDs7KQogICAg IERQUklOVEYoKCJicmFja2V0IDAgZmFpbGVkXG4iKSk7CiAgICAgUlJFVFVSTjsKIAorICAgIC8q IFNraXAgb3ZlciBsYXJnZSBleHRyYWN0aW9uIG51bWJlciBkYXRhIGlmIGVuY291bnRlcmVkLiAq LworCisgICAgQkVHSU5fT1BDT0RFKEJSQU5VTUJFUik6CisgICAgZnJhbWUtPmVjb2RlICs9IDM7 CisgICAgTkVYVF9PUENPREU7CisKICAgICAvKiBFbmQgb2YgdGhlIHBhdHRlcm4uICovCiAKICAg ICBCRUdJTl9PUENPREUoRU5EKToKQEAgLTE4NjYsNyArMTg3Miw2IEBAIGZvciAoOzspCiAgICAg ICB9CiAgICAgLyogQ29udHJvbCBuZXZlciBnZXRzIGhlcmUgKi8KIAotICAgIEJFR0lOX09QQ09E RShCUkFOVU1CRVIpOgogICAgIEJFR0lOX09QQ09ERShDUk1JTlBMVVMpOgogICAgIEJFR0lOX09Q Q09ERShDUk1JTlFVRVJZKToKICAgICBCRUdJTl9PUENPREUoQ1JNSU5SQU5HRSk6CkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzcyOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE0IEBACisyMDA3LTExLTEyICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAt IHRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTUxCisg ICAgICAgICAgUkVHUkVTU0lPTjogYXNzZXJ0aW9uIGZhaWx1cmUgaW4gcmVnZXhwIG1hdGNoKCkg d2hlbiBydW5uaW5nIEpTIHRlc3RzCisKKyAgICAgICAgKiBmYXN0L2pzL3JlZ2V4cC1tYW55LWJy YWNrZXRzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9yZWdleHAtbWFu eS1icmFja2V0cy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL3Jlc291cmNlcy9yZWdl eHAtbWFueS1icmFja2V0cy5qczogQWRkZWQuCisKIDIwMDctMTEtMTIgIEdlb2ZmcmV5IEdhcmVu ICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBPbGl2ZXIg SHVudC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcmVnZXhwLW1hbnktYnJhY2tldHMtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvcmVnZXhwLW1hbnkt YnJhY2tldHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9q cy9yZWdleHAtbWFueS1icmFja2V0cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTEgQEAKK1Rlc3QgcmVndWxhciBleHByZXNzaW9uIHByb2Nlc3Npbmcgd2l0aCBtYW55IGNh cHR1cmluZyBicmFja2V0cyAoMjAwKS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisK K1BBU1MgJ2hlbGxvJy5tYXRjaChtYW55QnJhY2tldHNSZWdFeHApIGlzIG1hbnlIZWxsb3NBcnJh eQorCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwoK UHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZWdleHAtbWFueS1icmFj a2V0cy1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0 aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZWdleHAtbWFueS1icmFja2V0cy5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvcmVnZXhwLW1hbnktYnJhY2tldHMu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcmVnZXhwLW1hbnktYnJh Y2tldHMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwg UFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJl bD0ic3R5bGVzaGVldCIgaHJlZj0icmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3Jp cHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2Pgor PHNjcmlwdCBzcmM9InJlc291cmNlcy9yZWdleHAtbWFueS1icmFja2V0cy5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jl Z2V4cC1tYW55LWJyYWNrZXRzLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAg ICsgdGV4dC9odG1sCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9yZWdleHAtbWFueS1icmFja2V0cy5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9yZWdleHAtbWFueS1icmFja2V0 cy5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL3JlZ2V4 cC1tYW55LWJyYWNrZXRzLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIzIEBACitkZXNjcmlw dGlvbigKKydUZXN0IHJlZ3VsYXIgZXhwcmVzc2lvbiBwcm9jZXNzaW5nIHdpdGggbWFueSBjYXB0 dXJpbmcgYnJhY2tldHMgKDIwMCkuJworKTsKKwordmFyIGNvdW50ID0gMjAwOworCit2YXIgcmVn ZXhwID0gIiI7Citmb3IgKHZhciBpID0gMDsgaSA8IGNvdW50OyArK2kpCisgICAgcmVnZXhwICs9 ICIoIjsKK3JlZ2V4cCArPSAiaGVsbG8iOworZm9yICh2YXIgaSA9IDA7IGkgPCBjb3VudDsgKytp KQorICAgIHJlZ2V4cCArPSAiKSI7CisKK3ZhciBtYW55SGVsbG9zQXJyYXkgPSBuZXcgQXJyYXk7 Citmb3IgKHZhciBpID0gMDsgaSA8PSBjb3VudDsgKytpKQorICAgIG1hbnlIZWxsb3NBcnJheVtp XSA9ICJoZWxsbyI7CisKK3ZhciBtYW55QnJhY2tldHNSZWdFeHAgPSBuZXcgUmVnRXhwKHJlZ2V4 cCk7CitzaG91bGRCZSgiJ2hlbGxvJy5tYXRjaChtYW55QnJhY2tldHNSZWdFeHApIiwgIm1hbnlI ZWxsb3NBcnJheSIpOworCitkZWJ1ZygnJyk7CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOwo=