159497 2016-07-06 16:38:39 -0700 [WK2][Cocoa] Disable ResourceResponse lazy initialization 2016-07-06 18:33:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue webkit-bug-importer oldest_to_newest 1208434 0 cdumez 2016-07-06 16:38:39 -0700 Disable ResponseResponse lazy initialization for WebKit2 as we always end up initializing all the fields anyway when sending the response to the WebContent process via IPC. Even worse, we always do a partial lazy initialization (common fields only) before the IPC so we always do the initialization in 2 steps. This normally would not be an issue but the 2 steps actually have some overlap because both call CFHTTPMessageCopyAllHeaderFields(), which is expensive (See <rdar://problem/26796059>) to first get the common HTTP headers, then ALL the HTTP headers. 1208435 1 webkit-bug-importer 2016-07-06 16:39:26 -0700 <rdar://problem/27209066> 1208446 2 282963 cdumez 2016-07-06 16:54:52 -0700 Created attachment 282963 Patch 1208458 3 282963 achristensen 2016-07-06 17:14:21 -0700 Comment on attachment 282963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282963&action=review > Source/WebCore/ChangeLog:3 > + [WK2][Cocoa] Disable ResponseResponse lazy initialization ResourceResponse. 1208488 4 cdumez 2016-07-06 18:33:22 -0700 Committed r202888: <http://trac.webkit.org/changeset/202888> 282963 2016-07-06 16:54:52 -0700 2016-07-06 17:14:21 -0700 Patch bug-159497-20160706165420.patch text/plain 4872 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQwNWI4MTRhOTkzNDhh NTA1N2M4ZDEyZGUzZjIxNDdkNWU4Mzc3Yy4uZmJmZTcwZTM0MWM1NzU5NjY3OThiYTA3MDRmNTg5 NDBhNDE3ZjNmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTA3LTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgW1dLMl1bQ29jb2FdIERpc2Fi bGUgUmVzcG9uc2VSZXNwb25zZSBsYXp5IGluaXRpYWxpemF0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0OTcKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI3MjA5MDY2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBtZXRob2QgdG8gQ29jb2EncyBSZXNwb25zZVJlc3BvbnNlIGhlYWRlciB0 byBkaXNhYmxlCisgICAgICAgIGxhenkgaW5pdGlhbGl6YXRpb24uCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2UuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2NvY29hL1Jlc291cmNlUmVzcG9uc2VDb2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlUmVzcG9uc2U6OmRpc2FibGVMYXp5SW5pdGlhbGl6YXRpb24pOgorCisyMDE2LTA3 LTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgRG9jdW1lbnQu Ym9keSBzaG91bGQgcmV0dXJuIHRoZSBmaXJzdCBjaGlsZCBvZiB0aGUgaHRtbCBlbGVtZW50IHRo YXQgaXMgZWl0aGVyIGEgYm9keSAvIGZyYW1lc2V0IGVsZW1lbnQKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTQ4OAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGYz N2ZkYWFhMmM0OTA4NDExNjM3NmVmNGI2ZDA4ODlhMGQ5NTUzOC4uOGEwZWQwY2ZjNzgzOGI5NmE3 OWYyNjM1NWVmNDI2NGQ5ZWY2ZWI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2 LTA3LTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1b Q29jb2FdIERpc2FibGUgUmVzcG9uc2VSZXNwb25zZSBsYXp5IGluaXRpYWxpemF0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0OTcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzI3MjA5MDY2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgUmVzcG9uc2VSZXNwb25zZSBsYXp5IGluaXRp YWxpemF0aW9uIGZvciBXZWJLaXQyIGFzCisgICAgICAgIHdlIGFsd2F5cyBlbmQgdXAgaW5pdGlh bGl6aW5nIGFsbCB0aGUgZmllbGRzIGFueXdheSB3aGVuCisgICAgICAgIHNlbmRpbmcgdGhlIHJl c3BvbnNlIHRvIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgdmlhIElQQy4KKworICAgICAgICBFdmVu IHdvcnNlLCB3ZSBhbHdheXMgZG8gYSBwYXJ0aWFsIGxhenkgaW5pdGlhbGl6YXRpb24gKGNvbW1v bgorICAgICAgICBmaWVsZHMgb25seSkgYmVmb3JlIHRoZSBJUEMgc28gd2UgYWx3YXlzIGRvIHRo ZSBpbml0aWFsaXphdGlvbgorICAgICAgICBpbiAyIHN0ZXBzLiBUaGlzIG5vcm1hbGx5IHdvdWxk IG5vdCBiZSBhbiBpc3N1ZSBidXQgdGhlIDIgc3RlcHMKKyAgICAgICAgYWN0dWFsbHkgaGF2ZSBz b21lIG92ZXJsYXAgYmVjYXVzZSBib3RoIGNhbGwKKyAgICAgICAgQ0ZIVFRQTWVzc2FnZUNvcHlB bGxIZWFkZXJGaWVsZHMoKSwgd2hpY2ggaXMgZXhwZW5zaXZlIChTZWUKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI2Nzk2MDU5PikgdG8gZmlyc3QgZ2V0IHRoZSBjb21tb24gSFRUUCBoZWFkZXJz LAorICAgICAgICB0aGVuIEFMTCB0aGUgSFRUUCBoZWFkZXJzLgorCisgICAgICAgICogTmV0d29y a1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbToKKyAgICAgICAgKC1bV0tOZXR3 b3JrU2Vzc2lvbkRlbGVnYXRlIFVSTFNlc3Npb246ZGF0YVRhc2s6ZGlkUmVjZWl2ZVJlc3BvbnNl OmNvbXBsZXRpb25IYW5kbGVyOl0pOgorCiAyMDE2LTA3LTA2ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2FsbCBjb250aW51ZUNhbkF1dGhl bnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2Ugd2hlbiBjYW5jZWxsaW5nIGxvYWRzIHdhaXRp bmcgZm9yIHRoZSBjYWxsYmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2UuaAppbmRleCBlNmFjZWY2NDM3ZDZhNThkYTgyNzRm YWFmNWRhNWRkNWQ5NzZjMjY0Li41ZTcxYmM2NTdjM2YzZDc2NDE5M2Q0YWEyOTZmZWMyMTE4NzQ4 OTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291 cmNlUmVzcG9uc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jl c291cmNlUmVzcG9uc2UuaApAQCAtNjgsNiArNjgsMTAgQEAgcHVibGljOgogICAgIHsKICAgICB9 CiAKKyNpZiBQTEFURk9STShDT0NPQSkKKyAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGRpc2FibGVM YXp5SW5pdGlhbGl6YXRpb24oKTsKKyNlbmRpZgorCiAgICAgdW5zaWduZWQgbWVtb3J5VXNhZ2Uo KSBjb25zdAogICAgIHsKICAgICAgICAgLy8gRklYTUU6IEZpbmQgc29tZSBwcm9ncmFtbWF0aWMg bGlnaHdlaWdodCB3YXkgdG8gY2FsY3VsYXRlIFJlc291cmNlUmVzcG9uc2UgYW5kIGFzc29jaWF0 ZWQgY2xhc3Nlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y29jb2EvUmVzb3VyY2VSZXNwb25zZUNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KaW5kZXggNDM1N2I1ZjE1NGIz NGM3NjNiZjMzMmQ4Mzc1YTMyOGZmOWE0YjMwMS4uNGRlMTY4NTAzYThlNmYxNTUzZGU3MTA4MGRk MDQ5MjcyNDk5MWUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KQEAgLTY4LDYgKzY4 LDExIEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6aW5pdE5TVVJMUmVzcG9uc2UoKSBjb25zdAog ICAgIFttX25zUmVzcG9uc2UuZ2V0KCkgX3NldE1JTUVUeXBlOihOU1N0cmluZyAqKW1fbWltZVR5 cGVdOwogfQogCit2b2lkIFJlc291cmNlUmVzcG9uc2U6OmRpc2FibGVMYXp5SW5pdGlhbGl6YXRp b24oKQoreworICAgIGxhenlJbml0KEFsbEZpZWxkcyk7Cit9CisKIENlcnRpZmljYXRlSW5mbyBS ZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNlcnRpZmljYXRlSW5mbygpIGNvbnN0CiB7CiAjaWYg VVNFKENGTkVUV09SSykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCmluZGV4IGFkMzVhYmY5NjhmZTY1ZDVl ZmY2MDQ0NTE3MTI5ZGEwMTcyNTM5YzcuLjdkZjE0ZDk0MTA5OGRjNDdlYjBhODlmMzkzMWU0YzQ0 M2FlMTAyZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29h L05ldHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQpAQCAtMjQ1LDYgKzI0NSwxMCBAQCAtICh2 b2lkKVVSTFNlc3Npb246KE5TVVJMU2Vzc2lvbiAqKXNlc3Npb24gZGF0YVRhc2s6KE5TVVJMU2Vz c2lvbkRhdGFUYXNrICopZGF0YQogICAgICAgICB9CiAKICAgICAgICAgV2ViQ29yZTo6UmVzb3Vy Y2VSZXNwb25zZSByZXNvdXJjZVJlc3BvbnNlKHJlc3BvbnNlKTsKKyAgICAgICAgLy8gTGF6eSBp bml0aWFsaXphdGlvbiBpcyBub3QgaGVscGZ1bCBpbiB0aGUgV2ViS2l0MiBjYXNlIGJlY2F1c2Ug d2UgYWx3YXlzIGVuZCB1cCBpbml0aWFsaXppbmcKKyAgICAgICAgLy8gYWxsIHRoZSBmaWVsZHMg d2hlbiBzZW5kaW5nIHRoZSByZXNwb25zZSB0byB0aGUgV2ViQ29udGVudCBwcm9jZXNzIG92ZXIg SVBDLgorICAgICAgICByZXNvdXJjZVJlc3BvbnNlLmRpc2FibGVMYXp5SW5pdGlhbGl6YXRpb24o KTsKKwogICAgICAgICBjb3B5VGltaW5nRGF0YShbZGF0YVRhc2sgX3RpbWluZ0RhdGFdLCByZXNv dXJjZVJlc3BvbnNlLnJlc291cmNlTG9hZFRpbWluZygpKTsKICAgICAgICAgYXV0byBjb21wbGV0 aW9uSGFuZGxlckNvcHkgPSBCbG9ja19jb3B5KGNvbXBsZXRpb25IYW5kbGVyKTsKICAgICAgICAg bmV0d29ya0RhdGFUYXNrLT5kaWRSZWNlaXZlUmVzcG9uc2UoV1RGTW92ZShyZXNvdXJjZVJlc3Bv bnNlKSwgW2NvbXBsZXRpb25IYW5kbGVyQ29weSwgdGFza0lkZW50aWZpZXJdKFdlYkNvcmU6OlBv bGljeUFjdGlvbiBwb2xpY3lBY3Rpb24pIHsK