159496 2016-07-06 16:27:54 -0700 All fullscreen videos should be able the control the controls manager 2016-07-07 11:58:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159437 1 bdakin webkit-unassigned bdakin eric.carlson jer.noble oldest_to_newest 1208429 0 bdakin 2016-07-06 16:27:54 -0700 All fullscreen videos should be able the control the controls manager rdar://problem/27009446 1208430 1 bdakin 2016-07-06 16:28:52 -0700 This patch is going to depend on https://bugs.webkit.org/show_bug.cgi?id=159437 because it uses a new function introduced in that patch. I expect the bots to fail for the time being. 1208431 2 282958 bdakin 2016-07-06 16:32:36 -0700 Created attachment 282958 Patch 1208716 3 bdakin 2016-07-07 11:58:51 -0700 Thanks Eric! https://trac.webkit.org/changeset/202924 282958 2016-07-06 16:32:36 -0700 2016-07-06 17:40:36 -0700 Patch for-review.txt text/plain 2016 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjg4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA3LTA2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBbGwgZnVsbHNjcmVlbiB2aWRlb3Mg c2hvdWxkIGJlIGFibGUgdGhlIGNvbnRyb2wgdGhlIGNvbnRyb2xzIG1hbmFnZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTQ5NgorICAgICAgICAt YW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI3MDA5NDQ2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZnVs bHNjcmVlbk1vZGVDaGFuZ2VkKToKKyAgICAgICAgKiBodG1sL01lZGlhRWxlbWVudFNlc3Npb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENv bnRyb2xzTWFuYWdlcik6CisKIDIwMTYtMDctMDYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBEb2N1bWVudC5ib2R5IHNob3VsZCByZXR1cm4gdGhlIGZpcnN0IGNo aWxkIG9mIHRoZSBodG1sIGVsZW1lbnQgdGhhdCBpcyBlaXRoZXIgYSBib2R5IC8gZnJhbWVzZXQg ZWxlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShy ZXZpc2lvbiAyMDI4MjApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTMwLDYgKzcxMzAsNyBAQCB2b2lkIEhUTUxNZWRpYUVs ZW1lbnQ6OmZ1bGxzY3JlZW5Nb2RlQ2hhCiAKICAgICBtX3ZpZGVvRnVsbHNjcmVlbk1vZGUgPSBt b2RlOwogICAgIG1fbWVkaWFTZXNzaW9uLT5zY2hlZHVsZUNsaWVudERhdGFCdWZmZXJpbmdDaGVj aygpOworICAgIHNjaGVkdWxlVXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKIH0KIAog fQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCShy ZXZpc2lvbiAyMDI4MjApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Np b24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTMsNiArMjEzLDExIEBAIGJvb2wgTWVkaWFFbGVt ZW50U2Vzc2lvbjo6cGFnZUFsbG93c1BsYXkKIAogYm9vbCBNZWRpYUVsZW1lbnRTZXNzaW9uOjpj YW5Db250cm9sQ29udHJvbHNNYW5hZ2VyKCkgY29uc3QKIHsKKyAgICBpZiAobV9lbGVtZW50Lmlz RnVsbHNjcmVlbigpKSB7CisgICAgICAgIExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246 OmNhbkNvbnRyb2xDb250cm9sc01hbmFnZXIgLSByZXR1cm5pbmcgVFJVRTogSXMgZnVsbHNjcmVl biIpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKICAgICBpZiAoIW1fZWxlbWVudC5o YXNBdWRpbygpKSB7CiAgICAgICAgIExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246OmNh bkNvbnRyb2xDb250cm9sc01hbmFnZXIgLSByZXR1cm5pbmcgRkFMU0U6IE5vIGF1ZGlvIik7CiAg ICAgICAgIHJldHVybiBmYWxzZTsK