159487 2016-07-06 13:32:02 -0700 Web Inspector: REGRESSION: Hitting ⌘T in Web Inspector no longer opens in new tab in Safari 2016-07-06 20:26:33 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1208370 0 timothy 2016-07-06 13:32:02 -0700 Ricky: "I’ve grown used to this over a number of years." <rdar://problem/27188047> 1208371 1 282938 timothy 2016-07-06 13:37:11 -0700 Created attachment 282938 Patch 1208372 2 282938 nvasilyev 2016-07-06 13:42:01 -0700 Comment on attachment 282938 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282938&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:272 > + this._openNewTabKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, "T", this.showNewTabTab.bind(this)); Command-Shift-T reopens last closed tab in Safari 10. 1208417 3 282953 timothy 2016-07-06 14:54:01 -0700 Created attachment 282953 Patch 1208510 4 282953 joepeck 2016-07-06 20:04:43 -0700 Comment on attachment 282953 Patch r=me 1208514 5 282953 commit-queue 2016-07-06 20:26:28 -0700 Comment on attachment 282953 Patch Clearing flags on attachment: 282953 Committed r202891: <http://trac.webkit.org/changeset/202891> 1208515 6 commit-queue 2016-07-06 20:26:33 -0700 All reviewed patches have been landed. Closing bug. 282938 2016-07-06 13:37:11 -0700 2016-07-06 14:53:58 -0700 Patch bug-159487-20160706133634.patch text/plain 3042 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 MjEzYzk2MjlkNGEyMTIzMmYwYmYwYjkxYTk5M2NkOWVmMTUxNDVhLi5hYjdiMDUzYzA4MzVmNmE2 YzgwYzBlYjQyMmYyOWJkMTlkMjUwNDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wNy0wNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogSGl0dGluZyDijJhUIGlu IFdlYiBJbnNwZWN0b3Igbm8gbG9uZ2VyIG9wZW5zIGluIG5ldyB0YWIgaW4gU2FmYXJpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0ODcKKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMjcxODgwNDcKKworICAgICAgICBJIGFsc28gY2hhbmdlZCBDb21t YW5kLTEsIGV0Yy4gdG8gQ29tbWFuZC1PcHRpb24tMSwgZXRjLiB0byBzd2l0Y2ggdGFicy4gVGhl IG51bWJlciBjb21tYW5kcworICAgICAgICBjb25mbGljdGVkIHNpbWlsYXJseSB3aXRoIFNhZmFy aSBhbmQgZGlkbid0IHdvcmsgZm9yIG1lIGFzIGEgV2ViIEluc3BlY3RvciBzaG9ydGN1dCBhdCBh bGwuCisgICAgICAgIFdlIGNhbid0IHVzZSBDb21tYW5kLVNoaWZ0IGJlY2F1c2Ugb2YgQ29tbWFu ZC1TaGlmdC0zIGFuZCBDb21tYW5kLVNoaWZ0LTQgZm9yIHNjcmVlbnNob3RzLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9C YXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCk6CisKIDIw MTYtMDctMDUgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFN3aXRjaCBsYXN0IHVzZXMgb2YgLXdlYmtpdC1saW5lYXItZ3JhZGll bnQoKSB0byBsaW5lYXItZ3JhZGllbnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IGEyMmQ0NWQ4NTU1NDk1YjU2MmEzNTUzNGM3 MmY0NTdmMzdiNmVmN2MuLjJlMzgwMjY2ODRjYThjMTBlYjM1NGEwYzdlYzgyZTY4YjVmM2QyOGQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKQEAgLTI2OCw4ICsyNjgsOCBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0 aW9uKCkKICAgICB0aGlzLl9kZWNyZWFzZVpvb21LZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYklu c3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1v ZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lktl eS5NaW51cywgdGhpcy5fZGVjcmVhc2Vab29tLmJpbmQodGhpcykpOwogICAgIHRoaXMuX3Jlc2V0 Wm9vbUtleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQo V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwg IjAiLCB0aGlzLl9yZXNldFpvb20uYmluZCh0aGlzKSk7CiAKLSAgICB0aGlzLl9zaG93VGFiQXRJ bmRleEtleWJvYXJkU2hvcnRjdXRzID0gWzEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDldLm1hcCgo aSkgPT4gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsIGAke2l9YCwgdGhpcy5fc2hv d1RhYkF0SW5kZXguYmluZCh0aGlzLCBpKSkpOwotICAgIHRoaXMuX29wZW5OZXdUYWJLZXlib2Fy ZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsICJUIiwgdGhpcy5z aG93TmV3VGFiVGFiLmJpbmQodGhpcykpOworICAgIHRoaXMuX3Nob3dUYWJBdEluZGV4S2V5Ym9h cmRTaG9ydGN1dHMgPSBbMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOV0ubWFwKChpKSA9PiBuZXcg V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0Lk1vZGlmaWVyLk9wdGlvbiwgYCR7aX1gLCB0aGlzLl9zaG93VGFiQXRJbmRleC5iaW5kKHRo aXMsIGkpKSk7CisgICAgdGhpcy5fb3Blbk5ld1RhYktleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu TW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0 Lk1vZGlmaWVyLlNoaWZ0LCAiVCIsIHRoaXMuc2hvd05ld1RhYlRhYi5iaW5kKHRoaXMpKTsKIAog ICAgIHRoaXMudGFiQnJvd3NlciA9IG5ldyBXZWJJbnNwZWN0b3IuVGFiQnJvd3Nlcihkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGFiLWJyb3dzZXIiKSwgdGhpcy50YWJCYXIsIHRoaXMubmF2aWdh dGlvblNpZGViYXIsIHRoaXMuZGV0YWlsc1NpZGViYXIpOwogICAgIHRoaXMudGFiQnJvd3Nlci5h ZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UYWJCcm93c2VyLkV2ZW50LlNlbGVjdGVkVGFi Q29udGVudFZpZXdEaWRDaGFuZ2UsIHRoaXMuX3RhYkJyb3dzZXJTZWxlY3RlZFRhYkNvbnRlbnRW aWV3RGlkQ2hhbmdlLCB0aGlzKTsK 282953 2016-07-06 14:54:01 -0700 2016-07-06 20:26:28 -0700 Patch bug-159487-20160706145328.patch text/plain 3110 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 MjEzYzk2MjlkNGEyMTIzMmYwYmYwYjkxYTk5M2NkOWVmMTUxNDVhLi40MDJhZWQyZDkyZjk4NTc3 MDA3OGM1NjY5MDMwOGQzYzQyMjE4MTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wNy0wNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogSGl0dGluZyDijJhUIGlu IFdlYiBJbnNwZWN0b3Igbm8gbG9uZ2VyIG9wZW5zIGluIG5ldyB0YWIgaW4gU2FmYXJpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0ODcKKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMjcxODgwNDcKKworICAgICAgICBDaGFuZ2UgQ29tbWFuZC1UIHRv IENvbW1hbmQtT3B0aW9uLVQgdG8gb3BlbiBhIG5ldyB0YWIuCisKKyAgICAgICAgSSBhbHNvIGNo YW5nZWQgQ29tbWFuZC0xLCBldGMuIHRvIENvbW1hbmQtT3B0aW9uLTEsIGV0Yy4gdG8gc3dpdGNo IHRhYnMuIFRoZSBudW1iZXIgY29tbWFuZHMKKyAgICAgICAgY29uZmxpY3RlZCBzaW1pbGFybHkg d2l0aCBTYWZhcmkgYW5kIGRpZG4ndCB3b3JrIGZvciBtZSBhcyBhIFdlYiBJbnNwZWN0b3Igc2hv cnRjdXQgYXQgYWxsLgorICAgICAgICBXZSBjYW4ndCB1c2UgQ29tbWFuZC1TaGlmdCBiZWNhdXNl IG9mIENvbW1hbmQtU2hpZnQtMyBhbmQgQ29tbWFuZC1TaGlmdC00IGZvciBzY3JlZW5zaG90cy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2Fk ZWQpOgorCiAyMDE2LTA3LTA1ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTd2l0Y2ggbGFzdCB1c2VzIG9mIC13ZWJraXQtbGlu ZWFyLWdyYWRpZW50KCkgdG8gbGluZWFyLWdyYWRpZW50KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCBhMjJkNDVkODU1NTQ5NWI1 NjJhMzU1MzRjNzJmNDU3ZjM3YjZlZjdjLi4wY2QwYjAyNDM3MjhkYWZkZjEwMDMzNTEzZjFiZmJh MTNiMDBmYWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NYWluLmpzCkBAIC0yNjgsOCArMjY4LDggQEAgV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2Fk ZWQgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5fZGVjcmVhc2Vab29tS2V5Ym9hcmRTaG9ydGN1dCA9 IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5LZXkuTWludXMsIHRoaXMuX2RlY3JlYXNlWm9vbS5iaW5kKHRoaXMpKTsKICAgICB0 aGlzLl9yZXNldFpvb21LZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRP ckNvbnRyb2wsICIwIiwgdGhpcy5fcmVzZXRab29tLmJpbmQodGhpcykpOwogCi0gICAgdGhpcy5f c2hvd1RhYkF0SW5kZXhLZXlib2FyZFNob3J0Y3V0cyA9IFsxLCAyLCAzLCA0LCA1LCA2LCA3LCA4 LCA5XS5tYXAoKGkpID0+IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCBgJHtpfWAs IHRoaXMuX3Nob3dUYWJBdEluZGV4LmJpbmQodGhpcywgaSkpKTsKLSAgICB0aGlzLl9vcGVuTmV3 VGFiS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCAi VCIsIHRoaXMuc2hvd05ld1RhYlRhYi5iaW5kKHRoaXMpKTsKKyAgICB0aGlzLl9zaG93VGFiQXRJ bmRleEtleWJvYXJkU2hvcnRjdXRzID0gWzEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDldLm1hcCgo aSkgPT4gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5 Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5PcHRpb24sIGAke2l9YCwgdGhpcy5fc2hvd1RhYkF0SW5k ZXguYmluZCh0aGlzLCBpKSkpOworICAgIHRoaXMuX29wZW5OZXdUYWJLZXlib2FyZFNob3J0Y3V0 ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9h cmRTaG9ydGN1dC5Nb2RpZmllci5PcHRpb24sICJUIiwgdGhpcy5zaG93TmV3VGFiVGFiLmJpbmQo dGhpcykpOwogCiAgICAgdGhpcy50YWJCcm93c2VyID0gbmV3IFdlYkluc3BlY3Rvci5UYWJCcm93 c2VyKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YWItYnJvd3NlciIpLCB0aGlzLnRhYkJhciwg dGhpcy5uYXZpZ2F0aW9uU2lkZWJhciwgdGhpcy5kZXRhaWxzU2lkZWJhcik7CiAgICAgdGhpcy50 YWJCcm93c2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRhYkJyb3dzZXIuRXZlbnQu U2VsZWN0ZWRUYWJDb250ZW50Vmlld0RpZENoYW5nZSwgdGhpcy5fdGFiQnJvd3NlclNlbGVjdGVk VGFiQ29udGVudFZpZXdEaWRDaGFuZ2UsIHRoaXMpOwo=