159477 2016-07-06 11:16:05 -0700 [iOS] Text suggestions should be cleared when form input session is invalidated 2016-07-06 16:38:39 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cpugh webkit-unassigned commit-queue cpugh mitz oldest_to_newest 1208285 0 cpugh 2016-07-06 11:16:05 -0700 Text suggestions should be cleared when form input session is invalidated. Patch forthcoming. 1208291 1 282913 cpugh 2016-07-06 11:21:02 -0700 Created attachment 282913 [iOS] Text suggestions should be cleared when form input session is invalidated.txt 1208427 2 282957 cpugh 2016-07-06 16:07:06 -0700 Created attachment 282957 Patch v2 New patch where we just set the input delegate's suggestions to nil rather than nil-ing out the suggestions that the client set. 1208428 3 282957 mitz 2016-07-06 16:09:34 -0700 Comment on attachment 282957 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=282957&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:373 > + [suggestionDelegate setSuggestions:nil]; Can’t write suggestionDelegate.suggestions = nil? 1208432 4 282957 commit-queue 2016-07-06 16:38:35 -0700 Comment on attachment 282957 Patch v2 Clearing flags on attachment: 282957 Committed r202884: <http://trac.webkit.org/changeset/202884> 1208433 5 commit-queue 2016-07-06 16:38:39 -0700 All reviewed patches have been landed. Closing bug. 282913 2016-07-06 11:21:02 -0700 2016-07-06 16:07:06 -0700 [iOS] Text suggestions should be cleared when form input session is invalidated.txt [iOS] Text suggestions should be cleared when form input session is invalidated.txt text/plain 1194 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjg2MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA3LTA2ICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVGV4dCBzdWdnZXN0aW9u cyBzaG91bGQgYmUgY2xlYXJlZCB3aGVuIGZvcm0gaW5wdXQgc2Vzc2lvbiBpcyBpbnZhbGlkYXRl ZCAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTk0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAo LVtXS0Zvcm1JbnB1dFNlc3Npb24gaW52YWxpZGF0ZV0pOiBTZXQgc3VnZ2VzdGlvbnMgdG8gbmls IHdoZW4gYSBmb3JtIGlucHV0IHNlc3Npb24gaXMgaW52YWxpZGF0ZWQuCisgICAgICAgIFRoaXMg d2lsbCBzZXQgdGhlIGtleWJvYXJkIFF1aWNrVHlwZSBzdWdnZXN0aW9ucyBiYWNrIHRvIHRoZWly IGRlZmF1bHQgdmFsdWVzLgorCiAyMDE2LTA3LTA2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjAyNzI1 LgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDIwMjgzMykKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNv cHkpCkBAIC0zNjgsNiArMzY4LDcgQEAKIAogLSAodm9pZClpbnZhbGlkYXRlCiB7CisgICAgW3Nl bGYgc2V0U3VnZ2VzdGlvbnM6bmlsXTsKICAgICBfY29udGVudFZpZXcgPSBuaWw7CiB9CiAK 282957 2016-07-06 16:07:06 -0700 2016-07-06 16:38:35 -0700 Patch v2 [iOS] Text suggestions should be cleared when form input session is invalidated.txt text/plain 1407 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjg2MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA3LTA2ICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVGV4dCBzdWdnZXN0aW9u cyBzaG91bGQgYmUgY2xlYXJlZCB3aGVuIGZvcm0gaW5wdXQgc2Vzc2lvbiBpcyBpbnZhbGlkYXRl ZCAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTk0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAo LVtXS0Zvcm1JbnB1dFNlc3Npb24gaW52YWxpZGF0ZV0pOiBTZXQgaW5wdXQgZGVsZWdhdGUncyBz dWdnZXN0aW9ucyB0byBuaWwgd2hlbiBhIGZvcm0gaW5wdXQgc2Vzc2lvbiBpcworICAgICAgICBp bnZhbGlkYXRlZC4gVGhpcyB3aWxsIHNldCB0aGUga2V5Ym9hcmQgUXVpY2tUeXBlIHN1Z2dlc3Rp b25zIGJhY2sgdG8gdGhlaXIgZGVmYXVsdCB2YWx1ZXMuCisKIDIwMTYtMDctMDYgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIyMDI3MjUuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMjAyODMz KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTM2OCw2ICszNjgsMTAgQEAKIAogLSAodm9pZClpbnZh bGlkYXRlCiB7CisjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAwMDAw CisgICAgaWQgPFVJVGV4dElucHV0U3VnZ2VzdGlvbkRlbGVnYXRlPiBzdWdnZXN0aW9uRGVsZWdh dGUgPSAoaWQgPFVJVGV4dElucHV0U3VnZ2VzdGlvbkRlbGVnYXRlPilfY29udGVudFZpZXcuaW5w dXREZWxlZ2F0ZTsKKyAgICBbc3VnZ2VzdGlvbkRlbGVnYXRlIHNldFN1Z2dlc3Rpb25zOm5pbF07 CisjZW5kaWYKICAgICBfY29udGVudFZpZXcgPSBuaWw7CiB9CiAK