15947 2007-11-11 23:31:41 -0800 speed up page loading a bit by inlining 2018-10-03 08:53:19 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 60962 0 darin 2007-11-11 23:31:41 -0800 There's a hot function, isScheduledLocationChangePending, which we can inline just enough to make a difference. I discovered this a while back while profiling page load tests. 60963 1 17196 darin 2007-11-11 23:36:40 -0800 Created attachment 17196 patch 61025 2 darin 2007-11-12 14:31:08 -0800 r27729 17196 2007-11-11 23:36:40 -0800 2007-11-12 09:02:25 -0800 patch FrameLoaderInlinePatch.txt text/plain 2814 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzcxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMTEtMTEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NDcKKyAgICAgICAgICBzcGVl ZCB1cCBwYWdlIGxvYWRpbmcgYSBiaXQgYnkgaW5saW5pbmcKKworICAgICAgICAqIGxvYWRlci9G cmFtZUxvYWRlci5jcHA6IChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6aXNMb2NhdGlvbkNoYW5nZSk6 CisgICAgICAgIEZhY3RvcmVkIG91dCB0aGUgc2xvdyBjYXNlIG9mIGlzU2NoZWR1bGVkTG9jYXRp b25DaGFuZ2VQZW5kaW5nIGludG8gdGhpcy4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRl ci5oOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmlzU2NoZWR1bGVkTG9jYXRpb25D aGFuZ2VQZW5kaW5nKTogQWRkZWQgYW4KKyAgICAgICAgaW5saW5lIGNoZWNrIG9mIHRoZSBmYXIg YW5kIGF3YXkgbW9zdCBjb21tb24gY2FzZSwgd2hlcmUgbV9zY2hlZHVsZWRSZWRpcmVjdGlvbgor ICAgICAgICBpcyAwOyB0aGUgcmVzdCBpcyBpbiB0aGUgaXNMb2NhdGlvbkNoYW5nZSBmdW5jdGlv bi4KKwogMjAwNy0xMS0xMSAgSnVzdGluIEhheWdvb2QgIDxqaGF5Z29vZEByZWFrdGl4LmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAkocmV2aXNpb24gMjc3MDQpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEzNzYsMTEgKzEzNzYsOSBAQCB2b2lkIEZyYW1lTG9hZGVyOjpz Y2hlZHVsZVJlZnJlc2goYm9vbCB3CiAgICAgbV9jYWNoZVBvbGljeSA9IENhY2hlUG9saWN5UmVm cmVzaDsKIH0KIAotYm9vbCBGcmFtZUxvYWRlcjo6aXNTY2hlZHVsZWRMb2NhdGlvbkNoYW5nZVBl bmRpbmcoKSBjb25zdAorYm9vbCBGcmFtZUxvYWRlcjo6aXNMb2NhdGlvbkNoYW5nZShjb25zdCBT Y2hlZHVsZWRSZWRpcmVjdGlvbiYgcmVkaXJlY3Rpb24pCiB7Ci0gICAgaWYgKCFtX3NjaGVkdWxl ZFJlZGlyZWN0aW9uKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgc3dpdGNoIChtX3NjaGVk dWxlZFJlZGlyZWN0aW9uLT50eXBlKSB7CisgICAgc3dpdGNoIChyZWRpcmVjdGlvbi50eXBlKSB7 CiAgICAgICAgIGNhc2UgU2NoZWR1bGVkUmVkaXJlY3Rpb246OnJlZGlyZWN0aW9uOgogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBjYXNlIFNjaGVkdWxlZFJlZGlyZWN0aW9uOjpo aXN0b3J5TmF2aWdhdGlvbjoKSW5kZXg6IFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAkocmV2aXNpb24gMjc3MDQp CisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOTgs NyArMjk4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBTdHJpbmcgYmFzZVRhcmdl dCgpIGNvbnN0OwogICAgICAgICBLVVJMIGRhdGFVUkxCYXNlRnJvbVJlcXVlc3QoY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0KSBjb25zdDsKIAotICAgICAgICBib29sIGlzU2NoZWR1bGVk TG9jYXRpb25DaGFuZ2VQZW5kaW5nKCkgY29uc3Q7CisgICAgICAgIGJvb2wgaXNTY2hlZHVsZWRM b2NhdGlvbkNoYW5nZVBlbmRpbmcoKSBjb25zdCB7IHJldHVybiBtX3NjaGVkdWxlZFJlZGlyZWN0 aW9uICYmIGlzTG9jYXRpb25DaGFuZ2UoKm1fc2NoZWR1bGVkUmVkaXJlY3Rpb24pOyB9CiAgICAg ICAgIHZvaWQgc2NoZWR1bGVIVFRQUmVkaXJlY3Rpb24oZG91YmxlIGRlbGF5LCBjb25zdCBTdHJp bmcmIFVSTCk7CiAgICAgICAgIHZvaWQgc2NoZWR1bGVMb2NhdGlvbkNoYW5nZShjb25zdCBTdHJp bmcmIFVSTCwgY29uc3QgU3RyaW5nJiByZWZlcnJlciwgYm9vbCBsb2NrSGlzdG9yeSA9IHRydWUs IGJvb2wgdXNlckdlc3R1cmUgPSBmYWxzZSk7CiAgICAgICAgIHZvaWQgc2NoZWR1bGVSZWZyZXNo KGJvb2wgdXNlckdlc3R1cmUgPSBmYWxzZSk7CkBAIC01NjAsNiArNTYwLDggQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgICAgICB2b2lkIGRpc3BhdGNoRGlkRmluaXNoTG9hZGluZyhEb2N1bWVu dExvYWRlciosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllcik7CiAgICAgICAgIGJvb2wgZGlzcGF0 Y2hEaWRMb2FkUmVzb3VyY2VGcm9tTWVtb3J5Q2FjaGUoRG9jdW1lbnRMb2FkZXIqLCBjb25zdCBS ZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiwgaW50IGxlbmd0aCk7CiAK KyAgICAgICAgc3RhdGljIGJvb2wgaXNMb2NhdGlvbkNoYW5nZShjb25zdCBTY2hlZHVsZWRSZWRp cmVjdGlvbiYpOworCiAgICAgICAgIEZyYW1lKiBtX2ZyYW1lOwogICAgICAgICBGcmFtZUxvYWRl ckNsaWVudCogbV9jbGllbnQ7CiAK