159465 2016-07-06 05:31:23 -0700 [GTK][Threaded Compositor] Web view background colors don't work 2016-07-21 00:26:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159455 154066 1 cgarcia webkit-unassigned bugs-noreply yoon zan oldest_to_newest 1208186 0 cgarcia 2016-07-06 05:31:23 -0700 Bug #159455 makes them work for GTK+ when not using the threaded compositor, but it's not enough for the threaded compositor. 1208590 1 283004 cgarcia 2016-07-07 03:36:14 -0700 Created attachment 283004 Patch 1212969 2 283004 mcatanzaro 2016-07-20 17:30:00 -0700 Comment on attachment 283004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283004&action=review > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:87 > + m_drawsBackground = drawsBackground; This is fine as it is, but my style is to capture only protectedThis and use it explicitly in the lambda, instead of capturing both this and protectedThis. I'm not sure which style is more prevalent in WebKit code. 1213073 3 cgarcia 2016-07-21 00:21:39 -0700 (In reply to comment #2) > Comment on attachment 283004 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283004&action=review > > > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:87 > > + m_drawsBackground = drawsBackground; > > This is fine as it is, but my style is to capture only protectedThis and use > it explicitly in the lambda, instead of capturing both this and > protectedThis. I'm not sure which style is more prevalent in WebKit code. There's no consensus last time we discussed it, some people (like me) prefer to also capture this to make the lambda body easier to read without having to use protectedThis-> everywhere. 1213074 4 cgarcia 2016-07-21 00:26:33 -0700 Committed r203497: <http://trac.webkit.org/changeset/203497> 283004 2016-07-07 03:36:14 -0700 2016-07-20 17:30:00 -0700 Patch wk2-tc-view-background-color.diff text/plain 6870 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMjcwMWVmLi40MWNjYzhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTYtMDctMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdW1RocmVhZGVkIENvbXBvc2l0b3JdIFdlYiB2aWV3IGJhY2tncm91 bmQgY29sb3JzIGRvbid0IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmNyZWF0ZVByaW1hcnlHcmFwaGljc0xheWVy KTogSW5pdGlhbGl6ZSBmcmFtZSB2aWV3IGxheWVyIG9wYWNpdHkgZm9yIHBsYXRmb3JtcyBub3QK KyAgICAgICAgdXNpbmcgdGhlIHRpbGVkIGNhY2hlIGxheWVyLgorCiAyMDE2LTA3LTA2ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ29vcmRp bmF0ZWQgR3JhcGhpY3NdIFJlbW92ZSB0b0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllciBhbmQgdXNl IGRvd25jYXN0IGluc3RlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQmFja2luZy5jcHAKaW5kZXggMTg1MWMwNi4uNzdkYTUyZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTMxNSw3ICszMTUsNyBA QCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6Y3JlYXRlUHJpbWFyeUdyYXBoaWNzTGF5ZXIoKQog I2lmICFQTEFURk9STShJT1MpCiAgICAgaWYgKG1faXNNYWluRnJhbWVSZW5kZXJWaWV3TGF5ZXIp IHsKICAgICAgICAgLy8gUGFnZSBzY2FsZSBpcyBhcHBsaWVkIGFib3ZlIHRoZSBSZW5kZXJWaWV3 IG9uIGlPUy4KLSAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c09wYXF1ZSh0cnVl KTsKKyAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c09wYXF1ZSghY29tcG9zaXRv cigpLnZpZXdIYXNUcmFuc3BhcmVudEJhY2tncm91bmQoKSk7CiAgICAgICAgIG1fZ3JhcGhpY3NM YXllci0+c2V0QXBwbGllc1BhZ2VTY2FsZSgpOwogICAgIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4 IDg0ZTE5ZTEuLmRmOWVhM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNi0wNy0w NyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS11bVGhyZWFkZWQgQ29tcG9zaXRvcl0gV2ViIHZpZXcgYmFja2dyb3VuZCBjb2xvcnMgZG9u J3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU5NDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRD b21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGhyZWFkZWRDb21wb3NpdG9yOjpzZXRE cmF3c0JhY2tncm91bmQpOiBTZXQgbV9kcmF3c0JhY2tncm91bmQgaW4gY29tcG9zaXRpbmcgdGhy ZWFkIGFuZCBzY2hlZHVsZSBhCisgICAgICAgIGxheWVyIGZsdXNoLgorICAgICAgICAoV2ViS2l0 OjpUaHJlYWRlZENvbXBvc2l0b3I6OnJlbmRlckxheWVyVHJlZSk6IENsZWFyIHRoZSBhcmVhIHdo ZW4gbm90IHJlbmRlcmluZyBiYWNrZ3JvdW5kcy4KKyAgICAgICAgKiBTaGFyZWQvQ29vcmRpbmF0 ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmg6CisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvVGhyZWFkZWRDb29y ZGluYXRlZExheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpUaHJlYWRlZENvb3Jk aW5hdGVkTGF5ZXJUcmVlSG9zdDo6cGFnZUJhY2tncm91bmRUcmFuc3BhcmVuY3lDaGFuZ2VkKTog Tm90aWZ5IHRoZSBjb21wb3NpdG9yLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29y ZGluYXRlZEdyYXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0Lmg6CisKIDIw MTYtMDctMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtDb29yZGluYXRlZCBHcmFwaGljc10gUmVtb3ZlIHRvQ29vcmRpbmF0ZWRHcmFwaGlj c0xheWVyIGFuZCB1c2UgZG93bmNhc3QgaW5zdGVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVk Q29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGlj cy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcAppbmRleCAyNWNhZWY3 Li45OWI5MGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRH cmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0 b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcApAQCAtODEsNiArODEsMTQgQEAgdm9pZCBUaHJlYWRl ZENvbXBvc2l0b3I6OnNldERldmljZVNjYWxlRmFjdG9yKGZsb2F0IHNjYWxlKQogICAgIH0pOwog fQogCit2b2lkIFRocmVhZGVkQ29tcG9zaXRvcjo6c2V0RHJhd3NCYWNrZ3JvdW5kKGJvb2wgZHJh d3NCYWNrZ3JvdW5kKQoreworICAgIG1fY29tcG9zaXRpbmdSdW5Mb29wLT5wZXJmb3JtVGFzayhb dGhpcywgcHJvdGVjdGVkVGhpcyA9IFJlZjxUaHJlYWRlZENvbXBvc2l0b3I+KCp0aGlzKSwgZHJh d3NCYWNrZ3JvdW5kXSB7CisgICAgICAgIG1fZHJhd3NCYWNrZ3JvdW5kID0gZHJhd3NCYWNrZ3Jv dW5kOworICAgICAgICBzY2hlZHVsZURpc3BsYXlJbW1lZGlhdGVseSgpOworICAgIH0pOworfQor CiB2b2lkIFRocmVhZGVkQ29tcG9zaXRvcjo6ZGlkQ2hhbmdlVmlld3BvcnRTaXplKGNvbnN0IElu dFNpemUmIHNpemUpCiB7CiAgICAgbV9jb21wb3NpdGluZ1J1bkxvb3AtPnBlcmZvcm1UYXNrU3lu YyhbdGhpcywgcHJvdGVjdGVkVGhpcyA9IFJlZjxUaHJlYWRlZENvbXBvc2l0b3I+KCp0aGlzKSwg c2l6ZV0gewpAQCAtMjAwLDcgKzIwOCwxMSBAQCB2b2lkIFRocmVhZGVkQ29tcG9zaXRvcjo6cmVu ZGVyTGF5ZXJUcmVlKCkKICAgICB2aWV3cG9ydFRyYW5zZm9ybS5zY2FsZShtX3ZpZXdwb3J0Q29u dHJvbGxlci0+cGFnZVNjYWxlRmFjdG9yKCkgKiBtX2RldmljZVNjYWxlRmFjdG9yKTsKICAgICB2 aWV3cG9ydFRyYW5zZm9ybS50cmFuc2xhdGUoLXNjcm9sbFBvc3Rpb24ueCgpLCAtc2Nyb2xsUG9z dGlvbi55KCkpOwogCi0gICAgbV9zY2VuZS0+cGFpbnRUb0N1cnJlbnRHTENvbnRleHQodmlld3Bv cnRUcmFuc2Zvcm0sIDEsIGNsaXBSZWN0LCBDb2xvcjo6d2hpdGUsIGZhbHNlLCBzY3JvbGxQb3N0 aW9uKTsKKyAgICBpZiAoIW1fZHJhd3NCYWNrZ3JvdW5kKSB7CisgICAgICAgIGdsQ2xlYXJDb2xv cigwLCAwLCAwLCAwKTsKKyAgICAgICAgZ2xDbGVhcihHTF9DT0xPUl9CVUZGRVJfQklUKTsKKyAg ICB9CisgICAgbV9zY2VuZS0+cGFpbnRUb0N1cnJlbnRHTENvbnRleHQodmlld3BvcnRUcmFuc2Zv cm0sIDEsIGNsaXBSZWN0LCBDb2xvcjo6dHJhbnNwYXJlbnQsICFtX2RyYXdzQmFja2dyb3VuZCwg c2Nyb2xsUG9zdGlvbik7CiAKICAgICBnbENvbnRleHQoKS0+c3dhcEJ1ZmZlcnMoKTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL3RocmVh ZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9Db29yZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0 b3IuaAppbmRleCAyYTEyMzZhLi5jYzc0ZDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21w b3NpdG9yLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv dGhyZWFkZWRjb21wb3NpdG9yL1RocmVhZGVkQ29tcG9zaXRvci5oCkBAIC02Niw2ICs2Niw3IEBA IHB1YmxpYzoKIAogICAgIHZvaWQgc2V0TmF0aXZlU3VyZmFjZUhhbmRsZUZvckNvbXBvc2l0aW5n KHVpbnQ2NF90KTsKICAgICB2b2lkIHNldERldmljZVNjYWxlRmFjdG9yKGZsb2F0KTsKKyAgICB2 b2lkIHNldERyYXdzQmFja2dyb3VuZChib29sKTsKIAogICAgIHZvaWQgdXBkYXRlU2NlbmVTdGF0 ZShjb25zdCBXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzU3RhdGUmKTsKIApAQCAtMTA0LDYg KzEwNSw3IEBAIHByaXZhdGU6CiAKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fdmlld3BvcnRTaXpl OwogICAgIGZsb2F0IG1fZGV2aWNlU2NhbGVGYWN0b3IgeyAxIH07CisgICAgYm9vbCBtX2RyYXdz QmFja2dyb3VuZCB7IHRydWUgfTsKICAgICB1aW50NjRfdCBtX25hdGl2ZVN1cmZhY2VIYW5kbGUg eyAwIH07CiAKICAgICBzdGQ6OnVuaXF1ZV9wdHI8Q29tcG9zaXRpbmdSdW5Mb29wPiBtX2NvbXBv c2l0aW5nUnVuTG9vcDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBo aWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAppbmRleCA5YTAzYzI1Li41 OTEzODBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9UaHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv VGhyZWFkZWRDb29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC03MSw2ICs3MSwxMiBAQCB2 b2lkIFRocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpkZXZpY2VPclBhZ2VTY2FsZUZh Y3RvckNoYW5nZWQoKQogICAgIG1fY29tcG9zaXRvci0+c2V0RGV2aWNlU2NhbGVGYWN0b3IobV93 ZWJQYWdlLmRldmljZVNjYWxlRmFjdG9yKCkpOwogfQogCit2b2lkIFRocmVhZGVkQ29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0OjpwYWdlQmFja2dyb3VuZFRyYW5zcGFyZW5jeUNoYW5nZWQoKQorewor ICAgIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6cGFnZUJhY2tncm91bmRUcmFuc3BhcmVuY3lD aGFuZ2VkKCk7CisgICAgbV9jb21wb3NpdG9yLT5zZXREcmF3c0JhY2tncm91bmQobV93ZWJQYWdl LmRyYXdzQmFja2dyb3VuZCgpKTsKK30KKwogdm9pZCBUaHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJU cmVlSG9zdDo6c2l6ZURpZENoYW5nZShjb25zdCBJbnRTaXplJiBzaXplKQogewogICAgIENvb3Jk aW5hdGVkTGF5ZXJUcmVlSG9zdDo6c2l6ZURpZENoYW5nZShzaXplKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVh ZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9UaHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdC5oCmluZGV4IDkyNGI3MzAuLmYzM2RmYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0Nvb3JkaW5hdGVkR3JhcGhpY3MvVGhyZWFkZWRDb29yZGluYXRlZExheWVyVHJlZUhvc3QuaApA QCAtNTQsNiArNTQsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgc2Nyb2xsTm9uQ29tcG9zaXRlZENv bnRlbnRzKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIHNjcm9sbFJlY3QpIG92ZXJyaWRlOwogICAg IHZvaWQgc2l6ZURpZENoYW5nZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJikgb3ZlcnJpZGU7CiAg ICAgdm9pZCBkZXZpY2VPclBhZ2VTY2FsZUZhY3RvckNoYW5nZWQoKSBvdmVycmlkZTsKKyAgICB2 b2lkIHBhZ2VCYWNrZ3JvdW5kVHJhbnNwYXJlbmN5Q2hhbmdlZCgpIG92ZXJyaWRlOwogCiAgICAg dm9pZCBjb250ZW50c1NpemVDaGFuZ2VkKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKSBvdmVycmlk ZTsKICAgICB2b2lkIGRpZENoYW5nZVZpZXdwb3J0UHJvcGVydGllcyhjb25zdCBXZWJDb3JlOjpW aWV3cG9ydEF0dHJpYnV0ZXMmKSBvdmVycmlkZTsK