15946 2007-11-11 21:22:00 -0800 add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat) 2007-11-12 22:49:19 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 joshmoz webkit-unassigned gavin.sharp oldest_to_newest 60949 0 joshmoz 2007-11-11 21:22:00 -0800 From the NPAPI Drawing Models spec (http://wiki.mozilla.org/Mac:NPAPI_Drawing_Models): ============== Once the plugin finds a supported drawing model, it calls NPN_SetValue() to tell the browser which drawing model it will use. We're adding a new NPNVariable for this: NPNVpluginDrawingModel = 1000 /* The NPDrawingModel specified by the plugin */ ============== The problem is that NPN_SetValue requires an NPPValue, passing NPNVpluginDrawingModel will not compile. See Mozilla bug 403418 for the original Mozilla bug report. 60950 1 17195 joshmoz 2007-11-11 21:23:05 -0800 Created attachment 17195 fix v1.0 60957 2 ddkilzer 2007-11-11 22:24:33 -0800 (In reply to comment #1) > Created an attachment (id=17195) [edit] > fix v1.0 Please set the review? flag on the attachment (no need to specify a specific user) to make sure it's reviewed. Thanks! 61040 3 17195 darin 2007-11-12 19:00:42 -0800 Comment on attachment 17195 fix v1.0 Looks fine. r=me But we should change the WebKit code to actually use this, instead of misusing the NPNVpluginDrawingModel value. This needs a ChangeLog before it can be checked in. 61041 4 joshmoz 2007-11-12 19:12:10 -0800 Thanks, sorry I didn't notice your changelog requirement for contributors. New patch coming up. 61045 5 17219 joshmoz 2007-11-12 21:33:50 -0800 Created attachment 17219 fix v1.1 61047 6 17219 darin 2007-11-12 22:16:55 -0800 Comment on attachment 17219 fix v1.1 Looks fine. r=me 61052 7 sam 2007-11-12 22:49:19 -0800 Landed in r27745. 17195 2007-11-11 21:23:05 -0800 2007-11-12 21:33:50 -0800 fix v1.0 webkit_npapi1.patch text/plain 614 joshmoz SW5kZXg6IEphdmFTY3JpcHRDb3JlL2JpbmRpbmdzL25wYXBpLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvYmluZGluZ3MvbnBhcGkuaAkocmV2aXNpb24gMjc3MDQpCisrKyBKYXZhU2Ny aXB0Q29yZS9iaW5kaW5ncy9ucGFwaS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMzAsNyArMzMwLDEx IEBACiAgICAgICogZm9ybSBzdWJtaXNzaW9uIGlmIHRoZSBwbHVnaW4gaXMgcGFydCBvZiBhIGZv cm0uIFVzZQogICAgICAqIE5QTl9NZW1BbGxvYygpIHRvIGFsbG9jYXRlIG1lbW9yeSBmb3IgdGhl IHN0cmluZyBkYXRhLgogICAgICAqLwotICAgIE5QUFZmb3JtVmFsdWUgPSAxNiAgICAvKiBOb3Qg aW1wbGVtZW50ZWQgaW4gV2ViS2l0ICovCisgICAgTlBQVmZvcm1WYWx1ZSA9IDE2LCAgICAvKiBO b3QgaW1wbGVtZW50ZWQgaW4gV2ViS2l0ICovCisjaWZkZWYgWFBfTUFDT1NYCisgICAgLyogVXNl ZCBmb3IgbmVnb3RpYXRpbmcgZHJhd2luZyBtb2RlbHMgKi8KKyAgICBOUFBWcGx1Z2luRHJhd2lu Z01vZGVsID0gMTAwMAorI2VuZGlmCiB9IE5QUFZhcmlhYmxlOwogCiAvKgo= 17219 2007-11-12 21:33:50 -0800 2007-11-12 22:16:55 -0800 fix v1.1 webkit_npapi2.patch text/plain 2349 joshmoz SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NzQzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMTEtMTIgIEpvc2ggQWFz ICA8am9zaG1vekBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgLSBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTk0NgorICAgICAgICAgIGFkZCBOUFBWYWx1ZSBOUFBWcGx1Z2luRHJhd2luZ01vZGVsIChNb3pp bGxhIGJ1ZyA0MDM0MTggY29tcGF0KQorCisgICAgICAgICogYmluZGluZ3MvbnBhcGkuaDoKKwog MjAwNy0xMS0xMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtLgpJbmRleDogSmF2YVNjcmlwdENvcmUvYmluZGluZ3MvbnBhcGkuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9iaW5kaW5ncy9ucGFwaS5oCShyZXZpc2lvbiAyNzc0 MSkKKysrIEphdmFTY3JpcHRDb3JlL2JpbmRpbmdzL25wYXBpLmgJKHdvcmtpbmcgY29weSkKQEAg LTMzMCw3ICszMzAsMTEgQEAgdHlwZWRlZiBlbnVtIHsKICAgICAgKiBmb3JtIHN1Ym1pc3Npb24g aWYgdGhlIHBsdWdpbiBpcyBwYXJ0IG9mIGEgZm9ybS4gVXNlCiAgICAgICogTlBOX01lbUFsbG9j KCkgdG8gYWxsb2NhdGUgbWVtb3J5IGZvciB0aGUgc3RyaW5nIGRhdGEuCiAgICAgICovCi0gICAg TlBQVmZvcm1WYWx1ZSA9IDE2ICAgIC8qIE5vdCBpbXBsZW1lbnRlZCBpbiBXZWJLaXQgKi8KKyAg ICBOUFBWZm9ybVZhbHVlID0gMTYsICAgIC8qIE5vdCBpbXBsZW1lbnRlZCBpbiBXZWJLaXQgKi8K KyNpZmRlZiBYUF9NQUNPU1gKKyAgICAvKiBVc2VkIGZvciBuZWdvdGlhdGluZyBkcmF3aW5nIG1v ZGVscyAqLworICAgIE5QUFZwbHVnaW5EcmF3aW5nTW9kZWwgPSAxMDAwCisjZW5kaWYKIH0gTlBQ VmFyaWFibGU7CiAKIC8qCkluZGV4OiBXZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3NDMpCisrKyBXZWJLaXQvbWFjL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA3LTExLTEyICBKb3No IEFhcyAgPGpvc2htb3pAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIC0gaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU5NDYKKyAgICAgICAgICBhZGQgTlBQVmFsdWUgTlBQVnBsdWdpbkRyYXdpbmdNb2RlbCAo TW96aWxsYSBidWcgNDAzNDE4IGNvbXBhdCkKKworICAgICAgICAqIFBsdWdpbnMvV2ViQmFzZU5l dHNjYXBlUGx1Z2luVmlldy5tbToKKyAgICAgICAgKC1bV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmll dyBzZXRWYXJpYWJsZTp2YWx1ZTpdKToKKwogMjAwNy0xMS0xMiAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIGFuZCBHZW9mZi4KSW5k ZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1t CShyZXZpc2lvbiAyNzc0MSkKKysrIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQ bHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYxLDcgKzI1NjEsNyBAQCBzdGF0aWMg T1NTdGF0dXMgVFNNRXZlbnRIYW5kbGVyKEV2ZW50SGFuCiAgICAgICAgICAgICByZXR1cm4gTlBF UlJfTk9fRVJST1I7CiAgICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIGNhc2UgTlBOVnBsdWdp bkRyYXdpbmdNb2RlbDoKKyAgICAgICAgY2FzZSBOUFBWcGx1Z2luRHJhd2luZ01vZGVsOgogICAg ICAgICB7CiAgICAgICAgICAgICAvLyBDYW4gb25seSBzZXQgZHJhd2luZyBtb2RlbCBpbnNpZGUg TlBQX05ldygpCiAgICAgICAgICAgICBpZiAoc2VsZiAhPSBbW3NlbGYgY2xhc3NdIGN1cnJlbnRQ bHVnaW5WaWV3XSkK