159454 2016-07-06 00:23:35 -0700 [Win] Add null pointer check in gesture handling. 2016-07-06 10:12:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham webkit-bug-importer oldest_to_newest 1208106 0 pvollan 2016-07-06 00:23:35 -0700 When handling gestures in WebVew, we should make sure we have a valid scrollable layer. 1208107 1 282856 pvollan 2016-07-06 00:26:10 -0700 Created attachment 282856 Patch 1208108 2 pvollan 2016-07-06 00:30:33 -0700 <rdar://problem/27075268> 1208220 3 282856 bfulgham 2016-07-06 08:17:42 -0700 Comment on attachment 282856 Patch Was there a test case that illustrated this problem? We should try to add a layout test for this. Otherwise, it looks good! r=me. 1208263 4 pvollan 2016-07-06 10:09:54 -0700 (In reply to comment #3) > Comment on attachment 282856 [details] > Patch > > Was there a test case that illustrated this problem? We should try to add a > layout test for this. Otherwise, it looks good! r=me. There is no test case for this problem. I think it would involve creating a function in the Windows event sender which sends WM_GESTURE messages to the WebView. I can look into that :) Thanks for reviewing! 1208264 5 pvollan 2016-07-06 10:12:57 -0700 Committed r202861: <https://trac.webkit.org/changeset/202861> 282856 2016-07-06 00:26:10 -0700 2016-07-06 08:17:42 -0700 Patch bug-159454-20160706002538.patch text/plain 2060 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjg1MykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA3LTA2 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBB ZGQgbnVsbCBwb2ludGVyIGNoZWNrIGluIGdlc3R1cmUgaGFuZGxpbmcuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0NTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAg ICAoV2ViVmlldzo6Z2VzdHVyZSk6CisKIDIwMTYtMDctMDEgIFBlciBBcm5lIFZvbGxhbiAgPHB2 b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IGluZm8uYm1CaXRz UGl4ZWwgPT0gMzIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAyMDI4MDQpCisr KyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg2OSwx MiArMTg2OSwxNiBAQCBib29sIFdlYlZpZXc6Omdlc3R1cmUoV1BBUkFNIHdQYXJhbSwgTFBBCiAg ICAgICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gZGV2aWNlU2NhbGVGYWN0b3IoKTsKICAgICAgICAg SW50U2l6ZSBsb2dpY2FsU2Nyb2xsRGVsdGEoLWRlbHRhWCAqIHNjYWxlRmFjdG9yLCAtZGVsdGFZ ICogc2NhbGVGYWN0b3IpOwogCi0gICAgICAgIGlmICghbV9nZXN0dXJlVGFyZ2V0Tm9kZSB8fCAh bV9nZXN0dXJlVGFyZ2V0Tm9kZS0+cmVuZGVyZXIoKSkgeworICAgICAgICBSZW5kZXJMYXllciog c2Nyb2xsYWJsZUxheWVyID0gbnVsbHB0cjsKKyAgICAgICAgaWYgKG1fZ2VzdHVyZVRhcmdldE5v ZGUgJiYgbV9nZXN0dXJlVGFyZ2V0Tm9kZS0+cmVuZGVyZXIoKSAmJiBtX2dlc3R1cmVUYXJnZXRO b2RlLT5yZW5kZXJlcigpLT5lbmNsb3NpbmdMYXllcigpKQorICAgICAgICAgICAgc2Nyb2xsYWJs ZUxheWVyID0gbV9nZXN0dXJlVGFyZ2V0Tm9kZS0+cmVuZGVyZXIoKS0+ZW5jbG9zaW5nTGF5ZXIo KS0+ZW5jbG9zaW5nU2Nyb2xsYWJsZUxheWVyKCk7CisKKyAgICAgICAgaWYgKCFzY3JvbGxhYmxl TGF5ZXIpIHsKICAgICAgICAgICAgIC8vIFdlIG1pZ2h0IGRpcmVjdGx5IGhpdCB0aGUgZG9jdW1l bnQgd2l0aG91dCBoaXR0aW5nIGFueSBub2RlcwogICAgICAgICAgICAgY29yZUZyYW1lLT52aWV3 KCktPnNjcm9sbEJ5KGxvZ2ljYWxTY3JvbGxEZWx0YSk7CiAgICAgICAgICAgICBzY3JvbGxlZEFy ZWEgPSBjb3JlRnJhbWUtPnZpZXcoKTsKICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICBtX2dl c3R1cmVUYXJnZXROb2RlLT5yZW5kZXJlcigpLT5lbmNsb3NpbmdMYXllcigpLT5lbmNsb3NpbmdT Y3JvbGxhYmxlTGF5ZXIoKS0+c2Nyb2xsQnlSZWN1cnNpdmVseShsb2dpY2FsU2Nyb2xsRGVsdGEs IFdlYkNvcmU6OlJlbmRlckxheWVyOjpTY3JvbGxPZmZzZXRDbGFtcGVkLCAmc2Nyb2xsZWRBcmVh KTsKKyAgICAgICAgICAgIHNjcm9sbGFibGVMYXllci0+c2Nyb2xsQnlSZWN1cnNpdmVseShsb2dp Y2FsU2Nyb2xsRGVsdGEsIFdlYkNvcmU6OlJlbmRlckxheWVyOjpTY3JvbGxPZmZzZXRDbGFtcGVk LCAmc2Nyb2xsZWRBcmVhKTsKIAogICAgICAgICBpZiAoIShVcGRhdGVQYW5uaW5nRmVlZGJhY2tQ dHIoKSAmJiBCZWdpblBhbm5pbmdGZWVkYmFja1B0cigpICYmIEVuZFBhbm5pbmdGZWVkYmFja1B0 cigpKSkgewogICAgICAgICAgICAgQ2xvc2VHZXN0dXJlSW5mb0hhbmRsZVB0cigpKGdlc3R1cmVI YW5kbGUpOwo=