159437 2016-07-05 15:26:02 -0700 Facebook videos without audio tracks will sometimes cause playback controls to appear. 2016-07-12 14:35:11 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159533 InRadar P2 Normal --- 159496 1 jer.noble jer.noble bdakin eric.carlson webkit-bug-importer oldest_to_newest 1207959 0 jer.noble 2016-07-05 15:26:02 -0700 Facebook videos without audio tracks will sometimes cause playback controls to appear. 1207968 1 282818 jer.noble 2016-07-05 15:44:58 -0700 Created attachment 282818 Patch 1207969 2 jer.noble 2016-07-05 15:46:27 -0700 <rdar://problem/27114174> 1208221 3 282818 eric.carlson 2016-07-06 08:24:10 -0700 Comment on attachment 282818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282818&action=review > Source/WebCore/html/HTMLMediaElement.cpp:7119 > + if (!m_updatePlaybackControlsManagerQueue.hasPendingTasks()) > + m_updatePlaybackControlsManagerQueue.enqueueTask(std::bind(&HTMLMediaElement::updatePlaybackControlsManager, this)); Why do we need yet another GenericTaskQueue member variable, couldn't you give m_pauseAfterDetachedTaskQueue a more generic name (e.g. m_deferredTaskQueue?) and use it? If not, don't you need to call m_updatePlaybackControlsManagerQueue.close() in contextDestroyed and in the destructor? 1208677 4 jer.noble 2016-07-07 11:01:30 -0700 Committed r202918: <http://trac.webkit.org/changeset/202918> 282818 2016-07-05 15:44:58 -0700 2016-07-06 08:24:10 -0700 Patch bug-159437-20160705154427.patch text/plain 4935 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgyMDA3MTk5Mjg5Yjdl NzY1MGQ5ZTliNGI3ZDM5ZjZiOGExOWQ4NS4uMmJmNjU1YzliOTE3ZmVkYTA2NmQxM2Q1OTViYjI5 Y2Q3MGVlNzAzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE2LTA3LTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEZhY2Vib29rIHZpZGVvcyB3 aXRob3V0IGF1ZGlvIHRyYWNrcyB3aWxsIHNvbWV0aW1lcyBjYXVzZSBwbGF5YmFjayBjb250cm9s cyB0byBhcHBlYXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTk0MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCZWNhdXNlIHVwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKCkgd2lsbCBjYXVzZSB0 aGUgc2Vzc2lvbiBtYW5hZ2VyIHRvIHdhbGsgdGhyb3VnaCBhbGwKKyAgICAgICAgdGhlIG91dHN0 YW5kaW5nIHNlc3Npb25zIGFza2luZyBpZiBpdCBjYW5Db250cm9sQ29udHJvbHNNYW5hZ2VyKCks IHNvbWUgc2Vzc2lvbnMgd2lsbCBzYXkKKyAgICAgICAgdGhleSBjYW4gY29udHJvbCB0aGUgY29u dHJvbHMgbWFuYWdlciBpZiB3ZSBhcmUgY3VycmVudGx5IHByb2Nlc3NpbmcgYSB1c2VyIGdlc3R1 cmUuIFRoaXMgaXMKKyAgICAgICAgb2J2aW91c2x5IG5vdCBpbnRlbmRlZCAodGhlcmUgbWF5IGJl IGEgdXNlciBnZXN0dXJlIHRvIHVuLW11dGUgdmlkZW8gMSwgYnV0IGFuIHVucmVsYXRlZAorICAg ICAgICB2aWRlbyAyIHNob3VsZCBub3QgYmUgYWxsb3dlZCB0byB1c2UgdGhhdCB1c2UgZ2VzdHVy ZSB0byBmdWxmaWxsIGl0cyBvd24gcmVxdWlyZW1lbnRzLikKKworICAgICAgICBTbyBpbiB0aG9z ZSBzaXR1YXRpb25zIHdoZXJlIGNvbmRpdGlvbnMgbWF5IGhhdmUgY2hhbmdlZCBhbmQgdXBkYXRl UGxheWJhY2tDb250cm9sc01hbmFnZXIoKQorICAgICAgICBuZWVkcyB0byBiZSBjYWxsZWQsIGlu c3RlYWQgc2NoZWR1bGUgdGhlIHVwZGF0ZSBmb3IgdGhlIG5leHQgcnVuIGxvb3AuCisgICAgICAg IAorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MTWVkaWFFbGVtZW50OjpzZXRNdXRlZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVk aWFFbGVtZW50OjpsYXlvdXRTaXplQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVk aWFFbGVtZW50Ojp1cGRhdGVQbGF5U3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6Y3JlYXRlTWVkaWFQbGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6c2NoZWR1bGVVcGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlcik6CisgICAgICAg ICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisKIDIwMTYtMDctMDEgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIwMjY0MSk6IE5ldGZs aXggcGxheWJhY2sgc3RhbGxzIGFmdGVyIGEgZmV3IHNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGYzOTI5NzNhMmVlMDliOGIzODZlZWQyYTQ2YTYz YmM1N2U4YjNmMjIuLmM1M2MwMjk0ZjIzZDFmNDljYzQ5OTVjZDQwYzBjN2E2ZjQ3NDE5MmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMzM2OCw3ICszMzY4 LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzZXRNdXRlZChib29sIG11dGVkKQogI2VuZGlm CiAgICAgfQogCi0gICAgdXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKKyAgICBzY2hl ZHVsZVVwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKCk7CiB9CiAKIHZvaWQgSFRNTE1lZGlh RWxlbWVudDo6dG9nZ2xlUGxheVN0YXRlKCkKQEAgLTQwMTMsNyArNDAxMyw3IEBAIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6bGF5b3V0U2l6ZUNoYW5nZWQoKQogCiAgICAgaWYgKCFtX3JlY2VpdmVk TGF5b3V0U2l6ZUNoYW5nZWQpIHsKICAgICAgICAgbV9yZWNlaXZlZExheW91dFNpemVDaGFuZ2Vk ID0gdHJ1ZTsKLSAgICAgICAgdXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKKyAgICAg ICAgc2NoZWR1bGVVcGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlcigpOwogICAgIH0KIH0KIApA QCAtNDg2MSw3ICs0ODYxLDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVQbGF5U3Rh dGUoVXBkYXRlU3RhdGUgdXBkYXRlU3RhdGUpCiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxl bWVudDo6dXBkYXRlUGxheVN0YXRlKCVwKSAtIHNob3VsZEJlUGxheWluZyA9ICVzLCBwbGF5ZXJQ YXVzZWQgPSAlcyIsIHRoaXMsIGJvb2xTdHJpbmcoc2hvdWxkQmVQbGF5aW5nKSwgYm9vbFN0cmlu ZyhwbGF5ZXJQYXVzZWQpKTsKIAogICAgIGlmIChzaG91bGRCZVBsYXlpbmcpIHsKLSAgICAgICAg dXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKKyAgICAgICAgc2NoZWR1bGVVcGRhdGVQ bGF5YmFja0NvbnRyb2xzTWFuYWdlcigpOwogCiAgICAgICAgIHNldERpc3BsYXlNb2RlKFZpZGVv KTsKICAgICAgICAgaW52YWxpZGF0ZUNhY2hlZFRpbWUoKTsKQEAgLTQ4OTUsNyArNDg5NSw3IEBA IHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRlKFVwZGF0ZVN0YXRlIHVwZGF0 ZVN0YXRlKQogICAgICAgICBzdGFydFBsYXliYWNrUHJvZ3Jlc3NUaW1lcigpOwogICAgICAgICBz ZXRQbGF5aW5nKHRydWUpOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIHVwZGF0ZVBsYXliYWNrQ29u dHJvbHNNYW5hZ2VyKCk7CisgICAgICAgIHNjaGVkdWxlVXBkYXRlUGxheWJhY2tDb250cm9sc01h bmFnZXIoKTsKIAogICAgICAgICBpZiAoIXBsYXllclBhdXNlZCkKICAgICAgICAgICAgIG1fcGxh eWVyLT5wYXVzZSgpOwpAQCAtNTk0OSw3ICs1OTQ5LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50 OjpjcmVhdGVNZWRpYVBsYXllcigpCiAgICAgZm9yZ2V0UmVzb3VyY2VTcGVjaWZpY1RyYWNrcygp OwogI2VuZGlmCiAgICAgbV9wbGF5ZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPE1lZGlhUGxheWVyPihz dGF0aWNfY2FzdDxNZWRpYVBsYXllckNsaWVudCY+KCp0aGlzKSk7Ci0gICAgdXBkYXRlUGxheWJh Y2tDb250cm9sc01hbmFnZXIoKTsKKyAgICBzY2hlZHVsZVVwZGF0ZVBsYXliYWNrQ29udHJvbHNN YW5hZ2VyKCk7CiAKICNpZiBFTkFCTEUoV0VCX0FVRElPKQogICAgIGlmIChtX2F1ZGlvU291cmNl Tm9kZSkgewpAQCAtNzExMyw2ICs3MTEzLDEyIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBk YXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKQogICAgICAgICBwYWdlLT5jaHJvbWUoKS5jbGll bnQoKS5zZXRVcFBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKGRvd25jYXN0PE1lZGlhRWxlbWVudFNl c3Npb24+KHNlc3Npb24pLT5lbGVtZW50KCkpOwogfQogCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OnNjaGVkdWxlVXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKQoreworICAgIGlmICghbV91 cGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlclF1ZXVlLmhhc1BlbmRpbmdUYXNrcygpKQorICAg ICAgICBtX3VwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyUXVldWUuZW5xdWV1ZVRhc2soc3Rk OjpiaW5kKCZIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlciwg dGhpcykpOworfQorCiBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OnNob3VsZE92ZXJyaWRlQmFja2dy b3VuZExvYWRpbmdSZXN0cmljdGlvbigpIGNvbnN0CiB7CiAjaWYgRU5BQkxFKFdJUkVMRVNTX1BM QVlCQUNLX1RBUkdFVCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKaW5kZXgg NWQ5MTlkZWFmNGM5ZTY4NmEwZWFmZGZlOGIwZWEwNWU1YTk2OTlhMy4uMmQ4YzdhZmYyNjIyMDg3 OTQzMWYyMTgxMjFjMWFlZDA5NjY1Njc0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmgKQEAgLTc4MSw2ICs3ODEsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBwYXVzZUFm dGVyRGV0YWNoZWRUYXNrKCk7CiAgICAgdm9pZCB1cGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdl cigpOworICAgIHZvaWQgc2NoZWR1bGVVcGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlcigpOwog CiAgICAgdm9pZCB1cGRhdGVSZW5kZXJlcigpOwogCkBAIC03OTcsNiArNzk4LDcgQEAgcHJpdmF0 ZToKICAgICBHZW5lcmljVGFza1F1ZXVlPFRpbWVyPiBtX3NoYWRvd0RPTVRhc2tRdWV1ZTsKICAg ICBHZW5lcmljVGFza1F1ZXVlPFRpbWVyPiBtX3Byb21pc2VUYXNrUXVldWU7CiAgICAgR2VuZXJp Y1Rhc2tRdWV1ZTxUaW1lcj4gbV9wYXVzZUFmdGVyRGV0YWNoZWRUYXNrUXVldWU7CisgICAgR2Vu ZXJpY1Rhc2tRdWV1ZTxUaW1lcj4gbV91cGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlclF1ZXVl OwogICAgIFJlZlB0cjxUaW1lUmFuZ2VzPiBtX3BsYXllZFRpbWVSYW5nZXM7CiAgICAgR2VuZXJp Y0V2ZW50UXVldWUgbV9hc3luY0V2ZW50UXVldWU7CiAK