159431 2016-07-05 12:29:20 -0700 after many successive calls to reportAbandonedObjectGraph(), we still might take a while to GC 2016-07-05 15:41:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 saam jer.noble benjamin fpizlo ggaren gskachkov jer.noble keith_miller mark.lam msaboff oliver sukolsak webkit-bug-importer ysuzuki oldest_to_newest 1207906 0 282805 saam 2016-07-05 12:29:20 -0700 Created attachment 282805 gc bug using JSC API see attached test case. The max size usually creeps up to ~500. And it's often in the 200-400 range. It should be much smaller given how often reportAbandonedObjectGraph() is called. 1207908 1 webkit-bug-importer 2016-07-05 12:31:50 -0700 <rdar://problem/27178534> 1207961 2 282816 jer.noble 2016-07-05 15:30:22 -0700 Created attachment 282816 Patch 1207963 3 saam 2016-07-05 15:35:26 -0700 Jer, I think your patch is for another bug :) 1207966 4 282816 jer.noble 2016-07-05 15:41:49 -0700 Comment on attachment 282816 Patch Whoops! My mistake. 282805 2016-07-05 12:29:20 -0700 2016-07-05 12:29:20 -0700 gc bug using JSC API bug-gc.m application/octet-stream 1471 saam I2ltcG9ydCA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9uLmg+CgojaW1wb3J0IDxKYXZhU2NyaXB0Q29y ZS9KYXZhU2NyaXB0Q29yZS5oPgojaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2VQcml2YXRl Lmg+CgpzaXplX3QgY291bnQ7CnNpemVfdCBjb3VudE1heDsKCnZvaWQgRmluYWxpemUoSlNPYmpl Y3RSZWYgb2JqZWN0KQp7CiAgICAtLWNvdW50OwoJTlNMb2coQCJGaW5hbGl6ZWQhOiBjb3VudDog JWxkLCBjb3VudE1heDogJWxkIiwgY291bnQsIGNvdW50TWF4KTsKfQoKaW50IG1haW4oaW50IGFy Z2MsIGNvbnN0IGNoYXIgKiBhcmd2W10pCnsKCUBhdXRvcmVsZWFzZXBvb2wKCXsKCQlKU0NvbnRl eHQgKmpzQ29udGV4dCA9IFtbSlNDb250ZXh0IGFsbG9jXSBpbml0XTsKCQlqc0NvbnRleHQuZXhj ZXB0aW9uSGFuZGxlciA9IF4oSlNDb250ZXh0ICpjb250ZXh0LCBKU1ZhbHVlICpleGNlcHRpb24p IHsKCQkJTlNMb2coQCJPS0phdmFTY3JpcHQgRXhjZXB0aW9uIGluIGNvbnRleHQgXCIlQFwiOiBc IiVAXCIiLCBjb250ZXh0LCBleGNlcHRpb24pOwoJCX07CgoJCUpTQ2xhc3NEZWZpbml0aW9uIGpz Q2xhc3NEZWZpbml0aW9uID0ga0pTQ2xhc3NEZWZpbml0aW9uRW1wdHk7CgkJanNDbGFzc0RlZmlu aXRpb24uZmluYWxpemUgPSBGaW5hbGl6ZTsKCQlKU0NsYXNzUmVmIGpzQ2xhc3MgPSBKU0NsYXNz Q3JlYXRlKCZqc0NsYXNzRGVmaW5pdGlvbik7CgoJCXdoaWxlICgxKQoJCXsKICAgICAgICAgICAg SlNPYmplY3RSZWYgdGhpc09iamVjdCA9IEpTT2JqZWN0TWFrZShqc0NvbnRleHQuSlNHbG9iYWxD b250ZXh0UmVmLCBqc0NsYXNzLCBOVUxMKTsKICAgICAgICAgICAgKytjb3VudDsKICAgICAgICAg ICAgaWYgKGNvdW50ID4gY291bnRNYXgpCiAgICAgICAgICAgICAgICBjb3VudE1heCA9IGNvdW50 OwoKICAgICAgICAgICAgSlNWYWx1ZVJlZiAJCWV4Y2VwdGlvblZhbHVlID0gMDsKICAgICAgICAg ICAgSlNTdHJpbmdSZWYgCXNjcmlwdEpTID0gSlNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoKENG U3RyaW5nUmVmKUAiIik7CiAgICAgICAgICAgIEpTVmFsdWVSZWYgCQlyZXN1bHQgPSBKU0V2YWx1 YXRlU2NyaXB0KGpzQ29udGV4dC5KU0dsb2JhbENvbnRleHRSZWYsIHNjcmlwdEpTLCB0aGlzT2Jq ZWN0LCAwLCAwLCAmZXhjZXB0aW9uVmFsdWUpOwogICAgICAgICAgICBKU1N0cmluZ1JlbGVhc2Uo c2NyaXB0SlMpOwoKICAgICAgICAgICAgSlNFdmFsdWF0ZVNjcmlwdChqc0NvbnRleHQuSlNHbG9i YWxDb250ZXh0UmVmLCBzY3JpcHRKUywgTlVMTCwgMCwgMCwgJmV4Y2VwdGlvblZhbHVlKTsKCgkJ CUpTR2FyYmFnZUNvbGxlY3QoanNDb250ZXh0LkpTR2xvYmFsQ29udGV4dFJlZik7CgkJCVtbTlNS dW5Mb29wIGN1cnJlbnRSdW5Mb29wXSBydW5VbnRpbERhdGU6W05TRGF0ZSBkYXRlV2l0aFRpbWVJ bnRlcnZhbFNpbmNlTm93OjAuMDAxXV07CgkJfQoJfQoKCXJldHVybiAwOwp9Cg== 282816 2016-07-05 15:30:22 -0700 2016-07-05 15:41:49 -0700 Patch bug-159431-20160705152951.patch text/plain 4978 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgyMDA3MTk5Mjg5Yjdl NzY1MGQ5ZTliNGI3ZDM5ZjZiOGExOWQ4NS4uYzBiYWY0YzY2ZWE4ZDlkMTdkODBhYmVhMTFjMDA3 Mjc5ZGY0NDc1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE2LTA3LTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIGFmdGVyIG1hbnkgc3VjY2Vz c2l2ZSBjYWxscyB0byByZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCgpLCB3ZSBzdGlsbCBtaWdo dCB0YWtlIGEgd2hpbGUgdG8gR0MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTQzMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjcxNzg1MzQ+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSB1 cGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlcigpIHdpbGwgY2F1c2UgdGhlIHNlc3Npb24gbWFu YWdlciB0byB3YWxrIHRocm91Z2ggYWxsCisgICAgICAgIHRoZSBvdXRzdGFuZGluZyBzZXNzaW9u cyBhc2tpbmcgaWYgaXQgY2FuQ29udHJvbENvbnRyb2xzTWFuYWdlcigpLCBzb21lIHNlc3Npb25z IHdpbGwgc2F5CisgICAgICAgIHRoZXkgY2FuIGNvbnRyb2wgdGhlIGNvbnRyb2xzIG1hbmFnZXIg aWYgd2UgYXJlIGN1cnJlbnRseSBwcm9jZXNzaW5nIGEgdXNlciBnZXN0dXJlLiBUaGlzIGlzCisg ICAgICAgIG9idmlvdXNseSBub3QgaW50ZW5kZWQgKHRoZXJlIG1heSBiZSBhIHVzZXIgZ2VzdHVy ZSB0byB1bi1tdXRlIHZpZGVvIDEsIGJ1dCBhbiB1bnJlbGF0ZWQKKyAgICAgICAgdmlkZW8gMiBz aG91bGQgbm90IGJlIGFsbG93ZWQgdG8gdXNlIHRoYXQgdXNlIGdlc3R1cmUgdG8gZnVsZmlsbCBp dHMgb3duIHJlcXVpcmVtZW50cy4pCisKKyAgICAgICAgU28gaW4gdGhvc2Ugc2l0dWF0aW9ucyB3 aGVyZSBjb25kaXRpb25zIG1heSBoYXZlIGNoYW5nZWQgYW5kIHVwZGF0ZVBsYXliYWNrQ29udHJv bHNNYW5hZ2VyKCkKKyAgICAgICAgbmVlZHMgdG8gYmUgY2FsbGVkLCBpbnN0ZWFkIHNjaGVkdWxl IHRoZSB1cGRhdGUgZm9yIHRoZSBuZXh0IHJ1biBsb29wLgorICAgICAgICAKKyAgICAgICAgKiBo dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6c2V0TXV0ZWQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6bGF5 b3V0U2l6ZUNoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBk YXRlUGxheVN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNyZWF0 ZU1lZGlhUGxheWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNjaGVk dWxlVXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIpOgorICAgICAgICAqIGh0bWwvSFRNTE1l ZGlhRWxlbWVudC5oOgorCiAyMDE2LTA3LTAxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMDI2NDEpOiBOZXRmbGl4IHBsYXliYWNrIHN0 YWxscyBhZnRlciBhIGZldyBzZWNvbmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcAppbmRleCBmMzkyOTczYTJlZTA5YjhiMzg2ZWVkMmE0NmE2M2JjNTdlOGIzZjIyLi5j NTNjMDI5NGYyM2QxZjQ5Y2M0OTk1Y2Q0MGMwYzdhNmY0NzQxOTJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTMzNjgsNyArMzM2OCw3IEBAIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6c2V0TXV0ZWQoYm9vbCBtdXRlZCkKICNlbmRpZgogICAgIH0KIAotICAg IHVwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKCk7CisgICAgc2NoZWR1bGVVcGRhdGVQbGF5 YmFja0NvbnRyb2xzTWFuYWdlcigpOwogfQogCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnRvZ2ds ZVBsYXlTdGF0ZSgpCkBAIC00MDEzLDcgKzQwMTMsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OmxheW91dFNpemVDaGFuZ2VkKCkKIAogICAgIGlmICghbV9yZWNlaXZlZExheW91dFNpemVDaGFu Z2VkKSB7CiAgICAgICAgIG1fcmVjZWl2ZWRMYXlvdXRTaXplQ2hhbmdlZCA9IHRydWU7Ci0gICAg ICAgIHVwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKCk7CisgICAgICAgIHNjaGVkdWxlVXBk YXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKICAgICB9CiB9CiAKQEAgLTQ4NjEsNyArNDg2 MSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRlKFVwZGF0ZVN0YXRl IHVwZGF0ZVN0YXRlKQogICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBs YXlTdGF0ZSglcCkgLSBzaG91bGRCZVBsYXlpbmcgPSAlcywgcGxheWVyUGF1c2VkID0gJXMiLCB0 aGlzLCBib29sU3RyaW5nKHNob3VsZEJlUGxheWluZyksIGJvb2xTdHJpbmcocGxheWVyUGF1c2Vk KSk7CiAKICAgICBpZiAoc2hvdWxkQmVQbGF5aW5nKSB7Ci0gICAgICAgIHVwZGF0ZVBsYXliYWNr Q29udHJvbHNNYW5hZ2VyKCk7CisgICAgICAgIHNjaGVkdWxlVXBkYXRlUGxheWJhY2tDb250cm9s c01hbmFnZXIoKTsKIAogICAgICAgICBzZXREaXNwbGF5TW9kZShWaWRlbyk7CiAgICAgICAgIGlu dmFsaWRhdGVDYWNoZWRUaW1lKCk7CkBAIC00ODk1LDcgKzQ4OTUsNyBAQCB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OnVwZGF0ZVBsYXlTdGF0ZShVcGRhdGVTdGF0ZSB1cGRhdGVTdGF0ZSkKICAgICAg ICAgc3RhcnRQbGF5YmFja1Byb2dyZXNzVGltZXIoKTsKICAgICAgICAgc2V0UGxheWluZyh0cnVl KTsKICAgICB9IGVsc2UgewotICAgICAgICB1cGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlcigp OworICAgICAgICBzY2hlZHVsZVVwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKCk7CiAKICAg ICAgICAgaWYgKCFwbGF5ZXJQYXVzZWQpCiAgICAgICAgICAgICBtX3BsYXllci0+cGF1c2UoKTsK QEAgLTU5NDksNyArNTk0OSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y3JlYXRlTWVkaWFQ bGF5ZXIoKQogICAgIGZvcmdldFJlc291cmNlU3BlY2lmaWNUcmFja3MoKTsKICNlbmRpZgogICAg IG1fcGxheWVyID0gc3RkOjptYWtlX3VuaXF1ZTxNZWRpYVBsYXllcj4oc3RhdGljX2Nhc3Q8TWVk aWFQbGF5ZXJDbGllbnQmPigqdGhpcykpOwotICAgIHVwZGF0ZVBsYXliYWNrQ29udHJvbHNNYW5h Z2VyKCk7CisgICAgc2NoZWR1bGVVcGRhdGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlcigpOwogCiAj aWYgRU5BQkxFKFdFQl9BVURJTykKICAgICBpZiAobV9hdWRpb1NvdXJjZU5vZGUpIHsKQEAgLTcx MTMsNiArNzExMywxMiBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXliYWNrQ29u dHJvbHNNYW5hZ2VyKCkKICAgICAgICAgcGFnZS0+Y2hyb21lKCkuY2xpZW50KCkuc2V0VXBQbGF5 YmFja0NvbnRyb2xzTWFuYWdlcihkb3duY2FzdDxNZWRpYUVsZW1lbnRTZXNzaW9uPihzZXNzaW9u KS0+ZWxlbWVudCgpKTsKIH0KIAordm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzY2hlZHVsZVVwZGF0 ZVBsYXliYWNrQ29udHJvbHNNYW5hZ2VyKCkKK3sKKyAgICBpZiAoIW1fdXBkYXRlUGxheWJhY2tD b250cm9sc01hbmFnZXJRdWV1ZS5oYXNQZW5kaW5nVGFza3MoKSkKKyAgICAgICAgbV91cGRhdGVQ bGF5YmFja0NvbnRyb2xzTWFuYWdlclF1ZXVlLmVucXVldWVUYXNrKHN0ZDo6YmluZCgmSFRNTE1l ZGlhRWxlbWVudDo6dXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIsIHRoaXMpKTsKK30KKwog Ym9vbCBIVE1MTWVkaWFFbGVtZW50OjpzaG91bGRPdmVycmlkZUJhY2tncm91bmRMb2FkaW5nUmVz dHJpY3Rpb24oKSBjb25zdAogewogI2lmIEVOQUJMRShXSVJFTEVTU19QTEFZQkFDS19UQVJHRVQp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDVkOTE5ZGVhZjRjOWU2 ODZhMGVhZmRmZThiMGVhMDVlNWE5Njk5YTMuLjJkOGM3YWZmMjYyMjA4Nzk0MzFmMjE4MTIxYzFh ZWQwOTY2NTY3NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC03 ODEsNiArNzgxLDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgcGF1c2VBZnRlckRldGFjaGVkVGFz aygpOwogICAgIHZvaWQgdXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKKyAgICB2b2lk IHNjaGVkdWxlVXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXIoKTsKIAogICAgIHZvaWQgdXBk YXRlUmVuZGVyZXIoKTsKIApAQCAtNzk3LDYgKzc5OCw3IEBAIHByaXZhdGU6CiAgICAgR2VuZXJp Y1Rhc2tRdWV1ZTxUaW1lcj4gbV9zaGFkb3dET01UYXNrUXVldWU7CiAgICAgR2VuZXJpY1Rhc2tR dWV1ZTxUaW1lcj4gbV9wcm9taXNlVGFza1F1ZXVlOwogICAgIEdlbmVyaWNUYXNrUXVldWU8VGlt ZXI+IG1fcGF1c2VBZnRlckRldGFjaGVkVGFza1F1ZXVlOworICAgIEdlbmVyaWNUYXNrUXVldWU8 VGltZXI+IG1fdXBkYXRlUGxheWJhY2tDb250cm9sc01hbmFnZXJRdWV1ZTsKICAgICBSZWZQdHI8 VGltZVJhbmdlcz4gbV9wbGF5ZWRUaW1lUmFuZ2VzOwogICAgIEdlbmVyaWNFdmVudFF1ZXVlIG1f YXN5bmNFdmVudFF1ZXVlOwogCg==