159422 2016-07-05 08:50:34 -0700 AX: Image attachment in email does not show up in AX tree 2016-07-05 17:42:25 -0700 1 1 1 Unclassified WebKit Accessibility Safari 9 All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni esprehn+autocc glenn jcraig jdiggs kondapallykalyan mario samuel_white webkit-bug-importer oldest_to_newest 1207854 0 cfleizach 2016-07-05 08:50:34 -0700 It appears that if an image is loaded after a delay, the AX tree doesn't get updated <rdar://problem/26338151> 1207857 1 282796 cfleizach 2016-07-05 09:00:20 -0700 Created attachment 282796 patch 1207948 2 cfleizach 2016-07-05 14:11:17 -0700 Joanie, are you able to review? 1207962 3 282796 jdiggs 2016-07-05 15:33:36 -0700 Comment on attachment 282796 patch View in context: https://bugs.webkit.org/attachment.cgi?id=282796&action=review I assume images are a missed/unhandled case and that other elements don't suffer from the same problem? One additional, code-specific question inline. > Source/WebCore/rendering/RenderImage.cpp:256 > + if (UNLIKELY(AXObjectCache::accessibilityEnabled())) { What does using this check buy us here (both the macro and accessibilityEnabled())? It looks like more often than not, we're not doing either before calling existingAXObjectCache(). Are images special? Or should this check be (re)moved? 1207973 4 jdiggs 2016-07-05 15:53:38 -0700 Chris: One more thing *if* the response to my questions is going to result in a new patch. On my platform, the before count is 0 and the after count is 1. (ATK doesn't do StaticTextRole children which don't have properties necessitating their own accessible object.) If the answers to my questions won't lead to a new patch, I'll do a patch for this change after your patch lands. Otherwise, a platform check would be cool. 1207974 5 cfleizach 2016-07-05 15:53:58 -0700 (In reply to comment #3) > Comment on attachment 282796 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282796&action=review > > I assume images are a missed/unhandled case and that other elements don't > suffer from the same problem? It appears that the loading of the image does not trigger any thing in AX to update its tree > > One additional, code-specific question inline. > > > Source/WebCore/rendering/RenderImage.cpp:256 > > + if (UNLIKELY(AXObjectCache::accessibilityEnabled())) { > > What does using this check buy us here (both the macro and > accessibilityEnabled())? It looks like more often than not, we're not doing > either before calling existingAXObjectCache(). Are images special? Or should > this check be (re)moved? This is the way that's it used elsewhere in WebCore code. I don't know how much it buys us, but for the general user case I suppose this if check is slightly faster (In reply to comment #3) > Comment on attachment 282796 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282796&action=review > > I assume images are a missed/unhandled case and that other elements don't > suffer from the same problem? > > One additional, code-specific question inline. > > > Source/WebCore/rendering/RenderImage.cpp:256 > > + if (UNLIKELY(AXObjectCache::accessibilityEnabled())) { > > What does using this check buy us here (both the macro and > accessibilityEnabled())? It looks like more often than not, we're not doing > either before calling existingAXObjectCache(). Are images special? Or should > this check be (re)moved? 1207975 6 cfleizach 2016-07-05 15:54:24 -0700 (In reply to comment #4) > Chris: One more thing *if* the response to my questions is going to result > in a new patch. On my platform, the before count is 0 and the after count is > 1. (ATK doesn't do StaticTextRole children which don't have properties > necessitating their own accessible object.) > > If the answers to my questions won't lead to a new patch, I'll do a patch > for this change after your patch lands. Otherwise, a platform check would be > cool. Ok, I can do that 1207989 7 282824 cfleizach 2016-07-05 16:10:25 -0700 Created attachment 282824 patch Updated patch with a layout test that should work for all platforms 1207991 8 jdiggs 2016-07-05 16:28:17 -0700 (In reply to comment #5) > This is the way that's it used elsewhere in WebCore code. I don't know how > much it buys us, but for the general user case I suppose this if check is > slightly faster Fair enough re slightly faster. And it's used in RenderBlockLineLayout.cpp. From a quick grep, there are quite a few more places where it's not used. If it does make a difference, it might be worth adding the check to Document::existingAXObjectCache(). (In a new bug; not this one.) (In reply to comment #6) > Ok, I can do that You rock. Thanks! 1208006 9 cfleizach 2016-07-05 17:24:02 -0700 (In reply to comment #8) > (In reply to comment #5) > > > This is the way that's it used elsewhere in WebCore code. I don't know how > > much it buys us, but for the general user case I suppose this if check is > > slightly faster > > Fair enough re slightly faster. And it's used in RenderBlockLineLayout.cpp. > > From a quick grep, there are quite a few more places where it's not used. If > it does make a difference, it might be worth adding the check to > Document::existingAXObjectCache(). (In a new bug; not this one.) https://bugs.webkit.org/show_bug.cgi?id=159445 > > (In reply to comment #6) > > > Ok, I can do that > > You rock. Thanks! 1208011 10 282824 commit-queue 2016-07-05 17:42:21 -0700 Comment on attachment 282824 patch Clearing flags on attachment: 282824 Committed r202841: <http://trac.webkit.org/changeset/202841> 1208012 11 commit-queue 2016-07-05 17:42:25 -0700 All reviewed patches have been landed. Closing bug. 282796 2016-07-05 09:00:20 -0700 2016-07-05 16:10:25 -0700 patch patch text/plain 4226 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjgxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTA1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEltYWdlIGF0dGFj aG1lbnQgaW4gZW1haWwgZG9lcyBub3Qgc2hvdyB1cCBpbiBBWCB0cmVlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0MjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGFuIGltYWdlIGxvYWRzIGFm dGVyIHRoZSBhY2Nlc3NpYmlsaXR5IHRyZWUgaGFzIGFscmVhZHkgYmVlbiBjcmVhdGVkLCB0aGUg aWdub3JlZCBzdGF0dXMKKyAgICAgICAgb2YgdGhhdCBpbWFnZSBkb2VzIG5vdCBnZXQgdXBkYXRl ZC4KKworICAgICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L2ltYWdlLWxvYWQtb24tZGVsYXkuaHRt bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckltYWdlOjppbWFnZUNoYW5nZWQpOgorCiAyMDE2LTA3LTA1ICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQ3JlZGVudGlhbFJlcXVl c3QgUmVzb3VyY2VMb2FkZXJPcHRpb25zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJJbWFnZS5jcHAJKHJldmlzaW9uIDIwMjcyMikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJJbWFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJSZW5kZXJJbWFnZS5oIgogCisjaW5jbHVkZSAi QVhPYmplY3RDYWNoZS5oIgogI2luY2x1ZGUgIkJpdG1hcEltYWdlLmgiCiAjaW5jbHVkZSAiQ2Fj aGVkSW1hZ2UuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKQEAgLTI1Miw2ICsyNTMs MTEgQEAKICAgICAgICAgaW1hZ2VTaXplQ2hhbmdlID0gc2V0SW1hZ2VTaXplRm9yQWx0VGV4dChp bWFnZVJlc291cmNlKCkuY2FjaGVkSW1hZ2UoKSk7CiAgICAgfQogCisgICAgaWYgKFVOTElLRUxZ KEFYT2JqZWN0Q2FjaGU6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkpKSB7CisgICAgICAgIGlmIChB WE9iamVjdENhY2hlKiBjYWNoZSA9IGRvY3VtZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCkp CisgICAgICAgICAgICBjYWNoZS0+cmVjb21wdXRlSXNJZ25vcmVkKHRoaXMpOworICAgIH0KKwog ICAgIHJlcGFpbnRPck1hcmtGb3JMYXlvdXQoaW1hZ2VTaXplQ2hhbmdlLCByZWN0KTsKIH0KIApJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMjAyNzIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDctMDUgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogSW1hZ2UgYXR0YWNobWVudCBpbiBl bWFpbCBkb2VzIG5vdCBzaG93IHVwIGluIEFYIHRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTQyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9uLWRl bGF5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pbWFnZS1s b2FkLW9uLWRlbGF5Lmh0bWw6IEFkZGVkLgorCiAyMDE2LTA2LTMwICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFNraXBwaW5nIGZsYWt5IGluc3BlY3Rvci9k ZWJ1Z2dlci9icmVhay1vbi0qIHRlc3RzCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L2ltYWdlLWxvYWQtb24tZGVsYXktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvaW1hZ2UtbG9hZC1vbi1kZWxheS1leHBlY3RlZC50eHQJKG5vbmV4 aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9uLWRlbGF5 LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEyIEBACit0ZXN0ICB0ZXN0 CitUaGlzIHZlcmlmaWVzIHRoYXQgd2hlbiBhbiBpbWFnZSBsb2FkcyBpdHMgcmVzb3VyY2UgbGF0 ZSwgdGhlIEFYIHRyZWUgaXMgdXBkYXRlZCB0byByZS1hZGQgdGhlIGltYWdlLgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworQkVGT1JFOiBHcm91cCBjb3VudDogMgorQUZURVI6IEdy b3VwIGNvdW50OiAzCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N UExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9uLWRl bGF5Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pbWFnZS1s b2FkLW9uLWRlbGF5Lmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9pbWFnZS1sb2FkLW9uLWRlbGF5Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwz OSBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0 bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8ZGl2IGlkPSJjb250ZW50Ij4K K3Rlc3QKKzxpbWcgc3JjPSJyZXNvdXJjZXMvX19fLnBuZyIgd2lkdGg9MTAwIGhlaWdodD0xMDAg aWQ9ImltYWdlIj4KK3Rlc3QKKzwvZGl2PgorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxk aXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKworICAgIGRlc2NyaXB0aW9uKCJUaGlz IHZlcmlmaWVzIHRoYXQgd2hlbiBhbiBpbWFnZSBsb2FkcyBpdHMgcmVzb3VyY2UgbGF0ZSwgdGhl IEFYIHRyZWUgaXMgdXBkYXRlZCB0byByZS1hZGQgdGhlIGltYWdlLiIpOworCisgICAgaWYgKHdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworICAgICAgICAgIHdpbmRvdy5qc1Rlc3RJ c0FzeW5jID0gdHJ1ZTsKKyAgICAgICAgICB2YXIgY29udGVudCA9IGFjY2Vzc2liaWxpdHlDb250 cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgiY29udGVudCIpOworICAgICAgICAgIGRlYnVn KCJCRUZPUkU6IEdyb3VwIGNvdW50OiAiICsgY29udGVudC5jaGlsZHJlbkNvdW50KTsKKworICAg ICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbWFnZSIpLm9ubG9hZCA9IGZ1bmN0aW9u KCkgeworICAgICAgICAgICAgICBkZWJ1ZygiQUZURVI6IEdyb3VwIGNvdW50OiAiICsgY29udGVu dC5jaGlsZHJlbkNvdW50KTsKKyAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAg ICAgfTsKKworICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7IAorICAgICAgICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1hZ2UiKS5zcmMgPSAicmVzb3VyY2VzL2Nha2Uu cG5nIjsgCisgICAgICAgICAgfSwgMTAwMCk7CisgICAgfQorCis8L3NjcmlwdD4KKworPHNjcmlw dCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5Pgor PC9odG1sPgo= 282824 2016-07-05 16:10:25 -0700 2016-07-05 17:42:21 -0700 patch patch text/plain 4248 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjgxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTA1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEltYWdlIGF0dGFj aG1lbnQgaW4gZW1haWwgZG9lcyBub3Qgc2hvdyB1cCBpbiBBWCB0cmVlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0MjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGFuIGltYWdlIGxvYWRzIGFm dGVyIHRoZSBhY2Nlc3NpYmlsaXR5IHRyZWUgaGFzIGFscmVhZHkgYmVlbiBjcmVhdGVkLCB0aGUg aWdub3JlZCBzdGF0dXMKKyAgICAgICAgb2YgdGhhdCBpbWFnZSBkb2VzIG5vdCBnZXQgdXBkYXRl ZC4KKworICAgICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L2ltYWdlLWxvYWQtb24tZGVsYXkuaHRt bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckltYWdlOjppbWFnZUNoYW5nZWQpOgorCiAyMDE2LTA3LTA1ICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQ3JlZGVudGlhbFJlcXVl c3QgUmVzb3VyY2VMb2FkZXJPcHRpb25zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJJbWFnZS5jcHAJKHJldmlzaW9uIDIwMjcyMikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJJbWFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJSZW5kZXJJbWFnZS5oIgogCisjaW5jbHVkZSAi QVhPYmplY3RDYWNoZS5oIgogI2luY2x1ZGUgIkJpdG1hcEltYWdlLmgiCiAjaW5jbHVkZSAiQ2Fj aGVkSW1hZ2UuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKQEAgLTI1Miw2ICsyNTMs MTEgQEAKICAgICAgICAgaW1hZ2VTaXplQ2hhbmdlID0gc2V0SW1hZ2VTaXplRm9yQWx0VGV4dChp bWFnZVJlc291cmNlKCkuY2FjaGVkSW1hZ2UoKSk7CiAgICAgfQogCisgICAgaWYgKFVOTElLRUxZ KEFYT2JqZWN0Q2FjaGU6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkpKSB7CisgICAgICAgIGlmIChB WE9iamVjdENhY2hlKiBjYWNoZSA9IGRvY3VtZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCkp CisgICAgICAgICAgICBjYWNoZS0+cmVjb21wdXRlSXNJZ25vcmVkKHRoaXMpOworICAgIH0KKwog ICAgIHJlcGFpbnRPck1hcmtGb3JMYXlvdXQoaW1hZ2VTaXplQ2hhbmdlLCByZWN0KTsKIH0KIApJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMjAyNzIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDctMDUgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogSW1hZ2UgYXR0YWNobWVudCBpbiBl bWFpbCBkb2VzIG5vdCBzaG93IHVwIGluIEFYIHRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTQyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9uLWRl bGF5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pbWFnZS1s b2FkLW9uLWRlbGF5Lmh0bWw6IEFkZGVkLgorCiAyMDE2LTA2LTMwICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFNraXBwaW5nIGZsYWt5IGluc3BlY3Rvci9k ZWJ1Z2dlci9icmVhay1vbi0qIHRlc3RzCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L2ltYWdlLWxvYWQtb24tZGVsYXktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvaW1hZ2UtbG9hZC1vbi1kZWxheS1leHBlY3RlZC50eHQJKG5vbmV4 aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9uLWRlbGF5 LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEyIEBACisxICAyCitUaGlz IHZlcmlmaWVzIHRoYXQgd2hlbiBhbiBpbWFnZSBsb2FkcyBpdHMgcmVzb3VyY2UgbGF0ZSwgdGhl IEFYIHRyZWUgaXMgdXBkYXRlZCB0byByZS1hZGQgdGhlIGltYWdlLgorCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKKworQkVGT1JFOiBHcm91cCBjb3VudDogMgorQUZURVI6IEdyb3VwIGNv dW50OiAzCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9uLWRlbGF5Lmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9u LWRlbGF5Lmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9p bWFnZS1sb2FkLW9uLWRlbGF5Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzOSBAQAor PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8 aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8ZGl2IGlkPSJjb250ZW50Ij4KKzxidXR0 b24+MTwvYnV0dG9uPgorPGltZyBzcmM9InJlc291cmNlcy9fX18ucG5nIiB3aWR0aD0xMDAgaGVp Z2h0PTEwMCBpZD0iaW1hZ2UiPgorPGJ1dHRvbj4yPC9idXR0b24+Cis8L2Rpdj4KKworPHAgaWQ9 ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisK KyAgICBkZXNjcmlwdGlvbigiVGhpcyB2ZXJpZmllcyB0aGF0IHdoZW4gYW4gaW1hZ2UgbG9hZHMg aXRzIHJlc291cmNlIGxhdGUsIHRoZSBBWCB0cmVlIGlzIHVwZGF0ZWQgdG8gcmUtYWRkIHRoZSBp bWFnZS4iKTsKKworICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAg ICAgICAgICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisgICAgICAgICAgdmFyIGNvbnRl bnQgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImNvbnRl bnQiKTsKKyAgICAgICAgICBkZWJ1ZygiQkVGT1JFOiBHcm91cCBjb3VudDogIiArIGNvbnRlbnQu Y2hpbGRyZW5Db3VudCk7CisKKyAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1h Z2UiKS5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgZGVidWcoIkFGVEVSOiBH cm91cCBjb3VudDogIiArIGNvbnRlbnQuY2hpbGRyZW5Db3VudCk7CisgICAgICAgICAgICAgIGZp bmlzaEpTVGVzdCgpOworICAgICAgICAgIH07CisKKyAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0 aW9uKCkgeyAKKyAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltYWdlIiku c3JjID0gInJlc291cmNlcy9jYWtlLnBuZyI7IAorICAgICAgICAgIH0sIDEwMDApOworICAgIH0K KworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K