159407 2016-07-04 07:53:07 -0700 [EFL] Remove mac configuration dependency in WebKit Version definition 2016-07-04 23:36:19 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue lucas.de.marchi ossy tonikitoo oldest_to_newest 1207676 0 gyuyoung.kim 2016-07-04 07:53:07 -0700 EFL port has been used Version.xconfig file in WebKit/mac/Configurations in order to generate WebKitVersion.h file. But it can be simply defined in cmake as GTK port. Let's remove the mac dependency ! 1207677 1 282720 gyuyoung.kim 2016-07-04 07:54:36 -0700 Created attachment 282720 Patch 1207748 2 282720 ysuzuki 2016-07-04 23:01:22 -0700 Comment on attachment 282720 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282720&action=review r=me with one question. > Source/WebCore/PlatformEfl.cmake:-262 > - Is it OK not to keep the version in sync with Mac ports? Personally, I think it's OK, since GTK port already does the same thing and EFL port can have its own user agent number. 1207752 3 gyuyoung.kim 2016-07-04 23:14:47 -0700 (In reply to comment #2) > Comment on attachment 282720 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282720&action=review > > r=me with one question. > > > Source/WebCore/PlatformEfl.cmake:-262 > > - > > Is it OK not to keep the version in sync with Mac ports? > Personally, I think it's OK, since GTK port already does the same thing and > EFL port can have its own user agent number. I plan to be in sync with mac port version manually whenever EFLWebKit is released. Anyway I think EFL port doesn't need to have mac port dependency when building EFL port. Thanks review ! 1207755 4 282720 commit-queue 2016-07-04 23:36:15 -0700 Comment on attachment 282720 Patch Clearing flags on attachment: 282720 Committed r202813: <http://trac.webkit.org/changeset/202813> 1207756 5 commit-queue 2016-07-04 23:36:19 -0700 All reviewed patches have been landed. Closing bug. 282720 2016-07-04 07:54:36 -0700 2016-07-04 23:36:15 -0700 Patch bug-159407-20160704235407.patch text/plain 4348 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2QwYTM5MzRmYTY1MzA1 OTk5ZDRhOThlZGU4YTY5MzhmMTlhNjZkYi4uNDY4MGUwMjgxYTAxZWU5YzIxNDNjMDVkNjg3ZmEx YzE0NmE2NWE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTA0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXSBSZW1v dmUgbWFjIGNvbmZpZ3VyYXRpb24gZGVwZW5kZW5jeSBpbiBXZWJLaXQgVmVyc2lvbiBkZWZpbml0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0 MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFRkwg cG9ydCBoYXMgYmVlbiB1c2VkIFZlcnNpb24ueGNvbmZpZyBmaWxlIGluIFdlYktpdC9tYWMvQ29u ZmlndXJhdGlvbnMKKyAgICAgICAgaW4gb3JkZXIgdG8gZ2VuZXJhdGUgV2ViS2l0VmVyc2lvbi5o IGZpbGUuIEJ1dCBpdCBjYW4gYmUgc2ltcGx5IGRlZmluZWQKKyAgICAgICAgaW4gY21ha2UuCisK KyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZTogUmVtb3ZlIFdlYktpdFZlcnNpb24uaCBnZW5l cmF0aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6dmVyc2lvbkZvclVBU3RyaW5nKTogVXNlIFVTRVJfQUdFTlRfRUZMX01BSk9S X1ZFUlNJT04gYW5kIFVTRVJfQUdFTlRfRUZMX01JTk9SX1ZFUlNJT04uCisKIDIwMTYtMDctMDIg IFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFN5bmNocm9ub3Vz IHByZWZsaWdodCBjaGVja2VyIHNob3VsZCBzZXQgbG9hZGluZyBvcHRpb25zIHRvIG5vdCB1c2Ug Y3JlZGVudGlhbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtl IGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXggMzYxNjFmMDlkODg3MTAw YTgyNGJlOTg5OTAzNmY4YjNlNzdiNGYwMi4uM2ZlNjAzNzhjMjZjZjA4ZTQ1ZjM3M2VkNTMzODdk ZWY3ODQ1NmNhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UK KysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTI1MiwxNCArMjUyLDYg QEAgc2V0KFdlYkNvcmVfVVNFUl9BR0VOVF9TQ1JJUFRTCiAgICAgJHtXRUJDT1JFX0RJUn0vTW9k dWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNCYXNlLmpzCiApCiAKLWFkZF9jdXN0b21f Y29tbWFuZCgKLSAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1dlYktp dFZlcnNpb24uaAotICAgIE1BSU5fREVQRU5ERU5DWSAke1dFQktJVF9ESVJ9L3NjcmlwdHMvZ2Vu ZXJhdGUtd2Via2l0dmVyc2lvbi5wbAotICAgIERFUEVORFMgJHtXRUJLSVRfRElSfS9tYWMvQ29u ZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZwotICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFC TEV9ICR7V0VCS0lUX0RJUn0vc2NyaXB0cy9nZW5lcmF0ZS13ZWJraXR2ZXJzaW9uLnBsIC0tY29u ZmlnICR7V0VCS0lUX0RJUn0vbWFjL0NvbmZpZ3VyYXRpb25zL1ZlcnNpb24ueGNjb25maWcgLS1v dXRwdXREaXIgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9Ci0gICAgVkVSQkFUSU0pCi1s aXN0KEFQUEVORCBXZWJDb3JlX0RFUklWRURfU09VUkNFUyAke0RFUklWRURfU09VUkNFU19XRUJD T1JFX0RJUn0vV2ViS2l0VmVyc2lvbi5oKQotCiBzZXQoV2ViQ29yZV9VU0VSX0FHRU5UX1NDUklQ VFNfREVQRU5ERU5DSUVTICR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVm bC5jcHApCiAKIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwCmluZGV4IGI3YTA2NGFmODA0N2VlYWNkYzRk YWQ4OTQ4YjRjODBjMmQxMWU0NDYuLjBjZGY0ZWQ5ZTI2NzQwNDQxZGNjZmQyNzUwYjg0MmRjYzEy Y2Q4MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRF ZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3Bw CkBAIC0yNiw3ICsyNiw2IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiVXNlckFn ZW50RWZsLmgiCiAKLSNpbmNsdWRlICJXZWJLaXRWZXJzaW9uLmgiCiAjaW5jbHVkZSA8d3RmL05l dmVyRGVzdHJveWVkLmg+CiAKICNpZiBPUyhVTklYKQpAQCAtNTcsMTEgKzU2LDcgQEAgc3RhdGlj IFN0cmluZyBwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpCiAKIHN0YXRpYyBjb25zdCBjaGFy KiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQogewotI2RlZmluZSBNQUtFX1NUUklORyh2YWx1ZSkgI3Zh bHVlCi0jZGVmaW5lIE1BS0VfVkVSU0lPTihtYWpvciwgbWlub3IpIE1BS0VfU1RSSU5HKG1ham9y KSAiLiIgTUFLRV9TVFJJTkcobWlub3IpCi0gICAgcmV0dXJuIE1BS0VfVkVSU0lPTihXRUJLSVRf TUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04pOwotI3VuZGVmIE1BS0VfU1RSSU5H Ci0jdW5kZWYgTUFLRV9WRVJTSU9OCisgICAgcmV0dXJuIFVTRVJfQUdFTlRfRUZMX01BSk9SX1ZF UlNJT04gIi4iIFVTRVJfQUdFTlRfRUZMX01JTk9SX1ZFUlNJT047CiB9CiAKIFN0cmluZyBzdGFu ZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwgY29uc3QgU3RyaW5n JiBhcHBsaWNhdGlvblZlcnNpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0Vm bC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDI3MjAyMGJjZTM4 ZDRmODY1YWUwM2RhMjAyZTdlZWNkN2M3MzNiNDAuLmRjODlkYTAxMzg4NjllYWVhNzFhYjZhNWQ4 NzdjOTA5MDM4ZWVlMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl CisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0zOSw2ICszOSw4IEBAIGlm IChDTUFLRV9DT01QSUxFUl9JU19HTlVDQyBBTkQgVU5JWCBBTkQgTk9UIEFQUExFKQogZW5kaWYg KCkKIAogYWRkX2RlZmluaXRpb25zKC1EQlVJTERJTkdfRUZMX189MSkKK2FkZF9kZWZpbml0aW9u cygtRFVTRVJfQUdFTlRfRUZMX01BSk9SX1ZFUlNJT049IjYwMiIpCithZGRfZGVmaW5pdGlvbnMo LURVU0VSX0FHRU5UX0VGTF9NSU5PUl9WRVJTSU9OPSIxIikKIGFkZF9kZWZpbml0aW9ucygtRERB VEFfRElSPSIke0NNQUtFX0lOU1RBTExfUFJFRklYfS8ke0RBVEFfSU5TVEFMTF9ESVJ9IgogICAg ICAgICAgICAgICAgIC1EREVGQVVMVF9USEVNRV9ESVI9IiR7VEhFTUVfQklOQVJZX0RJUn0iKQog CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYjM2NzI1ZjczYmI1NDk2 MzVjNjBmMjQ4ZTE1ODMwMjg1ZDY1Y2YzYi4uNzI1MzllMDQwODBlZmE4Yzc3YTAwNWRmZjE2ZmE3 MDU3ZDZkYmQzMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA3LTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0 Lm9yZz4KKworICAgICAgICBbRUZMXSBSZW1vdmUgbWFjIGNvbmZpZ3VyYXRpb24gZGVwZW5kZW5j eSBpbiBXZWJLaXQgVmVyc2lvbiBkZWZpbml0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk0MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFRkwgcG9ydCBoYXMgYmVlbiB1c2VkIFZlcnNpb24ueGNv bmZpZyBmaWxlIGluIFdlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMuCisgICAgICAgIGluIG9yZGVy IHRvIGdlbmVyYXRlIFdlYktpdFZlcnNpb24uaCBmaWxlLiBCdXQgaXQgY2FuIGJlIHNpbXBseSBk ZWZpbmVkCisgICAgICAgIGluIGNtYWtlLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv bnNFZmwuY21ha2U6CisKIDIwMTYtMDctMDEgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5A eWFuZGV4LnJ1PgogCiAgICAgICAgIFtjbWFrZV0gTWFrZSBMRUdBQ1lfV0VCX0FVRElPIGRlcGVu ZCBvbiBXRUJfQVVESU8uCg==