159394 2016-07-03 23:21:06 -0700 webkit-patch failure-reason always raises TypeError 2016-07-04 01:06:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii webkit-unassigned ap benjamin commit-queue ddkilzer glenn joepeck lforschler oldest_to_newest 1207572 0 fujii 2016-07-03 23:21:06 -0700 > $ ./Tools/Scripts/webkit-patch failure-reason > Auto-installing package: mechanize > Traceback (most recent call last): > File "./Tools/Scripts/webkit-patch", line 84, in <module> > main() > File "./Tools/Scripts/webkit-patch", line 79, in main > WebKitPatch(os.path.abspath(__file__)).main() > File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main > result = command.check_arguments_and_execute(options, args, self) > File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute > return self.execute(options, args, tool) or 0 > File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/commands/queries.py", line 334, in execute > (builder, latest_revision) = self._builder_to_explain() > File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/commands/queries.py", line 318, in _builder_to_explain > print "%s failing" % (pluralize("builder", len(red_statuses))) > File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/grammar.py", line 43, in pluralize > noun = plural(noun) > File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/grammar.py", line 35, in plural > if re.search("h$", noun): > File "/usr/lib/python2.7/re.py", line 146, in search > return _compile(pattern, flags).search(string) > TypeError: expected string or buffer > $ In r170637 (Bug 133067), the first and second arguments of pluralize were swapped. 1207579 1 282683 fujii 2016-07-03 23:34:57 -0700 Created attachment 282683 Patch 1207608 2 282683 benjamin 2016-07-04 00:46:40 -0700 Comment on attachment 282683 Patch Thanks for fixing this. 1207616 3 282683 commit-queue 2016-07-04 01:06:37 -0700 Comment on attachment 282683 Patch Clearing flags on attachment: 282683 Committed r202804: <http://trac.webkit.org/changeset/202804> 1207617 4 commit-queue 2016-07-04 01:06:41 -0700 All reviewed patches have been landed. Closing bug. 282683 2016-07-03 23:34:57 -0700 2016-07-04 01:06:37 -0700 Patch bug-159394-20160704153429.patch text/plain 1785 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNzk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmQ4NmU4NzhlZmQxOGY3MGIzN2VmZGJlNmQ4ZGIzNTlj OTE5ZjU3Yy4uNWMxMGRmZDMyNDQ0ZTQ2ZTllNTE5NzY1Y2I1MzNkMTEzY2EyOWY5YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE2LTA3LTAzICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBmYWlsdXJlLXJlYXNvbiBhbHdheXMgcmFpc2VzIFR5 cGVFcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU5Mzk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gcjE3MDYzNyAoQnVnIDEzMzA2NyksIHRoZSBmaXJzdCBhbmQgc2Vjb25kIGFyZ3VtZW50cyBv ZgorICAgICAgICBwbHVyYWxpemUgd2VyZSBzd2FwcGVkLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHk6CisgICAgICAgIChGYWlsdXJlUmVhc29u Ll9idWlsZGVyX3RvX2V4cGxhaW4pOiBTd2FwIHRoZSBmaXJzdCBhbmQgc2Vjb25kCisgICAgICAg IGFyZ3VtZW50cyBvZiBwbHVyYWxpemUuCisKIDIwMTYtMDctMDIgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5mQGdtYWlsLmNvbT4KIAogICAgICAgICBNYWtlIGl0IHN0cmFpZ2h0Zm9yd2FyZCB0byBz dGFydCB0aGUgV2ViIFBsYXRmb3JtIFRlc3RzIEhUVFAgc2VydmVyIHVzaW5nIHJ1bi13ZWJraXQt aHR0cGQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x dWVyaWVzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMu cHkKaW5kZXggNmFlNjc5ZGMxYzNjYTQwOTM4MWRmNjA3ODAwMjE0MTk4YTllOWYyZi4uYmI1YmJh MjI5MGJhN2M5NmQwN2JjYTFmMjgzZmZiYTk1M2UzMTJiNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKQEAgLTMxNSw3ICszMTUsNyBAQCBj bGFzcyBGYWlsdXJlUmVhc29uKENvbW1hbmQpOgogICAgIGRlZiBfYnVpbGRlcl90b19leHBsYWlu KHNlbGYpOgogICAgICAgICBidWlsZGVyX3N0YXR1c2VzID0gc2VsZi5fdG9vbC5idWlsZGJvdC5i dWlsZGVyX3N0YXR1c2VzKCkKICAgICAgICAgcmVkX3N0YXR1c2VzID0gW3N0YXR1cyBmb3Igc3Rh dHVzIGluIGJ1aWxkZXJfc3RhdHVzZXMgaWYgbm90IHN0YXR1c1siaXNfZ3JlZW4iXV0KLSAgICAg ICAgcHJpbnQgIiVzIGZhaWxpbmciICUgKHBsdXJhbGl6ZSgiYnVpbGRlciIsIGxlbihyZWRfc3Rh dHVzZXMpKSkKKyAgICAgICAgcHJpbnQgIiVzIGZhaWxpbmciICUgKHBsdXJhbGl6ZShsZW4ocmVk X3N0YXR1c2VzKSwgImJ1aWxkZXIiKSkKICAgICAgICAgYnVpbGRlcl9jaG9pY2VzID0gW3N0YXR1 c1sibmFtZSJdIGZvciBzdGF0dXMgaW4gcmVkX3N0YXR1c2VzXQogICAgICAgICAjIFdlIGNvdWxk IG9mZmVyIGFuICJBbGwiIGNob2ljZSBoZXJlLgogICAgICAgICBjaG9zZW5fbmFtZSA9IHNlbGYu X3Rvb2wudXNlci5wcm9tcHRfd2l0aF9saXN0KCJXaGljaCBidWlsZGVyIHRvIGRpYWdub3NlOiIs IGJ1aWxkZXJfY2hvaWNlcykK