15939 2007-11-10 18:37:28 -0800 Add currentThread API 2008-01-24 12:47:22 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.4 RESOLVED FIXED P2 Normal --- 15940 1 jhaygood webkit-unassigned oldest_to_newest 60878 0 jhaygood 2007-11-10 18:37:28 -0800 in order to get rid of all direct useages of pthread, we need a currentThread API 60879 1 17179 jhaygood 2007-11-10 18:37:56 -0800 Created attachment 17179 Implements currentThread API 60951 2 17179 aroben 2007-11-11 21:25:40 -0800 Comment on attachment 17179 Implements currentThread API +static ThreadIdentifier identifierByPthreadHandle(pthread_t& pthreadhandle) The parameter should be marked const (ditto for the ThreadingGtk version). + for (; i != threadMap().end(); ++i) { + if (i->second == thread)) + return i->first; + } You don't need the braces around the body of the loop. r=me 60953 3 aroben 2007-11-11 21:30:36 -0800 (In reply to comment #2) > (From update of attachment 17179 [edit]) > + for (; i != threadMap().end(); ++i) { > + if (i->second == thread)) > + return i->first; > + } > > You don't need the braces around the body of the loop. Please disregard this. The braces are correct per our style guidelines <http://webkit.org/coding/coding-style.html>. 60954 4 mrowe 2007-11-11 21:58:54 -0800 Landed in r27707 after some fixes to the gthreads version and improvements to match the style guidelines. 68125 5 ap 2008-01-24 12:47:22 -0800 *** Bug 15935 has been marked as a duplicate of this bug. *** 17179 2007-11-10 18:37:56 -0800 2007-11-11 21:25:40 -0800 Implements currentThread API currentthread.patch text/plain 5705 jhaygood SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3Njgw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDctMTEt MTAgIEp1c3RpbiBIYXlnb29kICA8amhheWdvb2RAcmVha3RpeC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBBZGRzIGEgY3VycmVu dFRocmVhZCBBUEksIGZvciB1c2UgZm9yIFNRTGl0ZURhdGFiYXNlLCBldGMuLgorCisgICAgICAg ICogcGxhdGZvcm0vVGhyZWFkaW5nLmg6CisgICAgICAgICogcGxhdGZvcm0vVGhyZWFkaW5nTm9u ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjdXJyZW50VGhyZWFkKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVGhyZWFkaW5nR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlkZW50aWZpZXJC eUd0aHJlYWRIYW5kbGUpOgorICAgICAgICAoV2ViQ29yZTo6KToKKyAgICAgICAgKiBwbGF0Zm9y bS9wdGhyZWFkcy9UaHJlYWRpbmdQdGhyZWFkcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjppZGVu dGlmaWVyQnlQdGhyZWFkSGFuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6OmN1cnJlbnRUaHJlYWQp OgorCiAyMDA3LTExLTEwICBOaWtvbGFzIFppbW1lcm1hbm4gIDx6aW1tZXJtYW5uQGtkZS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYy4KSW5kZXg6IHBsYXRmb3JtL1RocmVhZGluZy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL1RocmVhZGluZy5oCShyZXZpc2lvbiAyNzY4MCkKKysr IHBsYXRmb3JtL1RocmVhZGluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNiBAQAogLyoK ICAqIENvcHlyaWdodCAoQykgMjAwNyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMDcgSnVzdGluIEhheWdvb2QgKGpoYXlnb29kQHJlYWt0aXguY29t KQogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC00MSw2ICs0MiwxMSBAQCB0eXBl ZGVmIHN0cnVjdCBfR011dGV4IEdNdXRleDsKIHR5cGVkZWYgc3RydWN0IF9HQ29uZCBHQ29uZDsK ICNlbmRpZgogCisjaWYgUExBVEZPUk0oUVQpCitjbGFzcyBRTXV0ZXg7CitjbGFzcyBRV2FpdENv bmRpdGlvbjsKKyNlbmRpZgorCiAjaW5jbHVkZSA8c3RkaW50Lmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKQEAgLTUwLDYgKzU2LDcgQEAgdHlwZWRlZiB2b2lkKiAoKlRocmVhZEZ1bmN0aW9uKSh2 b2lkKiBhcgogCiAvLyBSZXR1cm5zIDAgaWYgdGhyZWFkIGNyZWF0aW9uIGZhaWxlZAogVGhyZWFk SWRlbnRpZmllciBjcmVhdGVUaHJlYWQoVGhyZWFkRnVuY3Rpb24sIHZvaWQqKTsKK1RocmVhZElk ZW50aWZpZXIgY3VycmVudFRocmVhZCgpOwogaW50IHdhaXRGb3JUaHJlYWRDb21wbGV0aW9uKFRo cmVhZElkZW50aWZpZXIsIHZvaWQqKik7CiB2b2lkIGRldGFjaFRocmVhZChUaHJlYWRJZGVudGlm aWVyKTsKIApAQCAtNTksNiArNjYsOSBAQCB0eXBlZGVmIHB0aHJlYWRfY29uZF90IFBsYXRmb3Jt Q29uZGl0aW9uCiAjZWxpZiBQTEFURk9STShHVEspCiB0eXBlZGVmIEdNdXRleCogUGxhdGZvcm1N dXRleDsKIHR5cGVkZWYgR0NvbmQqIFBsYXRmb3JtQ29uZGl0aW9uOworI2VsaWYgUExBVEZPUk0o UVQpCit0eXBlZGVmIFFNdXRleCogUGxhdGZvcm1NdXRleDsKK3R5cGVkZWYgUVdhaXRDb25kaXRp b24qIFBsYXRmb3JtQ29uZGl0aW9uOwogI2Vsc2UKIHR5cGVkZWYgdm9pZCogUGxhdGZvcm1NdXRl eDsKIHR5cGVkZWYgdm9pZCogUGxhdGZvcm1Db25kaXRpb247CkluZGV4OiBwbGF0Zm9ybS9UaHJl YWRpbmdOb25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9UaHJlYWRpbmdOb25lLmNwcAko cmV2aXNpb24gMjc2ODApCisrKyBwbGF0Zm9ybS9UaHJlYWRpbmdOb25lLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA3IEp1c3RpbiBIYXln b29kIChqaGF5Z29vZEByZWFrdGl4LmNvbSkKICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cwpAQCAtMzMsNiArMzQsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBUaHJlYWRJZGVudGlmaWVy IGNyZWF0ZVRocmVhZChUaHJlYWRGdW5jdGlvbiwgdm9pZCopIHsgcmV0dXJuIDA7IH0KIGludCB3 YWl0Rm9yVGhyZWFkQ29tcGxldGlvbihUaHJlYWRJZGVudGlmaWVyLCB2b2lkKiopIHsgcmV0dXJu IDA7IH0KIHZvaWQgZGV0YWNoVGhyZWFkKFRocmVhZElkZW50aWZpZXIpIHsgfQorVGhyZWFkSWRl bnRpZmllciBjdXJyZW50VGhyZWFkKCl7IHJldHVybiAwOyB9CiAKIE11dGV4OjpNdXRleCgpIHt9 CiBNdXRleDo6fk11dGV4KCkge30KSW5kZXg6IHBsYXRmb3JtL2d0ay9UaHJlYWRpbmdHdGsuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL2d0ay9UaHJlYWRpbmdHdGsuY3BwCShyZXZpc2lvbiAy NzY4MCkKKysrIHBsYXRmb3JtL2d0ay9UaHJlYWRpbmdHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwNyBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDcgSnVzdGluIEhheWdvb2QgKGpo YXlnb29kQHJlYWt0aXguY29tKQogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC03 OSw2ICs4MCwxOSBAQCBzdGF0aWMgVGhyZWFkSWRlbnRpZmllciBlc3RhYmxpc2hJZGVudGlmCiAg ICAgcmV0dXJuIGlkZW50aWZpZXJDb3VudCsrOwogfQogCitzdGF0aWMgVGhyZWFkSWRlbnRpZmll ciBpZGVudGlmaWVyQnlHdGhyZWFkSGFuZGxlKCBHVGhyZWFkKiYgdGhyZWFkICkKK3sKKyAgICBN dXRleExvY2tlciBsb2NrZXIodGhyZWFkTWFwTXV0ZXgoKSk7CisKKyAgICBIYXNoTWFwPFRocmVh ZElkZW50aWZpZXIsIEdUaHJlYWQqPjo6aXRlcmF0b3IgaSA9IHRocmVhZE1hcCgpLmJlZ2luKCk7 CisgICAgZm9yICg7IGkgIT0gdGhyZWFkTWFwKCkuZW5kKCk7ICsraSkgeworICAgICAgICBpZiAo aS0+c2Vjb25kID09IHRocmVhZCkpCisgICAgICAgICAgICByZXR1cm4gaS0+Zmlyc3Q7CisgICAg fQorCisgICAgcmV0dXJuIDA7Cit9CisKIHN0YXRpYyBHVGhyZWFkKiB0aHJlYWRGb3JJZGVudGlm aWVyKFRocmVhZElkZW50aWZpZXIgaWQpCiB7CiAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKHRocmVh ZE1hcE11dGV4KCkpOwpAQCAtMTI0LDYgKzEzOCwxNSBAQCB2b2lkIGRldGFjaFRocmVhZChUaHJl YWRJZGVudGlmaWVyKQogewogfQogCitUaHJlYWRJZGVudGlmaWVyIGN1cnJlbnRUaHJlYWQoKQor eworICAgIEdUaHJlYWQqIGN1cnJlbnRUaHJlYWQgPSBnX3RocmVhZF9zZWxmKCk7CisgICAgVGhy ZWFkSWRlbnRpZmllciBpZCA9IGlkZW50aWZpZXJCeUd0aHJlYWRIYW5kbGUoY3VycmVudFRocmVh ZCk7CisgICAgaWYgKGlkID09IDApCisgICAgICAgIGlkID0gdGhyZWFkRm9ySWRlbnRpZmllcihj dXJyZW50VGhyZWFkKTsKKyAgICByZXR1cm4gaWQ7Cit9CisKIE11dGV4OjpNdXRleCgpCiAgICAg OiBtX211dGV4KGdfbXV0ZXhfbmV3KCkpCiB7CkluZGV4OiBwbGF0Zm9ybS9wdGhyZWFkcy9UaHJl YWRpbmdQdGhyZWFkcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vcHRocmVhZHMvVGhyZWFk aW5nUHRocmVhZHMuY3BwCShyZXZpc2lvbiAyNzY4MCkKKysrIHBsYXRmb3JtL3B0aHJlYWRzL1Ro cmVhZGluZ1B0aHJlYWRzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYgQEAKIC8qCiAg KiBDb3B5cmlnaHQgKEMpIDIwMDcgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICog Q29weXJpZ2h0IChDKSAyMDA3IEp1c3RpbiBIYXlnb29kIChqaGF5Z29vZEByZWFrdGl4LmNvbSkK ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNTgsNiArNTksMTkgQEAgc3RhdGlj IFRocmVhZElkZW50aWZpZXIgZXN0YWJsaXNoSWRlbnRpZgogICAgIHJldHVybiBpZGVudGlmaWVy Q291bnQrKzsKIH0KIAorc3RhdGljIFRocmVhZElkZW50aWZpZXIgaWRlbnRpZmllckJ5UHRocmVh ZEhhbmRsZShwdGhyZWFkX3QmIHB0aHJlYWRoYW5kbGUpCit7CisgICAgTXV0ZXhMb2NrZXIgbG9j a2VyKHRocmVhZE1hcE11dGV4KCkpOworCisgICAgSGFzaE1hcDxUaHJlYWRJZGVudGlmaWVyLCBw dGhyZWFkX3Q+OjppdGVyYXRvciBpID0gdGhyZWFkTWFwKCkuYmVnaW4oKTsKKyAgICBmb3IgKDsg aSAhPSB0aHJlYWRNYXAoKS5lbmQoKTsgKytpKSB7CisgICAgICAgIGlmIChwdGhyZWFkX2VxdWFs KGktPnNlY29uZCwgcHRocmVhZGhhbmRsZSkpCisgICAgICAgICAgICByZXR1cm4gaS0+Zmlyc3Q7 CisgICAgfQorCisgICAgcmV0dXJuIDA7Cit9CisKIHN0YXRpYyBwdGhyZWFkX3QgcHRocmVhZEhh bmRsZUZvcklkZW50aWZpZXIoVGhyZWFkSWRlbnRpZmllciBpZCkKIHsKICAgICBNdXRleExvY2tl ciBsb2NrZXIodGhyZWFkTWFwTXV0ZXgoKSk7CkBAIC0xMTIsNiArMTI2LDE1IEBAIHZvaWQgZGV0 YWNoVGhyZWFkKFRocmVhZElkZW50aWZpZXIgdGhyZWEKICAgICBjbGVhclB0aHJlYWRIYW5kbGVG b3JJZGVudGlmaWVyKHRocmVhZElEKTsKIH0KIAorVGhyZWFkSWRlbnRpZmllciBjdXJyZW50VGhy ZWFkKCkKK3sKKyAgICBwdGhyZWFkX3QgY3VycmVudFRocmVhZCA9IHB0aHJlYWRfc2VsZigpOwor ICAgIFRocmVhZElkZW50aWZpZXIgaWQgPSBpZGVudGlmaWVyQnlQdGhyZWFkSGFuZGxlKGN1cnJl bnRUaHJlYWQpOworICAgIGlmIChpZCA9PSAwKQorICAgICAgICBpZCA9IGVzdGFibGlzaElkZW50 aWZpZXJGb3JQdGhyZWFkSGFuZGxlKGN1cnJlbnRUaHJlYWQpOworICAgIHJldHVybiBpZDsKK30K KwogTXV0ZXg6Ok11dGV4KCkKIHsKICAgICBwdGhyZWFkX211dGV4X2luaXQoJm1fbXV0ZXgsIE5V TEwpOwo=