159387 2016-07-02 10:39:23 -0700 BytecodeGenerator::getVariablesUnderTDZ is too conservative 2016-07-03 14:37:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo saam benjamin cdumez cmarcelo commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver saam sukolsak ysuzuki oldest_to_newest 1207446 0 fpizlo 2016-07-02 10:39:23 -0700 For example it will say that "x" is under TDZ in the "...": { { let x; ... } let x; } 1207488 1 282657 saam 2016-07-03 02:14:23 -0700 Created attachment 282657 patch 1207527 2 282657 commit-queue 2016-07-03 14:37:19 -0700 Comment on attachment 282657 patch Clearing flags on attachment: 282657 Committed r202795: <http://trac.webkit.org/changeset/202795> 1207528 3 commit-queue 2016-07-03 14:37:25 -0700 All reviewed patches have been landed. Closing bug. 282657 2016-07-03 02:14:23 -0700 2016-07-03 14:37:19 -0700 patch a-backup.diff text/plain 5238 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNzg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE2LTA3LTAzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEJ5dGVjb2RlR2VuZXJhdG9yOjpnZXRWYXJpYWJsZXNVbmRlclREWiBpcyB0b28gY29uc2VydmF0 aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkz ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3 ZXJlIHRvbyBjb25zZXJ2YXRpdmUgaW4gdGhlIGZvbGxvd2luZyB0eXBlIG9mIHByb2dyYW1zOgor ICAgICAgICBgYGAKKyAgICAgICAgeworICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGxl dCB4OworICAgICAgICAgICAgICAgIC4uLgorICAgICAgICAgICAgfQorICAgICAgICAgICAgbGV0 IHg7CisgICAgICAgIH0KKyAgICAgICAgYGBgCisgICAgICAgIFdlIHVzZWQgdG8gcmVwb3J0ICJ4 IiBhcyB1bmRlciBURFogd2hlbiBjYWxsaW5nIGdldFZhcmlhYmxlc1VuZGVyVERaIGF0IHRoZQor ICAgICAgICAiLi4uIiwgZXZlbiB0aG91Z2ggIngiIGlzIG5vdCB1bmRlciBURFouIFRoaXMgcGF0 Y2ggcmVtb3ZlcyB0aGlzIGNvbnNlcnZhdGlzbQorICAgICAgICBhbmQgbWFrZXMgdGhlIGFsZ29y aXRobSBwcmVjaXNlLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9y LmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmdldFZhcmlhYmxlc1VuZGVy VERaKToKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaDoKKwogMjAx Ni0wNi0zMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFNjb3Bl cyB0aGF0IGFyZSBub3QgdW5kZXIgVERaIHNob3VsZCBzdGlsbCBwdXNoIHRoZWlyIHZhcmlhYmxl cyBvbnRvIHRoZSBURFogc3RhY2sgc28gdGhhdCBsaWZ0aW5nIFREWiBkb2Vzbid0IGJ5cGFzcyB0 aGF0IHNjb3BlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gMjAyNzg1KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAKICNpbmNsdWRlICJVbmxpbmtlZENvZGVCbG9j ay5oIgogI2luY2x1ZGUgIlVubGlua2VkSW5zdHJ1Y3Rpb25TdHJlYW0uaCIKICNpbmNsdWRlIDx3 dGYvQ29tbWFQcmludGVyLmg+CisjaW5jbHVkZSA8d3RmL1NtYWxsUHRyU2V0Lmg+CiAjaW5jbHVk ZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgog CkBAIC0yNzkxLDcgKzI3OTIsOCBAQCB2b2lkIEJ5dGVjb2RlR2VuZXJhdG9yOjpwdXNoVERaVmFy aWFibGVzCiAKIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OmdldFZhcmlhYmxlc1VuZGVyVERaKFZh cmlhYmxlRW52aXJvbm1lbnQmIHJlc3VsdCkKIHsKLSAgICAvLyBOT1RFOiBUaGlzIGlzIGNvbnNl cnZhdGl2ZS4gSWYgY2FsbGVkIGF0ICIuLi4iLCBpdCB3aWxsIHJlcG9ydCAieCIgYXMgYmVpbmcg dW5kZXIgVERaOgorICAgIC8vIFdlIGtlZXAgdHJhY2sgb2YgdmFyaWFibGVzVGhhdERvbnROZWVk VERaIGluIHRoaXMgYWxnb3JpdGhtIHRvIHByZXZlbnQKKyAgICAvLyByZXBvcnRpbmcgdGhhdCAi eCIgaXMgdW5kZXIgVERaIGlmIHRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGF0ICIuLi4iLgogICAg IC8vCiAgICAgLy8gICAgIHsKICAgICAvLyAgICAgICAgIHsKQEAgLTI4MDEsMTEgKzI4MDMsMTUg QEAgdm9pZCBCeXRlY29kZUdlbmVyYXRvcjo6Z2V0VmFyaWFibGVzVW5kZQogICAgIC8vICAgICAg ICAgbGV0IHg7CiAgICAgLy8gICAgIH0KICAgICAvLwotICAgIC8vIEZJWE1FOiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5Mzg3Ci0gICAgZm9yIChhdXRvJiBtYXAg OiBtX1REWlN0YWNrKSB7CisgICAgU21hbGxQdHJTZXQ8VW5pcXVlZFN0cmluZ0ltcGwqLCAxNj4g dmFyaWFibGVzVGhhdERvbnROZWVkVERaOworICAgIGZvciAodW5zaWduZWQgaSA9IG1fVERaU3Rh Y2suc2l6ZSgpOyBpLS07ICkgeworICAgICAgICBhdXRvJiBtYXAgPSBtX1REWlN0YWNrW2ldOwog ICAgICAgICBmb3IgKGF1dG8mIGVudHJ5IDogbWFwKSAgewotICAgICAgICAgICAgaWYgKGVudHJ5 LnZhbHVlICE9IFREWk5lY2Vzc2l0eUxldmVsOjpOb3ROZWVkZWQpCi0gICAgICAgICAgICAgICAg cmVzdWx0LmFkZChlbnRyeS5rZXkuZ2V0KCkpOworICAgICAgICAgICAgaWYgKGVudHJ5LnZhbHVl ICE9IFREWk5lY2Vzc2l0eUxldmVsOjpOb3ROZWVkZWQpIHsKKyAgICAgICAgICAgICAgICBpZiAo IXZhcmlhYmxlc1RoYXREb250TmVlZFREWi5jb250YWlucyhlbnRyeS5rZXkuZ2V0KCkpKQorICAg ICAgICAgICAgICAgICAgICByZXN1bHQuYWRkKGVudHJ5LmtleS5nZXQoKSk7CisgICAgICAgICAg ICB9IGVsc2UKKyAgICAgICAgICAgICAgICB2YXJpYWJsZXNUaGF0RG9udE5lZWRURFouYWRkKGVu dHJ5LmtleS5nZXQoKSk7CiAgICAgICAgIH0KICAgICB9CiB9CkluZGV4OiBTb3VyY2UvV1RGL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMjAy Nzg1KQorKysgU291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OSBAQAorMjAxNi0wNy0wMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAg ICAgICBCeXRlY29kZUdlbmVyYXRvcjo6Z2V0VmFyaWFibGVzVW5kZXJURFogaXMgdG9vIGNvbnNl cnZhdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU5Mzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SSd2ZSB0ZW1wbGF0aXplZCBTbWFsbFB0clNldCBvbiBpdHMgU21hbGxBcnJheVNpemUgaW5zdGVh ZAorICAgICAgICBvZiBpdCBhbHdheXMgYmVpbmcgOC4gIAorCisgICAgICAgICogd3RmL1NtYWxs UHRyU2V0Lmg6CisgICAgICAgIChXVEY6OlNtYWxsUHRyU2V0OjpTbWFsbFB0clNldCk6CisgICAg ICAgIChXVEY6OlNtYWxsUHRyU2V0OjphZGQpOgorICAgICAgICAoV1RGOjpTbWFsbFB0clNldDo6 aXRlcmF0b3I6Om9wZXJhdG9yIT0pOgorICAgICAgICAoV1RGOjpTbWFsbFB0clNldDo6YnVja2V0 KToKKwogMjAxNi0wNy0wMiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAg ICAgIEJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1NtYWxsUHRyU2V0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi93dGYvU21hbGxQdHJTZXQuaAkocmV2aXNpb24gMjAyNzg1KQor KysgU291cmNlL1dURi93dGYvU21hbGxQdHJTZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsMTEg KzMzLDEyIEBACiAKIG5hbWVzcGFjZSBXVEYgewogCi10ZW1wbGF0ZTx0eXBlbmFtZSBQdHJUeXBl PgordGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZSwgdW5zaWduZWQgU21hbGxBcnJheVNpemUgPSA4 PgogY2xhc3MgU21hbGxQdHJTZXQgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFNtYWxsUHRy U2V0KTsKICAgICBzdGF0aWNfYXNzZXJ0KHN0ZDo6aXNfdHJpdmlhbGx5X2Rlc3RydWN0aWJsZTxQ dHJUeXBlPjo6dmFsdWUsICJXZSBjdXJyZW50bHkgZG9uJ3Qgc3VwcG9ydCBub24tdHJpdmlhbGx5 IGRlc3RydWN0aWJsZSBwb2ludGVyIHR5cGVzLiIpOwogICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9m KFB0clR5cGUpID09IHNpemVvZih2b2lkKiksICJPbmx5IHN1cHBvcnQgcG9pbnRlciBzaXplZCB0 aGluZ3MuIik7CisgICAgc3RhdGljX2Fzc2VydCghKFNtYWxsQXJyYXlTaXplICYgKFNtYWxsQXJy YXlTaXplIC0gMSkpLCAiSW5saW5lIHNpemUgbXVzdCBiZSBhIHBvd2VyIG9mIHR3by4iKTsKIAog cHVibGljOiAKICAgICBTbWFsbFB0clNldCgpCkBAIC05MCw3ICs5MSw3IEBAIHB1YmxpYzogCiAg ICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBncm93 KDY0KTsKKyAgICAgICAgICAgIGdyb3coc3RkOjptYXgoNjR1LCBTbWFsbEFycmF5U2l6ZSAqIDIp KTsKICAgICAgICAgICAgIC8vIEZhbGwgdGhyb3VnaC4gV2UncmUgbm8gbG9uZ2VyIHNtYWxsIDoo CiAgICAgICAgIH0KIApAQCAtMTM4LDcgKzEzOSw3IEBAIHB1YmxpYzogCiAgICAgICAgIGJvb2wg b3BlcmF0b3IhPShjb25zdCBpdGVyYXRvciYgb3RoZXIpIGNvbnN0IHsgQVNTRVJUKG1fYnVmZmVy ID09IG90aGVyLm1fYnVmZmVyKTsgcmV0dXJuICEoKnRoaXMgPT0gb3RoZXIpOyB9CiAKICAgICBw cml2YXRlOgotICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBmcmllbmQgY2xhc3MgV1RGOjpT bWFsbFB0clNldDsKKyAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVSwgdW5zaWduZWQgUz4gZnJp ZW5kIGNsYXNzIFdURjo6U21hbGxQdHJTZXQ7CiAgICAgICAgIHVuc2lnbmVkIG1faW5kZXg7CiAg ICAgICAgIHVuc2lnbmVkIG1fY2FwYWNpdHk7CiAgICAgICAgIHZvaWQqKiBtX2J1ZmZlcjsKQEAg LTIzOSw4ICsyNDAsNiBAQCBwcml2YXRlOgogICAgICAgICB9CiAgICAgfQogCi0gICAgc3RhdGlj IGNvbnN0IHVuc2lnbmVkIFNtYWxsQXJyYXlTaXplID0gODsKLQogICAgIHVuc2lnbmVkIG1fc2l6 ZTsKICAgICB1bnNpZ25lZCBtX2NhcGFjaXR5OwogICAgIHZvaWQqKiBtX2J1ZmZlcjsK