159368 2016-07-01 13:58:30 -0700 Web Inspector: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation) 2016-07-02 20:36:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1207255 0 joepeck 2016-07-01 13:58:30 -0700 Summary: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation) file:///Users/pecoraro/Build/Debug/WebInspectorUI.framework/Resources/TestCombined.js:10761:23: CONSOLE ERROR > WebInspector.CallFrame = class CallFrame extends WebInspector.Object > { > constructor(id, sourceCodeLocation, functionName, thisObject, scopeChain, nativeCode, programCode, isTailDeleted) > { > super(); > > console.assert(!sourceCodeLocation || sourceCodeLocation instanceof WebInspector.SourceCodeLocation); Turns out the sourceCodeLocation is an instanceof WebInspector.LazySourceCodeLocation which is a subclass of WebInspector.SourceCodeLocation. However, SourceCodeLocation is defined again AFTER SourceCodeLocation+LazySourceCodeLocation were setup... 1207260 1 282574 joepeck 2016-07-01 13:59:46 -0700 Created attachment 282574 [PATCH] Proposed Fix 1207481 2 282574 commit-queue 2016-07-02 20:36:39 -0700 Comment on attachment 282574 [PATCH] Proposed Fix Clearing flags on attachment: 282574 Committed r202785: <http://trac.webkit.org/changeset/202785> 1207482 3 commit-queue 2016-07-02 20:36:42 -0700 All reviewed patches have been landed. Closing bug. 282574 2016-07-01 13:59:46 -0700 2016-07-02 20:36:39 -0700 [PATCH] Proposed Fix oops-1.patch text/plain 1423 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ3MzQ2YWEuLmY2Y2IzYmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA3LTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FsbEZy YW1lIGNvbnNvbGUuYXNzZXJ0IHNlZW4gaW4gdGVzdHMgKHNvdXJjZUNvZGVMb2NhdGlvbiBpbnN0 YW5jZW9mIFNvdXJjZUNvZGVMb2NhdGlvbikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1OTM2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9UZXN0Lmh0bWw6CisgICAgICAgIFNv dXJjZUNvZGVMb2NhdGlvbiB3YXMgYWxyZWFkeSBpbmNsdWRlZCBlYXJsaWVyLiBUaGlzIHJlZGVm aW5lcyBpdCBhbmQKKyAgICAgICAgdGhlcmVieSBicmVha3Mgc29tZSB0aGluZ3MuCisKIDIwMTYt MDYtMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBp bnNwZWN0b3IvZGVidWdnZXIvY29tbWFuZC1saW5lLWFwaS1leGNlcHRpb24uaHRtbCBmbGFraWx5 IHRpbWVzIG91dCBvbiBtYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1Rlc3QuaHRtbCBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1Rlc3QuaHRtbAppbmRleCAwYmMwMDI1Li44YWQyMTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0Lmh0bWwKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC5odG1sCkBAIC0xNTIsNyArMTUyLDYgQEAKICAgICA8 c2NyaXB0IHNyYz0iTW9kZWxzL1NjcmlwdEluc3RydW1lbnQuanMiPjwvc2NyaXB0PgogICAgIDxz Y3JpcHQgc3JjPSJNb2RlbHMvU2NyaXB0U3ludGF4VHJlZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNj cmlwdCBzcmM9Ik1vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcyI+PC9zY3JpcHQ+Ci0gICAg PHNjcmlwdCBzcmM9Ik1vZGVscy9Tb3VyY2VDb2RlTG9jYXRpb24uanMiPjwvc2NyaXB0PgogICAg IDxzY3JpcHQgc3JjPSJNb2RlbHMvU291cmNlQ29kZVJldmlzaW9uLmpzIj48L3NjcmlwdD4KICAg ICA8c2NyaXB0IHNyYz0iTW9kZWxzL1NvdXJjZUNvZGVUaW1lbGluZS5qcyI+PC9zY3JpcHQ+CiAg ICAgPHNjcmlwdCBzcmM9Ik1vZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qcyI+PC9zY3JpcHQ+Cg==