159337 2016-07-01 02:23:34 -0700 [EFL] Many layout tests are timeout after r202532. 2016-07-01 20:03:56 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159077 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1207039 0 hs85.jeong 2016-07-01 02:23:34 -0700 202725 failure #28700 Failed exiting early after 0 crashes and 50 timeouts. 7352 tests run. 60 failures 1 new passes 1 missing results api tests ... 202534 failure #28634 Failed exiting early after 0 crashes and 50 timeouts. 7349 tests run. 78 failures 1 new passes 4 missing results api tests 202531 failure #28633 Failed 196 failures 35 new passes 27 flakes 5 missing results EFL port's layout test failed for a long time. 1207050 1 282533 hs85.jeong 2016-07-01 02:48:52 -0700 Created attachment 282533 Patch 1207051 2 commit-queue 2016-07-01 02:49:40 -0700 Attachment 282533 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:82: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:65: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1207054 3 282533 gyuyoung.kim 2016-07-01 02:56:49 -0700 Comment on attachment 282533 Patch Patch looks good because this is copied from DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing(). But please fix style error. 1207059 4 hs85.jeong 2016-07-01 03:05:11 -0700 I think that is false positive. Other codes also add white space before '(' in function callback. 1207080 5 gyuyoung.kim 2016-07-01 05:43:15 -0700 (In reply to comment #4) > I think that is false positive. > Other codes also add white space before '(' in function callback. No, there are definitely code which follows coding style. If there is no rational reason, I think we have to adhere coding style alarm. void StackVisitor::Frame::dump(PrintStream& out, Indenter indent, std::function<void(PrintStream&)> prefix) const { if (!this->callFrame()) { out.print(indent, "frame 0x0\n"); return; } 1207106 6 282548 hs85.jeong 2016-07-01 07:49:39 -0700 Created attachment 282548 Patch 1207109 7 hs85.jeong 2016-07-01 07:53:06 -0700 (In reply to comment #5) > (In reply to comment #4) > > I think that is false positive. > > Other codes also add white space before '(' in function callback. > > No, there are definitely code which follows coding style. If there is no > rational reason, I think we have to adhere coding style alarm. > > void StackVisitor::Frame::dump(PrintStream& out, Indenter indent, > std::function<void(PrintStream&)> prefix) const > { > if (!this->callFrame()) { > out.print(indent, "frame 0x0\n"); > return; > } Okay. I changed it!! 1207416 8 282548 gyuyoung.kim 2016-07-01 19:43:32 -0700 Comment on attachment 282548 Patch r=me. 1207420 9 282548 commit-queue 2016-07-01 20:03:52 -0700 Comment on attachment 282548 Patch Clearing flags on attachment: 282548 Committed r202773: <http://trac.webkit.org/changeset/202773> 1207421 10 commit-queue 2016-07-01 20:03:56 -0700 All reviewed patches have been landed. Closing bug. 282533 2016-07-01 02:48:52 -0700 2016-07-01 07:49:32 -0700 Patch bug-159337-20160701184829.patch text/plain 2714 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjcyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA3LTAxICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBNYW55IGxh eW91dCB0ZXN0cyBhcmUgdGltZW91dCBhZnRlciByMjAyNTMyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MzM3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUGFnZVByb3h5Ojpmb3JjZVJlcGFpbnQo KSB3YWl0IGZvciB0aGUgbmV4dCBjb21taXQgZnJvbSB0aGUgd2ViIHByb2Nlc3MKKyAgICAgICAg YWZ0ZXIgcjIwMjUzMiwgYnV0IFdlYlBhZ2VQcm94eTo6Y2FsbEFmdGVyTmV4dFByZXNlbnRhdGlv blVwZGF0ZSgpIGlzIG5vdCAKKyAgICAgICAgaW1wbGVtZW50ZWQgaW4gQ29vcmRpbmF0ZWREcmF3 aW5nQXJlYVByb3h5LgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRp bmF0ZWREcmF3aW5nQXJlYVByb3h5Ojpjb250ZW50c1JlY3QpOgorICAgICAgICAoV2ViS2l0OjpD b29yZGluYXRlZERyYXdpbmdBcmVhUHJveHk6OmRpc3BhdGNoQWZ0ZXJFbnN1cmluZ0RyYXdpbmcp OgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZERyYXdpbmdBcmVhUHJveHk6OnNpemVEaWRD aGFuZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5h dGVkRHJhd2luZ0FyZWFQcm94eS5oOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZERyYXdp bmdBcmVhUHJveHk6OnBhZ2UpOgorCiAyMDE2LTA3LTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u ZkBnbWFpbC5jb20+CiAKICAgICAgICAgQWRkIGEgcnVudGltZSBmbGFnIGZvciBET00gaXRlcmF0 b3JzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZERyYXdpbmdBcmVhUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWFQ cm94eS5jcHAJKHJldmlzaW9uIDIwMjY2MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTcyLDYgKzcyLDE2IEBAIFdlYkNvcmU6OkludFJlY3QgQ29vcmRpbmF0ZWRE cmF3aW5nQXJlYVAKICAgICByZXR1cm4gSW50UmVjdChJbnRQb2ludDo6emVybygpLCBtX3dlYlBh Z2VQcm94eS52aWV3U2l6ZSgpKTsKIH0KIAordm9pZCBDb29yZGluYXRlZERyYXdpbmdBcmVhUHJv eHk6OmRpc3BhdGNoQWZ0ZXJFbnN1cmluZ0RyYXdpbmcoc3RkOjpmdW5jdGlvbjx2b2lkIChDYWxs YmFja0Jhc2U6OkVycm9yKT4gY2FsbGJhY2tGdW5jdGlvbikKK3sKKyAgICBpZiAoIW1fd2ViUGFn ZVByb3h5LmlzVmFsaWQoKSkgeworICAgICAgICBjYWxsYmFja0Z1bmN0aW9uKENhbGxiYWNrQmFz ZTo6RXJyb3I6Ok93bmVyV2FzSW52YWxpZGF0ZWQpOworICAgICAgICByZXR1cm47CisgICAgfQor CisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtjYWxsYmFja0Z1bmN0aW9uXSB7IGNhbGxi YWNrRnVuY3Rpb24oQ2FsbGJhY2tCYXNlOjpFcnJvcjo6Tm9uZSk7IH0pOworfQorCiB2b2lkIENv b3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eTo6c2l6ZURpZENoYW5nZSgpCiB7CiAgICAgYmFja2lu Z1N0b3JlU3RhdGVEaWRDaGFuZ2UoUmVzcG9uZEltbWVkaWF0ZWx5KTsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0Fy ZWFQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eS5oCShyZXZpc2lvbiAyMDI2 NjMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29y ZGluYXRlZERyYXdpbmdBcmVhUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsOSBA QCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGVWaWV3cG9ydCgpOwogCiAgICAgV2ViUGFnZVByb3h5 JiBwYWdlKCkgeyByZXR1cm4gbV93ZWJQYWdlUHJveHk7IH0KKyAgICAKKyAgICB2b2lkIGRpc3Bh dGNoQWZ0ZXJFbnN1cmluZ0RyYXdpbmcoc3RkOjpmdW5jdGlvbjx2b2lkIChDYWxsYmFja0Jhc2U6 OkVycm9yKT4pIG92ZXJyaWRlOworCiBwcml2YXRlOgogICAgIC8vIERyYXdpbmdBcmVhUHJveHkK ICAgICB2aXJ0dWFsIHZvaWQgc2l6ZURpZENoYW5nZSgpOwo= 282548 2016-07-01 07:49:39 -0700 2016-07-01 20:03:52 -0700 Patch bug-159337-20160701234916.patch text/plain 2978 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2ZiMjA0MmUxYjhmNTQz NzMyODRhMDc0ODIyZjE5OWVmNzU0MmNhOS4uODU2YmFjYjhlNDQzZjJiYmU4NzQ2MjhjY2ZhMDk3 ZDE2NTMwMzZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA3LTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBNYW55 IGxheW91dCB0ZXN0cyBhcmUgdGltZW91dCBhZnRlciByMjAyNTMyLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MzM3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUGFnZVByb3h5Ojpmb3JjZVJlcGFp bnQoKSB3YWl0IGZvciB0aGUgbmV4dCBjb21taXQgZnJvbSB0aGUgd2ViIHByb2Nlc3MKKyAgICAg ICAgYWZ0ZXIgcjIwMjUzMiwgYnV0IFdlYlBhZ2VQcm94eTo6Y2FsbEFmdGVyTmV4dFByZXNlbnRh dGlvblVwZGF0ZSgpIGlzIG5vdCAKKyAgICAgICAgaW1wbGVtZW50ZWQgaW4gQ29vcmRpbmF0ZWRE cmF3aW5nQXJlYVByb3h5LgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29v cmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5Ojpjb250ZW50c1JlY3QpOgorICAgICAgICAoV2ViS2l0 OjpDb29yZGluYXRlZERyYXdpbmdBcmVhUHJveHk6OmRpc3BhdGNoQWZ0ZXJFbnN1cmluZ0RyYXdp bmcpOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZERyYXdpbmdBcmVhUHJveHk6OnNpemVE aWRDaGFuZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3Jk aW5hdGVkRHJhd2luZ0FyZWFQcm94eS5oOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZERy YXdpbmdBcmVhUHJveHk6OnBhZ2UpOgorCiAyMDE2LTA3LTAxICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uZkBnbWFpbC5jb20+CiAKICAgICAgICAgQWRkIGEgcnVudGltZSBmbGFnIGZvciBET00gaXRl cmF0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRH cmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5 LmNwcAppbmRleCA1MTJiODlhMThjNTZiYzNiMTYwOTE1ODg5ZDU3ZTgyZmRhZjRlZGQ5Li5iMDky OThlYzhkMjNmNGNlZGUxYTQ1NjY5MzQ4MDUzMDIyMDRkMmMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdB cmVhUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eS5jcHAKQEAgLTcyLDYgKzcyLDE4IEBA IFdlYkNvcmU6OkludFJlY3QgQ29vcmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5Ojpjb250ZW50c1Jl Y3QoKSBjb25zdAogICAgIHJldHVybiBJbnRSZWN0KEludFBvaW50Ojp6ZXJvKCksIG1fd2ViUGFn ZVByb3h5LnZpZXdTaXplKCkpOwogfQogCit2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94 eTo6ZGlzcGF0Y2hBZnRlckVuc3VyaW5nRHJhd2luZyhzdGQ6OmZ1bmN0aW9uPHZvaWQoQ2FsbGJh Y2tCYXNlOjpFcnJvcik+IGNhbGxiYWNrRnVuY3Rpb24pCit7CisgICAgaWYgKCFtX3dlYlBhZ2VQ cm94eS5pc1ZhbGlkKCkpIHsKKyAgICAgICAgY2FsbGJhY2tGdW5jdGlvbihDYWxsYmFja0Jhc2U6 OkVycm9yOjpPd25lcldhc0ludmFsaWRhdGVkKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwor ICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbY2FsbGJhY2tGdW5jdGlvbl0geworICAgICAg ICBjYWxsYmFja0Z1bmN0aW9uKENhbGxiYWNrQmFzZTo6RXJyb3I6Ok5vbmUpOworICAgIH0pOwor fQorCiB2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eTo6c2l6ZURpZENoYW5nZSgpCiB7 CiAgICAgYmFja2luZ1N0b3JlU3RhdGVEaWRDaGFuZ2UoUmVzcG9uZEltbWVkaWF0ZWx5KTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkRHJhd2luZ0FyZWFQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nv b3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5LmgKaW5kZXggYmVm NzczMGQwOTlhMWVmNmMxMTA0ODdiYmE1NWRiNTExYjgzZjRlYS4uMjYzY2ViODRkYjkwNTA1ODhh YTBlNGJiOWU4MzEzYWE4NWQwMGZjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYVByb3h5LmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0 ZWREcmF3aW5nQXJlYVByb3h5LmgKQEAgLTYxLDYgKzYxLDkgQEAgcHVibGljOgogICAgIHZvaWQg dXBkYXRlVmlld3BvcnQoKTsKIAogICAgIFdlYlBhZ2VQcm94eSYgcGFnZSgpIHsgcmV0dXJuIG1f d2ViUGFnZVByb3h5OyB9CisgICAgCisgICAgdm9pZCBkaXNwYXRjaEFmdGVyRW5zdXJpbmdEcmF3 aW5nKHN0ZDo6ZnVuY3Rpb248dm9pZChDYWxsYmFja0Jhc2U6OkVycm9yKT4pIG92ZXJyaWRlOwor CiBwcml2YXRlOgogICAgIC8vIERyYXdpbmdBcmVhUHJveHkKICAgICB2aXJ0dWFsIHZvaWQgc2l6 ZURpZENoYW5nZSgpOwo=