159329 2016-06-30 21:14:44 -0700 [Mac] Get rid of the old timey rubber-banding linen pattern. 2016-07-06 09:56:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified REOPENED Performance P2 Normal --- 159473 1 kling kling bdakin commit-queue kling sam simon.fraser thorton oldest_to_newest 1206984 0 kling 2016-06-30 21:14:44 -0700 We're sometimes loading the linen pattern image despite never actually showing it. This can happen if we go down rendering code paths from the WebPage constructor, before settings are fully loaded. 1206990 1 282512 kling 2016-06-30 21:49:44 -0700 Created attachment 282512 Patch 1207006 2 282512 commit-queue 2016-06-30 23:58:55 -0700 Comment on attachment 282512 Patch Clearing flags on attachment: 282512 Committed r202725: <http://trac.webkit.org/changeset/202725> 1207007 3 commit-queue 2016-06-30 23:59:00 -0700 All reviewed patches have been landed. Closing bug. 1207008 4 bdakin 2016-07-01 00:00:41 -0700 Do we have any API clients that set backgroundExtendsBeyondPage to YES? And if so, does this change their behavior? 1207016 5 kling 2016-07-01 00:34:11 -0700 (In reply to comment #4) > Do we have any API clients that set backgroundExtendsBeyondPage to YES? And > if so, does this change their behavior? AFAICT the only client of this API is Safari, which always sets it to YES, and thus nothing changes. 1207017 6 kling 2016-07-01 00:35:33 -0700 (In reply to comment #5) > (In reply to comment #4) > > Do we have any API clients that set backgroundExtendsBeyondPage to YES? And > > if so, does this change their behavior? > > AFAICT the only client of this API is Safari, which always sets it to YES, > and thus nothing changes. Sorry, I spoke too soon. I found two other clients who also set it to YES. (see cf) 1207149 7 bdakin 2016-07-01 09:34:04 -0700 (In reply to comment #4) > Do we have any API clients that set backgroundExtendsBeyondPage to YES? And > if so, does this change their behavior? Oh yeah, I guess I meant NO. :P 1207154 8 kling 2016-07-01 09:38:26 -0700 (In reply to comment #7) > (In reply to comment #4) > > Do we have any API clients that set backgroundExtendsBeyondPage to YES? And > > if so, does this change their behavior? > > Oh yeah, I guess I meant NO. :P Oh duh, late night reading comprehension pls. I couldn't find any clients that set this to NO. 1207159 9 thorton 2016-07-01 09:41:49 -0700 Isn't NO the default for WKView? (but not WKWebView?) 1207163 10 thorton 2016-07-01 09:45:38 -0700 (In reply to comment #9) > Isn't NO the default for WKView? (but not WKWebView?) (it is). So you have changed behavior for WKView clients. Probably most will not care, but we should make sure (App Store and iTunes come to mind). 1207165 11 kling 2016-07-01 09:48:19 -0700 (In reply to comment #10) > (In reply to comment #9) > > Isn't NO the default for WKView? (but not WKWebView?) > > (it is). So you have changed behavior for WKView clients. Probably most will > not care, but we should make sure (App Store and iTunes come to mind). I see! I also found this in WTR: // This setting differs between the antique and modern Mac WebKit2 API. // For now, maintain the antique behavior, because some tests depend on it! // FIXME: We should be testing the default. WKPageSetBackgroundExtendsBeyondPage(m_mainWebView->page(), false); While it appears this change hasn't affected any tests, perhaps it was wrong to remove the check for backgroundShouldExtendBeyondPage() in updateOverflowControlsLayers().. 1207166 12 thorton 2016-07-01 09:51:39 -0700 Well, we've talked about making YES the only value, so it's possible you've just accelerated the transition :) 1208250 13 kling 2016-07-06 09:53:55 -0700 This didn't end up affecting dirty "CoreUI image data" memory after all, so I'm going to roll it out since it unintentionally changed behavior. We can revisit it in the future once we're sure we want the new behavior. 1208253 14 commit-queue 2016-07-06 09:56:03 -0700 Re-opened since this is blocked by bug 159473 282512 2016-06-30 21:49:44 -0700 2016-06-30 23:58:55 -0700 Patch bug-159329.diff text/plain 11709 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MzcyMmNmLi5kYjNmNTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzQg QEAKKzIwMTYtMDYtMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtNYWNdIEdldCByaWQgb2YgdGhlIG9sZCB0aW1leSBydWJiZXItYmFuZGluZyBsaW5lbiBw YXR0ZXJuLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTU5MzI5PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgIlNjcm9s bGluZ092ZXJoYW5nIiBjdXN0b20gR3JhcGhpY3NMYXllciBhcHBlYXJhbmNlIHNpbmNlIHRoYXQg d2FzIG9ubHkgdXNlZCB0bworICAgICAgICBpbnN0YWxsIHRoZSBvbGQgdGltZXkgbGluZW4gcGF0 dGVybiBiZWhpbmQgdGhlIHdlYiBjb250ZW50LgorCisgICAgICAgIFdlIG5vdyBhbHdheXMganVz dCBzZXQgdGhlIG92ZXJoYW5nIGFyZWEncyBiYWNrZ3JvdW5kIGNvbG9yIHRvIHRoZSBkb2N1bWVu dCBiYWNrZ3JvdW5kIGNvbG9yLgorCisgICAgICAgIFRoaXMgZml4ZXMgYW4gaXNzdWUgd2hlcmUg d2UgY291bGQgZW5kIHVwIGxvYWRpbmcgdGhlIGxpbmVuIHBhdHRlcm4gYW5kIGtlZXBpbmcgaXQg aW4gbWVtb3J5CisgICAgICAgIGRlc3BpdGUgbmV2ZXIgYWN0dWFsbHkgc2hvd2luZyBpdCBvbiBz Y3JlZW4uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxiYXJUaGVtZS5oOgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWU6OnNldFVwT3ZlcmhhbmdBcmVhc0xheWVyQ29udGVudHMp OiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3Bw OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDoKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5ZXJDb2NvYS5tbToKKyAg ICAgICAgKFBsYXRmb3JtQ0FMYXllckNvY29hOjp1cGRhdGVDdXN0b21BcHBlYXJhbmNlKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpsaW5lbkJh Y2tncm91bmRDb2xvcik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVt ZU1hYzo6c2V0VXBPdmVyaGFuZ0FyZWFCYWNrZ3JvdW5kKTogRGVsZXRlZC4KKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjpyZW1vdmVPdmVyaGFuZ0FyZWFCYWNrZ3JvdW5kKTog RGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjpzZXRVcE92ZXJo YW5nQXJlYXNMYXllckNvbnRlbnRzKTogRGVsZXRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29t cG9zaXRvcjo6dXBkYXRlT3ZlcmZsb3dDb250cm9sc0xheWVycyk6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnNldFJvb3RFeHRlbmRlZEJhY2tncm91bmRDb2xvcik6 CisKIDIwMTYtMDYtMzAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBDcmVhdGUgYSBnZW5lcmljICJsaW5rZWQtb24tb3ItYWZ0ZXIiIGNoZWNrIGZvciBuZXcg Q1NQIFJ1bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXJU aGVtZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFyVGhlbWUuaAppbmRleCA3 MjUyOTQyLi5lMjg4NjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxiYXJUaGVtZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhclRoZW1l LmgKQEAgLTkxLDcgKzkxLDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBwYWludE92ZXJo YW5nQXJlYXMoU2Nyb2xsVmlldyYsIEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IEludFJlY3QmLCBj b25zdCBJbnRSZWN0JiwgY29uc3QgSW50UmVjdCYpIHsgfQogCiAjaWYgRU5BQkxFKFJVQkJFUl9C QU5ESU5HKQotICAgIHZpcnR1YWwgdm9pZCBzZXRVcE92ZXJoYW5nQXJlYXNMYXllckNvbnRlbnRz KEdyYXBoaWNzTGF5ZXIqLCBjb25zdCBDb2xvciYpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBzZXRV cENvbnRlbnRTaGFkb3dMYXllcihHcmFwaGljc0xheWVyKikgeyB9CiAjZW5kaWYKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAppbmRl eCAyYTI2NDc3Li4yZDYwZWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0xheWVyLmNwcApAQCAtODk0LDcgKzg5NCw2IEBAIFRleHRTdHJlYW0m IG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYgdHMsIGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6 OkN1c3RvbUFwcGVhCiB7CiAgICAgc3dpdGNoIChjdXN0b21BcHBlYXJhbmNlKSB7CiAgICAgY2Fz ZSBHcmFwaGljc0xheWVyOjpDdXN0b21BcHBlYXJhbmNlOjpOb0N1c3RvbUFwcGVhcmFuY2U6IHRz IDw8ICJub25lIjsgYnJlYWs7Ci0gICAgY2FzZSBHcmFwaGljc0xheWVyOjpDdXN0b21BcHBlYXJh bmNlOjpTY3JvbGxpbmdPdmVyaGFuZzogdHMgPDwgInNjcm9sbGluZy1vdmVyaGFuZyI7IGJyZWFr OwogICAgIGNhc2UgR3JhcGhpY3NMYXllcjo6Q3VzdG9tQXBwZWFyYW5jZTo6U2Nyb2xsaW5nU2hh ZG93OiB0cyA8PCAic2Nyb2xsaW5nLXNoYWRvdyI7IGJyZWFrOwogICAgIGNhc2UgR3JhcGhpY3NM YXllcjo6Q3VzdG9tQXBwZWFyYW5jZTo6TGlnaHRCYWNrZHJvcEFwcGVhcmFuY2U6IHRzIDw8ICJs aWdodC1iYWNrZHJvcCI7IGJyZWFrOwogICAgIGNhc2UgR3JhcGhpY3NMYXllcjo6Q3VzdG9tQXBw ZWFyYW5jZTo6RGFya0JhY2tkcm9wQXBwZWFyYW5jZTogdHMgPDwgImRhcmstYmFja2Ryb3AiOyBi cmVhazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5 ZXIuaAppbmRleCAyNmExZDJhLi5kYmM1Zjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oCkBAIC00ODEsNyArNDgxLDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgdm9pZCBzZXREZWJ1Z0JhY2tncm91bmRDb2xvcihjb25zdCBDb2xvciYp IHsgfQogICAgIHZpcnR1YWwgdm9pZCBzZXREZWJ1Z0JvcmRlcihjb25zdCBDb2xvciYsIGZsb2F0 IC8qYm9yZGVyV2lkdGgqLykgeyB9CiAKLSAgICBlbnVtIEN1c3RvbUFwcGVhcmFuY2UgeyBOb0N1 c3RvbUFwcGVhcmFuY2UsIFNjcm9sbGluZ092ZXJoYW5nLCBTY3JvbGxpbmdTaGFkb3csIExpZ2h0 QmFja2Ryb3BBcHBlYXJhbmNlLCBEYXJrQmFja2Ryb3BBcHBlYXJhbmNlIH07CisgICAgZW51bSBD dXN0b21BcHBlYXJhbmNlIHsgTm9DdXN0b21BcHBlYXJhbmNlLCBTY3JvbGxpbmdTaGFkb3csIExp Z2h0QmFja2Ryb3BBcHBlYXJhbmNlLCBEYXJrQmFja2Ryb3BBcHBlYXJhbmNlIH07CiAgICAgdmly dHVhbCB2b2lkIHNldEN1c3RvbUFwcGVhcmFuY2UoQ3VzdG9tQXBwZWFyYW5jZSBjdXN0b21BcHBl YXJhbmNlKSB7IG1fY3VzdG9tQXBwZWFyYW5jZSA9IGN1c3RvbUFwcGVhcmFuY2U7IH0KICAgICBD dXN0b21BcHBlYXJhbmNlIGN1c3RvbUFwcGVhcmFuY2UoKSBjb25zdCB7IHJldHVybiBtX2N1c3Rv bUFwcGVhcmFuY2U7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2EvY29jb2EvUGxhdGZvcm1DQUxheWVyQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5ZXJDb2NvYS5tbQppbmRleCA3 Yzc4ZTQ0Li4wMmYzNzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5ZXJDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5ZXJDb2NvYS5tbQpAQCAt OTUxLDEyICs5NTEsOCBAQCB2b2lkIFBsYXRmb3JtQ0FMYXllckNvY29hOjp1cGRhdGVDdXN0b21B cHBlYXJhbmNlKEdyYXBoaWNzTGF5ZXI6OkN1c3RvbUFwcGVhcmFuYwogICAgIGNhc2UgR3JhcGhp Y3NMYXllcjo6Tm9DdXN0b21BcHBlYXJhbmNlOgogICAgIGNhc2UgR3JhcGhpY3NMYXllcjo6TGln aHRCYWNrZHJvcEFwcGVhcmFuY2U6CiAgICAgY2FzZSBHcmFwaGljc0xheWVyOjpEYXJrQmFja2Ry b3BBcHBlYXJhbmNlOgotICAgICAgICBTY3JvbGxiYXJUaGVtZU1hYzo6cmVtb3ZlT3ZlcmhhbmdB cmVhQmFja2dyb3VuZChwbGF0Zm9ybUxheWVyKCkpOwogICAgICAgICBTY3JvbGxiYXJUaGVtZU1h Yzo6cmVtb3ZlT3ZlcmhhbmdBcmVhU2hhZG93KHBsYXRmb3JtTGF5ZXIoKSk7CiAgICAgICAgIGJy ZWFrOwotICAgIGNhc2UgR3JhcGhpY3NMYXllcjo6U2Nyb2xsaW5nT3Zlcmhhbmc6Ci0gICAgICAg IFNjcm9sbGJhclRoZW1lTWFjOjpzZXRVcE92ZXJoYW5nQXJlYUJhY2tncm91bmQocGxhdGZvcm1M YXllcigpKTsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBHcmFwaGljc0xheWVyOjpTY3JvbGxp bmdTaGFkb3c6CiAgICAgICAgIFNjcm9sbGJhclRoZW1lTWFjOjpzZXRVcE92ZXJoYW5nQXJlYVNo YWRvdyhwbGF0Zm9ybUxheWVyKCkpOwogICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLmgKaW5kZXggYTcyODI5OC4uYTJjZDlk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1l TWFjLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFj LmgKQEAgLTY4LDkgKzY4LDYgQEAgcHVibGljOgogICAgIGJvb2wgaXNMYXlvdXREaXJlY3Rpb25S VEwoU2Nyb2xsYmFyJik7CiAKICNpZiBFTkFCTEUoUlVCQkVSX0JBTkRJTkcpCi0gICAgV0VCQ09S RV9FWFBPUlQgc3RhdGljIHZvaWQgc2V0VXBPdmVyaGFuZ0FyZWFCYWNrZ3JvdW5kKENBTGF5ZXIg KiwgY29uc3QgQ29sb3ImIGN1c3RvbUJhY2tncm91bmRDb2xvciA9IENvbG9yKCkpOwotICAgIFdF QkNPUkVfRVhQT1JUIHN0YXRpYyB2b2lkIHJlbW92ZU92ZXJoYW5nQXJlYUJhY2tncm91bmQoQ0FM YXllciAqKTsKLQogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyB2b2lkIHNldFVwT3ZlcmhhbmdB cmVhU2hhZG93KENBTGF5ZXIgKik7CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIHZvaWQgcmVt b3ZlT3ZlcmhhbmdBcmVhU2hhZG93KENBTGF5ZXIgKik7CiAjZW5kaWYKQEAgLTkyLDcgKzg5LDYg QEAgcHJvdGVjdGVkOgogICAgIGludCBzY3JvbGxiYXJQYXJ0VG9ISVByZXNzZWRTdGF0ZShTY3Jv bGxiYXJQYXJ0KTsKIAogI2lmIEVOQUJMRShSVUJCRVJfQkFORElORykKLSAgICB2b2lkIHNldFVw T3ZlcmhhbmdBcmVhc0xheWVyQ29udGVudHMoR3JhcGhpY3NMYXllciosIGNvbnN0IENvbG9yJikg b3ZlcnJpZGU7CiAgICAgdm9pZCBzZXRVcENvbnRlbnRTaGFkb3dMYXllcihHcmFwaGljc0xheWVy Kikgb3ZlcnJpZGU7CiAjZW5kaWYKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0KaW5kZXggOTFjYmVkZC4uZWViNDdiOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQpAQCAtNDcs MTAgKzQ3LDYgQEAKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKLUBpbnRlcmZhY2UgTlND b2xvciAoV2ViTlNDb2xvckRldGFpbHMpCi0rIChOU0ltYWdlICopX2xpbmVuUGF0dGVybkltYWdl OwotQGVuZAotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHR5cGVkZWYgSGFzaE1hcDxTY3JvbGxi YXIqLCBSZXRhaW5QdHI8TlNTY3JvbGxlckltcD4+IFNjcm9sbGVySW1wTWFwOwpAQCAtNTY0LDM4 ICs1NjAsNiBAQCBib29sIFNjcm9sbGJhclRoZW1lTWFjOjpwYWludChTY3JvbGxiYXImIHNjcm9s bGJhciwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjbwogfQogCiAjaWYgRU5BQkxFKFJVQkJF Ul9CQU5ESU5HKQotc3RhdGljIFJldGFpblB0cjxDR0NvbG9yUmVmPiBsaW5lbkJhY2tncm91bmRD b2xvcigpCi17Ci0gICAgTlNJbWFnZSAqaW1hZ2UgPSBuaWw7Ci0gICAgQ0dJbWFnZVJlZiBjZ0lt YWdlID0gbnVsbHB0cjsKLSAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlM7Ci0gICAgaW1h Z2UgPSBbTlNDb2xvciBfbGluZW5QYXR0ZXJuSW1hZ2VdOwotICAgIGNnSW1hZ2UgPSBbaW1hZ2Ug Q0dJbWFnZUZvclByb3Bvc2VkUmVjdDpOVUxMIGNvbnRleHQ6TlVMTCBoaW50czpuaWxdOwotICAg IEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7Ci0gICAgCi0gICAgaWYgKCFjZ0ltYWdlKQotICAg ICAgICByZXR1cm4gbnVsbHB0cjsKLQotICAgIFJldGFpblB0cjxDR1BhdHRlcm5SZWY+IHBhdHRl cm4gPSBhZG9wdENGKHdrQ0dQYXR0ZXJuQ3JlYXRlV2l0aEltYWdlQW5kVHJhbnNmb3JtKGNnSW1h Z2UsIENHQWZmaW5lVHJhbnNmb3JtSWRlbnRpdHksIHdrUGF0dGVyblRpbGluZ05vRGlzdG9ydGlv bikpOwotICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNvbG9yU3BhY2UgPSBhZG9wdENG KENHQ29sb3JTcGFjZUNyZWF0ZVBhdHRlcm4oMCkpOwotCi0gICAgY29uc3QgQ0dGbG9hdCBhbHBo YSA9IDEuMDsKLSAgICByZXR1cm4gYWRvcHRDRihDR0NvbG9yQ3JlYXRlV2l0aFBhdHRlcm4oY29s b3JTcGFjZS5nZXQoKSwgcGF0dGVybi5nZXQoKSwgJmFscGhhKSk7Ci19Ci0KLXZvaWQgU2Nyb2xs YmFyVGhlbWVNYWM6OnNldFVwT3ZlcmhhbmdBcmVhQmFja2dyb3VuZChDQUxheWVyICpsYXllciwg Y29uc3QgQ29sb3ImIGN1c3RvbUJhY2tncm91bmRDb2xvcikKLXsKLSAgICBzdGF0aWMgQ0dDb2xv clJlZiBjYWNoZWRMaW5lbkJhY2tncm91bmRDb2xvciA9IGxpbmVuQmFja2dyb3VuZENvbG9yKCku bGVha1JlZigpOwotICAgIC8vIFdlIG9wZXJhdGUgb24gdGhlIENBTGF5ZXIgZGlyZWN0bHkgaGVy ZSwgc2luY2UgR3JhcGhpY3NMYXllciBkb2Vzbid0IGhhdmUgdGhlIGNvbmNlcHQKLSAgICAvLyBv ZiBwYXR0ZXJuIGltYWdlcywgYW5kIHdlIGtub3cgdGhhdCBXZWJDb3JlIHdvbid0IHRvdWNoIHRo aXMgbGF5ZXIuCi0gICAgbGF5ZXIuYmFja2dyb3VuZENvbG9yID0gY3VzdG9tQmFja2dyb3VuZENv bG9yLmlzVmFsaWQoKSA/IGNhY2hlZENHQ29sb3IoY3VzdG9tQmFja2dyb3VuZENvbG9yKSA6IGNh Y2hlZExpbmVuQmFja2dyb3VuZENvbG9yOwotfQotCi12b2lkIFNjcm9sbGJhclRoZW1lTWFjOjpy ZW1vdmVPdmVyaGFuZ0FyZWFCYWNrZ3JvdW5kKENBTGF5ZXIgKmxheWVyKQotewotICAgIGxheWVy LmJhY2tncm91bmRDb2xvciA9IG5pbDsKLX0KLQogdm9pZCBTY3JvbGxiYXJUaGVtZU1hYzo6c2V0 VXBPdmVyaGFuZ0FyZWFTaGFkb3coQ0FMYXllciAqbGF5ZXIpCiB7CiAgICAgc3RhdGljIGNvbnN0 IENHRmxvYXQgc2hhZG93T3BhY2l0eSA9IDAuNjY7CkBAIC02MTksMTEgKzU4Myw2IEBAIHZvaWQg U2Nyb2xsYmFyVGhlbWVNYWM6OnJlbW92ZU92ZXJoYW5nQXJlYVNoYWRvdyhDQUxheWVyICpsYXll cikKICAgICBsYXllci5zaGFkb3dPcGFjaXR5ID0gMDsKIH0KIAotdm9pZCBTY3JvbGxiYXJUaGVt ZU1hYzo6c2V0VXBPdmVyaGFuZ0FyZWFzTGF5ZXJDb250ZW50cyhHcmFwaGljc0xheWVyKiBncmFw aGljc0xheWVyLCBjb25zdCBDb2xvciYgY3VzdG9tQmFja2dyb3VuZENvbG9yKQotewotICAgIFNj cm9sbGJhclRoZW1lTWFjOjpzZXRVcE92ZXJoYW5nQXJlYUJhY2tncm91bmQoZ3JhcGhpY3NMYXll ci0+cGxhdGZvcm1MYXllcigpLCBjdXN0b21CYWNrZ3JvdW5kQ29sb3IpOwotfQotCiB2b2lkIFNj cm9sbGJhclRoZW1lTWFjOjpzZXRVcENvbnRlbnRTaGFkb3dMYXllcihHcmFwaGljc0xheWVyKiBn cmFwaGljc0xheWVyKQogewogICAgIC8vIFdlIG9wZXJhdGUgb24gdGhlIENBTGF5ZXIgZGlyZWN0 bHkgaGVyZSwgc2luY2UgR3JhcGhpY3NMYXllciBkb2Vzbid0IGhhdmUgdGhlIGNvbmNlcHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAK aW5kZXggYzE5YmIyZi4uZGFlMGFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTMyNzAsOSArMzI3MCw2IEBAIHZvaWQg UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzZXRSb290RXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IoY29u c3QgQ29sb3ImIGNvbG9yKQogICAgICAgICByZXR1cm47CiAKICAgICBtX2xheWVyRm9yT3Zlcmhh bmdBcmVhcy0+c2V0QmFja2dyb3VuZENvbG9yKG1fcm9vdEV4dGVuZGVkQmFja2dyb3VuZENvbG9y KTsKLQotICAgIGlmICghbV9yb290RXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IuaXNWYWxpZCgpKQot ICAgICAgICBtX2xheWVyRm9yT3ZlcmhhbmdBcmVhcy0+c2V0Q3VzdG9tQXBwZWFyYW5jZShHcmFw aGljc0xheWVyOjpTY3JvbGxpbmdPdmVyaGFuZyk7CiAjZW5kaWYKIH0KIApAQCAtMzI5MywxMSAr MzI5MCw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVPdmVyZmxvd0NvbnRy b2xzTGF5ZXJzKCkKICAgICAgICAgICAgIG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFzLT5zZXRTaXpl KG92ZXJoYW5nQXJlYVNpemUpOwogICAgICAgICAgICAgbV9sYXllckZvck92ZXJoYW5nQXJlYXMt PnNldFBvc2l0aW9uKEZsb2F0UG9pbnQoMCwgdG9wQ29udGVudEluc2V0KSk7CiAgICAgICAgICAg ICBtX2xheWVyRm9yT3ZlcmhhbmdBcmVhcy0+c2V0QW5jaG9yUG9pbnQoRmxvYXRQb2ludDNEKCkp OwotCi0gICAgICAgICAgICBpZiAobV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLmZyYW1lKCkuc2V0 dGluZ3MoKS5iYWNrZ3JvdW5kU2hvdWxkRXh0ZW5kQmV5b25kUGFnZSgpKQotICAgICAgICAgICAg ICAgIG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFzLT5zZXRCYWNrZ3JvdW5kQ29sb3IobV9yZW5kZXJW aWV3LmZyYW1lVmlldygpLmRvY3VtZW50QmFja2dyb3VuZENvbG9yKCkpOwotICAgICAgICAgICAg ZWxzZQotICAgICAgICAgICAgICAgIG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFzLT5zZXRDdXN0b21B cHBlYXJhbmNlKEdyYXBoaWNzTGF5ZXI6OlNjcm9sbGluZ092ZXJoYW5nKTsKKyAgICAgICAgICAg IG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFzLT5zZXRCYWNrZ3JvdW5kQ29sb3IobV9yZW5kZXJWaWV3 LmZyYW1lVmlldygpLmRvY3VtZW50QmFja2dyb3VuZENvbG9yKCkpOwogCiAgICAgICAgICAgICAv LyBXZSB3YW50IHRoZSBvdmVyaGFuZyBhcmVhcyBsYXllciB0byBiZSBwb3NpdGlvbmVkIGJlbG93 IHRoZSBmcmFtZSBjb250ZW50cywKICAgICAgICAgICAgIC8vIHNvIGluc2VydCBpdCBiZWxvdyB0 aGUgY2xpcCBsYXllci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1NzdjZGExMy4uMTk0MTk1YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA2LTMwICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFw cGxlLmNvbT4KKworICAgICAgICBbTWFjXSBHZXQgcmlkIG9mIHRoZSBvbGQgdGltZXkgcnViYmVy LWJhbmRpbmcgbGluZW4gcGF0dGVybi4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE1 OTMyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVyLm1tOgorICAgICAgICAo V2ViS2l0Ojp1cGRhdGVDdXN0b21BcHBlYXJhbmNlKToKKwogMjAxNi0wNi0zMCAgQnJpYW4gQnVy ZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyMDIzMjkpOiBXZWJJ bnNwZWN0b3JQcm94eSdzIFdLUGFnZVBvbGljeUNsaWVudCBjYWxsYmFja3MgYXJlIG5vdCBiZWlu ZyBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5 ZXJUcmVlUHJvcGVydHlBcHBsaWVyLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1v dGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIubW0KaW5kZXggYTkyYWIyMS4uMDg0NjljZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVQcm9wZXJ0 eUFwcGxpZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRy ZWVQcm9wZXJ0eUFwcGxpZXIubW0KQEAgLTExMSwxMiArMTExLDggQEAgc3RhdGljIHZvaWQgdXBk YXRlQ3VzdG9tQXBwZWFyYW5jZShDQUxheWVyICpsYXllciwgR3JhcGhpY3NMYXllcjo6Q3VzdG9t QXBwZWFyYW4KICAgICBjYXNlIEdyYXBoaWNzTGF5ZXI6Ok5vQ3VzdG9tQXBwZWFyYW5jZToKICAg ICBjYXNlIEdyYXBoaWNzTGF5ZXI6OkRhcmtCYWNrZHJvcEFwcGVhcmFuY2U6CiAgICAgY2FzZSBH cmFwaGljc0xheWVyOjpMaWdodEJhY2tkcm9wQXBwZWFyYW5jZToKLSAgICAgICAgU2Nyb2xsYmFy VGhlbWVNYWM6OnJlbW92ZU92ZXJoYW5nQXJlYUJhY2tncm91bmQobGF5ZXIpOwogICAgICAgICBT Y3JvbGxiYXJUaGVtZU1hYzo6cmVtb3ZlT3ZlcmhhbmdBcmVhU2hhZG93KGxheWVyKTsKICAgICAg ICAgYnJlYWs7Ci0gICAgY2FzZSBHcmFwaGljc0xheWVyOjpTY3JvbGxpbmdPdmVyaGFuZzoKLSAg ICAgICAgU2Nyb2xsYmFyVGhlbWVNYWM6OnNldFVwT3ZlcmhhbmdBcmVhQmFja2dyb3VuZChsYXll cik7Ci0gICAgICAgIGJyZWFrOwogICAgIGNhc2UgR3JhcGhpY3NMYXllcjo6U2Nyb2xsaW5nU2hh ZG93OgogICAgICAgICBTY3JvbGxiYXJUaGVtZU1hYzo6c2V0VXBPdmVyaGFuZ0FyZWFTaGFkb3co bGF5ZXIpOwogICAgICAgICBicmVhazsK