159325 2016-06-30 17:58:40 -0700 Web Inspector: Fix inspector/debugger/pause-reason.html 2016-07-02 20:32:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker msaboff nvasilyev timothy webkit-bug-importer oldest_to_newest 1206953 0 joepeck 2016-06-30 17:58:40 -0700 Summary: This test currently fails. Steps to Reproduce: 1. shell> run-webkit-tests --force inspector/debugger/pause-reason.html => Fail Notes: Seems to fail because we don't pause where we expect to pause due to test behavior. Change the "pause on next statement" to not pause on inspector code, but instead pause on page code. 1206955 1 joepeck 2016-06-30 18:03:47 -0700 *** Bug 151893 has been marked as a duplicate of this bug. *** 1206956 2 282499 joepeck 2016-06-30 18:04:22 -0700 Created attachment 282499 [PATCH] Proposed Fix 1207132 3 282499 bburg 2016-07-01 09:07:37 -0700 Comment on attachment 282499 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=282499&action=review > LayoutTests/inspector/debugger/pause-reason.html:33 > test.setup(); If there are other evaluateOnPage things queued up, how do we guarantee that the pause will be on test.expression and not some other expression? 1207209 4 joepeck 2016-07-01 11:36:50 -0700 (In reply to comment #3) > Comment on attachment 282499 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282499&action=review > > > LayoutTests/inspector/debugger/pause-reason.html:33 > > test.setup(); > > If there are other evaluateOnPage things queued up, how do we guarantee that > the pause will be on test.expression and not some other expression? I'm not sure there is a way we can guarantee this. This test is testing evaluateInPage + pause on next statement. If anything happens in between the test will be broken. That said, one possible solution might be evaluateInPage where the Runtime.evaluate options include doNotPauseOnExceptionsAndMuteConsole:true to evaluate a "setTimeout(something,0)". Not sure that is much better. What do you think? 1207476 5 282499 commit-queue 2016-07-02 20:32:47 -0700 Comment on attachment 282499 [PATCH] Proposed Fix Clearing flags on attachment: 282499 Committed r202783: <http://trac.webkit.org/changeset/202783> 1207477 6 commit-queue 2016-07-02 20:32:51 -0700 All reviewed patches have been landed. Closing bug. 282499 2016-06-30 18:04:22 -0700 2016-07-02 20:32:47 -0700 [PATCH] Proposed Fix pause-reason-1.patch text/plain 2595 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3YTNhM2Y4Li41NWNlODEyZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTA2 LTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogRml4IGluc3BlY3Rvci9kZWJ1Z2dlci9wYXVzZS1yZWFzb24uaHRtbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MzI1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZGVidWdnZXIvcGF1c2Ut cmVhc29uLmh0bWw6CisgICAgICAgIFRoaXMgdGVzdCB3YXMgcGF1c2luZyBvbiBpbnNwZWN0b3Ig Y29kZSAoZXZhbHVhdGVJblBhZ2UpIGFuZAorICAgICAgICBhdXRvLXJlc3VtaW5nLiBJbnN0ZWFk IGNoYW5nZSB0aGUgdGVzdCB0byBwYXVzZSBvbiB0aGUgcGFnZQorICAgICAgICBkb2luZyB0aGUg c2V0VGltZW91dCwgc28gd2UgZ2V0IHRoZSBleHBlY3RlZCBwYXVzZSBvbiBuZXh0CisgICAgICAg IHN0YXRlbWVudCBldmFsdWF0aW9uLgorCisyMDE2LTA2LTMwICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYW51cCBpbnNw ZWN0b3IvY29uc29sZS9jb25zb2xlLW1lc3NhZ2UuaHRtbAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MzI0CiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9wYXVzZS1yZWFzb24uaHRtbCBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9kZWJ1Z2dlci9wYXVzZS1yZWFzb24uaHRtbAppbmRleCA3ZTdiNTA3Li5kMGVmNzg1 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvcGF1c2UtcmVhc29u Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3BhdXNlLXJlYXNvbi5o dG1sCkBAIC0xNiw3ICsxNiw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICB7IGV4cHJlc3Np b246ICJzZXRUaW1lb3V0KHRyaWdnZXJEZWJ1Z2dlclN0YXRlbWVudCwgMCkiIH0sCiAgICAgICAg IHsgZXhwcmVzc2lvbjogInNldFRpbWVvdXQodHJpZ2dlckFzc2VydCwgMCkiIH0sCiAgICAgICAg IHsgZXhwcmVzc2lvbjogInNldFRpbWVvdXQodHJpZ2dlckJyZWFrcG9pbnQsIDApIiB9LAotICAg ICAgICB7IGV4cHJlc3Npb246ICJzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyAxKzEgfSwgMCkiLCBz ZXR1cDogZnVuY3Rpb24oKSB7IFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIucGF1c2UoKTsg fSB9LAorICAgICAgICB7IGV4cHJlc3Npb246ICJzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyAxKzE7 IH0sIDUwKSIsIHNldHVwOiBmdW5jdGlvbigpIHsgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdl ci5wYXVzZSgpOyB9IH0sCiAgICAgXTsKIAogICAgIGZ1bmN0aW9uIG5leHRUZXN0Q2FzZSgpCkBA IC0yNywxMCArMjcsMTAgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KIAorICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKHRlc3QuZXhw cmVzc2lvbik7CisKICAgICAgICAgaWYgKHRlc3Quc2V0dXApCiAgICAgICAgICAgICB0ZXN0LnNl dHVwKCk7Ci0KLSAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSh0ZXN0LmV4cHJl c3Npb24pOwogICAgIH0KIAogICAgIGZ1bmN0aW9uIHNhbml0aXplUGF1c2VEYXRhKGRhdGEpCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDVjZTEzOWYuLjEw ZjQzZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC03 NDUsNyArNzQ1LDYgQEAgd2Via2l0Lm9yZy9iLzE1MTgzMiBpbnNwZWN0b3IvZGVidWdnZXIvYnJl YWstb24tdW5jYXVnaHQtZXhjZXB0aW9uLXRocm93LWluLXByb20KIGluc3BlY3Rvci9kZWJ1Z2dl ci9zZXRCcmVha3BvaW50LWRmZy1jYWxsZWUtYW5kLWV4YW1pbmUtZGZnLWxvY2FsLmh0bWwKIGlu c3BlY3Rvci9kZWJ1Z2dlci9kaWRTYW1wbGVQcm9iZS1tdWx0aXBsZS1wcm9iZXMuaHRtbAogaW5z cGVjdG9yL2RlYnVnZ2VyL25lc3RlZC1pbnNwZWN0b3JzLmh0bWwKLWluc3BlY3Rvci9kZWJ1Z2dl ci9wYXVzZS1yZWFzb24uaHRtbAogCiB3ZWJraXQub3JnL2IvMTI0MzExIGNvbXBvc2l0aW5nL3Jl Z2lvbnMvdHJhbnNmb3JtLXRyYW5zcGFyZW50LXBvc2l0aW9uZWQtdmlkZW8taW5zaWRlLXJlZ2lv bi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAK