159310 2016-06-30 13:23:34 -0700 HTMLAttachment elements don't receive clicks after the first on iOS 2016-07-05 15:24:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified iOS 9.3 RESOLVED FIXED P2 Normal --- 1 enrica enrica cdumez commit-queue esprehn+autocc gyuyoung.kim simon.fraser thorton oldest_to_newest 1206824 0 enrica 2016-06-30 13:23:34 -0700 The first click on the element selects it. On iOS we prevent clicks to go through on a selected element, in order to toggle the selection menu. rdar://problem/25776940 1206826 1 282458 enrica 2016-06-30 13:28:38 -0700 Created attachment 282458 Patch 1206827 2 thorton 2016-06-30 13:29:38 -0700 Is this testable? 1206828 3 commit-queue 2016-06-30 13:30:14 -0700 Attachment 282458 did not pass style-queue: ERROR: Source/WebCore/html/HTMLAttachmentElement.h:55: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1206884 4 enrica 2016-06-30 15:21:23 -0700 (In reply to comment #2) > Is this testable? Actually I think so, even without using gestures. 1206936 5 enrica 2016-06-30 16:45:15 -0700 We already have a test that checks the selection of the attachment element. I just need to change it to reliably testing on iOS too. I'll add it to the patch before landing. 1207957 6 enrica 2016-07-05 15:24:56 -0700 Updated test to correctly detect new behavior. Committed revision 202835. 282458 2016-06-30 13:28:38 -0700 2016-06-30 13:29:25 -0700 Patch clickonlyonceonattachments.txt text/plain 1417 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjY5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTMwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTEF0dGFjaG1lbnQgZWxl bWVudHMgZG9uJ3QgcmVjZWl2ZSBjbGlja3MgYWZ0ZXIgdGhlIGZpcnN0IG9uIGlPUy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTMxMAorICAgICAg ICByZGFyOi8vcHJvYmxlbS8yNTc3Njk0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIHNob3VsZFNlbGVjdE9uTW91c2VEb3duKCkgbm93IHJldHVybnMg ZmFsc2Ugb24gaU9TLgorCisgICAgICAgICogaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuaDoK KwogMjAxNi0wNi0zMCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIE1lZGlhIGNvbnRyb2xzIGFyZSB0b28gY3JhbXBlZCB3aXRoIHNtYWxsIHZpZGVv CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdHRhY2htZW50RWxlbWVudC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmgJKHJl dmlzaW9uIDIwMjQ5MSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVt ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDEzIEBAIHByaXZhdGU6CiAKICAgICBS ZW5kZXJQdHI8UmVuZGVyRWxlbWVudD4gY3JlYXRlRWxlbWVudFJlbmRlcmVyKFJlbmRlclN0eWxl JiYsIGNvbnN0IFJlbmRlclRyZWVQb3NpdGlvbiYpIG92ZXJyaWRlOwogCi0gICAgYm9vbCBzaG91 bGRTZWxlY3RPbk1vdXNlRG93bigpIG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0KKyAgICBib29s IHNob3VsZFNlbGVjdE9uTW91c2VEb3duKCkgb3ZlcnJpZGUgeworI2lmIFBMQVRGT1JNKElPUykK KyAgICAgICAgcmV0dXJuIGZhbHNlOworI2Vsc2UKKyAgICAgICAgcmV0dXJuIHRydWU7CisjZW5k aWYKKyAgICB9CiAgICAgYm9vbCBjYW5Db250YWluUmFuZ2VFbmRQb2ludCgpIGNvbnN0IG92ZXJy aWRlIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdm9pZCBwYXJzZUF0dHJpYnV0ZShjb25zdCBRdWFs aWZpZWROYW1lJiwgY29uc3QgQXRvbWljU3RyaW5nJikgb3ZlcnJpZGU7CiAgICAgCg==