159299 2016-06-30 06:49:46 -0700 [Win][Debug] Assertion fails in TestWTF. 2016-06-30 11:20:36 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler oldest_to_newest 1206707 0 pvollan 2016-06-30 06:49:46 -0700 The assert in the & operator in the UniqueRef class fails, because the UniqueRef instance has been moved. The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing the assertion failure. > WTF.dll!WTFCrash() Line 317 C++ TestWTFLib.dll!WTF::UniqueRef<TestWebKitAPI::A>::operator&() Line 54 C++ TestWTFLib.dll!TestWebKitAPI::WTF_UniqueRef_Test::TestBody() Line 83 C++ TestWTFLib.dll!testing::Test::Run() Line 2070 C++ TestWTFLib.dll!testing::internal::TestInfoImpl::Run() Line 2318 C++ TestWTFLib.dll!testing::TestCase::Run() Line 2421 C++ TestWTFLib.dll!testing::internal::UnitTestImpl::RunAllTests() Line 4025 C++ TestWTFLib.dll!testing::UnitTest::Run() Line 3677 C++ TestWTFLib.dll!TestWebKitAPI::TestsController::run(int argc, char * * argv) Line 80 C++ TestWTFLib.dll!main(int argc, char * * argv) Line 53 C++ TestWTFLib.dll!dllLauncherEntryPoint(int argc, char * * argv) Line 60 C++ TestWTF.exe!main(int argc, const char * * argv) Line 247 C++ 1206709 1 282436 pvollan 2016-06-30 06:57:17 -0700 Created attachment 282436 Patch 1206779 2 282436 commit-queue 2016-06-30 10:49:15 -0700 Comment on attachment 282436 Patch Clearing flags on attachment: 282436 Committed r202686: <http://trac.webkit.org/changeset/202686> 1206780 3 commit-queue 2016-06-30 10:49:17 -0700 All reviewed patches have been landed. Closing bug. 1206786 4 pvollan 2016-06-30 11:20:36 -0700 Thanks for reviewing :) 282436 2016-06-30 06:57:17 -0700 2016-06-30 10:49:15 -0700 Patch bug-159299-20160630065658.patch text/plain 1380 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjY3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA2LTMwICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXVtEZWJ1Z10gQXNzZXJ0aW9uIGZhaWxzIGluIFRlc3RXVEYuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkyOTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYXNzZXJ0 IGluIHRoZSAmIG9wZXJhdG9yIGluIHRoZSBVbmlxdWVSZWYgY2xhc3MgZmFpbHMsIGJlY2F1c2Ug dGhlIGluc3RhbmNlIGhhcyBiZWVuIG1vdmVkLgorICAgICAgICBUaGUgV2luZG93cyB2ZXJzaW9u IG9mIHRoZSBVTlVTRURfUEFSQU0gbWFjcm8gaXMgZ2V0dGluZyB0aGUgYWRkcmVzcyBvZiB0aGUg cGFyYW1ldGVyLCBjYXVzaW5nCisgICAgICAgIHRoZSBhc3NlcnRpb24gZmFpbHVyZS4gU2luY2Ug dGhlIHZhcmlhYmxlIGlzIGFjdHVhbGx5IHVzZWQsIHRoZXJlIGlzIG5vIG5lZWQgdG8gdXNlIHRo ZQorICAgICAgICBVTlVTRURfUEFSQU0gbWFjcm8uCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9VbmlxdWVSZWYuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6 CisKIDIwMTYtMDYtMjkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBzdXBwb3J0IGZvciBjb2xsZWN0aW5nIGN1bXVsYXRpdmUgTExJTlQgc3RhdHMgdmlhIGEg SlNDX2xsaW50U3RhdHNGaWxlIG9wdGlvbi4KSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV1RGL1VuaXF1ZVJlZi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XVEYvVW5pcXVlUmVmLmNwcAkocmV2aXNpb24gMjAyNjc2KQorKysgVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XVEYvVW5pcXVlUmVmLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzksNyAr NzksNiBAQCBURVNUKFdURiwgVW5pcXVlUmVmKQogICAgIEMgaChtYWtlVW5pcXVlUmVmPEE+KCkp OwogICAgIEMgaShtYWtlVW5pcXVlUmVmPEQ+KCkpOwogICAgIAotICAgIFVOVVNFRF9QQVJBTShh KTsKICAgICBVTlVTRURfUEFSQU0oYik7CiAgICAgVU5VU0VEX1BBUkFNKGMpOwogICAgIFVOVVNF RF9QQVJBTShkKTsK