159293 2016-06-30 02:30:37 -0700 Remove support for value iterators from JSDOMIterator 2016-07-14 12:31:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf cdumez commit-queue oldest_to_newest 1206681 0 youennf 2016-06-30 02:30:37 -0700 JSDOMIterator should only support pair iterators for now and to some extent set and map iterators. 1210968 1 283637 youennf 2016-07-14 06:33:44 -0700 Created attachment 283637 Patch 1211026 2 283637 cdumez 2016-07-14 10:09:35 -0700 Comment on attachment 283637 Patch r=me 1211088 3 283637 commit-queue 2016-07-14 12:30:57 -0700 Comment on attachment 283637 Patch Clearing flags on attachment: 283637 Committed r203234: <http://trac.webkit.org/changeset/203234> 1211089 4 commit-queue 2016-07-14 12:31:01 -0700 All reviewed patches have been landed. Closing bug. 283637 2016-07-14 06:33:44 -0700 2016-07-14 12:30:57 -0700 Patch bug-159293-20160714153257.patch text/plain 6853 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc0ZDViNjcyNjdlNTNj ZTZmN2UzMzg4ZTJjMDM4OThkODE0MTcxZC4uNjk1ZGM2ZTdkYjBlNGM0NDU4ZGU0NDBiMDFhODZk NWVhZTg3NjNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTA3LTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUgc3VwcG9ydCBm b3IgdmFsdWUgaXRlcmF0b3JzIGZyb20gSlNET01JdGVyYXRvcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MjkzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVmFsdWUgaXRlcmF0b3JzIGFyZSBub3cgaGFu ZGxlZCB3aXRob3V0IHVzaW5nIERPTUl0ZXJhdG9yLgorICAgICAgICBTaW5jZSBGb250RmFjZVNl dCBpcyB1c2luZyBET01JdGVyYXRvciBhcyBhbiBpbnRlcm1lZGlhdGUgc3RlcCB0b3dhcmRzIHN1 cHBvcnRpbmcgc2V0LWxpa2UsCisgICAgICAgIGVudHJpZXMgYW5kIGZvckVhY2ggaW1wbGVtZW50 YXRpb24gc2hvdWxkIGJlIG1hZGUgY29tcGxpYW50IHdpdGggc2V0LWxpa2UuCisgICAgICAgIFRo aXMgbWVhbnMgdGhhdCBpdGVtIHZhbHVlIHNob3VsZCBiZSBwYXNzZWQgaW5zdGVhZCBvZiBhbiBp bmRleCBpbiBlbnRyaWVzIGl0ZXJhdG9yIGFuZCBmb3JFYWNoIGNhbGxiYWNrLgorCisgICAgICAg IENvdmVyZWQgYnkgdXBkYXRlZCB0ZXN0LgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNET01J dGVyYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6SlNET01JdGVyYXRvcjxKU1dyYXBwZXI+Ojph c0pTKTogUGFzcyBzZXQgaXRlbSBhcyBlbnRyaWVzIHZhbHVlIGZpZWxkLgorICAgICAgICAoV2Vi Q29yZTo6YXBwZW5kRm9yRWFjaEFyZ3VtZW50cyk6IFBhc3Mgc2V0IGl0ZW0gYXMgc2Vjb25kIHBh cmFtZXRlci4KKyAgICAgICAgKFdlYkNvcmU6Oml0ZXJhdG9yRm9yRWFjaCk6IFJlbW92ZSBpbmRl eCBoYW5kbGluZy4KKworMjAxNi0wNy0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CisKICAgICAgICAgRE9NIHZhbHVlIGl0ZXJhYmxlIGludGVyZmFjZXMgc2hvdWxkIHVzZSBB cnJheSBwcm90b3R5cGUgbWV0aG9kcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU5Mjk2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTRE9NSXRlcmF0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9N SXRlcmF0b3IuaAppbmRleCAzYTc0ZDlmMDcwNWRkMDAyM2NhNDFiZWYzM2U1ZDUxYjI3ZWZkNGQ4 Li41NDBmMTE1M2U4YWExZGM5YzYxNjMzMjcwNjU2NGQ4ZDAxYjEzNTc2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmgKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNET01JdGVyYXRvci5oCkBAIC0xMTksNyArMTE5LDYgQEAgcHJp dmF0ZToKIAogICAgIE9wdGlvbmFsPHR5cGVuYW1lIERPTVdyYXBwZWQ6Okl0ZXJhdG9yPiBtX2l0 ZXJhdG9yOwogICAgIEl0ZXJhdGlvbktpbmQgbV9raW5kOwotICAgIHNpemVfdCBtX2luZGV4IHsg MCB9OwogfTsKIAogdGVtcGxhdGU8dHlwZW5hbWUgSlNXcmFwcGVyPgpAQCAtMTU3LDExICsxNTYs MTEgQEAgSlNET01JdGVyYXRvcjxKU1dyYXBwZXI+Ojphc0pTKEpTQzo6RXhlY1N0YXRlJiBzdGF0 ZSwgSXRlcmF0b3JWYWx1ZSYgdmFsdWUpCiAgICAgaWYgKG1fa2luZCAhPSBJdGVyYXRpb25LaW5k OjpLZXlWYWx1ZSkKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKIAotICAgIHJldHVybiBqc1BhaXIo c3RhdGUsIGdsb2JhbE9iamVjdCgpLCBKU0M6OmpzTnVtYmVyKG1faW5kZXgrKyksIHJlc3VsdCk7 CisgICAgcmV0dXJuIGpzUGFpcihzdGF0ZSwgZ2xvYmFsT2JqZWN0KCksIHJlc3VsdCwgcmVzdWx0 KTsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgSXRlcmF0b3JWYWx1ZT4gdHlwZW5hbWUgc3RkOjpl bmFibGVfaWY8SXRlcmF0b3JJbnNwZWN0b3I8SXRlcmF0b3JWYWx1ZT46OmlzTWFwLCB2b2lkPjo6 dHlwZQotYXBwZW5kRm9yRWFjaEFyZ3VtZW50cyhKU0M6OkV4ZWNTdGF0ZSYgc3RhdGUsIEpTRE9N R2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTQzo6TWFya2VkQXJndW1lbnRCdWZmZXImIGFy Z3VtZW50cywgSXRlcmF0b3JWYWx1ZSYgdmFsdWUsIHNpemVfdCYpCithcHBlbmRGb3JFYWNoQXJn dW1lbnRzKEpTQzo6RXhlY1N0YXRlJiBzdGF0ZSwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9i amVjdCwgSlNDOjpNYXJrZWRBcmd1bWVudEJ1ZmZlciYgYXJndW1lbnRzLCBJdGVyYXRvclZhbHVl JiB2YWx1ZSkKIHsKICAgICBBU1NFUlQodmFsdWUpOwogICAgIGFyZ3VtZW50cy5hcHBlbmQodG9K Uygmc3RhdGUsIGdsb2JhbE9iamVjdCwgdmFsdWUtPnZhbHVlKSk7CkBAIC0xNjksMTIgKzE2OCwx MiBAQCBhcHBlbmRGb3JFYWNoQXJndW1lbnRzKEpTQzo6RXhlY1N0YXRlJiBzdGF0ZSwgSlNET01H bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSgogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBJdGVy YXRvclZhbHVlPiB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjxJdGVyYXRvckluc3BlY3RvcjxJdGVy YXRvclZhbHVlPjo6aXNTZXQsIHZvaWQ+Ojp0eXBlCi1hcHBlbmRGb3JFYWNoQXJndW1lbnRzKEpT Qzo6RXhlY1N0YXRlJiBzdGF0ZSwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlND OjpNYXJrZWRBcmd1bWVudEJ1ZmZlciYgYXJndW1lbnRzLCBJdGVyYXRvclZhbHVlJiB2YWx1ZSwg c2l6ZV90JiBpbmRleCkKK2FwcGVuZEZvckVhY2hBcmd1bWVudHMoSlNDOjpFeGVjU3RhdGUmIHN0 YXRlLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU0M6Ok1hcmtlZEFyZ3VtZW50 QnVmZmVyJiBhcmd1bWVudHMsIEl0ZXJhdG9yVmFsdWUmIHZhbHVlKQogewogICAgIEFTU0VSVCh2 YWx1ZSk7CiAgICAgSlNDOjpKU1ZhbHVlIGFyZ3VtZW50ID0gdG9KUygmc3RhdGUsIGdsb2JhbE9i amVjdCwgKnZhbHVlKTsKICAgICBhcmd1bWVudHMuYXBwZW5kKGFyZ3VtZW50KTsKLSAgICBhcmd1 bWVudHMuYXBwZW5kKEpTQzo6anNOdW1iZXIoaW5kZXgrKykpOworICAgIGFyZ3VtZW50cy5hcHBl bmQoYXJndW1lbnQpOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBKU1dyYXBwZXI+CkBAIC0xOTIs MTEgKzE5MSwxMCBAQCBKU0M6OkVuY29kZWRKU1ZhbHVlIGl0ZXJhdG9yRm9yRWFjaChKU0M6OkV4 ZWNTdGF0ZSYgc3RhdGUsIGNvbnN0IGNoYXIqIHByb3BlcnR5TgogICAgIGlmIChjYWxsVHlwZSA9 PSBKU0M6OkNhbGxUeXBlOjpOb25lKQogICAgICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcigm c3RhdGUpOwogCi0gICAgc2l6ZV90IGluZGV4ID0gMDsKICAgICBhdXRvIGl0ZXJhdG9yID0gd3Jh cHBlci0+d3JhcHBlZCgpLmNyZWF0ZUl0ZXJhdG9yKCk7CiAgICAgd2hpbGUgKGF1dG8gdmFsdWUg PSBpdGVyYXRvci5uZXh0KCkpIHsKICAgICAgICAgSlNDOjpNYXJrZWRBcmd1bWVudEJ1ZmZlciBh cmd1bWVudHM7Ci0gICAgICAgIGFwcGVuZEZvckVhY2hBcmd1bWVudHMoc3RhdGUsIHdyYXBwZXIt Pmdsb2JhbE9iamVjdCgpLCBhcmd1bWVudHMsIHZhbHVlLCBpbmRleCk7CisgICAgICAgIGFwcGVu ZEZvckVhY2hBcmd1bWVudHMoc3RhdGUsIHdyYXBwZXItPmdsb2JhbE9iamVjdCgpLCBhcmd1bWVu dHMsIHZhbHVlKTsKICAgICAgICAgYXJndW1lbnRzLmFwcGVuZCh3cmFwcGVyKTsKICAgICAgICAg SlNDOjpjYWxsKCZzdGF0ZSwgY2FsbGJhY2ssIGNhbGxUeXBlLCBjYWxsRGF0YSwgdGhpc1ZhbHVl LCBhcmd1bWVudHMpOwogICAgICAgICBpZiAoc3RhdGUuaGFkRXhjZXB0aW9uKCkpCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg ZmJjZGQzNmIzYzA5NDI5ZmVlOGU5NTViYTAyOTlkNzE3MzU4MzYxMS4uY2Y0Y2FjNGJlNWUyMDJh NDM3N2E5MjRmY2VkYjc3YjY3NjUyZWZkZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTA3 LTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUg c3VwcG9ydCBmb3IgdmFsdWUgaXRlcmF0b3JzIGZyb20gSlNET01JdGVyYXRvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MjkzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvZm9udC1m YWNlLXNldC1qYXZhc2NyaXB0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L3RleHQvZm9u dC1mYWNlLXNldC1qYXZhc2NyaXB0Lmh0bWw6CisKKzIwMTYtMDctMTQgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgorCiAgICAgICAgIERPTSB2YWx1ZSBpdGVyYWJsZSBpbnRlcmZh Y2VzIHNob3VsZCB1c2UgQXJyYXkgcHJvdG90eXBlIG1ldGhvZHMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTI5NgogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L3RleHQvZm9udC1mYWNlLXNldC1qYXZhc2NyaXB0LWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvdGV4dC9mb250LWZhY2Utc2V0LWphdmFzY3JpcHQtZXhwZWN0ZWQu dHh0CmluZGV4IDViMmIxMmVjMDk2OTUwNzMyNTgzMjdkZTBhMTRjZjY2ZDA4MmEwOGYuLmFlZDM0 N2U2MTE4NTY0MWQ1MmU1OWUyYmE3OTMzZTM0ZDQ2MGNlZmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvdGV4dC9mb250LWZhY2Utc2V0LWphdmFzY3JpcHQtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2Zhc3QvdGV4dC9mb250LWZhY2Utc2V0LWphdmFzY3JpcHQtZXhwZWN0ZWQu dHh0CkBAIC00LDcgKzQsNyBAQCBQQVNTIG5ldyBGb250RmFjZVNldChbZm9udEZhY2UxXSkuc2l6 ZSBpcyAxCiBQQVNTIGZvbnRGYWNlU2V0LnN0YXR1cyBpcyAibG9hZGVkIgogUEFTUyBpdGVtLmRv bmUgaXMgZmFsc2UKIFBBU1MgaXRlbS52YWx1ZS5sZW5ndGggaXMgMgotUEFTUyBpdGVtLnZhbHVl WzBdIGlzIDAKK1BBU1MgaXRlbS52YWx1ZVswXSBpcyBmb250RmFjZTEKIFBBU1MgaXRlbS52YWx1 ZVsxXSBpcyBmb250RmFjZTEKIFBBU1MgaXRlbS5kb25lIGlzIHRydWUKIFBBU1MgaXRlbS52YWx1 ZSBpcyB1bmRlZmluZWQKQEAgLTE0LDYgKzE0LDggQEAgUEFTUyBpdGVtLmRvbmUgaXMgdHJ1ZQog UEFTUyBpdGVtLmRvbmUgaXMgZmFsc2UKIFBBU1MgaXRlbS52YWx1ZSBpcyBmb250RmFjZTEKIFBB U1MgaXRlbS5kb25lIGlzIHRydWUKK1BBU1MgZm9udEZhY2VTZXQgaXMgc2V0CitQQVNTIHZhbHVl MSBpcyB2YWx1ZTIKIFBBU1MgZm9udEZhY2VTZXQuYWRkKGZvbnRGYWNlMikgaXMgZm9udEZhY2VT ZXQKIFBBU1MgZm9udEZhY2VTZXQuc2l6ZSBpcyAyCiBQQVNTIGZvbnRGYWNlU2V0LmFkZChudWxs KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBBcmd1bWVudCAxICgnZm9udCcpIHRvIEZvbnRG YWNlU2V0LmFkZCBtdXN0IGJlIGFuIGluc3RhbmNlIG9mIEZvbnRGYWNlLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC90ZXh0L2ZvbnQtZmFjZS1zZXQtamF2YXNjcmlwdC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC90ZXh0L2ZvbnQtZmFjZS1zZXQtamF2YXNjcmlwdC5odG1sCmluZGV4IGYw ZmZkYzQxMTA1ZTZmZDczMTQ4ZGYzZWJmZWRlN2NjMWYwZWE0N2YuLjI2OWQxZDdiNGFlZGJjODA4 ZDZjNjM4YmMwMzg3ZmJhYzYyNWNhMWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvdGV4 dC9mb250LWZhY2Utc2V0LWphdmFzY3JpcHQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3Rl eHQvZm9udC1mYWNlLXNldC1qYXZhc2NyaXB0Lmh0bWwKQEAgLTI0LDcgKzI0LDcgQEAgdmFyIGl0 ZXJhdG9yID0gZm9udEZhY2VTZXQuZW50cmllcygpOwogdmFyIGl0ZW0gPSBpdGVyYXRvci5uZXh0 KCk7CiBzaG91bGRCZUZhbHNlKCJpdGVtLmRvbmUiKTsKIHNob3VsZEJlKCJpdGVtLnZhbHVlLmxl bmd0aCIsICIyIik7Ci1zaG91bGRCZSgiaXRlbS52YWx1ZVswXSIsICIwIik7CitzaG91bGRCZSgi aXRlbS52YWx1ZVswXSIsICJmb250RmFjZTEiKTsKIHNob3VsZEJlKCJpdGVtLnZhbHVlWzFdIiwg ImZvbnRGYWNlMSIpOwogaXRlbSA9IGl0ZXJhdG9yLm5leHQoKTsKIHNob3VsZEJlVHJ1ZSgiaXRl bS5kb25lIik7CkBAIC00NCw2ICs0NCwxNSBAQCBzaG91bGRCZSgiaXRlbS52YWx1ZSIsICJmb250 RmFjZTEiKTsKIGl0ZW0gPSBpdGVyYXRvci5uZXh0KCk7CiBzaG91bGRCZVRydWUoIml0ZW0uZG9u ZSIpOwogCit2YXIgdmFsdWUxLCB2YWx1ZTIsIHNldDsKK2ZvbnRGYWNlU2V0LmZvckVhY2goZnVu Y3Rpb24odjEsIHYyLCBzKXsKKyAgICB2YWx1ZTEgPSB2MTsKKyAgICB2YWx1ZTIgPSB2MjsKKyAg ICBzZXQgPSBzOworICAgIHNob3VsZEJlKCJmb250RmFjZVNldCIsICJzZXQiKTsKKyAgICBzaG91 bGRCZSgidmFsdWUxIiwgInZhbHVlMiIpOworfSk7CisKIHNob3VsZEJlKCJmb250RmFjZVNldC5h ZGQoZm9udEZhY2UyKSIsICJmb250RmFjZVNldCIpOwogc2hvdWxkQmUoImZvbnRGYWNlU2V0LnNp emUiLCAiMiIpOwogCg==