159290 2016-06-29 20:22:51 -0700 We need to to_this when an inner arrow function uses 'this' 2016-06-30 11:47:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak webkit-bug-importer ysuzuki oldest_to_newest 1206621 0 saam 2016-06-29 20:22:51 -0700 ... 1206622 1 saam 2016-06-29 20:24:03 -0700 <rdar://problem/27058322> 1206648 2 282415 saam 2016-06-29 22:08:45 -0700 Created attachment 282415 patch 1206755 3 282415 ggaren 2016-06-30 09:49:06 -0700 Comment on attachment 282415 patch r=me 1206789 4 282415 saam 2016-06-30 11:44:37 -0700 Comment on attachment 282415 patch Going to land manually 1206794 5 saam 2016-06-30 11:47:09 -0700 landed in: https://trac.webkit.org/changeset/202693 282415 2016-06-29 22:08:45 -0700 2016-06-30 11:44:37 -0700 patch b-backup.diff text/plain 4451 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNjcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA CisyMDE2LTA2LTI5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlIG5lZWQgdG8gdG9fdGhpcyB3aGVuIGFuIGlubmVyIGFycm93IGZ1bmN0aW9uIHVzZXMgJ3Ro aXMnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTky OTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3MDU4MzIyPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHB1dCB0aGUgfHRoaXN8IHZhbHVlIGlu dG8gdGhlIGNsb3N1cmUgb2JqZWN0IHdoZW4gdGhlcmUKKyAgICAgICAgaXMgYW4gYXJyb3cgZnVu Y3Rpb24gdGhhdCB1c2VzIHx0aGlzfC4gSG93ZXZlciwgYW4gYXJyb3cgZnVuY3Rpb24KKyAgICAg ICAgdXNpbmcgfHRoaXN8IHdhc24ndCBjYXVzaW5nIHRoZSBjcmVhdG9yIG9mIHRoZSBjbG9zdXJl IHRoYXQKKyAgICAgICAgaG9sZHMgfHRoaXN8IHRvIHRvX3RoaXMgaXRzIHZhbHVlIGJlZm9yZSBw dXR0aW5nIGl0IGluIHRoZQorICAgICAgICBjbG9zdXJlLiBUaGF0J3MgYSBodWdlIGJ1ZyBiZWNh dXNlIGl0IG1lYW5zIHNvbWUgYXJyb3cgZnVuY3Rpb25zCisgICAgICAgIGNhbiBjYXB0dXJlIHRo ZSByYXcgfHRoaXN8IHZhbHVlLCB3aGljaCBtaWdodCBiZSBhIEpTTGV4aWNhbEVudmlyb25tZW50 LgorICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoaXMgYnkgYWRkaW5nIGFuIGVhc3kgdG8gY2hl Y2sgdG8gc2VlIGlmIGFueQorICAgICAgICBpbm5lciBhcnJvdyBmdW5jdGlvbnMgdXNlIHx0aGlz fCwgYW5kIGlmIGFueSBkbywgaXQgd2lsbCB0b190aGlzCisgICAgICAgIHRoZSB8dGhpc3wgdmFs dWUuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAg ICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IpOgorICAgICAg ICAqIHRlc3RzL3N0cmVzcy90by10aGlzLWJlZm9yZS1hcnJvdy1mdW5jdGlvbi1jbG9zZXMtb3Zl ci10aGlzLXRoYXQtc3RhcnRzLWFzLWxleGljYWwtZW52aXJvbm1lbnQuanM6IEFkZGVkLgorICAg ICAgICAoYXNzZXJ0KToKKyAgICAgICAgKG9iaik6CisgICAgICAgIChmb28uY2FwdHVyZSk6Cisg ICAgICAgIChmb28ud3JhcHBlci5sZXQueC4pOgorICAgICAgICAoZm9vMi5jYXB0dXJlKToKKyAg ICAgICAgKGZvbzIud3JhcHBlci5sZXQueC4pOgorICAgICAgICAoZm9vMi53cmFwcGVyLmJhcik6 CisKIDIwMTYtMDYtMjkgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTigyMDAxMTQpOiBOZXRmbGl4IGFwcCBkb2VzIG5vdCBzZWUgQ2hyb21l Q2FzdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdl bmVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21w aWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHJldmlzaW9uIDIwMjY2NykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC01NTEsNyArNTUxLDcgQEAgQnl0ZWNvZGVHZW5lcmF0b3I6OkJ5dGVjb2RlR2Vu ZXJhdG9yKFZNJgogICAgICAgICAgICAgICAgICAgICBlbWl0Q3JlYXRlVGhpcygmbV90aGlzUmVn aXN0ZXIpOwogICAgICAgICAgICAgfSBlbHNlIGlmIChjb25zdHJ1Y3RvcktpbmQoKSAhPSBDb25z dHJ1Y3RvcktpbmQ6Ok5vbmUpIHsKICAgICAgICAgICAgICAgICBlbWl0VGhyb3dUeXBlRXJyb3Io IkNhbm5vdCBjYWxsIGEgY2xhc3MgY29uc3RydWN0b3IiKTsKLSAgICAgICAgICAgIH0gZWxzZSBp ZiAoZnVuY3Rpb25Ob2RlLT51c2VzVGhpcygpIHx8IGNvZGVCbG9jay0+dXNlc0V2YWwoKSkgewor ICAgICAgICAgICAgfSBlbHNlIGlmIChmdW5jdGlvbk5vZGUtPnVzZXNUaGlzKCkgfHwgY29kZUJs b2NrLT51c2VzRXZhbCgpIHx8IGlzVGhpc1VzZWRJbklubmVyQXJyb3dGdW5jdGlvbigpKSB7CiAg ICAgICAgICAgICAgICAgbV9jb2RlQmxvY2stPmFkZFByb3BlcnR5QWNjZXNzSW5zdHJ1Y3Rpb24o aW5zdHJ1Y3Rpb25zKCkuc2l6ZSgpKTsKICAgICAgICAgICAgICAgICBlbWl0T3Bjb2RlKG9wX3Rv X3RoaXMpOwogICAgICAgICAgICAgICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChraWxsKCZtX3Ro aXNSZWdpc3RlcikpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy90 by10aGlzLWJlZm9yZS1hcnJvdy1mdW5jdGlvbi1jbG9zZXMtb3Zlci10aGlzLXRoYXQtc3RhcnRz LWFzLWxleGljYWwtZW52aXJvbm1lbnQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3Rlc3RzL3N0cmVzcy90by10aGlzLWJlZm9yZS1hcnJvdy1mdW5jdGlvbi1jbG9zZXMt b3Zlci10aGlzLXRoYXQtc3RhcnRzLWFzLWxleGljYWwtZW52aXJvbm1lbnQuanMJKHJldmlzaW9u IDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3RvLXRoaXMtYmVmb3Jl LWFycm93LWZ1bmN0aW9uLWNsb3Nlcy1vdmVyLXRoaXMtdGhhdC1zdGFydHMtYXMtbGV4aWNhbC1l bnZpcm9ubWVudC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDU4IEBACitmdW5jdGlvbiBh c3NlcnQoYikgeworICAgIGlmICghYikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJCYWQgYXNz ZXJ0aW9uISIpCit9CisKK2Z1bmN0aW9uIG9iaigpIHsgCisgICAgcmV0dXJuIHt9OworfQorbm9J bmxpbmUob2JqKTsKKworLy8gVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCB3aGVuIHdyYXBwZXIo KSBpcyBjYWxsZWQgd2l0aCB0aGUgY2xvc3VyZSBjcmVhdGVkIGluIGZvbygpIGFzIHx0aGlzfAor Ly8gdGhhdCB3ZSB0b190aGlzIHRoZSB8dGhpc3wgdGhhdCBpcyBhIGNsb3N1cmUgYmVmb3JlIHRo ZSBhcnJvdyBmdW5jdGlvbiBjYXB0dXJlcyBpdHMgdmFsdWUuCisvLyBUaGlzIGNyYXNoZXMgaWYg dGhlcmUgaXMgYSBidWcgaW4gZGVidWcgYnVpbGRzLgorCitjb25zdCBnbG9iYWxUaGlzID0gdGhp czsKK2Z1bmN0aW9uIGZvbygpIHsKKyAgICBmdW5jdGlvbiBjYXB0dXJlKCkgeyByZXR1cm4gd3Jh cHBlcjsgfQorICAgIGZ1bmN0aW9uIHdyYXBwZXIoKSB7CisgICAgICAgIGxldCB4ID0gKCkgPT4g eworICAgICAgICAgICAgLy8gVGhpcyBzaG91bGQgbm90IGRlZmluZVByb3BlcnR5IG9uIGEgSlNM ZXhpY2FsRW52aXJvbm1lbnQhIFRoYXQncyBhIGh1Z2UgYnVnLgorICAgICAgICAgICAgT2JqZWN0 LmRlZmluZVByb3BlcnR5KHRoaXMsICJmb28iLCB7CisgICAgICAgICAgICAgICAgZ2V0OiBmdW5j dGlvbigpIHsgfSwKKyAgICAgICAgICAgICAgICBzZXQ6IGZ1bmN0aW9uKCkgeyB9CisgICAgICAg ICAgICB9KTsKKyAgICAgICAgICAgIGFzc2VydCghKCJiYXIiIGluIHRoaXMpKTsKKyAgICAgICAg ICAgIGFzc2VydCh0aGlzID09PSBnbG9iYWxUaGlzKTsKKyAgICAgICAgfQorCisgICAgICAgIHgo KTsKKyAgICB9CisgICAgd3JhcHBlcigpOworfQorZm9vKCk7CisKKworZnVuY3Rpb24gZm9vMigp IHsKKyAgICBmdW5jdGlvbiBjYXB0dXJlKCkgeyByZXR1cm4gd3JhcHBlcjsgfQorICAgIGZ1bmN0 aW9uIHdyYXBwZXIoKSB7CisgICAgICAgIGxldCB4ID0gKCkgPT4geworICAgICAgICAgICAgLy8g VGhpcyBzaG91bGQgbm90IGRlZmluZVByb3BlcnR5IG9uIGEgSlNMZXhpY2FsRW52aXJvbm1lbnQh IFRoYXQncyBhIGh1Z2UgYnVnLgorICAgICAgICAgICAgT2JqZWN0LmRlZmluZVByb3BlcnR5KHRo aXMsICJmb28iLCB7CisgICAgICAgICAgICAgICAgZ2V0OiBmdW5jdGlvbigpIHsgfSwKKyAgICAg ICAgICAgICAgICBzZXQ6IGZ1bmN0aW9uKCkgeyB9CisgICAgICAgICAgICB9KTsKKyAgICAgICAg fQorCisgICAgICAgIHgoKTsKKworICAgICAgICBmdW5jdGlvbiBiYXIoKSB7CisgICAgICAgICAg ICB3aXRoIChvYmooKSkgeworICAgICAgICAgICAgICAgIGFzc2VydDsKKyAgICAgICAgICAgIH0K KyAgICAgICAgfQorICAgICAgICBiYXIoKTsKKyAgICB9CisgICAgd3JhcHBlcigpOworfQorZm9v MigpOwo=