159287 2016-06-29 18:19:00 -0700 REGRESSION(200114): Netflix app does not see ChromeCast 2016-06-29 21:47:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff benjamin commit-queue keith_miller mark.lam saam oldest_to_newest 1206587 0 msaboff 2016-06-29 18:19:00 -0700 We are dying in the following function: t = function() { var e = g.defer(), a = this, f = a.config.appId; n.info.always("Initializing Cast SDK - Version: " + NFGCKFrameworkVersion + " - AppId: " + f); var h = c.processIflist(nrdp.device.iflist); a.networkId = c.networkIdFromInterface(h), l.forEach(o, function(b) { b.handler = b.handler.bind(a), nrdp.device.addEventListener(b.name, b.handler) }); var i = NFGCKFilterCriteria.criteriaForAvailableApplicationWithID(f); return NFGCKDeviceScanner.initWithFilterCriteria(i, function(c) { return c ? (d = c, b = NFGCKDeviceScannerListener.init(), b.didComeOnline = v.bind(a), b.didGoOffline = r.bind(a), b.didChange = s.bind(a), d.addListener(b), d.startScan(), void e.resolve()) : void e.reject(new m(m.ERRORS.START_ERROR, "No cast scanner instance")) }), e.promise } We are dying because there is no initWithFilterCriteria property on NFGCKDeviceScanner. This looks like this is an inadvertent result of change set <http://trac.webkit.org/changeset/200114>. 1206588 1 msaboff 2016-06-29 18:19:26 -0700 <rdar://problem/26878852> 1206589 2 282401 msaboff 2016-06-29 18:30:48 -0700 Created attachment 282401 Patch 1206609 3 282401 benjamin 2016-06-29 19:24:18 -0700 Comment on attachment 282401 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282401&action=review I would really like an explanation of the actual bug in the ChangeLog or in Radar. I have an hypothesis as to why the dyld_get_program_sdk_version() was failing but I can't find if my hypothesis holds from this changelog or radar. This should be documented IMHO. > Source/JavaScriptCore/API/JSWrapperMap.mm:665 > + static int32_t versionOfLinkTimeJavaScriptCore = 0; > + if (!versionOfLinkTimeJavaScriptCore) Looks like something that should use dispatch_once(). > Source/JavaScriptCore/API/JSWrapperMap.mm:667 > + // Only do the link time version comparision if we linked directly with JavaScriptCore Typo: comparision 1206638 4 msaboff 2016-06-29 21:30:43 -0700 (In reply to comment #3) > Comment on attachment 282401 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282401&action=review > > I would really like an explanation of the actual bug in the ChangeLog or in > Radar. Added. > I have an hypothesis as to why the dyld_get_program_sdk_version() was > failing but I can't find if my hypothesis holds from this changelog or > radar. This should be documented IMHO. > > > Source/JavaScriptCore/API/JSWrapperMap.mm:665 > > + static int32_t versionOfLinkTimeJavaScriptCore = 0; > > + if (!versionOfLinkTimeJavaScriptCore) > > Looks like something that should use dispatch_once(). > > > Source/JavaScriptCore/API/JSWrapperMap.mm:667 > > + // Only do the link time version comparision if we linked directly with JavaScriptCore > > Typo: comparision Fixed. 1206644 5 msaboff 2016-06-29 21:47:15 -0700 Committed r202670: <http://trac.webkit.org/changeset/202670> 282401 2016-06-29 18:30:48 -0700 2016-06-29 19:24:18 -0700 Patch 159287.patch text/plain 3025 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNjYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE2LTA2LTI5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04oMjAwMTE0KTogTmV0ZmxpeCBhcHAgZG9lcyBub3Qgc2VlIENocm9tZUNh c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTI4 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVk IGJhY2sgdGhlIHByaW9yIGNoZWNrIG9mIHRoZSB2ZXJzaW9uIG9mIEphdmFTY3JpcHRDb3JlIHRo ZSBwcm9ncmFtIHdhcworICAgICAgICBkaXJlY3RseSBsaW5rZWQgYWdhaW5zdC4gIEhvd2V2ZXIg d2Ugb25seSB1c2UgdGhpcyBjaGVjayBpZiB3ZSBkaXJlY3RseSBsaW5rZWQKKyAgICAgICAgd2l0 aCBKYXZhU2NyaXB0Q29yZS4gIE90aGVyd2lzZSB3ZSBmYWxsIHRocm91Z2ggdG8gY2hlY2sgYWdh aW5zdCB0aGUgU0RLIHRoZQorICAgICAgICBwcm9ncmFtIHdhcyBidWlsdCB3aXRoLiAgRm9yIGlP UyBidWlsZHMsIGNoYW5nZWQgdGhlIFNESyB2ZXJzaW9uIHdlIGNoZWNrCisgICAgICAgIGFnYWlu c3QgdG8gYmUgdGhlIGN1cnJlbnQgdmVyc2lvbiBvZiBpT1MgKGlPUyAxMCkuCisKKyAgICAgICAg VGhpcyBwcm92aWRlcyBjb21wYXRpYmxlIGJlaGF2aW9yIGZvciBleGlzdGluZyBwcm9ncmFtcywg YnV0IG1heSByZXF1aXJlIGNoYW5nZXMKKyAgICAgICAgd2hlbiBhIHByb2dyYW0gaXMgcmVidWls dCB3aXRoIHRoZSBpT1MgMTAgU0RLLgorCisgICAgICAgICogQVBJL0pTV3JhcHBlck1hcC5tbToK KyAgICAgICAgKHN1cHBvcnRzSW5pdE1ldGhvZENvbnN0cnVjdG9ycyk6CisKIDIwMTYtMDYtMjkg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBXcm9uZyBmdW5jdGlvbiBuYW1lIG5leHQgdG8gc2NvcGUKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCShyZXZpc2lvbiAyMDI2NDcpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTV3JhcHBlck1hcC5tbQkod29ya2luZyBjb3B5KQpA QCAtNDYsMTEgKzQ2LDE0IEBACiAjaW5jbHVkZSA8bWFjaC1vL2R5bGQuaD4KIAogI2lmIFBMQVRG T1JNKEFQUExFVFYpCi0jZWxpZiBQTEFURk9STShJT1MpCi1zdGF0aWMgY29uc3QgdWludDMyX3Qg Zmlyc3RTREtWZXJzaW9uV2l0aEluaXRDb25zdHJ1Y3RvclN1cHBvcnQgPSAweDgwMDAwOyAvLyBp T1MgOC4wLjAKKyNlbHNlCitzdGF0aWMgY29uc3QgaW50MzJfdCBmaXJzdEphdmFTY3JpcHRDb3Jl VmVyc2lvbldpdGhJbml0Q29uc3RydWN0b3JTdXBwb3J0ID0gMHgyMUEwNDAwOyAvLyA1MzguNC4w CisjaWYgUExBVEZPUk0oSU9TKQorc3RhdGljIGNvbnN0IHVpbnQzMl90IGZpcnN0U0RLVmVyc2lv bldpdGhJbml0Q29uc3RydWN0b3JTdXBwb3J0ID0gRFlMRF9JT1NfVkVSU0lPTl8xMF8wOwogI2Vs aWYgUExBVEZPUk0oTUFDKQogc3RhdGljIGNvbnN0IHVpbnQzMl90IGZpcnN0U0RLVmVyc2lvbldp dGhJbml0Q29uc3RydWN0b3JTdXBwb3J0ID0gMHhBMEEwMDsgLy8gT1NYIDEwLjEwLjAKICNlbmRp ZgorI2VuZGlmCiAKIEBjbGFzcyBKU09iakNDbGFzc0luZm87CiAKQEAgLTY1Nyw5ICs2NjAsMjAg QEAgYm9vbCBzdXBwb3J0c0luaXRNZXRob2RDb25zdHJ1Y3RvcnMoKQogICAgIC8vIFRoZXJlIGFy ZSBubyBvbGQgY2xpZW50cyBvbiBBcHBsZSBUViwgc28gdGhlcmUncyBubyBuZWVkIGZvciBiYWNr d2FyZHMgY29tcGF0aWJpbGl0eS4KICAgICByZXR1cm4gdHJ1ZTsKICNlbHNlCisgICAgLy8gRmly c3QgY2hlY2sgdG8gc2VlIHRoZSB2ZXJzaW9uIG9mIEphdmFTY3JpcHRDb3JlIHdlIGRpcmVjdGx5 IGxpbmtlZCBhZ2FpbnN0LgorICAgIHN0YXRpYyBpbnQzMl90IHZlcnNpb25PZkxpbmtUaW1lSmF2 YVNjcmlwdENvcmUgPSAwOworICAgIGlmICghdmVyc2lvbk9mTGlua1RpbWVKYXZhU2NyaXB0Q29y ZSkKKyAgICAgICAgdmVyc2lvbk9mTGlua1RpbWVKYXZhU2NyaXB0Q29yZSA9IE5TVmVyc2lvbk9m TGlua1RpbWVMaWJyYXJ5KCJKYXZhU2NyaXB0Q29yZSIpOworICAgIC8vIE9ubHkgZG8gdGhlIGxp bmsgdGltZSB2ZXJzaW9uIGNvbXBhcmlzaW9uIGlmIHdlIGxpbmtlZCBkaXJlY3RseSB3aXRoIEph dmFTY3JpcHRDb3JlCisgICAgaWYgKHZlcnNpb25PZkxpbmtUaW1lSmF2YVNjcmlwdENvcmUgIT0g LTEpCisgICAgICAgIHJldHVybiB2ZXJzaW9uT2ZMaW5rVGltZUphdmFTY3JpcHRDb3JlID49IGZp cnN0SmF2YVNjcmlwdENvcmVWZXJzaW9uV2l0aEluaXRDb25zdHJ1Y3RvclN1cHBvcnQ7CisKKyAg ICAvLyBJZiB3ZSBkaWRuJ3QgbGluayBkaXJlY3RseSB3aXRoIEphdmFTY3JpcHRDb3JlLAorICAg IC8vIGJhc2Ugb3VyIGNoZWNrIG9uIHdoYXQgU0RLIHdhcyB1c2VkIHRvIGJ1aWxkIHRoZSBhcHBs aWNhdGlvbi4KICAgICBzdGF0aWMgdWludDMyX3QgcHJvZ3JhbVNES1ZlcnNpb24gPSAwOwogICAg IGlmICghcHJvZ3JhbVNES1ZlcnNpb24pCiAgICAgICAgIHByb2dyYW1TREtWZXJzaW9uID0gZHls ZF9nZXRfcHJvZ3JhbV9zZGtfdmVyc2lvbigpOworCiAgICAgcmV0dXJuIHByb2dyYW1TREtWZXJz aW9uID49IGZpcnN0U0RLVmVyc2lvbldpdGhJbml0Q29uc3RydWN0b3JTdXBwb3J0OwogI2VuZGlm CiB9Cg==