159285 2016-06-29 17:06:27 -0700 JSGlobalLexicalEnvironment needs a toThis implementation 2016-06-30 01:10:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver ossy sukolsak ysuzuki oldest_to_newest 1206567 0 saam 2016-06-29 17:06:27 -0700 ... 1206571 1 282393 saam 2016-06-29 17:22:51 -0700 Created attachment 282393 patch 1206572 2 282393 mark.lam 2016-06-29 17:24:22 -0700 Comment on attachment 282393 patch r=me 1206614 3 saam 2016-06-29 19:47:28 -0700 I forgot to make JSGlobalLexicalEnvironment put the OverridesToThis flag on its StructureFlags. That's needed. 1206624 4 282410 saam 2016-06-29 20:25:59 -0700 Created attachment 282410 patch for landing 1206629 5 282410 commit-queue 2016-06-29 20:55:58 -0700 Comment on attachment 282410 patch for landing Clearing flags on attachment: 282410 Committed r202664: <http://trac.webkit.org/changeset/202664> 1206630 6 commit-queue 2016-06-29 20:56:02 -0700 All reviewed patches have been landed. Closing bug. 1206668 7 ossy 2016-06-30 01:10:09 -0700 (In reply to comment #5) > Comment on attachment 282410 [details] > patch for landing > > Clearing flags on attachment: 282410 > > Committed r202664: <http://trac.webkit.org/changeset/202664> This patch ( or bug159286 ) made many JSC tests assert: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/3307 282393 2016-06-29 17:22:51 -0700 2016-06-29 20:25:59 -0700 patch a-backup.diff text/plain 2977 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNjYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTA2LTI5ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEpTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50IG5lZWRzIGEgdG9UaGlzIGltcGxlbWVudGF0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkyODUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdh cyBhIGh1Z2Ugb3ZlcnNpZ2h0IG9mIG15IG9yaWdpbmFsIGltcGxlbWVudGF0aW9uLiBJdCBnYXZl IHVzZXJzCisgICAgICAgIG9mIHRoZSBsYW5ndWFnZSBkaXJlY3QgYWNjZXNzIHRvIHRoZSBKU0ds b2JhbExleGljYWxFbnZpcm9ubWVudCBvYmplY3QuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2xv YmFsTGV4aWNhbEVudmlyb25tZW50LmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxMZXhpY2Fs RW52aXJvbm1lbnQ6OmlzQ29uc3RWYXJpYWJsZSk6CisgICAgICAgIChKU0M6OkpTR2xvYmFsTGV4 aWNhbEVudmlyb25tZW50Ojp0b1RoaXMpOgorICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxMZXhp Y2FsRW52aXJvbm1lbnQuaDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxMZXhpY2FsRW52aXJvbm1l bnQ6OmlzRW1wdHkpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9nbG9iYWwtbGV4aWNhbC1lbnZp cm9ubWVudC10by10aGlzLmpzOiBBZGRlZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAgIChs ZXQuZik6CisgICAgICAgIChsZXQuZlN0cmljdCk6CisKIDIwMTYtMDYtMjkgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXcm9u ZyBmdW5jdGlvbiBuYW1lIG5leHQgdG8gc2NvcGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudC5j cHAJKHJldmlzaW9uIDIwMjY1MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT R2xvYmFsTGV4aWNhbEVudmlyb25tZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsNCArNjEs MTEgQEAgYm9vbCBKU0dsb2JhbExleGljYWxFbnZpcm9ubWVudDo6aXNDb25zdAogICAgIHJldHVy biBlbnRyeS5pc1JlYWRPbmx5KCk7CiB9CiAKK0pTVmFsdWUgSlNHbG9iYWxMZXhpY2FsRW52aXJv bm1lbnQ6OnRvVGhpcyhKU0NlbGwqLCBFeGVjU3RhdGUqIGV4ZWMsIEVDTUFNb2RlIGVjbWFNb2Rl KQoreworICAgIGlmIChlY21hTW9kZSA9PSBTdHJpY3RNb2RlKQorICAgICAgICByZXR1cm4ganNV bmRlZmluZWQoKTsKKyAgICByZXR1cm4gZXhlYy0+Z2xvYmFsVGhpc1ZhbHVlKCk7Cit9CisKIH0g Ly8gbmFtZXNwYWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH bG9iYWxMZXhpY2FsRW52aXJvbm1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudC5oCShyZXZpc2lvbiAyMDI2 NTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZp cm9ubWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC01Niw2ICs1Niw4IEBAIHB1YmxpYzoKIAogICAg IGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuICFzeW1ib2xUYWJsZSgpLT5zaXplKCk7IH0K ICAgICBib29sIGlzQ29uc3RWYXJpYWJsZShVbmlxdWVkU3RyaW5nSW1wbCopOworCisgICAgc3Rh dGljIEpTVmFsdWUgdG9UaGlzKEpTQ2VsbCosIEV4ZWNTdGF0ZSosIEVDTUFNb2RlKTsKICAgICAK ICAgICBERUNMQVJFX0lORk87CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9z dHJlc3MvZ2xvYmFsLWxleGljYWwtZW52aXJvbm1lbnQtdG8tdGhpcy5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2dsb2JhbC1sZXhpY2FsLWVudmly b25tZW50LXRvLXRoaXMuanMJKG5vbmV4aXN0ZW50KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rlc3RzL3N0cmVzcy9nbG9iYWwtbGV4aWNhbC1lbnZpcm9ubWVudC10by10aGlzLmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsMjIgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7CisgICAgaWYg KCFiKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoIkJhZCEiKQorfQorCitsZXQgZiA9IGZ1bmN0 aW9uKCkgeworICAgIHJldHVybiB0aGlzOworfQorbm9JbmxpbmUoZik7CisKK2xldCBmU3RyaWN0 ID0gZnVuY3Rpb24oKSB7CisgICAgInVzZSBzdHJpY3QiOworICAgIHJldHVybiB0aGlzOworfQor bm9JbmxpbmUoZlN0cmljdCk7CisKK2NvbnN0IGdsb2JhbFRoaXMgPSB0aGlzOworZm9yIChsZXQg aSA9IDA7IGkgPCAxMDAwOyBpKyspCisgICAgYXNzZXJ0KGYoKSA9PT0gZ2xvYmFsVGhpcyk7CisK K2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDsgaSsrKQorICAgIGFzc2VydChmU3RyaWN0KCkgPT09 IHVuZGVmaW5lZCk7Cg== 282410 2016-06-29 20:25:59 -0700 2016-06-29 20:55:58 -0700 patch for landing a-backup.diff text/plain 3415 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNjYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTA2LTI5ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEpTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50IG5lZWRzIGEgdG9UaGlzIGltcGxlbWVudGF0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkyODUK KworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBUaGlzIHdhcyBhIGh1 Z2Ugb3ZlcnNpZ2h0IG9mIG15IG9yaWdpbmFsIGltcGxlbWVudGF0aW9uLiBJdCBnYXZlIHVzZXJz CisgICAgICAgIG9mIHRoZSBsYW5ndWFnZSBkaXJlY3QgYWNjZXNzIHRvIHRoZSBKU0dsb2JhbExl eGljYWxFbnZpcm9ubWVudCBvYmplY3QuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsTGV4 aWNhbEVudmlyb25tZW50LmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxMZXhpY2FsRW52aXJv bm1lbnQ6OmlzQ29uc3RWYXJpYWJsZSk6CisgICAgICAgIChKU0M6OkpTR2xvYmFsTGV4aWNhbEVu dmlyb25tZW50Ojp0b1RoaXMpOgorICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxMZXhpY2FsRW52 aXJvbm1lbnQuaDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxMZXhpY2FsRW52aXJvbm1lbnQ6Omlz RW1wdHkpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9nbG9iYWwtbGV4aWNhbC1lbnZpcm9ubWVu dC10by10aGlzLmpzOiBBZGRlZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAgIChsZXQuZik6 CisgICAgICAgIChsZXQuZlN0cmljdCk6CisKIDIwMTYtMDYtMjkgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXcm9uZyBmdW5j dGlvbiBuYW1lIG5leHQgdG8gc2NvcGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudC5jcHAJKHJl dmlzaW9uIDIwMjY1MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFs TGV4aWNhbEVudmlyb25tZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsNCArNjEsMTEgQEAg Ym9vbCBKU0dsb2JhbExleGljYWxFbnZpcm9ubWVudDo6aXNDb25zdAogICAgIHJldHVybiBlbnRy eS5pc1JlYWRPbmx5KCk7CiB9CiAKK0pTVmFsdWUgSlNHbG9iYWxMZXhpY2FsRW52aXJvbm1lbnQ6 OnRvVGhpcyhKU0NlbGwqLCBFeGVjU3RhdGUqIGV4ZWMsIEVDTUFNb2RlIGVjbWFNb2RlKQorewor ICAgIGlmIChlY21hTW9kZSA9PSBTdHJpY3RNb2RlKQorICAgICAgICByZXR1cm4ganNVbmRlZmlu ZWQoKTsKKyAgICByZXR1cm4gZXhlYy0+Z2xvYmFsVGhpc1ZhbHVlKCk7Cit9CisKIH0gLy8gbmFt ZXNwYWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxM ZXhpY2FsRW52aXJvbm1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudC5oCShyZXZpc2lvbiAyMDI2NTMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIGNsYXNzIEpTR2xvYmFsTGV4aWNh bEVudmlyb25tZW50IDogcHVibGkKIHB1YmxpYzoKICAgICB0eXBlZGVmIEpTU2VnbWVudGVkVmFy aWFibGVPYmplY3QgQmFzZTsKIAotICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBTdHJ1Y3R1cmVG bGFncyA9IEJhc2U6OlN0cnVjdHVyZUZsYWdzIHwgT3ZlcnJpZGVzR2V0T3duUHJvcGVydHlTbG90 OworICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBTdHJ1Y3R1cmVGbGFncyA9IEJhc2U6OlN0cnVj dHVyZUZsYWdzIHwgT3ZlcnJpZGVzR2V0T3duUHJvcGVydHlTbG90IHwgT3ZlcnJpZGVzVG9UaGlz OwogCiAgICAgc3RhdGljIEpTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50KiBjcmVhdGUoVk0mIHZt LCBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgSlNTY29wZSogcGFyZW50U2NvcGUpCiAgICAgewpAQCAt NTYsNiArNTYsOCBAQCBwdWJsaWM6CiAKICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVy biAhc3ltYm9sVGFibGUoKS0+c2l6ZSgpOyB9CiAgICAgYm9vbCBpc0NvbnN0VmFyaWFibGUoVW5p cXVlZFN0cmluZ0ltcGwqKTsKKworICAgIHN0YXRpYyBKU1ZhbHVlIHRvVGhpcyhKU0NlbGwqLCBF eGVjU3RhdGUqLCBFQ01BTW9kZSk7CiAgICAgCiAgICAgREVDTEFSRV9JTkZPOwogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2dsb2JhbC1sZXhpY2FsLWVudmlyb25t ZW50LXRvLXRoaXMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3Rz L3N0cmVzcy9nbG9iYWwtbGV4aWNhbC1lbnZpcm9ubWVudC10by10aGlzLmpzCShub25leGlzdGVu dCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZ2xvYmFsLWxleGljYWwt ZW52aXJvbm1lbnQtdG8tdGhpcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIyIEBACitm dW5jdGlvbiBhc3NlcnQoYiwgaSkgeworICAgIGlmICghYikKKyAgICAgICAgdGhyb3cgbmV3IEVy cm9yKCJCYWQhICIgKyBpKQorfQorCitsZXQgZiA9IGZ1bmN0aW9uKCkgeworICAgIHJldHVybiB0 aGlzOworfQorbm9JbmxpbmUoZik7CisKK2xldCBmU3RyaWN0ID0gZnVuY3Rpb24oKSB7CisgICAg InVzZSBzdHJpY3QiOworICAgIHJldHVybiB0aGlzOworfQorbm9JbmxpbmUoZlN0cmljdCk7CisK K2NvbnN0IGdsb2JhbFRoaXMgPSB0aGlzOworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwOyBpKysp CisgICAgYXNzZXJ0KGYoKSA9PT0gZ2xvYmFsVGhpcywgaSk7CisKK2ZvciAobGV0IGkgPSAwOyBp IDwgMTAwMDsgaSsrKQorICAgIGFzc2VydChmU3RyaWN0KCkgPT09IHVuZGVmaW5lZCk7Cg==