159260 2016-06-29 06:08:28 -0700 [EFL] [GTK] Enable back crypto subtle on development builds. 2016-07-13 06:10:01 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159189 133122 1 clopez clopez achristensen bugs-noreply cdumez cgarcia commit-queue dbates gyuyoung.kim mcatanzaro mrobinson ossy ysuzuki oldest_to_newest 1206366 0 clopez 2016-06-29 06:08:28 -0700 Crypto subtle was disabled on GTK development builds on r173872: <http://trac.webkit.org/changeset/173872> On r202561 :<http://trac.webkit.org/changeset/r202561> the expectations were updated. However, it was missed that there were a global skip for this tests with manual passes that the layout-script didn't liked. 05:42:54.700 13141 LayoutTests/platform/gtk/TestExpectations:719 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:409 and LayoutTests/platform/gtk/TestExpectations:719. crypto/subtle/ 05:42:54.700 13141 LayoutTests/platform/gtk/TestExpectations:719 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:409 and LayoutTests/platform/gtk/TestExpectations:719. crypto/subtle/ 05:42:54.700 13141 LayoutTests/platform/gtk/TestExpectations:719 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:409 and LayoutTests/platform/gtk/TestExpectations:719. crypto/subtle/ [....] This were the previous contents: # crypto.subtle is not yet enabled, but digest algorithms are already implemented # and their tests are whitelisted webkit.org/b/133122 crypto/subtle [ Skip ] webkit.org/b/133319 crypto/subtle/sha-1.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-224.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-256.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-384.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-512.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-check-algorithm.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-export-key.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-generate-key.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-import-jwk.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-sign-verify-empty-key.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-sign-verify.html [ Pass ] So, I'm opening this bug to enable back subtle crypto when someone wants, and I'm pasting the above output that was on the TestExpectations working. 1206368 1 clopez 2016-06-29 06:10:17 -0700 (In reply to comment #0) > Crypto subtle was disabled on GTK development builds on r173872: > <http://trac.webkit.org/changeset/173872> Sorry, I mean on r202535: <http://trac.webkit.org/changeset/202535> 1206369 2 clopez 2016-06-29 06:15:17 -0700 Committed r202623: <http://trac.webkit.org/changeset/202623> 1206370 3 clopez 2016-06-29 06:17:00 -0700 (In reply to comment #2) > Committed r202623: <http://trac.webkit.org/changeset/202623> Here I fixed the layout tests expectations. Once this feature is enabled back, please revert the part of that changeset that removes the tests that were passing when the feature was enabled. 1210424 4 283521 clopez 2016-07-13 05:46:35 -0700 Created attachment 283521 Patch 1210428 5 283521 commit-queue 2016-07-13 06:09:55 -0700 Comment on attachment 283521 Patch Clearing flags on attachment: 283521 Committed r203160: <http://trac.webkit.org/changeset/203160> 1210429 6 commit-queue 2016-07-13 06:10:01 -0700 All reviewed patches have been landed. Closing bug. 283521 2016-07-13 05:46:35 -0700 2016-07-13 06:09:55 -0700 Patch bug-159260-20160713144550.patch text/plain 3648 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzM2N2ExNmRiZmE0OWUxMjZhYmUwMTg2ZGI2ODI2YWQ3 NWY5NTJhNi4uNGI1ZDE3NDU5MTM1ZDk0ZTM1NWYwOGNhMzk2YjBhYTRmZmVjODVlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA3LTEzICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtFRkxdIFtHVEtdIEVuYWJsZSBiYWNrIGNyeXB0byBzdWJ0bGUg b24gZGV2ZWxvcG1lbnQgYnVpbGRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU5MjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIw MTYtMDctMTIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFdlIHNo b3VsZCB1c2UgZGlmZmVyZW50IHN0YWNrIGxpbWl0cyBmb3Igc3RhY2sgY2hlY2tzIGZyb20gSlMg YW5kIGhvc3QgY29kZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQppbmRl eCAxZWY3NjkzODVkNzc1Yjg3Yzk0YTIxZDVlYmFjMTUyOWYyODk4ZDFjLi43ZWVlZWJmM2VhZDU4 MTdjZjM2OGNlMWEyZGJjMGUxMzIzYjFmZTU5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0Zl YXR1cmVMaXN0LnBtCkBAIC0zOTIsNyArMzkyLDcgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgICAg ZGVmaW5lID0+ICJFTkFCTEVfU1RSRUFNU19BUEkiLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwk c3RyZWFtc0FQSVN1cHBvcnQgfSwKIAogICAgIHsgb3B0aW9uID0+ICJzdWJ0bGUtY3J5cHRvIiwg ZGVzYyA9PiAiVG9nZ2xlIFdlYkNyeXB0byBTdWJ0bGUtQ3J5cHRvIHN1cHBvcnQiLAotICAgICAg ZGVmaW5lID0+ICJFTkFCTEVfU1VCVExFX0NSWVBUTyIsIGRlZmF1bHQgPT4gKGlzQXBwbGVNYWNX ZWJLaXQoKSB8fCBpc0lPU1dlYktpdCgpKSwgdmFsdWUgPT4gXCRzdWJ0bGVDcnlwdG8gfSwKKyAg ICAgIGRlZmluZSA9PiAiRU5BQkxFX1NVQlRMRV9DUllQVE8iLCBkZWZhdWx0ID0+IChpc0d0aygp IHx8IGlzRWZsKCkgfHwgaXNBcHBsZU1hY1dlYktpdCgpIHx8IGlzSU9TV2ViS2l0KCkpLCB2YWx1 ZSA9PiBcJHN1YnRsZUNyeXB0byB9LAogCiAgICAgeyBvcHRpb24gPT4gInN2Zy1mb250cyIsIGRl c2MgPT4gIlRvZ2dsZSBTVkcgRm9udHMgc3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJM RV9TVkdfRk9OVFMiLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwkc3ZnRm9udHNTdXBwb3J0IH0s CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggMDc0ZDczMmFmMzk3OWUxYTM5ZDA5MTUxNGJlZjdjZGFiNDc0NWRiYS4uYzExZDZl MDc5M2U1MzZmNTdkYzAzMGRmNzI0MzY3ZjAyYjJjMTFjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDE2LTA3LTEzICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEu Y29tPgorCisgICAgICAgIFtFRkxdIFtHVEtdIEVuYWJsZSBiYWNrIGNyeXB0byBzdWJ0bGUgb24g ZGV2ZWxvcG1lbnQgYnVpbGRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU5MjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogRW5hYmxlIGJhY2sg dGhlIHRlc3RzIHRoYXQgd2VyZQorICAgICAgICBwYXNzaW5nIG9uIEdUSy4KKwogMjAxNi0wNy0x MyAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgVXBkYXRlIE1h dGhNTCBleHBlY3RhdGlvbnMgb24gRUZMIGFuZCBXaW5kb3dzIHBvcnRzLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1ZmI0YjNkODMxYWY5MWMzMDNkN2Zi YjhlYzFmYTgzMjIxNGFhODljLi5lOTAzNTZmYjY0NTE2NDIyYTY4MjViMWM5YzYzMGU1NDY3OTIx YjdiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNDA0 LDggKzQwNCwxOSBAQCBCdWcoR1RLKSBbIERlYnVnIF0gcGVyZiBbIFNraXAgXQogQnVnKEdUSykg ZWRpdGluZy9zZWN1cmUtaW5wdXQgWyBGYWlsdXJlIF0KIAogIyBjcnlwdG8uc3VidGxlIGlzIG5v dCB5ZXQgZW5hYmxlZCwgYnV0IGRpZ2VzdCBhbGdvcml0aG1zIGFyZSBhbHJlYWR5IGltcGxlbWVu dGVkCi0jIFRoaXMgZmVhdHVyZSB3YXMgZGlzYWJsZWQgZnJvbSBkZXZlbG9wbWVudCBidWlsZHMg cmVjZW50bHksIHNlZSBhbHNvIGJ1ZyAjMTU5MjYwCisjIGFuZCB0aGVpciB0ZXN0cyBhcmUgd2hp dGVsaXN0ZWQKIHdlYmtpdC5vcmcvYi8xMzMxMjIgY3J5cHRvL3N1YnRsZSBbIFNraXAgXQord2Vi a2l0Lm9yZy9iLzEzMzMxOSBjcnlwdG8vc3VidGxlL3NoYS0xLmh0bWwgWyBQYXNzIF0KK3dlYmtp dC5vcmcvYi8xMzMzMTkgY3J5cHRvL3N1YnRsZS9zaGEtMjI0Lmh0bWwgWyBQYXNzIF0KK3dlYmtp dC5vcmcvYi8xMzMzMTkgY3J5cHRvL3N1YnRsZS9zaGEtMjU2Lmh0bWwgWyBQYXNzIF0KK3dlYmtp dC5vcmcvYi8xMzMzMTkgY3J5cHRvL3N1YnRsZS9zaGEtMzg0Lmh0bWwgWyBQYXNzIF0KK3dlYmtp dC5vcmcvYi8xMzMzMTkgY3J5cHRvL3N1YnRsZS9zaGEtNTEyLmh0bWwgWyBQYXNzIF0KK3dlYmtp dC5vcmcvYi8xMzMzMjAgY3J5cHRvL3N1YnRsZS9obWFjLWNoZWNrLWFsZ29yaXRobS5odG1sIFsg UGFzcyBdCit3ZWJraXQub3JnL2IvMTMzMzIwIGNyeXB0by9zdWJ0bGUvaG1hYy1leHBvcnQta2V5 Lmh0bWwgWyBQYXNzIF0KK3dlYmtpdC5vcmcvYi8xMzMzMjAgY3J5cHRvL3N1YnRsZS9obWFjLWdl bmVyYXRlLWtleS5odG1sIFsgUGFzcyBdCit3ZWJraXQub3JnL2IvMTMzMzIwIGNyeXB0by9zdWJ0 bGUvaG1hYy1pbXBvcnQtandrLmh0bWwgWyBQYXNzIF0KK3dlYmtpdC5vcmcvYi8xMzMzMjAgY3J5 cHRvL3N1YnRsZS9obWFjLXNpZ24tdmVyaWZ5LWVtcHR5LWtleS5odG1sIFsgUGFzcyBdCit3ZWJr aXQub3JnL2IvMTMzMzIwIGNyeXB0by9zdWJ0bGUvaG1hYy1zaWduLXZlcmlmeS5odG1sIFsgUGFz cyBdCiAKICMgUXVpY2tUaW1lIHBsdWctaW4gbm90IHJlbGV2YW50IHRvIHRoaXMgcG9ydAogQnVn KEdUSykgcGx1Z2lucy9xdWlja3RpbWUtcGx1Z2luLXJlcGxhY2VtZW50Lmh0bWwgWyBTa2lwIF0K