159222 2016-06-28 13:22:21 -0700 reportAbandonedObjectGraph should report abandoned bytes based on capacity() so it works even if a GC has never happened 2016-07-05 12:49:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak webkit-bug-importer ysuzuki oldest_to_newest 1206141 0 saam 2016-06-28 13:22:21 -0700 .... 1206143 1 saam 2016-06-28 13:23:42 -0700 <rdar://problem/27001991> 1206213 2 282294 saam 2016-06-28 16:11:32 -0700 Created attachment 282294 patch 1206437 3 282294 ggaren 2016-06-29 11:16:37 -0700 Comment on attachment 282294 patch r=me I think we want an API test that mimics the test you've been working with -- allocate and call JSGarbageCollect in a loop, verify that not too many objects build up. I think you mentioned that this patch alone doesn't make that test pass. So, we probably need a follow-up patch with a test and a fix for the remaining bug. 1207907 4 saam 2016-07-05 12:30:54 -0700 Opened a bug to fix the remaining problem: https://bugs.webkit.org/show_bug.cgi?id=159431 1207917 5 282294 commit-queue 2016-07-05 12:49:53 -0700 Comment on attachment 282294 patch Clearing flags on attachment: 282294 Committed r202827: <http://trac.webkit.org/changeset/202827> 1207918 6 commit-queue 2016-07-05 12:49:57 -0700 All reviewed patches have been landed. Closing bug. 282294 2016-06-28 16:11:32 -0700 2016-07-05 12:49:53 -0700 patch a-backup.diff text/plain 3084 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNTk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE2LTA2LTI4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBoIHNob3VsZCByZXBvcnQgYWJhbmRvbmVkIGJ5dGVz IGJhc2VkIG9uIGNhcGFjaXR5KCkgc28gaXQgd29ya3MgZXZlbiBpZiBhIEdDIGhhcyBuZXZlciBo YXBwZW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU5MjIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzAwMTk5MT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHJlcG9ydEFiYW5kb25lZE9i amVjdEdyYXBoKCkgd2FzIGNhbGxlZCBiZWZvcmUgdGhlIGZpcnN0IEdDLCBpdCB1c2VkIHRvCisg ICAgICAgIG5vdCBpbmRpY2F0ZSB0byB0aGUgR0MgdGltZXJzIHRoYXQgd2UgaGF2ZSBtZW1vcnkg dGhhdCBuZWVkcyB0byBiZSBjb2xsZWN0ZWQKKyAgICAgICAgYmVjYXVzZSB0aGUgY2FsY3VsYXRp b24gd2FzIGJhc2VkIG9uIG1fc2l6ZUFmdGVyTGFzdENvbGxlY3QgKHdoaWNoIHdhcyB6ZXJvKS4K KyAgICAgICAgVGhpcyBwYXRjaCBtYWtlcyB0aGUgY2FsY3VsYXRpb24gYmFzZWQgb24gY2FwYWNp dHkoKSB3aGljaCBpcyBhIHZhbGlkIG51bWJlcgorICAgICAgICBldmVuIGJlZm9yZSB0aGUgZmly c3QgR0MuCisKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpIZWFwOjpy ZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCk6CisgICAgICAgIChKU0M6OkhlYXA6OnByb3RlY3Qp OgorICAgICAgICAoSlNDOjpIZWFwOjpkaWRBYmFuZG9uKTogRGVsZXRlZC4KKyAgICAgICAgKiBo ZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6aml0U3R1YlJvdXRpbmVzKToKKwogMjAx Ni0wNi0yOCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBzb21l IFdhdGNocG9pbnRzJyA6OmZpcmVJbnRlcm5hbCBtZXRob2Qgd2lsbCBjYWxsIG9wZXJhdGlvbnMg dGhhdCBtaWdodCBHQyB3aGVyZSB0aGUgR0Mgd2lsbCBjYXVzZSB0aGUgd2F0Y2hwb2ludCBpdHNl bGYgdG8gZGVzdHJ1Y3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCShyZXZp c2lvbiAyMDI1ODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDMyLDIyICs0MzIsMTcgQEAgdm9pZCBIZWFwOjpyZXBvcnRBYmFuZG9u ZWRPYmplY3RHcmFwaCgpCiB7CiAgICAgLy8gT3VyIGNsaWVudHMgZG9uJ3Qga25vdyBleGFjdGx5 IGhvdyBtdWNoIG1lbW9yeSB0aGV5CiAgICAgLy8gYXJlIGFiYW5kb25pbmcgc28gd2UganVzdCBn dWVzcyBmb3IgdGhlbS4KLSAgICBkb3VibGUgYWJhbmRvbmVkQnl0ZXMgPSAwLjEgKiBtX3NpemVB ZnRlckxhc3RDb2xsZWN0OworICAgIHNpemVfdCBhYmFuZG9uZWRCeXRlcyA9IHN0YXRpY19jYXN0 PHNpemVfdD4oMC4xICogY2FwYWNpdHkoKSk7CiAKICAgICAvLyBXZSB3YW50IHRvIGFjY2VsZXJh dGUgdGhlIG5leHQgY29sbGVjdGlvbi4gQmVjYXVzZSBtZW1vcnkgaGFzIGp1c3QgCiAgICAgLy8g YmVlbiBhYmFuZG9uZWQsIHRoZSBuZXh0IGNvbGxlY3Rpb24gaGFzIHRoZSBwb3RlbnRpYWwgdG8g CiAgICAgLy8gYmUgbW9yZSBwcm9maXRhYmxlLiBTaW5jZSBhbGxvY2F0aW9uIGlzIHRoZSB0cmln Z2VyIGZvciBjb2xsZWN0aW9uLCAKICAgICAvLyB3ZSBoYXN0ZW4gdGhlIG5leHQgY29sbGVjdGlv biBieSBwcmV0ZW5kaW5nIHRoYXQgd2UndmUgYWxsb2NhdGVkIG1vcmUgbWVtb3J5LiAKLSAgICBk aWRBYmFuZG9uKGFiYW5kb25lZEJ5dGVzKTsKLX0KLQotdm9pZCBIZWFwOjpkaWRBYmFuZG9uKHNp emVfdCBieXRlcykKLXsKICAgICBpZiAobV9mdWxsQWN0aXZpdHlDYWxsYmFjaykgewogICAgICAg ICBtX2Z1bGxBY3Rpdml0eUNhbGxiYWNrLT5kaWRBbGxvY2F0ZSgKICAgICAgICAgICAgIG1fc2l6 ZUFmdGVyTGFzdENvbGxlY3QgLSBtX3NpemVBZnRlckxhc3RGdWxsQ29sbGVjdCArIG1fYnl0ZXNB bGxvY2F0ZWRUaGlzQ3ljbGUgKyBtX2J5dGVzQWJhbmRvbmVkU2luY2VMYXN0RnVsbENvbGxlY3Qp OwogICAgIH0KLSAgICBtX2J5dGVzQWJhbmRvbmVkU2luY2VMYXN0RnVsbENvbGxlY3QgKz0gYnl0 ZXM7CisgICAgbV9ieXRlc0FiYW5kb25lZFNpbmNlTGFzdEZ1bGxDb2xsZWN0ICs9IGFiYW5kb25l ZEJ5dGVzOwogfQogCiB2b2lkIEhlYXA6OnByb3RlY3QoSlNWYWx1ZSBrKQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL0hlYXAuaAkocmV2aXNpb24gMjAyNTgzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjksOCArMjI5LDYgQEAgcHVi bGljOgogICAgIHZvaWQgZGVsZXRlQWxsVW5saW5rZWRDb2RlQmxvY2tzKCk7CiAKICAgICB2b2lk IGRpZEFsbG9jYXRlKHNpemVfdCk7Ci0gICAgdm9pZCBkaWRBYmFuZG9uKHNpemVfdCk7Ci0KICAg ICBib29sIGlzUGFnZWRPdXQoZG91YmxlIGRlYWRsaW5lKTsKICAgICAKICAgICBjb25zdCBKSVRT dHViUm91dGluZVNldCYgaml0U3R1YlJvdXRpbmVzKCkgeyByZXR1cm4gbV9qaXRTdHViUm91dGlu ZXM7IH0K