159211 2016-06-28 05:25:25 -0700 Iterable interfaces should have their related prototype @@iterator property writable 2016-06-29 03:35:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED http://heycam.github.io/webidl/#es-iterator InRadar P2 Normal --- 1 youennf youennf cdumez cgarcia commit-queue webkit-bug-importer zalan oldest_to_newest 1206008 0 youennf 2016-06-28 05:25:25 -0700 Currently the property is read-only, which is not consistent with JSC iterators. 1206010 1 282245 youennf 2016-06-28 05:53:13 -0700 Created attachment 282245 Patch 1206080 2 282245 cdumez 2016-06-28 10:52:12 -0700 Comment on attachment 282245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282245&action=review R=me with comments > Source/WebCore/ChangeLog:5 > + <rdar://problem/26950766> > Source/WebCore/ChangeLog:7 > + Please link to the spec: http://heycam.github.io/webidl/#es-iterator > Source/WebCore/ChangeLog:8 > + Related to radar 26950766. Move this to the top. 1206082 3 cdumez 2016-06-28 10:52:53 -0700 <rdar://problem/26950766> 1206083 4 282245 cdumez 2016-06-28 10:56:15 -0700 Comment on attachment 282245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282245&action=review > LayoutTests/fast/dom/nodeListIterator.html:90 > + shouldNotThrow('NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];'); Please also add a check for the value returned by Object.getOwnPropertyDescriptor(NodeList.prototype, Symbol.iterator) to make sure writable is true, enumerable is false and configurable is true. As per the Web IDL spec. 1206121 5 youennf 2016-06-28 12:28:49 -0700 Thanks for the review. > > Source/WebCore/ChangeLog:5 > > + > > <rdar://problem/26950766> OK. > > Source/WebCore/ChangeLog:7 > > + > > Please link to the spec: > http://heycam.github.io/webidl/#es-iterator OK. > > Source/WebCore/ChangeLog:8 > > + Related to radar 26950766. > > Move this to the top. OK > > LayoutTests/fast/dom/nodeListIterator.html:90 > > + shouldNotThrow('NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];'); > > Please also add a check for the value returned by > Object.getOwnPropertyDescriptor(NodeList.prototype, Symbol.iterator) to make > sure writable is true, enumerable is false and configurable is true. As per > the Web IDL spec. OK FWIW, I plan to beef-up wpt idlharness.js to have thorough testing of iterable and setlike. 1206128 6 282271 youennf 2016-06-28 12:49:40 -0700 Created attachment 282271 Patch for landing 1206139 7 282271 commit-queue 2016-06-28 13:19:22 -0700 Comment on attachment 282271 Patch for landing Clearing flags on attachment: 282271 Committed r202583: <http://trac.webkit.org/changeset/202583> 1206140 8 commit-queue 2016-06-28 13:19:26 -0700 All reviewed patches have been landed. Closing bug. 1206351 9 youennf 2016-06-29 03:35:22 -0700 > FWIW, I plan to beef-up wpt idlharness.js to have thorough testing of > iterable and setlike. Related PR is https://github.com/w3c/testharness.js/pull/201 282245 2016-06-28 05:53:13 -0700 2016-06-28 12:49:32 -0700 Patch bug-159211-20160628145253.patch text/plain 6936 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNhNzY3YTk0OTljZWQy MGVkMTg4NWYwMzJlNjk5MzRiZWZmZWI2MS4uZDNmM2FmNjEzYjk3OGMwZDM0MTY2YThhODc1NmQx NGZmYjkzYTE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA2LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBJdGVyYWJsZSBpbnRlcmZh Y2VzIHNob3VsZCBoYXZlIHRoZWlyIHJlbGF0ZWQgcHJvdG90eXBlIEBAaXRlcmF0b3IgcHJvcGVy dHkgd3JpdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1OTIxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbGF0ZWQgdG8gcmFkYXIgMjY5NTA3NjYuCisgICAgICAgIENvdmVyZWQgYnkgdXBkYXRl ZCB0ZXN0LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06 CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKTogUmVtb3ZpbmcgUmVhZE9ubHkgZmxh ZyBmcm9tIEBAaXRlcmF0b3IgcHJvcGVydHkgb2YgaXRlcmFibGUgaW50ZXJmYWNlcy4KKyAgICAg ICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpKU1Rlc3ROb2RlUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbik6IFJlYmFzaW5nIGV4 cGVjdGF0aW9uLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmou Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNUZXN0T2JqUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlv bik6IERpdHRvLgorCiAyMDE2LTA2LTI4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBpbXByb3ZlZCBkdXJhdGlvbiBxdWVyeSBz dXBwb3J0IGluIHRoZSBIVFRQIHNvdXJjZSBlbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDFkNGM0MzliMmY2NGE4 Mjc5OTVlMjBhZDlhNGI1ODcyNzA4YTJkYmEuLjlhNGViMTIxYTJlMzg0MjI2Yzg5YTM1YWMzOWIw YWY2MTE4ODhiY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckpTLnBtCkBAIC0yMzEwLDcgKzIzMTAsNyBAQCBzdWIgR2VuZXJhdGVJbXBs ZW1lbnRhdGlvbgogCiAgICAgICAgIGlmICgkaW50ZXJmYWNlLT5pdGVyYWJsZSkgewogICAgICAg ICAgICAgbXkgJGZ1bmN0aW9uTmFtZSA9IEdldEZ1bmN0aW9uTmFtZSgkaW50ZXJmYWNlLCAkY2xh c3NOYW1lLCBAeyRpbnRlcmZhY2UtPml0ZXJhYmxlLT5mdW5jdGlvbnN9WzBdKTsKLSAgICAgICAg ICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIHB1dERpcmVjdCh2bSwgdm0ucHJvcGVydHlOYW1l cy0+aXRlcmF0b3JTeW1ib2wsIEpTRnVuY3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0KCks IDAsIEFTQ0lJTGl0ZXJhbChcIltTeW1ib2wuSXRlcmF0b3JdXCIpLCAkZnVuY3Rpb25OYW1lKSwg UmVhZE9ubHkgfCBEb250RW51bSk7XG4iKTsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCAiICAgIHB1dERpcmVjdCh2bSwgdm0ucHJvcGVydHlOYW1lcy0+aXRlcmF0b3JTeW1ib2wsIEpT RnVuY3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0KCksIDAsIEFTQ0lJTGl0ZXJhbChcIltT eW1ib2wuSXRlcmF0b3JdXCIpLCAkZnVuY3Rpb25OYW1lKSwgRG9udEVudW0pO1xuIik7CiAgICAg ICAgIH0KIAogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIn1cblxuIik7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5jcHAK aW5kZXggMzMxM2QyZGJlODYzMTU4NTQ1ZDM2YTNhNDg4OWRlZmY3ZDFhMjUxNC4uMWY1ZmQ4YzIw MjY1ZjY0YWE0YjAyODAxNTAwYmNiMTY4MTE4YTQyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE5vZGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2RlLmNwcApAQCAtMTE1LDcg KzExNSw3IEBAIHZvaWQgSlNUZXN0Tm9kZVByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZt KQogewogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtKTsKICAgICByZWlmeVN0YXRpY1Byb3Bl cnRpZXModm0sIEpTVGVzdE5vZGVQcm90b3R5cGVUYWJsZVZhbHVlcywgKnRoaXMpOwotICAgIHB1 dERpcmVjdCh2bSwgdm0ucHJvcGVydHlOYW1lcy0+aXRlcmF0b3JTeW1ib2wsIEpTRnVuY3Rpb246 OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0KCksIDAsIEFTQ0lJTGl0ZXJhbCgiW1N5bWJvbC5JdGVy YXRvcl0iKSwganNUZXN0Tm9kZVByb3RvdHlwZUZ1bmN0aW9uU3ltYm9sSXRlcmF0b3IpLCBSZWFk T25seSB8IERvbnRFbnVtKTsKKyAgICBwdXREaXJlY3Qodm0sIHZtLnByb3BlcnR5TmFtZXMtPml0 ZXJhdG9yU3ltYm9sLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgpLCAwLCBB U0NJSUxpdGVyYWwoIltTeW1ib2wuSXRlcmF0b3JdIiksIGpzVGVzdE5vZGVQcm90b3R5cGVGdW5j dGlvblN5bWJvbEl0ZXJhdG9yKSwgRG9udEVudW0pOwogfQogCiBjb25zdCBDbGFzc0luZm8gSlNU ZXN0Tm9kZTo6c19pbmZvID0geyAiVGVzdE5vZGUiLCAmQmFzZTo6c19pbmZvLCAwLCBDUkVBVEVf TUVUSE9EX1RBQkxFKEpTVGVzdE5vZGUpIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCmluZGV4IDEzYzEyYjk2Y2ZlN2Iy ZjI2NWUwNjE5MWIwZDIwOGRhOGIxMDlhYjcuLjdiNDQ1MGUxNTE0Nzk0YWZlYmRhZTM2NjMzMGZm NjUxNzYzMmQ5OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv dGVzdC9KUy9KU1Rlc3RPYmouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCkBAIC0xMzI3LDcgKzEzMjcsNyBAQCB2b2lkIEpTVGVz dE9ialByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogICAgIEpTVk1DbGllbnREYXRh JiBjbGllbnREYXRhID0gKnN0YXRpY19jYXN0PEpTVk1DbGllbnREYXRhKj4odm0uY2xpZW50RGF0 YSk7CiAgICAgcHV0RGlyZWN0KHZtLCBjbGllbnREYXRhLmJ1aWx0aW5OYW1lcygpLnByaXZhdGVN ZXRob2RQcml2YXRlTmFtZSgpLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgp LCAwLCBTdHJpbmcoKSwganNUZXN0T2JqUHJvdG90eXBlRnVuY3Rpb25Qcml2YXRlTWV0aG9kKSwg UmVhZE9ubHkgfCBEb250RW51bSk7CiAgICAgcHV0RGlyZWN0KHZtLCBjbGllbnREYXRhLmJ1aWx0 aW5OYW1lcygpLnB1YmxpY0FuZFByaXZhdGVNZXRob2RQcml2YXRlTmFtZSgpLCBKU0Z1bmN0aW9u OjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgpLCAwLCBTdHJpbmcoKSwganNUZXN0T2JqUHJvdG90 eXBlRnVuY3Rpb25QdWJsaWNBbmRQcml2YXRlTWV0aG9kKSwgUmVhZE9ubHkgfCBEb250RW51bSk7 Ci0gICAgcHV0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5pdGVyYXRvclN5bWJvbCwgSlNG dW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QoKSwgMCwgQVNDSUlMaXRlcmFsKCJbU3lt Ym9sLkl0ZXJhdG9yXSIpLCBqc1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvblN5bWJvbEl0ZXJhdG9y KSwgUmVhZE9ubHkgfCBEb250RW51bSk7CisgICAgcHV0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5h bWVzLT5pdGVyYXRvclN5bWJvbCwgSlNGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3Qo KSwgMCwgQVNDSUlMaXRlcmFsKCJbU3ltYm9sLkl0ZXJhdG9yXSIpLCBqc1Rlc3RPYmpQcm90b3R5 cGVGdW5jdGlvblN5bWJvbEl0ZXJhdG9yKSwgRG9udEVudW0pOwogfQogCiBjb25zdCBDbGFzc0lu Zm8gSlNUZXN0T2JqOjpzX2luZm8gPSB7ICJUZXN0T2JqZWN0IiwgJkJhc2U6OnNfaW5mbywgJkpT VGVzdE9ialRhYmxlLCBDUkVBVEVfTUVUSE9EX1RBQkxFKEpTVGVzdE9iaikgfTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2 Nzc2M2QwZDgzYTE5MDkzNzk1ZmM5YWQxZWQ5YzE3MGJkNmQ2MThkLi4yYTA5MzQ3ODQ3ZTM2NzMz OTRiMTFjNWQyMzQ0YmNiYTk1YmRiZDgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTYtMDYt MjggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCisgICAgICAgIEl0ZXJhYmxl IGludGVyZmFjZXMgc2hvdWxkIGhhdmUgdGhlaXIgcmVsYXRlZCBwcm90b3R5cGUgQEBpdGVyYXRv ciBwcm9wZXJ0eSB3cml0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU5MjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBmYXN0L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLmh0bWw6IE92ZXJyaWRpbmcgTm9kZUxp c3QgQEBpdGVyYXRvciBieSBBcnJheSBvbmUgYW5kIGNoZWNraW5nIGV2ZXJ5dGhpbmcgaXMgZmlu ZS4KKworMjAxNi0wNi0yOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKICAg ICAgICAgaHR0cC90ZXN0cy9tZWRpYS9obHMvdmlkZW8tY29udHJvbGxlci1nZXRTdGFydERhdGUu aHRtbCBpcyBmYWlsaW5nIG9uIG5vbi1QRFQgdGltZS1iYXNlZCBjb21wdXRlcnMKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTEzNAogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3ItZXhwZWN0ZWQudHh0CmluZGV4 IGQ3ZGJkY2Q5YmI2ZjZiNDdlNjg4MWIyM2UxMTg4YzQyNzc2ZjZmMzMuLjc0YWI5Nzk0OTg1YzQ2 ZWRjMGJjMTE1YWRhN2ZlY2I5ZmVhZmJmYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL25vZGVMaXN0SXRlcmF0b3ItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL25vZGVMaXN0SXRlcmF0b3ItZXhwZWN0ZWQudHh0CkBAIC0zOCw2ICszOCwxMiBAQCBQQVNT IGVuZC5kb25lIGlzIHRydWUKIFBBU1MgZW5kLnZhbHVlIGlzIHVuZGVmaW5lZAogUEFTUyBlbmQu ZG9uZSBpcyB0cnVlCiBQQVNTIGVuZC52YWx1ZSBpcyB1bmRlZmluZWQKK1BBU1MgTm9kZUxpc3Qu cHJvdG90eXBlW1N5bWJvbC5pdGVyYXRvcl0gPSBBcnJheS5wcm90b3R5cGVbU3ltYm9sLml0ZXJh dG9yXTsgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIGEgaW5zdGFuY2VvZiBOb2RlIGlz IHRydWUKK1BBU1MgYSBpbnN0YW5jZW9mIE5vZGUgaXMgdHJ1ZQorUEFTUyBhIGluc3RhbmNlb2Yg Tm9kZSBpcyB0cnVlCitQQVNTIGEgaW5zdGFuY2VvZiBOb2RlIGlzIHRydWUKK1BBU1MgY291bnRl ciBpcyA0CiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3IuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3IuaHRtbAppbmRleCA0YzQ1MTA0 NGQ3NzdhNWU3ZmM1NTA5NTZlYjYxNzA0MDRhYWRjYTg1Li44ZGQ1NjdjZDMyNzk3ZjI0ZTA4MjVk Y2ZiNjNlMzQ5MzU3Zjk4ZDEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2Rl TGlzdEl0ZXJhdG9yLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZUxpc3RJdGVy YXRvci5odG1sCkBAIC04Nyw2ICs4NywxMyBAQAogICAgICAgICAgICAgdGVzdGluZ0dyb3VuZC5h cHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdwJykpOwogICAgICAgICAgICAgY2hl Y2tFbmRJdGVyYXRvcihpdGVyYXRvci5uZXh0KCkpOwogCisgICAgICAgICAgICBzaG91bGROb3RU aHJvdygnTm9kZUxpc3QucHJvdG90eXBlW1N5bWJvbC5pdGVyYXRvcl0gPSBBcnJheS5wcm90b3R5 cGVbU3ltYm9sLml0ZXJhdG9yXTsnKTsKKyAgICAgICAgICAgIHZhciBjb3VudGVyID0gMDsKKyAg ICAgICAgICAgIGZvciAodmFyIGEgb2Ygbm9kZUxpc3QpIHsKKyAgICAgICAgICAgICAgICBzaG91 bGRCZVRydWUoJ2EgaW5zdGFuY2VvZiBOb2RlJyk7CisgICAgICAgICAgICAgICAgY291bnRlcisr OworICAgICAgICAgICAgfQorICAgICAgICAgICAgc2hvdWxkQmUoJ2NvdW50ZXInLCAnNCcpOwog ICAgICAgICA8L3NjcmlwdD4KICAgICAgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgogICAgIDwvYm9keT4K 282271 2016-06-28 12:49:40 -0700 2016-06-28 13:19:22 -0700 Patch for landing bug-159211-20160628214922.patch text/plain 7269 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIzY2NkOWJhMjNjYjZl YTk0NTI3ZTgxZDQ3ZjFiZjFhNGY2NTY3Ni4uYWJjN2Q2Nzg0ZTg1OGM4MDQyNzA5Y2ZhODAyNjhm NzhiZTUxODFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA2LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBJdGVyYWJsZSBpbnRlcmZh Y2VzIHNob3VsZCBoYXZlIHRoZWlyIHJlbGF0ZWQgcHJvdG90eXBlIEBAaXRlcmF0b3IgcHJvcGVy dHkgd3JpdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1OTIxMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY5NTA3NjY+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgVXBkYXRpbmcgQEBpdGVyYXRvciBw cm9wZXJ0eSBhY2NvcmRpbmcgIGh0dHA6Ly9oZXljYW0uZ2l0aHViLmlvL3dlYmlkbC8jZXMtaXRl cmF0b3IuCisKKyAgICAgICAgQ292ZXJlZCBieSB1cGRhdGVkIHRlc3QuCisKKyAgICAgICAgKiBi aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEdlbmVyYXRlSW1w bGVtZW50YXRpb24pOiBSZW1vdmluZyBSZWFkT25seSBmbGFnIGZyb20gQEBpdGVyYXRvciBwcm9w ZXJ0eSBvZiBpdGVyYWJsZSBpbnRlcmZhY2VzLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv dGVzdC9KUy9KU1Rlc3ROb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTVGVzdE5vZGVQcm90 b3R5cGU6OmZpbmlzaENyZWF0aW9uKTogUmViYXNpbmcgZXhwZWN0YXRpb24uCisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpKU1Rlc3RPYmpQcm90b3R5cGU6OmZpbmlzaENyZWF0aW9uKTogRGl0dG8uCisKIDIwMTYtMDYt MjggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5d IEN1c3RvbSBlbGVtZW50cyB0ZXN0cyBhcmUgZmFpbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggMWQ0YzQzOWIyZjY0 YTgyNzk5NWUyMGFkOWE0YjU4NzI3MDhhMmRiYS4uOWE0ZWIxMjFhMmUzODQyMjZjODlhMzVhYzM5 YjBhZjYxMTg4OGJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTIzMTAsNyArMjMxMCw3IEBAIHN1YiBHZW5lcmF0ZUlt cGxlbWVudGF0aW9uCiAKICAgICAgICAgaWYgKCRpbnRlcmZhY2UtPml0ZXJhYmxlKSB7CiAgICAg ICAgICAgICBteSAkZnVuY3Rpb25OYW1lID0gR2V0RnVuY3Rpb25OYW1lKCRpbnRlcmZhY2UsICRj bGFzc05hbWUsIEB7JGludGVyZmFjZS0+aXRlcmFibGUtPmZ1bmN0aW9uc31bMF0pOwotICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgcHV0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5h bWVzLT5pdGVyYXRvclN5bWJvbCwgSlNGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3Qo KSwgMCwgQVNDSUlMaXRlcmFsKFwiW1N5bWJvbC5JdGVyYXRvcl1cIiksICRmdW5jdGlvbk5hbWUp LCBSZWFkT25seSB8IERvbnRFbnVtKTtcbiIpOworICAgICAgICAgICAgcHVzaChAaW1wbENvbnRl bnQsICIgICAgcHV0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5pdGVyYXRvclN5bWJvbCwg SlNGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QoKSwgMCwgQVNDSUlMaXRlcmFsKFwi W1N5bWJvbC5JdGVyYXRvcl1cIiksICRmdW5jdGlvbk5hbWUpLCBEb250RW51bSk7XG4iKTsKICAg ICAgICAgfQogCiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAifVxuXG4iKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2RlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2RlLmNw cAppbmRleCAzMzEzZDJkYmU4NjMxNTg1NDVkMzZhM2E0ODg5ZGVmZjdkMWEyNTE0Li4xZjVmZDhj MjAyNjVmNjRhYTRiMDI4MDE1MDBiY2IxNjgxMThhNDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE5vZGUuY3BwCkBAIC0xMTUs NyArMTE1LDcgQEAgdm9pZCBKU1Rlc3ROb2RlUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbihWTSYg dm0pCiB7CiAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24odm0pOwogICAgIHJlaWZ5U3RhdGljUHJv cGVydGllcyh2bSwgSlNUZXN0Tm9kZVByb3RvdHlwZVRhYmxlVmFsdWVzLCAqdGhpcyk7Ci0gICAg cHV0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5pdGVyYXRvclN5bWJvbCwgSlNGdW5jdGlv bjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QoKSwgMCwgQVNDSUlMaXRlcmFsKCJbU3ltYm9sLkl0 ZXJhdG9yXSIpLCBqc1Rlc3ROb2RlUHJvdG90eXBlRnVuY3Rpb25TeW1ib2xJdGVyYXRvciksIFJl YWRPbmx5IHwgRG9udEVudW0pOworICAgIHB1dERpcmVjdCh2bSwgdm0ucHJvcGVydHlOYW1lcy0+ aXRlcmF0b3JTeW1ib2wsIEpTRnVuY3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0KCksIDAs IEFTQ0lJTGl0ZXJhbCgiW1N5bWJvbC5JdGVyYXRvcl0iKSwganNUZXN0Tm9kZVByb3RvdHlwZUZ1 bmN0aW9uU3ltYm9sSXRlcmF0b3IpLCBEb250RW51bSk7CiB9CiAKIGNvbnN0IENsYXNzSW5mbyBK U1Rlc3ROb2RlOjpzX2luZm8gPSB7ICJUZXN0Tm9kZSIsICZCYXNlOjpzX2luZm8sIDAsIENSRUFU RV9NRVRIT0RfVEFCTEUoSlNUZXN0Tm9kZSkgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAKaW5kZXggMTNjMTJiOTZjZmU3 YjJmMjY1ZTA2MTkxYjBkMjA4ZGE4YjEwOWFiNy4uN2I0NDUwZTE1MTQ3OTRhZmViZGFlMzY2MzMw ZmY2NTE3NjMyZDk4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAKQEAgLTEzMjcsNyArMTMyNyw3IEBAIHZvaWQgSlNU ZXN0T2JqUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbihWTSYgdm0pCiAgICAgSlNWTUNsaWVudERh dGEmIGNsaWVudERhdGEgPSAqc3RhdGljX2Nhc3Q8SlNWTUNsaWVudERhdGEqPih2bS5jbGllbnRE YXRhKTsKICAgICBwdXREaXJlY3Qodm0sIGNsaWVudERhdGEuYnVpbHRpbk5hbWVzKCkucHJpdmF0 ZU1ldGhvZFByaXZhdGVOYW1lKCksIEpTRnVuY3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0 KCksIDAsIFN0cmluZygpLCBqc1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvblByaXZhdGVNZXRob2Qp LCBSZWFkT25seSB8IERvbnRFbnVtKTsKICAgICBwdXREaXJlY3Qodm0sIGNsaWVudERhdGEuYnVp bHRpbk5hbWVzKCkucHVibGljQW5kUHJpdmF0ZU1ldGhvZFByaXZhdGVOYW1lKCksIEpTRnVuY3Rp b246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0KCksIDAsIFN0cmluZygpLCBqc1Rlc3RPYmpQcm90 b3R5cGVGdW5jdGlvblB1YmxpY0FuZFByaXZhdGVNZXRob2QpLCBSZWFkT25seSB8IERvbnRFbnVt KTsKLSAgICBwdXREaXJlY3Qodm0sIHZtLnByb3BlcnR5TmFtZXMtPml0ZXJhdG9yU3ltYm9sLCBK U0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgpLCAwLCBBU0NJSUxpdGVyYWwoIltT eW1ib2wuSXRlcmF0b3JdIiksIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uU3ltYm9sSXRlcmF0 b3IpLCBSZWFkT25seSB8IERvbnRFbnVtKTsKKyAgICBwdXREaXJlY3Qodm0sIHZtLnByb3BlcnR5 TmFtZXMtPml0ZXJhdG9yU3ltYm9sLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVj dCgpLCAwLCBBU0NJSUxpdGVyYWwoIltTeW1ib2wuSXRlcmF0b3JdIiksIGpzVGVzdE9ialByb3Rv dHlwZUZ1bmN0aW9uU3ltYm9sSXRlcmF0b3IpLCBEb250RW51bSk7CiB9CiAKIGNvbnN0IENsYXNz SW5mbyBKU1Rlc3RPYmo6OnNfaW5mbyA9IHsgIlRlc3RPYmplY3QiLCAmQmFzZTo6c19pbmZvLCAm SlNUZXN0T2JqVGFibGUsIENSRUFURV9NRVRIT0RfVEFCTEUoSlNUZXN0T2JqKSB9OwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDYwMTMwMTIwMTFjYjVkYjQzNzlkZTQ3ZjI5N2M5NDcxMDcwZTRlMGQuLjM3Y2UwMjA0ZTM0Nzg1 YjY0OTgxYjg2MTcyZTBkOWM3NGJiZTgyMTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0w Ni0yOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgSXRlcmFi bGUgaW50ZXJmYWNlcyBzaG91bGQgaGF2ZSB0aGVpciByZWxhdGVkIHByb3RvdHlwZSBAQGl0ZXJh dG9yIHByb3BlcnR5IHdyaXRhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTkyMTEKKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4K KworICAgICAgICAqIGZhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3ItZXhwZWN0ZWQudHh0OgorICAg ICAgICAqIGZhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3IuaHRtbDogT3ZlcnJpZGluZyBOb2RlTGlz dCBAQGl0ZXJhdG9yIGJ5IEFycmF5IG9uZSBhbmQgY2hlY2tpbmcgZXZlcnl0aGluZyBpcyBmaW5l LgorCiAyMDE2LTA2LTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBVcGRhdGUgZXhwZWN0YXRpb25zIGZvciBzdWJ0bGUgY3J5cHRv IGxheW91dCB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZUxpc3RJ dGVyYXRvci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlTGlzdEl0ZXJh dG9yLWV4cGVjdGVkLnR4dAppbmRleCBkN2RiZGNkOWJiNmY2YjQ3ZTY4ODFiMjNlMTE4OGM0Mjc3 NmY2ZjMzLi4zM2JlN2VhOGI3ZjVhZjU4NmI3MjE3ZGRiZTQ4NDk3NGM3ODcwZjdkIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLWV4cGVjdGVkLnR4dAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLWV4cGVjdGVkLnR4dApA QCAtMzgsNiArMzgsMTUgQEAgUEFTUyBlbmQuZG9uZSBpcyB0cnVlCiBQQVNTIGVuZC52YWx1ZSBp cyB1bmRlZmluZWQKIFBBU1MgZW5kLmRvbmUgaXMgdHJ1ZQogUEFTUyBlbmQudmFsdWUgaXMgdW5k ZWZpbmVkCitQQVNTIGRlc2NyaXB0b3IuY29uZmlndXJhYmxlIGlzIHRydWUKK1BBU1MgZGVzY3Jp cHRvci53cml0YWJsZSBpcyB0cnVlCitQQVNTIGRlc2NyaXB0b3IuZW51bWVyYWJsZSBpcyBmYWxz ZQorUEFTUyBOb2RlTGlzdC5wcm90b3R5cGVbU3ltYm9sLml0ZXJhdG9yXSA9IEFycmF5LnByb3Rv dHlwZVtTeW1ib2wuaXRlcmF0b3JdOyBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KK1BBU1MgYSBp bnN0YW5jZW9mIE5vZGUgaXMgdHJ1ZQorUEFTUyBhIGluc3RhbmNlb2YgTm9kZSBpcyB0cnVlCitQ QVNTIGEgaW5zdGFuY2VvZiBOb2RlIGlzIHRydWUKK1BBU1MgYSBpbnN0YW5jZW9mIE5vZGUgaXMg dHJ1ZQorUEFTUyBjb3VudGVyIGlzIDQKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK IAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZUxp c3RJdGVyYXRvci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZUxpc3RJdGVyYXRvci5o dG1sCmluZGV4IDRjNDUxMDQ0ZDc3N2E1ZTdmYzU1MDk1NmViNjE3MDQwNGFhZGNhODUuLjc1Mjdm MjU0YzI2NDA0ZmNjM2FhOTNiNmNlZjhlYmEzMmZjNGZmMDUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3IuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLmh0bWwKQEAgLTg3LDYgKzg3LDE4IEBACiAgICAgICAgICAg ICB0ZXN0aW5nR3JvdW5kLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3AnKSk7 CiAgICAgICAgICAgICBjaGVja0VuZEl0ZXJhdG9yKGl0ZXJhdG9yLm5leHQoKSk7CiAKKyAgICAg ICAgICAgIHZhciBkZXNjcmlwdG9yID0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihO b2RlTGlzdC5wcm90b3R5cGUsIFN5bWJvbC5pdGVyYXRvcik7CisgICAgICAgICAgICBzaG91bGRC ZVRydWUoJ2Rlc2NyaXB0b3IuY29uZmlndXJhYmxlJyk7CisgICAgICAgICAgICBzaG91bGRCZVRy dWUoJ2Rlc2NyaXB0b3Iud3JpdGFibGUnKTsKKyAgICAgICAgICAgIHNob3VsZEJlRmFsc2UoJ2Rl c2NyaXB0b3IuZW51bWVyYWJsZScpOworCisgICAgICAgICAgICBzaG91bGROb3RUaHJvdygnTm9k ZUxpc3QucHJvdG90eXBlW1N5bWJvbC5pdGVyYXRvcl0gPSBBcnJheS5wcm90b3R5cGVbU3ltYm9s Lml0ZXJhdG9yXTsnKTsKKyAgICAgICAgICAgIHZhciBjb3VudGVyID0gMDsKKyAgICAgICAgICAg IGZvciAodmFyIGEgb2Ygbm9kZUxpc3QpIHsKKyAgICAgICAgICAgICAgICBzaG91bGRCZVRydWUo J2EgaW5zdGFuY2VvZiBOb2RlJyk7CisgICAgICAgICAgICAgICAgY291bnRlcisrOworICAgICAg ICAgICAgfQorICAgICAgICAgICAgc2hvdWxkQmUoJ2NvdW50ZXInLCAnNCcpOwogICAgICAgICA8 L3NjcmlwdD4KICAgICAgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBv c3QuanMiPjwvc2NyaXB0PgogICAgIDwvYm9keT4K