159207 2016-06-28 03:20:14 -0700 WebRTC: ice-char can not contain '=' characters for credentials 2016-06-29 10:36:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 alex alex adam.bergkvist commit-queue eric.carlson oldest_to_newest 1205982 0 alex 2016-06-28 03:20:14 -0700 We are generating a wrong pass string because we are using base64 random string with padding, and paddings are filled with '=' characters, it is a problem because the sdp parser does not work corrently in this cases and we are not sending good credentials. The parser in the test we have was modified to avoid this issue. 1206000 1 282242 alex 2016-06-28 04:13:31 -0700 Created attachment 282242 Patch 1206090 2 282242 adam.bergkvist 2016-06-28 11:10:43 -0700 Comment on attachment 282242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282242&action=review > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:75 > + , m_icePassword(randomString(24)) // From 22 to 256 ice-chars, we use base64 to generate we need to avoid padding. Feels like a word is missing to make these sentences complete 1206336 3 alex 2016-06-29 01:42:55 -0700 (In reply to comment #2) > Comment on attachment 282242 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282242&action=review > > > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:75 > > + , m_icePassword(randomString(24)) // From 22 to 256 ice-chars, we use base64 to generate we need to avoid padding. > > Feels like a word is missing to make these sentences complete Right, I'll fix it, thanks for the review! 1206338 4 282333 alex 2016-06-29 02:02:57 -0700 Created attachment 282333 Patch 1206382 5 282333 eric.carlson 2016-06-29 08:17:55 -0700 Comment on attachment 282333 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282333&action=review > Source/WebCore/ChangeLog:8 > + Avoided the general calculation to get a base64 without padding Nit: "Avoided the general calculation..." -> "Avoid a general calculation..." > Source/WebCore/ChangeLog:9 > + which was wrong in the randomString function. Each parameter using Nit: "Each parameter using..." -> "Because each parameter using..." > Source/WebCore/ChangeLog:16 > + Covered by existing test modified to match the correct behavior. Nit: "Covered by existing test modified to..." -> "Existing test modified to..." 1206418 6 282355 alex 2016-06-29 10:06:47 -0700 Created attachment 282355 Patch for landing 1206421 7 282355 commit-queue 2016-06-29 10:36:55 -0700 Comment on attachment 282355 Patch for landing Clearing flags on attachment: 282355 Committed r202628: <http://trac.webkit.org/changeset/202628> 1206422 8 commit-queue 2016-06-29 10:36:59 -0700 All reviewed patches have been landed. Closing bug. 282242 2016-06-28 04:13:31 -0700 2016-06-29 02:02:50 -0700 Patch bug-159207-20160628131313.patch text/plain 4540 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE5MGMyNDE3Yjc3MzY1 MjMyYTBmZmVhODQ1Mjc2YzJjMjc1Nzg0Yi4uZjE2MDBmMWQzYzU2NzBmMTdkNTI1ZTJjYWRiZDUx MTgwY2IxYjJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA2LTI4ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYlJUQzogaWNl LWNoYXIgY2FuIG5vdCBjb250YWluICc9JyBjaGFyYWN0ZXJzIGZvciBjcmVkZW50aWFscworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MjA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRlZCB0aGUg Z2VuZXJhbCBjYWxjdWxhdGlvbiB0byBjYWxjdWxhdGUgYmFzZTY0IHBhZGRpbmcgd2hpY2gKKyAg ICAgICAgd2FzIHdyb25nIGluIHRoZSByYW5kb21TdHJpbmcgZnVuY3Rpb24uIENvbnNpZGVyaW5n IGVhY2ggcGFyYW1ldGVyCisgICAgICAgIHVzaW5nIHRoZSBmdW5jdGlvbiByZXF1aXJlcyBhIGRp ZmZlcmVudCBzZXR1cCBhbmQgdGhpcyBpcyBub3QgYQorICAgICAgICBnZW5lcmFsIEFQSSwgaXQg aXMgYSBiZXR0ZXIgc29sdXRpb24gdG8gY2FsY3VsYXRlIHRoZSByZXF1aXJlZAorICAgICAgICB2 YWx1ZXMsIGNvbW1lbnQgdGhlbSBhbmQgdGVzdCB0aGVtLCBjb25zaWRlcmluZyB3ZSB1c2UgYmFz ZTY0IHRvCisgICAgICAgIGdlbmVyYXRlIHRoZSBzdHJpbmdzIHdlIGp1c3QgbmVlZCB0byBhdm9p ZCBwYWRkaW5nLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdCBtb2RpZmllZCB0 byBtYXRjaCB0aGUgY29ycmVjdCBiZWhhdmlvci4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFz dHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnJhbmRvbVN0cmluZyk6IE5vdyB0aGUgc2l6ZSBpcyB0aGUgb25lIHBhc3NlZC4KKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbjo6TWVkaWFFbmRwb2ludFBlZXJD b25uZWN0aW9uKToKKyAgICAgICAgVXNlZCBkaWZmZXJlbnQgdmFsaWQgdmFsdWVzIGZvbGxvd2lu ZyB0aGUgc2RwIHBhcnNlciBpbiBlYWNoIGNhc2UuCisKIDIwMTYtMDYtMjggIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEJpbmRpbmcgZ2VuZXJhdG9yIHNob3Vs ZCBnZW5lcmF0ZSBhY2Nlc3NvcnMgZm9yIGNvbnN0cnVjdG9ycyBzYWZlbHkgYWNjZXNzZWQgZnJv bSBKUyBidWlsdGluCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbi5jcHAKaW5kZXggZWI1 MzgxODZkOTEwN2RhMTQ4ZjQwYzkyNzdlMmQ3ZDRhY2QxMmVlMi4uM2FkNTM2MmY4ZDFmYjU3YTVh MTQ2OWM1Njc0ZTliOWU1NWFjYTY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9u LmNwcApAQCAtNjAsOSArNjAsOCBAQCBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFBlZXJDb25uZWN0 aW9uQmFja2VuZD4gY3JlYXRlTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uKAogCiBDcmVhdGVQ ZWVyQ29ubmVjdGlvbkJhY2tlbmQgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpjcmVhdGUgPSBjcmVh dGVNZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb247CiAKLXN0YXRpYyBTdHJpbmcgcmFuZG9tU3Ry aW5nKHNpemVfdCBsZW5ndGgpCitzdGF0aWMgU3RyaW5nIHJhbmRvbVN0cmluZyhzaXplX3Qgc2l6 ZSkKIHsKLSAgICBjb25zdCBzaXplX3Qgc2l6ZSA9IGNlaWwobGVuZ3RoICogMyAvIDQpOwogICAg IHVuc2lnbmVkIGNoYXIgcmFuZG9tVmFsdWVzW3NpemVdOwogICAgIGNyeXB0b2dyYXBoaWNhbGx5 UmFuZG9tVmFsdWVzKHJhbmRvbVZhbHVlcywgc2l6ZSk7CiAgICAgcmV0dXJuIGJhc2U2NEVuY29k ZShyYW5kb21WYWx1ZXMsIHNpemUpOwpAQCAtNzEsOSArNzAsOSBAQCBzdGF0aWMgU3RyaW5nIHJh bmRvbVN0cmluZyhzaXplX3QgbGVuZ3RoKQogTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uOjpN ZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24oUGVlckNvbm5lY3Rpb25CYWNrZW5kQ2xpZW50KiBj bGllbnQpCiAgICAgOiBtX2NsaWVudChjbGllbnQpCiAgICAgLCBtX3NkcFByb2Nlc3NvcihzdGQ6 OnVuaXF1ZV9wdHI8U0RQUHJvY2Vzc29yPihuZXcgU0RQUHJvY2Vzc29yKG1fY2xpZW50LT5zY3Jp cHRFeGVjdXRpb25Db250ZXh0KCkpKSkKLSAgICAsIG1fY25hbWUocmFuZG9tU3RyaW5nKDE2KSkK LSAgICAsIG1faWNlVWZyYWcocmFuZG9tU3RyaW5nKDQpKQotICAgICwgbV9pY2VQYXNzd29yZChy YW5kb21TdHJpbmcoMjIpKQorICAgICwgbV9jbmFtZShyYW5kb21TdHJpbmcoMTgpKQorICAgICwg bV9pY2VVZnJhZyhyYW5kb21TdHJpbmcoNikpIC8vIEZyb20gNCB0byAyNTYgaWNlLWNoYXJzLCB3 ZSB1c2UgYmFzZTY0IHRvIGdlbmVyYXRlIHdlIG5lZWQgdG8gYXZvaWQgcGFkZGluZy4KKyAgICAs IG1faWNlUGFzc3dvcmQocmFuZG9tU3RyaW5nKDI0KSkgLy8gRnJvbSAyMiB0byAyNTYgaWNlLWNo YXJzLCB3ZSB1c2UgYmFzZTY0IHRvIGdlbmVyYXRlIHdlIG5lZWQgdG8gYXZvaWQgcGFkZGluZy4K IHsKICAgICBtX21lZGlhRW5kcG9pbnQgPSBNZWRpYUVuZHBvaW50OjpjcmVhdGUoKnRoaXMpOwog ICAgIEFTU0VSVChtX21lZGlhRW5kcG9pbnQpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY3NzYzZDBkODNhMTkwOTM3OTVm YzlhZDFlZDljMTcwYmQ2ZDYxOGQuLjEwZGM4YjY5MTA2NjJhZTgyOTg4NWMzMjY4YmM1M2VjNGFi YzVmOTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wNi0yOCAgQWxlamFuZHJvIEcuIENh c3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJSVEM6IGljZS1jaGFyIGNhbiBu b3QgY29udGFpbiAnPScgY2hhcmFjdGVycyBmb3IgY3JlZGVudGlhbHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTIwNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmaWVkIHRoZSBwYXJzZXIgdG8g bWFrZSB0aGUgcmVnZXhwIHNpbWlsYXIgdG8gdGhlIG9uZSB3ZSBoYXZlCisgICAgICAgIGluIFdl YkNvcmUuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL3Jlc291cmNlcy9zZHAtdXRpbHMu anM6CisgICAgICAgIChwcmludENvbXBhcmFibGVTZXNzaW9uRGVzY3JpcHRpb24pOgorCiAyMDE2 LTA2LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRw L3Rlc3RzL21lZGlhL2hscy92aWRlby1jb250cm9sbGVyLWdldFN0YXJ0RGF0ZS5odG1sIGlzIGZh aWxpbmcgb24gbm9uLVBEVCB0aW1lLWJhc2VkIGNvbXB1dGVycwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9yZXNvdXJjZXMvc2RwLXV0aWxzLmpzIGIvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9yZXNvdXJjZXMvc2RwLXV0aWxzLmpzCmluZGV4IGI2MzJkMDVk ZjM3YWVjODhiNzQ4YzIzZDg4MWVmMTgzOTQwZTNmZjAuLmM0MzYzYmIyOTU4YjM2YjY2MzE2ZDM5 YmRlNzg1MmYxOTIzYjM5ZGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJl YW0vcmVzb3VyY2VzL3NkcC11dGlscy5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3Ry ZWFtL3Jlc291cmNlcy9zZHAtdXRpbHMuanMKQEAgLTE1LDcgKzE1LDcgQEAKICAgICAgICAgICAg ICJtaWQiOiAiXmE9bWlkOihbISMkJSYnKistLlxcd10qKS4qJCIsCiAgICAgICAgICAgICAibXNp ZCI6ICJeYT0oc3NyYzpcXGQrICk/bXNpZDooW1xcdysvXFwtPV0rKSArKFtcXHcrL1xcLT1dKyku KiQiLAogICAgICAgICAgICAgImljZXVmcmFnIjogIl5hPWljZS11ZnJhZzooW1xcdysvXSopLiok IiwKLSAgICAgICAgICAgICJpY2Vwd2QiOiAiXmE9aWNlLXB3ZDooW1xcdysvXSo9KikuKiQiLAor ICAgICAgICAgICAgImljZXB3ZCI6ICJeYT1pY2UtcHdkOihbXFx3Ky9dKikuKiQiLAogICAgICAg ICB9OwogCiAgICAgICAgIHZhciBtZGVzY0luZGV4ID0gLTE7Cg== 282333 2016-06-29 02:02:57 -0700 2016-06-29 10:06:40 -0700 Patch bug-159207-20160629110238.patch text/plain 5078 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1YTM0NzNhNDFjZjdi NGY1NDY0OGJhM2YyZmVjZmVhZDFmZTFhMC4uZTYwNDgxMzZmY2ViYTJiZDk0NjJkZGUyZWI0N2Y1 MmNhOWFkMDcxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTA2LTI5ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYlJUQzogaWNl LWNoYXIgY2FuIG5vdCBjb250YWluICc9JyBjaGFyYWN0ZXJzIGZvciBjcmVkZW50aWFscworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MjA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRlZCB0aGUg Z2VuZXJhbCBjYWxjdWxhdGlvbiB0byBnZXQgYSBiYXNlNjQgd2l0aG91dCBwYWRkaW5nCisgICAg ICAgIHdoaWNoIHdhcyB3cm9uZyBpbiB0aGUgcmFuZG9tU3RyaW5nIGZ1bmN0aW9uLiBFYWNoIHBh cmFtZXRlciB1c2luZworICAgICAgICB0aGUgZnVuY3Rpb24gcmVxdWlyZXMgYSBkaWZmZXJlbnQg c2V0dXAgZGVwZW5kaW5nIG9mIHRoZQorICAgICAgICBzcGVjaWZpY2F0aW9uIGFuZCB0aGlzIGlz IG5vdCBhIGdlbmVyYWwgQVBJLCBpdCBpcyBhIGJldHRlcgorICAgICAgICBzb2x1dGlvbiB0byBj YWxjdWxhdGUgYW5kIHN0b3JlIHRoZSBzaXplcyB3ZSB3YW50IHRvIHVzZSwgY29tbWVudAorICAg ICAgICB0aGVtIGFuZCB0ZXN0IHRoZW0sIGNvbnNpZGVyaW5nIHdlIHVzZSBiYXNlNjQgdG8gZ2Vu ZXJhdGUgdGhlCisgICAgICAgIHN0cmluZ3Mgd2UganVzdCBuZWVkIHRvIGF2b2lkIHBhZGRpbmcu CisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0IG1vZGlmaWVkIHRvIG1hdGNoIHRo ZSBjb3JyZWN0IGJlaGF2aW9yLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRp YUVuZHBvaW50UGVlckNvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmFuZG9tU3Ry aW5nKTogTm93IHRoZSBzaXplIGlzIHRoZSBvbmUgcGFzc2VkLgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uOjpNZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24p OgorICAgICAgICBVc2VkIGRpZmZlcmVudCB2YWxpZCB2YWx1ZXMgZm9sbG93aW5nIHRoZSBzZHAg cGFyc2VyIGluIGVhY2ggY2FzZS4KKwogMjAxNi0wNi0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTk4NzgyLCByMjAx MDQzKTogW2ltYWdlLWRlY29kZXJzXSBGbGlja2VyaW5nIHdpdGggc29tZSBhbmltYXRlZCBnaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFFbmRw b2ludFBlZXJDb25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcAppbmRleCBlYjUzODE4NmQ5MTA3ZGEx NDhmNDBjOTI3N2UyZDdkNGFjZDEyZWUyLi5lN2E1YmZhMzE1NGNhYjkyN2JhMjA1ZTliYTM5NGQ5 NmMzZWEzOWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uY3BwCkBAIC01Myw2 ICs1MywxMyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiB1c2luZyBuYW1lc3BhY2UgUGVlckNvbm5l Y3Rpb247CiB1c2luZyBuYW1lc3BhY2UgUGVlckNvbm5lY3Rpb25TdGF0ZXM7CiAKKy8vIFdlIHVz ZSBiYXNlNjQgdG8gZ2VuZXJhdGUgdGhlIHJhbmRvbSBzdHJpbmdzIHNvIHdlIG5lZWQgYSBzaXpl IHRoYXQgYXZvaWRzIHBhZGRpbmcgdG8gZ2V0IGljZS1jaGFycy4KK3N0YXRpYyBjb25zdCBzaXpl X3QgY25hbWVTaXplID0gMTg7CisvLyBTaXplIHJhbmdlIGZyb20gNCB0byAyNTYgaWNlLWNoYXJz IGRlZmluZWQgaW4gUkZDIDUyNDUuCitzdGF0aWMgY29uc3Qgc2l6ZV90IGljZVVmcmFnU2l6ZSA9 IDY7CisvLyBTaXplIHJhbmdlIGZyb20gMjIgdG8gMjU2IGljZS1jaGFycyBkZWZpbmVkIGluIFJG QyA1MjQ1Lgorc3RhdGljIGNvbnN0IHNpemVfdCBpY2VQYXNzd29yZFNpemUgPSAyNDsKKwogc3Rh dGljIHN0ZDo6dW5pcXVlX3B0cjxQZWVyQ29ubmVjdGlvbkJhY2tlbmQ+IGNyZWF0ZU1lZGlhRW5k cG9pbnRQZWVyQ29ubmVjdGlvbihQZWVyQ29ubmVjdGlvbkJhY2tlbmRDbGllbnQqIGNsaWVudCkK IHsKICAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRyPFBlZXJDb25uZWN0aW9uQmFja2VuZD4obmV3 IE1lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbihjbGllbnQpKTsKQEAgLTYwLDkgKzY3LDggQEAg c3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxQZWVyQ29ubmVjdGlvbkJhY2tlbmQ+IGNyZWF0ZU1lZGlh RW5kcG9pbnRQZWVyQ29ubmVjdGlvbigKIAogQ3JlYXRlUGVlckNvbm5lY3Rpb25CYWNrZW5kIFBl ZXJDb25uZWN0aW9uQmFja2VuZDo6Y3JlYXRlID0gY3JlYXRlTWVkaWFFbmRwb2ludFBlZXJDb25u ZWN0aW9uOwogCi1zdGF0aWMgU3RyaW5nIHJhbmRvbVN0cmluZyhzaXplX3QgbGVuZ3RoKQorc3Rh dGljIFN0cmluZyByYW5kb21TdHJpbmcoc2l6ZV90IHNpemUpCiB7Ci0gICAgY29uc3Qgc2l6ZV90 IHNpemUgPSBjZWlsKGxlbmd0aCAqIDMgLyA0KTsKICAgICB1bnNpZ25lZCBjaGFyIHJhbmRvbVZh bHVlc1tzaXplXTsKICAgICBjcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlcyhyYW5kb21WYWx1 ZXMsIHNpemUpOwogICAgIHJldHVybiBiYXNlNjRFbmNvZGUocmFuZG9tVmFsdWVzLCBzaXplKTsK QEAgLTcxLDkgKzc3LDkgQEAgc3RhdGljIFN0cmluZyByYW5kb21TdHJpbmcoc2l6ZV90IGxlbmd0 aCkKIE1lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbjo6TWVkaWFFbmRwb2ludFBlZXJDb25uZWN0 aW9uKFBlZXJDb25uZWN0aW9uQmFja2VuZENsaWVudCogY2xpZW50KQogICAgIDogbV9jbGllbnQo Y2xpZW50KQogICAgICwgbV9zZHBQcm9jZXNzb3Ioc3RkOjp1bmlxdWVfcHRyPFNEUFByb2Nlc3Nv cj4obmV3IFNEUFByb2Nlc3NvcihtX2NsaWVudC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKSkp Ci0gICAgLCBtX2NuYW1lKHJhbmRvbVN0cmluZygxNikpCi0gICAgLCBtX2ljZVVmcmFnKHJhbmRv bVN0cmluZyg0KSkKLSAgICAsIG1faWNlUGFzc3dvcmQocmFuZG9tU3RyaW5nKDIyKSkKKyAgICAs IG1fY25hbWUocmFuZG9tU3RyaW5nKGNuYW1lU2l6ZSkpCisgICAgLCBtX2ljZVVmcmFnKHJhbmRv bVN0cmluZyhpY2VVZnJhZ1NpemUpKQorICAgICwgbV9pY2VQYXNzd29yZChyYW5kb21TdHJpbmco aWNlUGFzc3dvcmRTaXplKSkKIHsKICAgICBtX21lZGlhRW5kcG9pbnQgPSBNZWRpYUVuZHBvaW50 OjpjcmVhdGUoKnRoaXMpOwogICAgIEFTU0VSVChtX21lZGlhRW5kcG9pbnQpOwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhm NmM0MDZmNTNkOTFmYzIzYzUzYjM2YTIzNjBiNjllNjI1N2M0NTguLjFjOGM4Zjk0YzkxM2RlNWFm ZDY5Y2NjNWZjYzQzY2Y5M2ZiODkwZTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wNi0y OSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJS VEM6IGljZS1jaGFyIGNhbiBub3QgY29udGFpbiAnPScgY2hhcmFjdGVycyBmb3IgY3JlZGVudGlh bHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTIw NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlm aWVkIHRoZSBwYXJzZXIgdG8gbWFrZSB0aGUgcmVnZXhwIHNpbWlsYXIgdG8gdGhlIG9uZSB3ZSBo YXZlCisgICAgICAgIGluIFdlYkNvcmUuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL3Jl c291cmNlcy9zZHAtdXRpbHMuanM6CisgICAgICAgIChwcmludENvbXBhcmFibGVTZXNzaW9uRGVz Y3JpcHRpb24pOgorCiAyMDE2LTA2LTI4ICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNv bT4KIAogICAgICAgICBBWDogQWRkIGFjY2Vzc2liaWxpdHkgdGVzdHMgZm9yIE1hdGhNTCBvcGVy YXRvcnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vcmVzb3VyY2Vz L3NkcC11dGlscy5qcyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vcmVzb3VyY2VzL3Nk cC11dGlscy5qcwppbmRleCBiNjMyZDA1ZGYzN2FlYzg4Yjc0OGMyM2Q4ODFlZjE4Mzk0MGUzZmYw Li5jNDM2M2JiMjk1OGIzNmI2NjMxNmQzOWJkZTc4NTJmMTkyM2IzOWRhIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL3Jlc291cmNlcy9zZHAtdXRpbHMuanMKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9yZXNvdXJjZXMvc2RwLXV0aWxzLmpzCkBAIC0x NSw3ICsxNSw3IEBACiAgICAgICAgICAgICAibWlkIjogIl5hPW1pZDooWyEjJCUmJyorLS5cXHdd KikuKiQiLAogICAgICAgICAgICAgIm1zaWQiOiAiXmE9KHNzcmM6XFxkKyApP21zaWQ6KFtcXHcr L1xcLT1dKykgKyhbXFx3Ky9cXC09XSspLiokIiwKICAgICAgICAgICAgICJpY2V1ZnJhZyI6ICJe YT1pY2UtdWZyYWc6KFtcXHcrL10qKS4qJCIsCi0gICAgICAgICAgICAiaWNlcHdkIjogIl5hPWlj ZS1wd2Q6KFtcXHcrL10qPSopLiokIiwKKyAgICAgICAgICAgICJpY2Vwd2QiOiAiXmE9aWNlLXB3 ZDooW1xcdysvXSopLiokIiwKICAgICAgICAgfTsKIAogICAgICAgICB2YXIgbWRlc2NJbmRleCA9 IC0xOwo= 282355 2016-06-29 10:06:47 -0700 2016-06-29 10:36:55 -0700 Patch for landing bug-159207-20160629190627.patch text/plain 5032 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk2NDI1YWMxODBkNjZm MTUyYzE5YjYzNzg2ODY3ODlkNjlmMDc3OC4uOTU5NTBjNjMzNzFlOTE3YTQ3ZTVjMTg0ZDZlNWU5 ZTY4ZjJhM2Y2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTA2LTI5ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYlJUQzogaWNl LWNoYXIgY2FuIG5vdCBjb250YWluICc9JyBjaGFyYWN0ZXJzIGZvciBjcmVkZW50aWFscworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MjA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIEF2b2lkIGEgZ2VuZXJh bCBjYWxjdWxhdGlvbiB0byBnZXQgYSBiYXNlNjQgd2l0aG91dCBwYWRkaW5nIHdoaWNoCisgICAg ICAgIHdhcyB3cm9uZyBpbiB0aGUgcmFuZG9tU3RyaW5nIGZ1bmN0aW9uLiBCZWNhdXNlIGVhY2gg cGFyYW1ldGVyCisgICAgICAgIHVzaW5nIHRoZSBmdW5jdGlvbiByZXF1aXJlcyBhIGRpZmZlcmVu dCBzZXR1cCBkZXBlbmRpbmcgb2YgdGhlCisgICAgICAgIHNwZWNpZmljYXRpb24gYW5kIHRoaXMg aXMgbm90IGEgZ2VuZXJhbCBBUEksIGl0IGlzIGEgYmV0dGVyCisgICAgICAgIHNvbHV0aW9uIHRv IGNhbGN1bGF0ZSBhbmQgc3RvcmUgdGhlIHNpemVzIHdlIHdhbnQgdG8gdXNlLCBjb21tZW50Cisg ICAgICAgIHRoZW0gYW5kIHRlc3QgdGhlbSwgY29uc2lkZXJpbmcgd2UgdXNlIGJhc2U2NCB0byBn ZW5lcmF0ZSB0aGUKKyAgICAgICAgc3RyaW5ncyB3ZSBqdXN0IG5lZWQgdG8gYXZvaWQgcGFkZGlu Zy4KKworICAgICAgICBFeGlzdGluZyB0ZXN0IG1vZGlmaWVkIHRvIG1hdGNoIHRoZSBjb3JyZWN0 IGJlaGF2aW9yLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50 UGVlckNvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmFuZG9tU3RyaW5nKTogTm93 IHRoZSBzaXplIGlzIHRoZSBvbmUgcGFzc2VkLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbmRw b2ludFBlZXJDb25uZWN0aW9uOjpNZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24pOgorICAgICAg ICBVc2VkIGRpZmZlcmVudCB2YWxpZCB2YWx1ZXMgZm9sbG93aW5nIHRoZSBzZHAgcGFyc2VyIGlu IGVhY2ggY2FzZS4KKwogMjAxNi0wNi0yOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gJ2lucHV0JyBldmVudCBoYW5kbGVyIGZvciBpbnB1 dFt0eXBlPWNvbG9yXSBjaGFuZ2VzIHRoZSBpbnB1dCB0eXBlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVy Q29ubmVjdGlvbi5jcHAKaW5kZXggYzFlNmI3NGY5YjUyNDg5MjcyZGQ5MzVhYzI3MmJhODhmYzI1 YTY4Yi4uN2E0MTk3Mjg3ODJhMzA5N2MyNDA2YTdkYzhlMDRhZTdlMmRmY2E0MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNv bm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVk aWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcApAQCAtNTMsNiArNTMsMTMgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIFBlZXJDb25uZWN0aW9uOwogdXNpbmcgbmFtZXNw YWNlIFBlZXJDb25uZWN0aW9uU3RhdGVzOwogCisvLyBXZSB1c2UgYmFzZTY0IHRvIGdlbmVyYXRl IHRoZSByYW5kb20gc3RyaW5ncyBzbyB3ZSBuZWVkIGEgc2l6ZSB0aGF0IGF2b2lkcyBwYWRkaW5n IHRvIGdldCBpY2UtY2hhcnMuCitzdGF0aWMgY29uc3Qgc2l6ZV90IGNuYW1lU2l6ZSA9IDE4Owor Ly8gU2l6ZSByYW5nZSBmcm9tIDQgdG8gMjU2IGljZS1jaGFycyBkZWZpbmVkIGluIFJGQyA1MjQ1 Lgorc3RhdGljIGNvbnN0IHNpemVfdCBpY2VVZnJhZ1NpemUgPSA2OworLy8gU2l6ZSByYW5nZSBm cm9tIDIyIHRvIDI1NiBpY2UtY2hhcnMgZGVmaW5lZCBpbiBSRkMgNTI0NS4KK3N0YXRpYyBjb25z dCBzaXplX3QgaWNlUGFzc3dvcmRTaXplID0gMjQ7CisKIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8 UGVlckNvbm5lY3Rpb25CYWNrZW5kPiBjcmVhdGVNZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24o UGVlckNvbm5lY3Rpb25CYWNrZW5kQ2xpZW50KiBjbGllbnQpCiB7CiAgICAgcmV0dXJuIHN0ZDo6 dW5pcXVlX3B0cjxQZWVyQ29ubmVjdGlvbkJhY2tlbmQ+KG5ldyBNZWRpYUVuZHBvaW50UGVlckNv bm5lY3Rpb24oY2xpZW50KSk7CkBAIC02MCw5ICs2Nyw4IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9w dHI8UGVlckNvbm5lY3Rpb25CYWNrZW5kPiBjcmVhdGVNZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rp b24oCiAKIENyZWF0ZVBlZXJDb25uZWN0aW9uQmFja2VuZCBQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6 OmNyZWF0ZSA9IGNyZWF0ZU1lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbjsKIAotc3RhdGljIFN0 cmluZyByYW5kb21TdHJpbmcoc2l6ZV90IGxlbmd0aCkKK3N0YXRpYyBTdHJpbmcgcmFuZG9tU3Ry aW5nKHNpemVfdCBzaXplKQogewotICAgIGNvbnN0IHNpemVfdCBzaXplID0gY2VpbChsZW5ndGgg KiAzIC8gNCk7CiAgICAgdW5zaWduZWQgY2hhciByYW5kb21WYWx1ZXNbc2l6ZV07CiAgICAgY3J5 cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXMocmFuZG9tVmFsdWVzLCBzaXplKTsKICAgICByZXR1 cm4gYmFzZTY0RW5jb2RlKHJhbmRvbVZhbHVlcywgc2l6ZSk7CkBAIC03Miw5ICs3OCw5IEBAIE1l ZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbjo6TWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uKFBl ZXJDb25uZWN0aW9uQmFja2VuZENsCiAgICAgOiBtX2NsaWVudChjbGllbnQpCiAgICAgLCBtX21l ZGlhRW5kcG9pbnQoTWVkaWFFbmRwb2ludDo6Y3JlYXRlKCp0aGlzKSkKICAgICAsIG1fc2RwUHJv Y2Vzc29yKHN0ZDo6dW5pcXVlX3B0cjxTRFBQcm9jZXNzb3I+KG5ldyBTRFBQcm9jZXNzb3IobV9j bGllbnQtPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkpKQotICAgICwgbV9jbmFtZShyYW5kb21T dHJpbmcoMTYpKQotICAgICwgbV9pY2VVZnJhZyhyYW5kb21TdHJpbmcoNCkpCi0gICAgLCBtX2lj ZVBhc3N3b3JkKHJhbmRvbVN0cmluZygyMikpCisgICAgLCBtX2NuYW1lKHJhbmRvbVN0cmluZyhj bmFtZVNpemUpKQorICAgICwgbV9pY2VVZnJhZyhyYW5kb21TdHJpbmcoaWNlVWZyYWdTaXplKSkK KyAgICAsIG1faWNlUGFzc3dvcmQocmFuZG9tU3RyaW5nKGljZVBhc3N3b3JkU2l6ZSkpCiB7CiAg ICAgQVNTRVJUKG1fbWVkaWFFbmRwb2ludCk7CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiZDRhZGM2MzY1NTdkYWIzNTc0 MTJmNGM5ZmEzZjQ5YmZmNTE3YWRkLi4yZjEzOGZiOGY1ODVhZmY5NTE3MDI0MTlkZGExODM1ZWEw MDJhYTgwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDYtMjkgIEFsZWphbmRybyBHLiBD YXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViUlRDOiBpY2UtY2hhciBjYW4g bm90IGNvbnRhaW4gJz0nIGNoYXJhY3RlcnMgZm9yIGNyZWRlbnRpYWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkyMDcKKworICAgICAgICBSZXZp ZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgTW9kaWZpZWQgdGhlIHBhcnNlciB0byBt YWtlIHRoZSByZWdleHAgc2ltaWxhciB0byB0aGUgb25lIHdlIGhhdmUKKyAgICAgICAgaW4gV2Vi Q29yZS4KKworICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vcmVzb3VyY2VzL3NkcC11dGlscy5q czoKKyAgICAgICAgKHByaW50Q29tcGFyYWJsZVNlc3Npb25EZXNjcmlwdGlvbik6CisKIDIwMTYt MDYtMjkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFz aCB3aGVuICdpbnB1dCcgZXZlbnQgaGFuZGxlciBmb3IgaW5wdXRbdHlwZT1jb2xvcl0gY2hhbmdl cyB0aGUgaW5wdXQgdHlwZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVh bS9yZXNvdXJjZXMvc2RwLXV0aWxzLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9y ZXNvdXJjZXMvc2RwLXV0aWxzLmpzCmluZGV4IGI2MzJkMDVkZjM3YWVjODhiNzQ4YzIzZDg4MWVm MTgzOTQwZTNmZjAuLmM0MzYzYmIyOTU4YjM2YjY2MzE2ZDM5YmRlNzg1MmYxOTIzYjM5ZGEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vcmVzb3VyY2VzL3NkcC11dGls cy5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL3Jlc291cmNlcy9zZHAtdXRp bHMuanMKQEAgLTE1LDcgKzE1LDcgQEAKICAgICAgICAgICAgICJtaWQiOiAiXmE9bWlkOihbISMk JSYnKistLlxcd10qKS4qJCIsCiAgICAgICAgICAgICAibXNpZCI6ICJeYT0oc3NyYzpcXGQrICk/ bXNpZDooW1xcdysvXFwtPV0rKSArKFtcXHcrL1xcLT1dKykuKiQiLAogICAgICAgICAgICAgImlj ZXVmcmFnIjogIl5hPWljZS11ZnJhZzooW1xcdysvXSopLiokIiwKLSAgICAgICAgICAgICJpY2Vw d2QiOiAiXmE9aWNlLXB3ZDooW1xcdysvXSo9KikuKiQiLAorICAgICAgICAgICAgImljZXB3ZCI6 ICJeYT1pY2UtcHdkOihbXFx3Ky9dKikuKiQiLAogICAgICAgICB9OwogCiAgICAgICAgIHZhciBt ZGVzY0luZGV4ID0gLTE7Cg==