159206 2016-06-28 03:06:06 -0700 [EFL] Fix build when media-stream is enabled. 2016-07-08 00:05:50 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1205977 0 hs85.jeong 2016-06-28 03:06:06 -0700 lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp.o):RealtimeMediaSourceCenterOwr.cpp:function WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints(WebCore::MediaStreamCreationClient*, WTF::RefPtr<WebCore::MediaConstraints>&, WTF::RefPtr<WebCore::MediaConstraints>&): error: undefined reference to 'owr_get_capture_sources' lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp.o):RealtimeMediaSourceCenterOwr.cpp:function WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable(_GList*): error: undefined reference to 'owr_media_source_get_type' lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/mediastream/openwebrtc/OpenWebRTCUtilities.cpp.o):OpenWebRTCUtilities.cpp:function WebCore::initializeOpenWebRTC(): error: undefined reference to 'owr_init' collect2: error: ld returned 1 exit status 1205981 1 hs85.jeong 2016-06-28 03:18:08 -0700 PkgConfig fails to find the OPENWEBRTC package. -- checking for modules 'openwebrtc-0.3;openwebrtc-gst-0.3' -- package 'openwebrtc-0.3' not found -- package 'openwebrtc-gst-0.3' not found -- Could NOT find OPENWEBRTC (missing: OPENWEBRTC_INCLUDE_DIRS OPENWEBRTC_LIBRARIES) 1207768 2 282756 hs85.jeong 2016-07-05 00:59:24 -0700 Created attachment 282756 Patch 1208053 3 282756 gyuyoung.kim 2016-07-05 19:46:00 -0700 Comment on attachment 282756 Patch LGTM. Then can we enable media-stream feature now ? 1208105 4 hs85.jeong 2016-07-06 00:19:18 -0700 (In reply to comment #3) > Comment on attachment 282756 [details] > Patch > > LGTM. Then can we enable media-stream feature now ? No,, I test the fast/mediastream tests with media-stream. But 25 tests ran as expected, 48 didn't. So we need more time to enable the mediastream. 1208987 5 282756 commit-queue 2016-07-08 00:05:46 -0700 Comment on attachment 282756 Patch Clearing flags on attachment: 282756 Committed r202969: <http://trac.webkit.org/changeset/202969> 1208988 6 commit-queue 2016-07-08 00:05:50 -0700 All reviewed patches have been landed. Closing bug. 282756 2016-07-05 00:59:24 -0700 2016-07-08 00:05:46 -0700 Patch bug-159206-20160705165854.patch text/plain 4074 hs85.jeong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjgxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA3LTA0ICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGQgd2hlbiBtZWRpYS1zdHJlYW0gaXMgZW5h YmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 OTIwNgorCisgICAgICAgIEJ1bXAgdXAgdGhlIG9wZW53ZWJydGMgdG8gZmluZCB0aGUgY29ycmVj dCBwYWNrYWdlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZWZsL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAgKiBlZmwvcGF0Y2hlcy9vcGVud2Vi cnRjLWNsYW5nLXdhcm5pbmctZml4LnBhdGNoOiBSZW1vdmVkLgorCiAyMDE2LTA3LTA0ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJQcm9jZXNzZXMgZG9u J3QgaGFuZGxlIERhdGFiYXNlUHJvY2VzcyBnb2luZyBhd2F5IHVuY2xlYW5seS4uCkluZGV4OiBU b29scy9lZmwvamhidWlsZC5tb2R1bGVzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2VmbC9qaGJ1aWxk Lm1vZHVsZXMJKHJldmlzaW9uIDIwMjc5NSkKKysrIFRvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMJ KHdvcmtpbmcgY29weSkKQEAgLTMxMCw5ICszMTAsOSBAQAogICAgIDxkZXBlbmRlbmNpZXM+CiAg ICAgICA8ZGVwIHBhY2thZ2U9ImdzdHJlYW1lciIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgotICAg IDxicmFuY2ggcmVwbz0ibmljZS5mcmVlZGVza3RvcC5vcmciIG1vZHVsZT0icmVsZWFzZXMvbGli bmljZS0wLjEuMTAudGFyLmd6IiBjaGVja291dGRpcj0ibGlibmljZSIgdmVyc2lvbj0iMC4xLjEw IgotICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjFkYmZiNjYzYjczMDg4OWFlOGNhYjEzYTI5MTNm ZTU1N2Q1ODFmNzBiNTEzYzkxOGJiYmQwYjdkM2VlZmViYzkiCi0gICAgICAgICAgICBtZDVzdW09 IjI3YjYyZDAwOTNjZTI5YTM5ZGYxYzZmY2YwYmI0Mzk2IiBzaXplPSI5MDMwODMiPgorICAgIDxi cmFuY2ggcmVwbz0ibmljZS5mcmVlZGVza3RvcC5vcmciIG1vZHVsZT0icmVsZWFzZXMvbGlibmlj ZS0wLjEuMTMudGFyLmd6IiBjaGVja291dGRpcj0ibGlibmljZSIgdmVyc2lvbj0iMC4xLjEzIgor ICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjYxMTEyZDlmM2JlOTMzYTgyN2M4MzY1ZjIwNTUxNTYz OTUzYWY2NzE4MDU3OTI4ZjUxZjQ4N2JmZTg4NDE5ZTEiCisgICAgICAgICAgICBtZDVzdW09IjMy MjZmYWVhZjQ4YTkxNTBhZGEwMGRhMmUyODY1OTU5IiBzaXplPSI5MTIzNzQiPgogICAgIDwvYnJh bmNoPgogICA8L2F1dG90b29scz4KIApAQCAtMzIxLDEwICszMjEsOSBAQAogICAgICAgPGRlcCBw YWNrYWdlPSJnc3QtcGx1Z2lucy1vcGVud2VicnRjIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9Imxp Ym5pY2UiLz4KICAgICAgPC9kZXBlbmRlbmNpZXM+Ci0gICAgPGJyYW5jaCByZXBvPSJnaXRodWIu Y29tIiBtb2R1bGU9IkVyaWNzc29uUmVzZWFyY2gvb3BlbndlYnJ0Yy9hcmNoaXZlLzEzNTE2Yzdm NzlhMGM0OGJiNDExNDY0Zjc2MTNkNGI0MjZjNzBmNWIudGFyLmd6IiBjaGVja291dGRpcj0ib3Bl bndlYnJ0YyIgdmVyc2lvbj0iMTM1MTZjN2Y3OWEwYzQ4YmI0MTE0NjRmNzYxM2Q0YjQyNmM3MGY1 YiIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1NjpjODQ5ZDM2ZDk3YzE3YTE5OGE1ZDljMTgwZjEz ZjE0Yzc4OTdjOTIzNmUyMzg0ZWExMTAyOWUyM2IwOWI1OWFjIgotICAgICAgICAgICAgbWQ1c3Vt PSIxMzUxNmM3Zjc5YTBjNDhiYjQxMTQ2NGY3NjEzZDRiNDI2YzcwZjViLnRhci5neiIgc2l6ZT0i MjU4OTM2Ij4KLSAgICAgIDxwYXRjaCBmaWxlPSJvcGVud2VicnRjLWNsYW5nLXdhcm5pbmctZml4 LnBhdGNoIiBzdHJpcD0iMSIvPgorICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIgbW9kdWxl PSJFcmljc3NvblJlc2VhcmNoL29wZW53ZWJydGMvYXJjaGl2ZS9mNTExZWExZmE3OWEzM2ZhM2Q1 MmJmZDFjMDk2OWMyODA4NGFlYjM1LnRhci5neiIgY2hlY2tvdXRkaXI9Im9wZW53ZWJydGMiIHZl cnNpb249ImY1MTFlYTFmYTc5YTMzZmEzZDUyYmZkMWMwOTY5YzI4MDg0YWViMzUiCisgICAgICAg ICAgICBoYXNoPSJzaGEyNTY6YWY4MGI4MDUxMmI1ZjVhNmI4MmI0Y2Y0M2FmYTI4ZGE5Yzk0Yzg2 ODAwZjZmYWRkMTA3NjIzNjEwNzlmYjVlMyIKKyAgICAgICAgICAgIG1kNXN1bT0iNDU1NWQyMDgy MWFmOGY1MzM0Zjc0YjRmMDMyN2YxNzgiIHNpemU9IjI5NjE0MyI+CiAgICAgPC9icmFuY2g+CiAg IDwvYXV0b3Rvb2xzPgogCkluZGV4OiBUb29scy9lZmwvcGF0Y2hlcy9vcGVud2VicnRjLWNsYW5n LXdhcm5pbmctZml4LnBhdGNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2VmbC9wYXRjaGVzL29wZW53 ZWJydGMtY2xhbmctd2FybmluZy1maXgucGF0Y2gJKHJldmlzaW9uIDIwMjc5NSkKKysrIFRvb2xz L2VmbC9wYXRjaGVzL29wZW53ZWJydGMtY2xhbmctd2FybmluZy1maXgucGF0Y2gJKHdvcmtpbmcg Y29weSkKQEAgLTEsNDggKzAsMCBAQAotZGlmZiAtLWdpdCBhL2dzdC9NYWtlZmlsZS5hbSBiL2dz dC9NYWtlZmlsZS5hbQotaW5kZXggZDBlMDA2Mi4uZDRiY2NlYSAxMDA2NDQKLS0tLSBhL2dzdC9N YWtlZmlsZS5hbQotKysrIGIvZ3N0L01ha2VmaWxlLmFtCi1AQCAtMTMsNiArMTMsNyBAQCBBTV9D RkxBR1MgPSBcCi0gICAgIC1XYWxsIFwKLSAgICAgLVdleHRyYSBcCi0gICAgIC1XZXJyb3IgXAot KyAgICAtV25vLXBhcmVudGhlc2VzLWVxdWFsaXR5IFwKLSAgICAgJChERUJVR19DRkxBR1MpCi0g Ci0gbGliX0xUTElCUkFSSUVTID0gbGlib3BlbndlYnJ0Y19nc3QubGEKLWRpZmYgLS1naXQgYS9s b2NhbC9NYWtlZmlsZS5hbSBiL2xvY2FsL01ha2VmaWxlLmFtCi1pbmRleCBlMmU3ODc2Li5jNmRj MmY3IDEwMDY0NAotLS0tIGEvbG9jYWwvTWFrZWZpbGUuYW0KLSsrKyBiL2xvY2FsL01ha2VmaWxl LmFtCi1AQCAtMTMsNiArMTMsNyBAQCBBTV9DRkxBR1MgPSBcCi0gICAgIC1XYWxsIFwKLSAgICAg LVdleHRyYSBcCi0gICAgIC1XZXJyb3IgXAotKyAgICAtV25vLXBhcmVudGhlc2VzLWVxdWFsaXR5 IFwKLSAgICAgJChERUJVR19DRkxBR1MpCi0gCi0gbm9pbnN0X0xUTElCUkFSSUVTID0gbGlib3Bl bndlYnJ0Y19sb2NhbC5sYQotZGlmZiAtLWdpdCBhL293ci9NYWtlZmlsZS5hbSBiL293ci9NYWtl ZmlsZS5hbQotaW5kZXggMmFmNDczNS4uZGMzZjFmMiAxMDA2NDQKLS0tLSBhL293ci9NYWtlZmls ZS5hbQotKysrIGIvb3dyL01ha2VmaWxlLmFtCi1AQCAtMTQsNiArMTQsNyBAQCBBTV9DRkxBR1Mg PSBcCi0gICAgIC1XYWxsIFwKLSAgICAgLVdleHRyYSBcCi0gICAgIC1XZXJyb3IgXAotKyAgICAt V25vLXBhcmVudGhlc2VzLWVxdWFsaXR5IFwKLSAgICAgJChERUJVR19DRkxBR1MpCi0gCi0gbGli X0xUTElCUkFSSUVTID0gbGlib3BlbndlYnJ0Yy5sYQotZGlmZiAtLWdpdCBhL3RyYW5zcG9ydC9N YWtlZmlsZS5hbSBiL3RyYW5zcG9ydC9NYWtlZmlsZS5hbQotaW5kZXggMzE0ZWE1My4uNWI1Yzc0 OSAxMDA2NDQKLS0tLSBhL3RyYW5zcG9ydC9NYWtlZmlsZS5hbQotKysrIGIvdHJhbnNwb3J0L01h a2VmaWxlLmFtCi1AQCAtMTUsNiArMTUsNyBAQCBBTV9DRkxBR1MgPSBcCi0gICAgIC1XYWxsIFwK LSAgICAgLVdleHRyYSBcCi0gICAgIC1XZXJyb3IgXAotKyAgICAtV25vLXBhcmVudGhlc2VzLWVx dWFsaXR5IFwKLSAgICAgJChERUJVR19DRkxBR1MpCi0gCi0gbm9pbnN0X0xUTElCUkFSSUVTID0g bGlib3BlbndlYnJ0Y190cmFuc3BvcnQubGEK