159194 2016-06-27 23:09:53 -0700 [JSC] Fix build break since r202502 2019-05-02 16:22:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park ap commit-queue fpizlo gyuyoung.kim keith_miller malvika.editsoftdigital mark.lam msaboff saam oldest_to_newest 1205887 0 jh718.park 2016-06-27 23:09:53 -0700 Add missing ASSERT_NOT_REACHED(); to TypeMap::at(). 1205893 1 282214 jh718.park 2016-06-27 23:27:29 -0700 Created attachment 282214 Patch 1205903 2 282214 achristensen 2016-06-27 23:48:35 -0700 Comment on attachment 282214 Patch sure 1205906 3 282214 jh718.park 2016-06-27 23:50:06 -0700 Comment on attachment 282214 Patch Overall comments 1205923 4 282214 commit-queue 2016-06-28 00:10:20 -0700 Comment on attachment 282214 Patch Clearing flags on attachment: 282214 Committed r202553: <http://trac.webkit.org/changeset/202553> 1205924 5 commit-queue 2016-06-28 00:10:25 -0700 All reviewed patches have been landed. Closing bug. 1205929 6 gyuyoung.kim 2016-06-28 00:26:02 -0700 hmm...this patch missed below compiler option. I already waited for passing ews in bug 159193 :( #if COMPILER(GCC) && ASSERT_DISABLED #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wreturn-type" #endif // COMPILER(GCC) && ASSERT_DISABLED 1205930 7 jh718.park 2016-06-28 00:30:46 -0700 Reopening to attach new patch. 1205931 8 282218 jh718.park 2016-06-28 00:30:52 -0700 Created attachment 282218 Patch 1205933 9 jh718.park 2016-06-28 00:34:25 -0700 (In reply to comment #6) > hmm...this patch missed below compiler option. I already waited for passing > ews in bug 159193 :( > > #if COMPILER(GCC) && ASSERT_DISABLED > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wreturn-type" > #endif // COMPILER(GCC) && ASSERT_DISABLED I see. Isn't it needed to add below also? #if COMPILER(GCC) && ASSERT_DISABLED #pragma GCC diagnostic pop #endif // COMPILER(GCC) && ASSERT_DISABLED 1205935 10 282218 gyuyoung.kim 2016-06-28 00:37:37 -0700 Comment on attachment 282218 Patch r=me based on Bug 159193 and Bug 152887. 1205938 11 gyuyoung.kim 2016-06-28 00:38:19 -0700 *** Bug 159193 has been marked as a duplicate of this bug. *** 1205979 12 282218 commit-queue 2016-06-28 03:16:18 -0700 Comment on attachment 282218 Patch Clearing flags on attachment: 282218 Committed r202555: <http://trac.webkit.org/changeset/202555> 1205980 13 commit-queue 2016-06-28 03:16:24 -0700 All reviewed patches have been landed. Closing bug. 282214 2016-06-27 23:27:29 -0700 2016-06-28 00:30:37 -0700 Patch bug-159194-20160628152711.patch text/plain 1275 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MmQ2Yjg1ZjU4NTM0YWM3MGJiMzBlMTdiYTUyZDcyYmFhNTNiNDhmLi5kM2ZhMmFjMzBhZWQzNWY5 ZGU1MmRkYjQ0OGU1ODY2ZGVmZDcxMjNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNi0yNyAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIyMDI1MDIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTE5NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhYm91dCB0 aGUgZXJyb3IgbWVzc2FnZSBiZWxvdy4KKyAgICAgICAgZXJyb3I6IGNvbnRyb2wgcmVhY2hlcyBl bmQgb2Ygbm9uLXZvaWQgZnVuY3Rpb24gWy1XZXJyb3I9cmV0dXJuLXR5cGVdCisKKyAgICAgICAg KiBiMy9CM1R5cGVNYXAuaDoKKyAgICAgICAgKEpTQzo6QjM6OlR5cGVNYXA6OmF0KTogYWRkIG1p c3NpbmcgQVNTRVJUX05PVF9SRUFDSEVEKCkuCisKIDIwMTYtMDYtMjcgIEtlaXRoIE1pbGxlciAg PGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGJhZCBhc3NlcnQgaW4gU3Ry dWN0dXJlUmFyZURhdGE6OnNldE9iamVjdFRvU3RyaW5nVmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1R5cGVNYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My9CM1R5cGVNYXAuaAppbmRleCAzN2JkMGMzY2FmYTczN2Q4NTdmYTM1YTA0NGVkNmZlMDNmNDAw NTRjLi5lYTFmODE1ZjhmZDQ0ZGYxMzRmZWU5YjIyYzc1NWJiMmVmMTZjMjI1IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNUeXBlTWFwLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL0IzVHlwZU1hcC5oCkBAIC01OSw2ICs1OSw3IEBAIHB1YmxpYzoKICAgICAg ICAgY2FzZSBEb3VibGU6CiAgICAgICAgICAgICByZXR1cm4gbV9kb3VibGU7CiAgICAgICAgIH0K KyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogICAgIAogICAgIGNvbnN0IFQm IGF0KFR5cGUgdHlwZSkgY29uc3QK 282218 2016-06-28 00:30:52 -0700 2016-06-28 03:16:18 -0700 Patch bug-159194-20160628163034.patch text/plain 1643 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MmI5MGU2YTdkNGMyNGY5NDU5OGQzOTAyYjM0N2ZkOWJmYzFkMTE5Li5jNzYwNDBkMmZiZTBlZGUw N2RhOWMyMjIzN2NkNTgyNjI4ZDVjODc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNi0wNi0yOCAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CiAKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIGJyZWFrIHNpbmNlIHIyMDI1MDIgLSAy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkxOTQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYWJv dXQgdGhlIGVycm9yIG1lc3NhZ2UgYmVsb3cuCisgICAgICAgIGVycm9yOiBjb250cm9sIHJlYWNo ZXMgZW5kIG9mIG5vbi12b2lkIGZ1bmN0aW9uIFstV2Vycm9yPXJldHVybi10eXBlXQorCisgICAg ICAgICogYjMvQjNUeXBlTWFwLmg6IGFkZCAjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQg Ii1XcmV0dXJuLXR5cGUiLgorCisyMDE2LTA2LTI4ICBKb29uZ2h1biBQYXJrICA8amg3MTgucGFy a0BzYW1zdW5nLmNvbT4KKwogICAgICAgICBbSlNDXSBGaXggYnVpbGQgYnJlYWsgc2luY2UgcjIw MjUwMgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5 MTk0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1R5cGVNYXAuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1R5cGVNYXAuaAppbmRleCBlYTFmODE1ZjhmZDQ0 ZGYxMzRmZWU5YjIyYzc1NWJiMmVmMTZjMjI1Li5kYWE2NTI5ZTAxOTdhMjVhYTBiNmRhNGY5ZGQx OTNiZmZlMDJjMTEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNUeXBl TWFwLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzVHlwZU1hcC5oCkBAIC0zMSw2 ICszMSwxMSBAQAogI2luY2x1ZGUgIkIzVHlwZS5oIgogI2luY2x1ZGUgPHd0Zi9QcmludFN0cmVh bS5oPgogCisjaWYgQ09NUElMRVIoR0NDKSAmJiBBU1NFUlRfRElTQUJMRUQKKyNwcmFnbWEgR0ND IGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkICItV3JldHVy bi10eXBlIgorI2VuZGlmIC8vIENPTVBJTEVSKEdDQykgJiYgQVNTRVJUX0RJU0FCTEVECisKIG5h bWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgQjMgewogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgpAQCAt OTcsNiArMTAyLDEwIEBAIHByaXZhdGU6CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpCMwogCisj aWYgQ09NUElMRVIoR0NDKSAmJiBBU1NFUlRfRElTQUJMRUQKKyNwcmFnbWEgR0NDIGRpYWdub3N0 aWMgcG9wCisjZW5kaWYgLy8gQ09NUElMRVIoR0NDKSAmJiBBU1NFUlRfRElTQUJMRUQKKwogI2Vu ZGlmIC8vIEVOQUJMRShCM19KSVQpCiAKICNlbmRpZiAvLyBCM1R5cGVNYXBfaAo=