159193 2016-06-27 21:41:38 -0700 [JSC] Fix build warning since r202502 2019-05-02 16:22:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 159194 P2 Normal --- 1 gyuyoung.kim gyuyoung.kim ap commit-queue fpizlo keith_miller malvika.editsoftdigital mark.lam msaboff saam ysuzuki oldest_to_newest 1205868 0 gyuyoung.kim 2016-06-27 21:41:38 -0700 r202502 made a build warning because there is no default return value in TypeMap::at(). [107/4159] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3InsertionSet.cpp.o In file included from ../../Source/JavaScriptCore/b3/B3InsertionSet.h:33:0, from ../../Source/JavaScriptCore/b3/B3InsertionSet.cpp:27: ../../Source/JavaScriptCore/b3/B3TypeMap.h: In member function ‘T& JSC::B3::TypeMap<T>::at(JSC::B3::Type) [with T = JSC::B3::Value*]’: ../../Source/JavaScriptCore/b3/B3TypeMap.h:62:5: warning: control reaches end of non-void function [-Wreturn-type] } ^ 1205869 1 282210 gyuyoung.kim 2016-06-27 21:42:43 -0700 Created attachment 282210 Patch 1205870 2 ysuzuki 2016-06-27 22:02:03 -0700 I think we should fix this like that https://bugs.webkit.org/show_bug.cgi?id=152887. See the context. https://bugs.webkit.org/show_bug.cgi?id=150794#c7 1205875 3 282212 gyuyoung.kim 2016-06-27 22:23:56 -0700 Created attachment 282212 Patch 1205876 4 gyuyoung.kim 2016-06-27 22:24:35 -0700 (In reply to comment #2) > I think we should fix this like that > https://bugs.webkit.org/show_bug.cgi?id=152887. > See the context. https://bugs.webkit.org/show_bug.cgi?id=150794#c7 Looks like this fix is better than me. Fixed. 1205877 5 282212 ysuzuki 2016-06-27 22:26:33 -0700 Comment on attachment 282212 Patch r=me 1205932 6 282219 gyuyoung.kim 2016-06-28 00:33:10 -0700 Created attachment 282219 Patch 1205937 7 gyuyoung.kim 2016-06-28 00:38:19 -0700 *** This bug has been marked as a duplicate of bug 159194 *** 282210 2016-06-27 21:42:43 -0700 2016-06-27 22:23:49 -0700 Patch bug-159193-20160628134226.patch text/plain 1178 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MmQ2Yjg1ZjU4NTM0YWM3MGJiMzBlMTdiYTUyZDcyYmFhNTNiNDhmLi42Yzk2NjEwOGNlMjgyYzY5 MDg4ZDFhOGFiNTYwMDkxOWUwZDhmYWZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wNi0yNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIHdhcm5pbmcgc2luY2UgcjIwMjUwMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MTkzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiMy9CM1R5 cGVNYXAuaDogQWRkIGEgZGVmYXVsdCByZXR1cm4gdmFsdWUoaW50MzIpLgorICAgICAgICAoSlND OjpCMzo6VHlwZU1hcDo6YXQpOgorCiAyMDE2LTA2LTI3ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9t aWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBiYWQgYXNzZXJ0IGluIFN0cnVjdHVyZVJh cmVEYXRhOjpzZXRPYmplY3RUb1N0cmluZ1ZhbHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYjMvQjNUeXBlTWFwLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNUeXBl TWFwLmgKaW5kZXggMzdiZDBjM2NhZmE3MzdkODU3ZmEzNWEwNDRlZDZmZTAzZjQwMDU0Yy4uODll MmY5NDE0NzkwNmZhMjU2MWE5MDk1ZTQ0MWNhOGQyYTBjMmI1MSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2IzL0IzVHlwZU1hcC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9CM1R5cGVNYXAuaApAQCAtNTksNiArNTksOCBAQCBwdWJsaWM6CiAgICAgICAgIGNhc2Ug RG91YmxlOgogICAgICAgICAgICAgcmV0dXJuIG1fZG91YmxlOwogICAgICAgICB9CisgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gbV9pbnQzMjsKICAgICB9CiAg ICAgCiAgICAgY29uc3QgVCYgYXQoVHlwZSB0eXBlKSBjb25zdAo= 282212 2016-06-27 22:23:56 -0700 2016-06-28 00:33:03 -0700 Patch bug-159193-20160628142339.patch text/plain 1441 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MmQ2Yjg1ZjU4NTM0YWM3MGJiMzBlMTdiYTUyZDcyYmFhNTNiNDhmLi4xZDIxMTgwZTNiNzlmMmY0 N2NkZmI2MmZiMzhjOTkxOWNjNzQwZjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wNi0yNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIHdhcm5pbmcgc2luY2UgcjIwMjUwMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MTkzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiMy9CM1R5 cGVNYXAuaDogSWdub3JlIHJldHVybi10eXBlIGJ1aWxkIHdhcm5pbmcuCisgICAgICAgIChKU0M6 OkIzOjpUeXBlTWFwOjphdCk6CisKIDIwMTYtMDYtMjcgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21p bGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGJhZCBhc3NlcnQgaW4gU3RydWN0dXJlUmFy ZURhdGE6OnNldE9iamVjdFRvU3RyaW5nVmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy9CM1R5cGVNYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1R5cGVN YXAuaAppbmRleCAzN2JkMGMzY2FmYTczN2Q4NTdmYTM1YTA0NGVkNmZlMDNmNDAwNTRjLi5iYWRm NGExOWMxODBiZjZiYWIwNWI4ZWQ5OWMyMGJkNDIyZjZjOWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYjMvQjNUeXBlTWFwLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL0IzVHlwZU1hcC5oCkBAIC0zMSw2ICszMSwxMSBAQAogI2luY2x1ZGUgIkIzVHlwZS5oIgog I2luY2x1ZGUgPHd0Zi9QcmludFN0cmVhbS5oPgogCisjaWYgQ09NUElMRVIoR0NDKSAmJiBBU1NF UlRfRElTQUJMRUQKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBHQ0MgZGlh Z25vc3RpYyBpZ25vcmVkICItV3JldHVybi10eXBlIgorI2VuZGlmIC8vIENPTVBJTEVSKEdDQykg JiYgQVNTRVJUX0RJU0FCTEVECisKIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgQjMgewogCiB0 ZW1wbGF0ZTx0eXBlbmFtZSBUPgpAQCAtNTksNiArNjQsNyBAQCBwdWJsaWM6CiAgICAgICAgIGNh c2UgRG91YmxlOgogICAgICAgICAgICAgcmV0dXJuIG1fZG91YmxlOwogICAgICAgICB9CisgICAg ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KICAgICAKICAgICBjb25zdCBUJiBhdChU eXBlIHR5cGUpIGNvbnN0Cg== 282219 2016-06-28 00:33:10 -0700 2016-06-28 00:34:35 -0700 Patch bug-159193-20160628163253.patch text/plain 1217 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MmI5MGU2YTdkNGMyNGY5NDU5OGQzOTAyYjM0N2ZkOWJmYzFkMTE5Li44NGY1OGZhOTBkMWU1Zjky NTc0ODQwYWZhODVhMWI1YmIxNDZlZGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNi0yOCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gRml4IGJ1aWxkIHdhcm5pbmcgc2luY2UgcjIwMjUwMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MTkzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAgICAqIGIzL0IzVHlw ZU1hcC5oOiBJZ25vcmUgcmV0dXJuLXR5cGUgYnVpbGQgd2FybmluZywgd2hpY2ggbWlzc2VkIGlu IHIyMDI1NTMuCisKIDIwMTYtMDYtMjggIEpvb25naHVuIFBhcmsgIDxqaDcxOC5wYXJrQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtKU0NdIEZpeCBidWlsZCBicmVhayBzaW5jZSByMjAyNTAyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNUeXBlTWFwLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYjMvQjNUeXBlTWFwLmgKaW5kZXggZWExZjgxNWY4ZmQ0NGRmMTM0ZmVl OWIyMmM3NTViYjJlZjE2YzIyNS4uZTI2OTc1OTYxMjZkMzJiYmYwYjEzMWE1NmQyY2E5NDJjMjMy NGUwNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzVHlwZU1hcC5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1R5cGVNYXAuaApAQCAtMzMsNiArMzMsMTEg QEAKIAogbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBCMyB7CiAKKyNpZiBDT01QSUxFUihHQ0Mp ICYmIEFTU0VSVF9ESVNBQkxFRAorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21h IEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XcmV0dXJuLXR5cGUiCisjZW5kaWYgLy8gQ09NUElM RVIoR0NDKSAmJiBBU1NFUlRfRElTQUJMRUQKKwogdGVtcGxhdGU8dHlwZW5hbWUgVD4KIGNsYXNz IFR5cGVNYXAgewogcHVibGljOgo=