159171 2016-06-27 14:47:31 -0700 Fix bad assert in StructureRareData::setObjectToStringValue 2016-06-27 17:42:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1205720 0 keith_miller 2016-06-27 14:47:31 -0700 Fix bad assert in StructureRareData::setObjectToStringValue 1205721 1 282169 keith_miller 2016-06-27 14:48:56 -0700 Created attachment 282169 Patch 1205725 2 keith_miller 2016-06-27 14:56:53 -0700 rdar://problem/26987355 1205726 3 282170 keith_miller 2016-06-27 14:58:25 -0700 Created attachment 282170 Patch for landing 1205812 4 keith_miller 2016-06-27 17:42:47 -0700 Committed r202528: <http://trac.webkit.org/changeset/202528> 282169 2016-06-27 14:48:56 -0700 2016-06-27 14:58:22 -0700 Patch bug-159171-20160627144840.patch text/plain 3461 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTdiOTcyNTMxODhjZDk3ZTY3M2YwYWUyMTFhMTY2MzFhMmI5OWM4Li4wZjJiNzMzOTI2MTNlYjM0 ZjczNDMzZWQ3ZTlkZGYxZTI3NTdkNjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wNi0yNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggYmFkIGFzc2VydCBpbiBTdHJ1Y3R1cmVSYXJlRGF0YTo6c2V0 T2JqZWN0VG9TdHJpbmdWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU5MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2Ugc2hvdWxkIG5vdCBoYXZlIGV4cGVjdGVkIHRoZSBnZW5lcmF0ZUNvbmRp dGlvbnNGb3JQcm90b3R5cGVQcm9wZXJ0eUhpdCB3b3VsZCBzdWNjZWVkLgorICAgICAgICBUaGVy ZSBhcmUgbWFueSByZWFzb25zIGl0IG1pZ2h0IGZhaWwgaW5jbHVkaW5nIHRoYXQgdGhlcmUgaXMg YSBwcm94eSBzb21ld2hlcmUgb24gdGhlCisgICAgICAgIHByb3RvdHlwZSBjaGFpbiBvZiB0aGUg b2JqZWN0LgorCisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmVSYXJlRGF0YS5jcHA6CisgICAg ICAgIChKU0M6OlN0cnVjdHVyZVJhcmVEYXRhOjpzZXRPYmplY3RUb1N0cmluZ1ZhbHVlKToKKyAg ICAgICAgKiB0ZXN0cy9zdHJlc3Mvb2JqZWN0LXRvU3RyaW5nLXdpdGgtcHJveHkuanM6IEFkZGVk LgorICAgICAgICAoZ2V0IHRhcmdldCk6CisKIDIwMTYtMDYtMjUgIEtlaXRoIE1pbGxlciAgPGtl aXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgREZHQnl0ZUNvZGVQYXJzaW5nIGRvZXMg bm90IGhhbmRsZSBjYWxsaW5nIHRoZSBPYmplY3QgY29uc3RydWN0b3Igd2l0aCBubyBhcmd1bWVu dHMgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9T dHJ1Y3R1cmVSYXJlRGF0YS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1 Y3R1cmVSYXJlRGF0YS5jcHAKaW5kZXggMjdkOWIyMzNlYTM2ZTFhNTc3ZjMwMDBmNTBhZDJjY2Y4 M2ExMzRlMy4uNGNmYmIyNmFmMzZhNGE4MDUwNWE2YWRjNDhjMjczMjg3NGNkMjZhZCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlUmFyZURhdGEuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZVJhcmVEYXRhLmNw cApAQCAtMTI2LDcgKzEyNiw3IEBAIHZvaWQgU3RydWN0dXJlUmFyZURhdGE6OnNldE9iamVjdFRv U3RyaW5nVmFsdWUoRXhlY1N0YXRlKiBleGVjLCBWTSYgdm0sIFN0cnVjdHVyCiAgICAgICAgIC8v IFRoaXMgd2lsbCBub3QgY3JlYXRlIGEgY29uZGl0aW9uIGZvciB0aGUgY3VycmVudCBzdHJ1Y3R1 cmUgYnV0IHRoYXQgaXMgZ29vZCBiZWNhdXNlIHdlIGtub3cgdGhlIFN5bWJvbC50b1N0cmluZ1Rh ZwogICAgICAgICAvLyBpcyBub3Qgb24gdGhlIG93blN0cnVjdHVyZSBzbyB3ZSB3aWxsIHRyYW5z aXNpdGlvbiBpZiBvbmUgaXMgYWRkZWQgYW5kIHRoaXMgY2FjaGUgd2lsbCBubyBsb25nZXIgYmUg dXNlZC4KICAgICAgICAgY29uZGl0aW9uU2V0ID0gZ2VuZXJhdGVDb25kaXRpb25zRm9yUHJvdG90 eXBlUHJvcGVydHlIaXQodm0sIHRoaXMsIGV4ZWMsIG93blN0cnVjdHVyZSwgdG9TdHJpbmdUYWdT eW1ib2xTbG90LnNsb3RCYXNlKCksIHZtLnByb3BlcnR5TmFtZXMtPnRvU3RyaW5nVGFnU3ltYm9s LmltcGwoKSk7Ci0gICAgICAgIEFTU0VSVChjb25kaXRpb25TZXQuaGFzT25lU2xvdEJhc2VDb25k aXRpb24oKSk7CisgICAgICAgIEFTU0VSVCghY29uZGl0aW9uU2V0LmlzVmFsaWQoKSB8fCBjb25k aXRpb25TZXQuaGFzT25lU2xvdEJhc2VDb25kaXRpb24oKSk7CiAgICAgfSBlbHNlIGlmICh0b1N0 cmluZ1RhZ1N5bWJvbFNsb3QuaXNVbnNldCgpKQogICAgICAgICBjb25kaXRpb25TZXQgPSBnZW5l cmF0ZUNvbmRpdGlvbnNGb3JQcm9wZXJ0eU1pc3Modm0sIHRoaXMsIGV4ZWMsIG93blN0cnVjdHVy ZSwgdm0ucHJvcGVydHlOYW1lcy0+dG9TdHJpbmdUYWdTeW1ib2wuaW1wbCgpKTsKICAgICBlbHNl CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29iamVjdC10 b1N0cmluZy13aXRoLXByb3h5LmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy9vYmplY3QtdG9TdHJpbmctd2l0aC1wcm94eS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44NTVlZTVlOWUwZjY1 MzExMTBhZGRhNWQxMjc0ZGZhMWFhMTEyMTczCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vYmplY3QtdG9TdHJpbmctd2l0aC1wcm94eS5qcwpA QCAtMCwwICsxLDI3IEBACitsZXQgZm9vID0ge307CitsZXQgcHJvcGVydGllcyA9IFtdOworbGV0 IHAgPSBuZXcgUHJveHkoZm9vLCB7IGdldDoodGFyZ2V0LCBwcm9wZXJ0eSkgPT4geworICAgIHBy b3BlcnRpZXMucHVzaChwcm9wZXJ0eS50b1N0cmluZygpKTsKKyAgICBpZiAocHJvcGVydHkgPT09 IFN5bWJvbC50b1N0cmluZ1RhZykKKyAgICAgICAgcmV0dXJuICJiYWQgdGhpbmdzIjsKKyAgICBy ZXR1cm4gdGFyZ2V0W3Byb3BlcnR5XTsKK319KTsKKworZm9yIChpID0gMDsgaSA8IDU7IGkrKykg eworICAgIGlmIChwICE9ICJbb2JqZWN0IGJhZCB0aGluZ3NdIikKKyAgICAgICAgdGhyb3cgbmV3 IEVycm9yKCJiYWQgdG9TdHJpbmcgcmVzdWx0LiIpOworCisgICAgaWYgKHByb3BlcnRpZXNbMF0g IT09ICJTeW1ib2woU3ltYm9sLnRvUHJpbWl0aXZlKSIgfHwgcHJvcGVydGllc1sxXSAhPT0gInZh bHVlT2YiIHx8IHByb3BlcnRpZXNbMl0gIT09ICJ0b1N0cmluZyIgfHwgcHJvcGVydGllc1szXSAh PT0gIlN5bWJvbChTeW1ib2wudG9TdHJpbmdUYWcpIikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9y KCJiYWQgcHJvcGVydHkgYWNjZXNzZXMuIik7CisKKyAgICBwcm9wZXJ0aWVzID0gW107Cit9CisK K3AgPSBjcmVhdGVQcm94eShmb28pOworCitmb3IgKGkgPSAwOyBpIDwgNTsgaSsrKSB7CisgICAg bGV0IHN0ciA9ICJiYWQgdGhpbmdzIiArIGk7CisgICAgZm9vW1N5bWJvbC50b1N0cmluZ1RhZ10g PSBzdHI7CisgICAgaWYgKHAgIT0gIltvYmplY3QgIiArIHN0ciArICJdIikKKyAgICAgICAgdGhy b3cgbmV3IEVycm9yKCJiYWQgdG9TdHJpbmcgcmVzdWx0LiIpOworfQo= 282170 2016-06-27 14:58:25 -0700 2016-06-27 17:32:13 -0700 Patch for landing bug-159171-20160627145810.patch text/plain 3490 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTdiOTcyNTMxODhjZDk3ZTY3M2YwYWUyMTFhMTY2MzFhMmI5OWM4Li5mMWMxMmM3ZTUxOTJmNjQ3 ODFkMmE0NzU3ZGIwZGY4OTdlNGEwNmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wNi0yNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggYmFkIGFzc2VydCBpbiBTdHJ1Y3R1cmVSYXJlRGF0YTo6c2V0 T2JqZWN0VG9TdHJpbmdWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU5MTcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjk4NzM1NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBXZSBzaG91bGQgbm90IGhh dmUgZXhwZWN0ZWQgdGhlIGdlbmVyYXRlQ29uZGl0aW9uc0ZvclByb3RvdHlwZVByb3BlcnR5SGl0 IHdvdWxkIHN1Y2NlZWQuCisgICAgICAgIFRoZXJlIGFyZSBtYW55IHJlYXNvbnMgaXQgbWlnaHQg ZmFpbCBpbmNsdWRpbmcgdGhhdCB0aGVyZSBpcyBhIHByb3h5IHNvbWV3aGVyZSBvbiB0aGUKKyAg ICAgICAgcHJvdG90eXBlIGNoYWluIG9mIHRoZSBvYmplY3QuCisKKyAgICAgICAgKiBydW50aW1l L1N0cnVjdHVyZVJhcmVEYXRhLmNwcDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJlUmFyZURhdGE6 OnNldE9iamVjdFRvU3RyaW5nVmFsdWUpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9vYmplY3Qt dG9TdHJpbmctd2l0aC1wcm94eS5qczogQWRkZWQuCisgICAgICAgIChnZXQgdGFyZ2V0KToKKwog MjAxNi0wNi0yNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBERkdCeXRlQ29kZVBhcnNpbmcgZG9lcyBub3QgaGFuZGxlIGNhbGxpbmcgdGhlIE9iamVj dCBjb25zdHJ1Y3RvciB3aXRoIG5vIGFyZ3VtZW50cyBjb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZVJhcmVEYXRhLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZVJhcmVEYXRhLmNwcAppbmRleCAyN2Q5 YjIzM2VhMzZlMWE1NzdmMzAwMGY1MGFkMmNjZjgzYTEzNGUzLi40Y2ZiYjI2YWYzNmE0YTgwNTA1 YTZhZGM0OGMyNzMyODc0Y2QyNmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TdHJ1Y3R1cmVSYXJlRGF0YS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvU3RydWN0dXJlUmFyZURhdGEuY3BwCkBAIC0xMjYsNyArMTI2LDcgQEAgdm9pZCBT dHJ1Y3R1cmVSYXJlRGF0YTo6c2V0T2JqZWN0VG9TdHJpbmdWYWx1ZShFeGVjU3RhdGUqIGV4ZWMs IFZNJiB2bSwgU3RydWN0dXIKICAgICAgICAgLy8gVGhpcyB3aWxsIG5vdCBjcmVhdGUgYSBjb25k aXRpb24gZm9yIHRoZSBjdXJyZW50IHN0cnVjdHVyZSBidXQgdGhhdCBpcyBnb29kIGJlY2F1c2Ug d2Uga25vdyB0aGUgU3ltYm9sLnRvU3RyaW5nVGFnCiAgICAgICAgIC8vIGlzIG5vdCBvbiB0aGUg b3duU3RydWN0dXJlIHNvIHdlIHdpbGwgdHJhbnNpc2l0aW9uIGlmIG9uZSBpcyBhZGRlZCBhbmQg dGhpcyBjYWNoZSB3aWxsIG5vIGxvbmdlciBiZSB1c2VkLgogICAgICAgICBjb25kaXRpb25TZXQg PSBnZW5lcmF0ZUNvbmRpdGlvbnNGb3JQcm90b3R5cGVQcm9wZXJ0eUhpdCh2bSwgdGhpcywgZXhl Yywgb3duU3RydWN0dXJlLCB0b1N0cmluZ1RhZ1N5bWJvbFNsb3Quc2xvdEJhc2UoKSwgdm0ucHJv cGVydHlOYW1lcy0+dG9TdHJpbmdUYWdTeW1ib2wuaW1wbCgpKTsKLSAgICAgICAgQVNTRVJUKGNv bmRpdGlvblNldC5oYXNPbmVTbG90QmFzZUNvbmRpdGlvbigpKTsKKyAgICAgICAgQVNTRVJUKCFj b25kaXRpb25TZXQuaXNWYWxpZCgpIHx8IGNvbmRpdGlvblNldC5oYXNPbmVTbG90QmFzZUNvbmRp dGlvbigpKTsKICAgICB9IGVsc2UgaWYgKHRvU3RyaW5nVGFnU3ltYm9sU2xvdC5pc1Vuc2V0KCkp CiAgICAgICAgIGNvbmRpdGlvblNldCA9IGdlbmVyYXRlQ29uZGl0aW9uc0ZvclByb3BlcnR5TWlz cyh2bSwgdGhpcywgZXhlYywgb3duU3RydWN0dXJlLCB2bS5wcm9wZXJ0eU5hbWVzLT50b1N0cmlu Z1RhZ1N5bWJvbC5pbXBsKCkpOwogICAgIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS90ZXN0cy9zdHJlc3Mvb2JqZWN0LXRvU3RyaW5nLXdpdGgtcHJveHkuanMgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29iamVjdC10b1N0cmluZy13aXRoLXByb3h5 LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjg1NWVlNWU5ZTBmNjUzMTExMGFkZGE1ZDEyNzRkZmExYWExMTIxNzMK LS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29i amVjdC10b1N0cmluZy13aXRoLXByb3h5LmpzCkBAIC0wLDAgKzEsMjcgQEAKK2xldCBmb28gPSB7 fTsKK2xldCBwcm9wZXJ0aWVzID0gW107CitsZXQgcCA9IG5ldyBQcm94eShmb28sIHsgZ2V0Oih0 YXJnZXQsIHByb3BlcnR5KSA9PiB7CisgICAgcHJvcGVydGllcy5wdXNoKHByb3BlcnR5LnRvU3Ry aW5nKCkpOworICAgIGlmIChwcm9wZXJ0eSA9PT0gU3ltYm9sLnRvU3RyaW5nVGFnKQorICAgICAg ICByZXR1cm4gImJhZCB0aGluZ3MiOworICAgIHJldHVybiB0YXJnZXRbcHJvcGVydHldOworfX0p OworCitmb3IgKGkgPSAwOyBpIDwgNTsgaSsrKSB7CisgICAgaWYgKHAgIT0gIltvYmplY3QgYmFk IHRoaW5nc10iKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoImJhZCB0b1N0cmluZyByZXN1bHQu Iik7CisKKyAgICBpZiAocHJvcGVydGllc1swXSAhPT0gIlN5bWJvbChTeW1ib2wudG9QcmltaXRp dmUpIiB8fCBwcm9wZXJ0aWVzWzFdICE9PSAidmFsdWVPZiIgfHwgcHJvcGVydGllc1syXSAhPT0g InRvU3RyaW5nIiB8fCBwcm9wZXJ0aWVzWzNdICE9PSAiU3ltYm9sKFN5bWJvbC50b1N0cmluZ1Rh ZykiKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoImJhZCBwcm9wZXJ0eSBhY2Nlc3Nlcy4iKTsK KworICAgIHByb3BlcnRpZXMgPSBbXTsKK30KKworcCA9IGNyZWF0ZVByb3h5KGZvbyk7CisKK2Zv ciAoaSA9IDA7IGkgPCA1OyBpKyspIHsKKyAgICBsZXQgc3RyID0gImJhZCB0aGluZ3MiICsgaTsK KyAgICBmb29bU3ltYm9sLnRvU3RyaW5nVGFnXSA9IHN0cjsKKyAgICBpZiAocCAhPSAiW29iamVj dCAiICsgc3RyICsgIl0iKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoImJhZCB0b1N0cmluZyBy ZXN1bHQuIik7Cit9Cg==