159159 2016-06-27 11:44:32 -0700 Add comment to Module feature in features.json 2019-05-02 16:25:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller ap commit-queue mark.lam msaboff saam thomasclein7 oldest_to_newest 1205640 0 keith_miller 2016-06-27 11:44:32 -0700 Add comment to Module feature in features.json 1205641 1 282148 keith_miller 2016-06-27 11:45:11 -0700 Created attachment 282148 Patch 1205642 2 282148 saam 2016-06-27 11:47:16 -0700 Comment on attachment 282148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282148&action=review > Source/JavaScriptCore/features.json:207 > + "comment": "ES6 work is done, however, this feature is still listed as \"In Development\" because it cannot be accessed via html" Can you also add a link to the module loading spec somewhere? 1205643 3 282148 saam 2016-06-27 11:48:06 -0700 Comment on attachment 282148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282148&action=review >> Source/JavaScriptCore/features.json:207 >> + "comment": "ES6 work is done, however, this feature is still listed as \"In Development\" because it cannot be accessed via html" > > Can you also add a link to the module loading spec somewhere? Also, can you give brief instructions on how people can test this with the jsc shell? 1205663 4 282153 keith_miller 2016-06-27 12:16:36 -0700 Created attachment 282153 Patch 1205674 5 282153 commit-queue 2016-06-27 12:52:45 -0700 Comment on attachment 282153 Patch Clearing flags on attachment: 282153 Committed r202508: <http://trac.webkit.org/changeset/202508> 1205675 6 commit-queue 2016-06-27 12:52:49 -0700 All reviewed patches have been landed. Closing bug. 282148 2016-06-27 11:45:11 -0700 2016-06-27 12:16:34 -0700 Patch bug-159159-20160627114455.patch text/plain 1598 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTdiOTcyNTMxODhjZDk3ZTY3M2YwYWUyMTFhMTY2MzFhMmI5OWM4Li5iNjg4ZDI3MTBjZTZjOTQ0 MTQ4ZTJhMTljMDhhNTU0MjUyOTBhZDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNi0yNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgY29tbWVudCB0byBNb2R1bGUgZmVhdHVyZSBpbiBmZWF0dXJl cy5qc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTkxNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZlYXR1cmVzLmpzb246CisKIDIwMTYtMDYtMjUgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxl ckBhcHBsZS5jb20+CiAKICAgICAgICAgREZHQnl0ZUNvZGVQYXJzaW5nIGRvZXMgbm90IGhhbmRs ZSBjYWxsaW5nIHRoZSBPYmplY3QgY29uc3RydWN0b3Igd2l0aCBubyBhcmd1bWVudHMgY29ycmVj dGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZmVhdHVyZXMuanNvbiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mZWF0dXJlcy5qc29uCmluZGV4IDIyZmNiY2U2OGM2MDE0NTM2 YjY3NjczYzQ1ZTU2ODRmN2RmZmY5NzUuLjVmMjU0NjQyMWI5NDY3MmUzNGI2MzViNzI5NTc1Y2Vl MWIwMjc2YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mZWF0dXJlcy5qc29u CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mZWF0dXJlcy5qc29uCkBAIC0yMDMsNyArMjAz LDggQEAKICAgICAgICAgInVybCI6ICJodHRwOi8vd3d3LmVjbWEtaW50ZXJuYXRpb25hbC5vcmcv ZWNtYS0yNjIvNi4wL2luZGV4Lmh0bWwjc2VjLW1vZHVsZXMiLAogICAgICAgICAiZG9jdW1lbnRh dGlvbi11cmwiOiAiaHR0cHM6Ly9oYWNrcy5tb3ppbGxhLm9yZy8yMDE1LzA4L2VzNi1pbi1kZXB0 aC1tb2R1bGVzLyIsCiAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJNb2R1bGVzIG1ha2UgbW9kdWxh cml6aW5nIGNvZGUgYW5kIHNwbGl0dGluZyBpdCBhY3Jvc3MgZGlmZmVyZW50IGZpbGVzIGVhc3kg YmVjYXVzZSB0aGUgc3ludGF4IGFuZCBzZW1hbnRpY3MgYXJlIG5vdyBzdGFuZGFyZCBpbiB0aGUg SmF2YVNjcmlwdCBsYW5nYXVnZS4iLAotICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJFUzYiCisg ICAgICAgICJzcGVjaWZpY2F0aW9uIjogIkVTNiIsCisgICAgICAgICJjb21tZW50IjogIkVTNiB3 b3JrIGlzIGRvbmUsIGhvd2V2ZXIsIHRoaXMgZmVhdHVyZSBpcyBzdGlsbCBsaXN0ZWQgYXMgXCJJ biBEZXZlbG9wbWVudFwiIGJlY2F1c2UgaXQgY2Fubm90IGJlIGFjY2Vzc2VkIHZpYSBodG1sIgog ICAgIH0sCiAgICAgewogICAgICAgICAibmFtZSI6ICJOdW1iZXIgT2JqZWN0IEV4dGVuc2lvbnMi LAo= 282153 2016-06-27 12:16:36 -0700 2016-06-27 12:52:45 -0700 Patch bug-159159-20160627121621.patch text/plain 1812 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTdiOTcyNTMxODhjZDk3ZTY3M2YwYWUyMTFhMTY2MzFhMmI5OWM4Li5iNjg4ZDI3MTBjZTZjOTQ0 MTQ4ZTJhMTljMDhhNTU0MjUyOTBhZDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNi0yNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgY29tbWVudCB0byBNb2R1bGUgZmVhdHVyZSBpbiBmZWF0dXJl cy5qc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTkxNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZlYXR1cmVzLmpzb246CisKIDIwMTYtMDYtMjUgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxl ckBhcHBsZS5jb20+CiAKICAgICAgICAgREZHQnl0ZUNvZGVQYXJzaW5nIGRvZXMgbm90IGhhbmRs ZSBjYWxsaW5nIHRoZSBPYmplY3QgY29uc3RydWN0b3Igd2l0aCBubyBhcmd1bWVudHMgY29ycmVj dGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZmVhdHVyZXMuanNvbiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mZWF0dXJlcy5qc29uCmluZGV4IDIyZmNiY2U2OGM2MDE0NTM2 YjY3NjczYzQ1ZTU2ODRmN2RmZmY5NzUuLjVkYTgwMGUxOTQzODUxNWU2ZWE5YWE4NmJhYzhjNDE4 MzdhODg3OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mZWF0dXJlcy5qc29u CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mZWF0dXJlcy5qc29uCkBAIC0yMDMsNyArMjAz LDggQEAKICAgICAgICAgInVybCI6ICJodHRwOi8vd3d3LmVjbWEtaW50ZXJuYXRpb25hbC5vcmcv ZWNtYS0yNjIvNi4wL2luZGV4Lmh0bWwjc2VjLW1vZHVsZXMiLAogICAgICAgICAiZG9jdW1lbnRh dGlvbi11cmwiOiAiaHR0cHM6Ly9oYWNrcy5tb3ppbGxhLm9yZy8yMDE1LzA4L2VzNi1pbi1kZXB0 aC1tb2R1bGVzLyIsCiAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJNb2R1bGVzIG1ha2UgbW9kdWxh cml6aW5nIGNvZGUgYW5kIHNwbGl0dGluZyBpdCBhY3Jvc3MgZGlmZmVyZW50IGZpbGVzIGVhc3kg YmVjYXVzZSB0aGUgc3ludGF4IGFuZCBzZW1hbnRpY3MgYXJlIG5vdyBzdGFuZGFyZCBpbiB0aGUg SmF2YVNjcmlwdCBsYW5nYXVnZS4iLAotICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJFUzYiCisg ICAgICAgICJzcGVjaWZpY2F0aW9uIjogIkVTNiIsCisgICAgICAgICJjb21tZW50IjogIkVTNiB3 b3JrIGlzIGRvbmUsIGhvd2V2ZXIsIHRoaXMgZmVhdHVyZSBpcyBzdGlsbCBsaXN0ZWQgYXMgXCJJ biBEZXZlbG9wbWVudFwiIGJlY2F1c2UgdGhlIG1vZHVsZSBsb2FkaW5nIHNwZWNpZmljYXRpb24g aGFzIHlldCB0byBiZSBmaW5hbGl6ZWQgPGEgaHJlZj1cImh0dHBzOlwvXC93aGF0d2cuZ2l0aHVi LmlvXC9sb2FkZXJcL1wiPjxcL2E+LiBJdCBpcyBwb3NzaWJsZSB0byB1c2UgTW9kdWxlcyB3aXRo IHRoZSBqc2MgY29tbWFuZCBsaW5lIHRvb2wgYnkgcGFzc2luZyB0aGUgLW0gZmxhZywgYWx0aG91 Z2ggaXQgaXMgcHJpbWFyaWx5IGludGVuZGVkIGZvciB0ZXN0aW5nLiIKICAgICB9LAogICAgIHsK ICAgICAgICAgIm5hbWUiOiAiTnVtYmVyIE9iamVjdCBFeHRlbnNpb25zIiwK