159158 2016-06-27 11:35:07 -0700 [Mac] PiP placeholder should remain visible when 'controls' attribute is removed 2016-06-27 13:39:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 1205636 0 eric.carlson 2016-06-27 11:35:07 -0700 The PiP placeholder should remain visible as long as the video is in PiP mode, regardless of the state of the 'controls' attribute. 1205638 1 eric.carlson 2016-06-27 11:36:15 -0700 <rdar://problem/26727435> 1205672 2 282156 eric.carlson 2016-06-27 12:39:01 -0700 Created attachment 282156 Proposed patch 1205691 3 eric.carlson 2016-06-27 13:39:07 -0700 Committed r202509: https://trac.webkit.org/r202509 282156 2016-06-27 12:39:01 -0700 2016-06-27 13:39:16 -0700 Proposed patch patch_1.txt text/plain 7428 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjUwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA2LTI3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFBpUCBwbGFj ZWhvbGRlciBzaG91bGQgcmVtYWluIHZpc2libGUgd2hlbiAnY29udHJvbHMnIGF0dHJpYnV0ZSBp cyByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTkxNTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NzI3NDM1PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgZXhpc3Rp bmcgdGVzdCB1cGRhdGVkLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNBcHBsZS5qczoKKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLnNob3VsZEhh dmVDb250cm9scyk6IEFsd2F5cyByZXR1cm4gdHJ1ZSB3aGVuIGluIFBpUCBvciBBaXJQbGF5IG1v ZGUuCisKIDIwMTYtMDYtMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBObyBlcnJvciBtZXNzYWdlIHdoZW4gcGFzc2luZyBhbiBpbnZhbGlkIEFQSSB2 ZXJzaW9uIHRvIEFwcGxlUGF5U2Vzc2lvbiBjb25zdHJ1Y3RvcgpJbmRleDogU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw cGxlLmpzCShyZXZpc2lvbiAyMDI1MDIpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0zMDUsNyAr MzA1LDEwIEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICBpZiAoIXRoaXMuaXNB dWRpbygpICYmICF0aGlzLmhvc3QuYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjaykKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogCi0gICAgICAgIHJldHVybiB0aGlzLnZpZGVvLmNvbnRyb2xzIHx8 IHRoaXMuaXNGdWxsU2NyZWVuKCk7CisgICAgICAgIGlmICh0aGlzLmlzRnVsbFNjcmVlbigpIHx8 IHRoaXMucHJlc2VudGF0aW9uTW9kZSgpID09PSAncGljdHVyZS1pbi1waWN0dXJlJyB8fCB0aGlz LmN1cnJlbnRQbGF5YmFja1RhcmdldElzV2lyZWxlc3MoKSkKKyAgICAgICAgICAgIHJldHVybiB0 cnVlOworCisgICAgICAgIHJldHVybiB0aGlzLnZpZGVvLmNvbnRyb2xzOwogICAgIH0sCiAKICAg ICBzZXROZWVkc1RpbWVsaW5lTWV0cmljc1VwZGF0ZTogZnVuY3Rpb24oKQpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gMjAyNDIzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTYtMDYtMjcgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgW01hY10gUGlQIHBsYWNlaG9sZGVyIHNob3VsZCByZW1haW4g dmlzaWJsZSB3aGVuICdjb250cm9scycgYXR0cmlidXRlIGlzIHJlbW92ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTE1OAorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMjY3Mjc0MzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBtZWRpYS9jb250cm9scy9waWN0dXJlLWluLXBpY3R1cmUtZXhwZWN0 ZWQudHh0OiBVcGRhdGVkLgorICAgICAgICAqIG1lZGlhL2NvbnRyb2xzL3BpY3R1cmUtaW4tcGlj dHVyZS5odG1sOiBEaXR0by4KKwogMjAxNi0wNi0yNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUu dGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXVtFRkxdIEltYWdlQnVmZmVyQ2Fpcm8gc2hv dWxkIGFjY2VwdCByZXNvbHV0aW9uIGZhY3RvcgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvY29u dHJvbHMvcGljdHVyZS1pbi1waWN0dXJlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9tZWRpYS9jb250cm9scy9waWN0dXJlLWluLXBpY3R1cmUtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAyMDI0MjMpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy9waWN0dXJlLWlu LXBpY3R1cmUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yMyw1ICsyMywxMSBAQCBU ZXN0IGZvciB0aGUgcGlwIHBsYWNlaG9sZGVyIHZpc2liaWxpdHkgCiBQQVNTOiBTaG91bGQgYmUg aW4gcGlwIG1vZGUKIFBBU1M6IElubGluZSBwbGFjZWhvbGRlciBzaG91bGQgYmUgdmlzaWJsZSBh dCB0aGlzIHBvaW50CiAKK1Rlc3QgZm9yIHRoZSBwaXAgcGxhY2Vob2xkZXIgdmlzaWJpbGl0eSBp biBwaXAgbW9kZSB3aXRob3V0IGEgJ2NvbnRyb2xzJyBhdHRyaWJ1dGUKKworUEFTUzogU2hvdWxk IHN0aWxsIGJlIGluIHBpcCBtb2RlCitQQVNTOiBObyBjb250cm9scyBhdHRyaWJ1dGUKK1BBU1M6 IElubGluZSBwbGFjZWhvbGRlciBzaG91bGQgc3RpbGwgYmUgdmlzaWJsZQorCiBUZXN0aW5nIGZp bmlzaGVkLgogCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy9waWN0dXJlLWluLXBp Y3R1cmUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy9waWN0 dXJlLWluLXBpY3R1cmUuaHRtbAkocmV2aXNpb24gMjAyNDIzKQorKysgTGF5b3V0VGVzdHMvbWVk aWEvY29udHJvbHMvcGljdHVyZS1pbi1waWN0dXJlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTcs MjAgKzcsMjAgQEAKICAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQogICAgICAgICAg ICAgICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0QWxsb3dzUGljdHVyZUluUGljdHVy ZU1lZGlhUGxheWJhY2sodHJ1ZSk7CiAKLSAgICAgICAgICAgIHZhciB0ZXN0ZXIgPSBuZXcgQ29u dHJvbHNUZXN0KCJub24tZXhpc3RlbnQtbWVkaWEtZmlsZSIsICJlcnJvciIpCisgICAgICAgICAg ICBjb25zdCB0ZXN0ZXIgPSBuZXcgQ29udHJvbHNUZXN0KCJub24tZXhpc3RlbnQtbWVkaWEtZmls ZSIsICJlcnJvciIpCiAgICAgICAgICAgICAgICAgLndoZW5SZWFkeShydW5UZXN0c1dpdGhvdXRW aWRlbykKICAgICAgICAgICAgICAgICAuc3RhcnQoKTsKIAogICAgICAgICAgICAgZnVuY3Rpb24g cnVuVGVzdHNXaXRob3V0VmlkZW8oKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIHZh ciBjdXJyZW50U3RhdGUgPSB0ZXN0ZXIuY3VycmVudFN0YXRlOworICAgICAgICAgICAgICAgIGNv bnN0IGN1cnJlbnRTdGF0ZSA9IHRlc3Rlci5jdXJyZW50U3RhdGU7CiAgICAgICAgICAgICAgICAg dGVzdGVyLnRlc3QoIldlIGFyZSB1c2luZyB0aGUgYXBwbGUgaWRpb20iKQogICAgICAgICAgICAg ICAgICAgICAudmFsdWUoY3VycmVudFN0YXRlLmlkaW9tKQogICAgICAgICAgICAgICAgICAgICAu aXNFcXVhbFRvKCJhcHBsZSIpOwogCiAgICAgICAgICAgICAgICAgdGVzdGVyLnN0YXJ0TmV3U2Vj dGlvbigiVGVzdCB0aGUgcGljdHVyZS1pbi1waWN0dXJlIGJ1dHRvbiB3aXRob3V0IHZpZGVvIiwg dHJ1ZSk7CiAKLSAgICAgICAgICAgICAgICB2YXIgc3RhdGVGb3JQaWN0dXJlSW5QaWN0dXJlQnV0 dG9uID0gdGVzdGVyLnN0YXRlRm9yQ29udHJvbHNFbGVtZW50KCJQaWN0dXJlLWluLXBpY3R1cmUg QnV0dG9uIik7CisgICAgICAgICAgICAgICAgY29uc3Qgc3RhdGVGb3JQaWN0dXJlSW5QaWN0dXJl QnV0dG9uID0gdGVzdGVyLnN0YXRlRm9yQ29udHJvbHNFbGVtZW50KCJQaWN0dXJlLWluLXBpY3R1 cmUgQnV0dG9uIik7CiAgICAgICAgICAgICAgICAgdGVzdGVyLnRlc3QoIlBpY3R1cmUtaW4tcGlj dHVyZSBidXR0b24gc2hvdWxkIG5vdCBiZSB2aXNpYmxlIGlmIHRoZXJlJ3Mgbm8gdmlkZW8iKQog ICAgICAgICAgICAgICAgICAgICAudmFsdWUoc3RhdGVGb3JQaWN0dXJlSW5QaWN0dXJlQnV0dG9u LmNsYXNzTmFtZSkKICAgICAgICAgICAgICAgICAgICAgLmNvbnRhaW5zKCJoaWRkZW4iKTsKQEAg LTM0LDcgKzM0LDcgQEAKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICB0ZXN0ZXIuc3Rh cnROZXdTZWN0aW9uKCJUZXN0IHRoZSBwaWN0dXJlLWluLXBpY3R1cmUgYnV0dG9uIHdpdGggdmFs aWQgdmlkZW8iKTsKIAotICAgICAgICAgICAgICAgIHZhciBzdGF0ZUZvclBpY3R1cmVJblBpY3R1 cmVCdXR0b24gPSB0ZXN0ZXIuc3RhdGVGb3JDb250cm9sc0VsZW1lbnQoIlBpY3R1cmUtaW4tcGlj dHVyZSBCdXR0b24iLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBjb25zdCBzdGF0ZUZvclBpY3R1 cmVJblBpY3R1cmVCdXR0b24gPSB0ZXN0ZXIuc3RhdGVGb3JDb250cm9sc0VsZW1lbnQoIlBpY3R1 cmUtaW4tcGljdHVyZSBCdXR0b24iLCB0cnVlKTsKICAgICAgICAgICAgICAgICB0ZXN0ZXIudGVz dCgiUGljdHVyZS1pbi1waWN0dXJlIGJ1dHRvbiBzaG91bGQgYmUgdmlzaWJsZSBpZiB0aGVyZSdz IHZpZGVvIikKICAgICAgICAgICAgICAgICAgICAgLnZhbHVlKHN0YXRlRm9yUGljdHVyZUluUGlj dHVyZUJ1dHRvbi5jbGFzc05hbWUpCiAgICAgICAgICAgICAgICAgICAgIC5kb2VzTm90Q29udGFp bigiaGlkZGVuIik7CkBAIC00Myw3ICs0Myw3IEBACiAgICAgICAgICAgICAgICAgICAgIC52YWx1 ZShzdGF0ZUZvclBpY3R1cmVJblBpY3R1cmVCdXR0b24ucGFyZW50RWxlbWVudCkKICAgICAgICAg ICAgICAgICAgICAgLmlzTm90RXF1YWxUbyh1bmRlZmluZWQpOwogCi0gICAgICAgICAgICAgICAg dmFyIHN0YXRlRm9yUGxhY2Vob2xkZXIgPSB0ZXN0ZXIuc3RhdGVGb3JDb250cm9sc0VsZW1lbnQo IklubGluZSBwbGF5YmFjayBwbGFjZWhvbGRlciIsIHRydWUpOworICAgICAgICAgICAgICAgIGNv bnN0IHN0YXRlRm9yUGxhY2Vob2xkZXIgPSB0ZXN0ZXIuc3RhdGVGb3JDb250cm9sc0VsZW1lbnQo IklubGluZSBwbGF5YmFjayBwbGFjZWhvbGRlciIsIHRydWUpOwogICAgICAgICAgICAgICAgIHRl c3Rlci50ZXN0KCJJbmxpbmUgcGxhY2Vob2xkZXIgc2hvdWxkIG5vdCBiZSB2aXNpYmxlIGF0IHRo aXMgcG9pbnQiKQogICAgICAgICAgICAgICAgICAgICAudmFsdWUoc3RhdGVGb3JQbGFjZWhvbGRl ci5jbGFzc05hbWUpCiAgICAgICAgICAgICAgICAgICAgIC5jb250YWlucygiaGlkZGVuIik7CkBA IC02MiwxMiArNjIsMzYgQEAKICAgICAgICAgICAgICAgICAgICAgLnZhbHVlKHRlc3Rlci5tZWRp YS53ZWJraXRQcmVzZW50YXRpb25Nb2RlKQogICAgICAgICAgICAgICAgICAgICAuaXNFcXVhbFRv KCJwaWN0dXJlLWluLXBpY3R1cmUiKTsKIAotICAgICAgICAgICAgICAgIHZhciBzdGF0ZUZvclBs YWNlaG9sZGVyID0gdGVzdGVyLnN0YXRlRm9yQ29udHJvbHNFbGVtZW50KCJJbmxpbmUgcGxheWJh Y2sgcGxhY2Vob2xkZXIiLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBjb25zdCBzdGF0ZUZvclBs YWNlaG9sZGVyID0gdGVzdGVyLnN0YXRlRm9yQ29udHJvbHNFbGVtZW50KCJJbmxpbmUgcGxheWJh Y2sgcGxhY2Vob2xkZXIiLCB0cnVlKTsKICAgICAgICAgICAgICAgICB0ZXN0ZXIudGVzdCgiSW5s aW5lIHBsYWNlaG9sZGVyIHNob3VsZCBiZSB2aXNpYmxlIGF0IHRoaXMgcG9pbnQiKQogICAgICAg ICAgICAgICAgICAgICAudmFsdWUoc3RhdGVGb3JQbGFjZWhvbGRlci5jbGFzc05hbWUpCiAgICAg ICAgICAgICAgICAgICAgIC5kb2VzTm90Q29udGFpbigiaGlkZGVuIik7CiAKKyAgICAgICAgICAg ICAgICBjb25zdCBjb250cm9sc09ic2VydmVyID0gbmV3IE11dGF0aW9uT2JzZXJ2ZXIoY29udHJv bHNEaWRDaGFuZ2UpOworICAgICAgICAgICAgICAgIGNvbnRyb2xzT2JzZXJ2ZXIub2JzZXJ2ZSh0 ZXN0ZXIubWVkaWEsIHsgYXR0cmlidXRlczogdHJ1ZSwgYXR0cmlidXRlRmlsdGVyOiBbJ2NvbnRy b2xzJ10gfSk7CisKKyAgICAgICAgICAgICAgICB0ZXN0ZXIubWVkaWEucmVtb3ZlQXR0cmlidXRl KCdjb250cm9scycpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBjb250 cm9sc0RpZENoYW5nZSgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgdGVzdGVyLnN0 YXJ0TmV3U2VjdGlvbigiVGVzdCBmb3IgdGhlIHBpcCBwbGFjZWhvbGRlciB2aXNpYmlsaXR5IGlu IHBpcCBtb2RlIHdpdGhvdXQgYSAnY29udHJvbHMnIGF0dHJpYnV0ZSIpOworCisgICAgICAgICAg ICAgICAgdGVzdGVyLnRlc3QoIlNob3VsZCBzdGlsbCBiZSBpbiBwaXAgbW9kZSIpCisgICAgICAg ICAgICAgICAgICAgIC52YWx1ZSh0ZXN0ZXIubWVkaWEud2Via2l0UHJlc2VudGF0aW9uTW9kZSkK KyAgICAgICAgICAgICAgICAgICAgLmlzRXF1YWxUbygicGljdHVyZS1pbi1waWN0dXJlIik7CisK KyAgICAgICAgICAgICAgICB0ZXN0ZXIudGVzdCgiTm8gY29udHJvbHMgYXR0cmlidXRlIikKKyAg ICAgICAgICAgICAgICAgICAgLnZhbHVlKHRlc3Rlci5tZWRpYS5oYXNBdHRyaWJ1dGUoJ2NvbnRy b2xzJykpCisgICAgICAgICAgICAgICAgICAgIC5pc0ZhbHNlKCk7CisKKyAgICAgICAgICAgICAg ICBjb25zdCBzdGF0ZUZvclBsYWNlaG9sZGVyID0gdGVzdGVyLnN0YXRlRm9yQ29udHJvbHNFbGVt ZW50KCJJbmxpbmUgcGxheWJhY2sgcGxhY2Vob2xkZXIiLCB0cnVlKTsKKyAgICAgICAgICAgICAg ICB0ZXN0ZXIudGVzdCgiSW5saW5lIHBsYWNlaG9sZGVyIHNob3VsZCBzdGlsbCBiZSB2aXNpYmxl IikKKyAgICAgICAgICAgICAgICAgICAgLnZhbHVlKHN0YXRlRm9yUGxhY2Vob2xkZXIuY2xhc3NO YW1lKQorICAgICAgICAgICAgICAgICAgICAuZG9lc05vdENvbnRhaW4oImhpZGRlbiIpOworCiAg ICAgICAgICAgICAgICAgdGVzdGVyLm1lZGlhLndlYmtpdFNldFByZXNlbnRhdGlvbk1vZGUoImlu bGluZSIpOworCiAgICAgICAgICAgICAgICAgdGVzdGVyLmVuZCgpOwogICAgICAgICAgICAgfQog ICAgICAgICA8L3NjcmlwdD4K