159157 2016-06-27 11:24:20 -0700 Remove now unused WTF::findNextLineStart 2016-06-27 12:11:56 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg benjamin cdumez cmarcelo commit-queue mark.lam oldest_to_newest 1205630 0 joepeck 2016-06-27 11:24:20 -0700 Remove now unused WTF::findNextLineStart. No longer used after r202498. 1205631 1 282147 joepeck 2016-06-27 11:25:14 -0700 Created attachment 282147 [PATCH] Proposed Fix 1205634 2 282147 mark.lam 2016-06-27 11:28:47 -0700 Comment on attachment 282147 [PATCH] Proposed Fix r=me 1205658 3 282147 commit-queue 2016-06-27 12:11:51 -0700 Comment on attachment 282147 [PATCH] Proposed Fix Clearing flags on attachment: 282147 Committed r202506: <http://trac.webkit.org/changeset/202506> 1205659 4 commit-queue 2016-06-27 12:11:56 -0700 All reviewed patches have been landed. Closing bug. 282147 2016-06-27 11:25:14 -0700 2016-06-27 12:11:51 -0700 [PATCH] Proposed Fix wtf-unused-1.patch text/plain 4189 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMTkwYzEyMy4uYTViYWVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNi0wNi0yNyAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBu b3cgdW51c2VkIFdURjo6ZmluZE5leHRMaW5lU3RhcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTE1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVudXNlZCBhZnRlciByMjAyNDk4LgorCisgICAgICAg ICogd3RmL3RleHQvU3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OmZp bmROZXh0TGluZVN0YXJ0KTogRGVsZXRlZC4KKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBs Lmg6CisgICAgICAgIChXVEY6OmZpbmROZXh0TGluZVN0YXJ0KTogRGVsZXRlZC4KKyAgICAgICAg KiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpmaW5kTmV4dExp bmVTdGFydCk6IERlbGV0ZWQuCisKIDIwMTYtMDYtMjEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgTm9uY29weWFibGVGdW5jdGlvbiB0byBG dW5jdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKaW5kZXggMmQwZGEzNS4uYzhkNTM1 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAorKysgYi9T b3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCkBAIC0xMjY0LDEzICsxMjY0LDYgQEAg c2l6ZV90IFN0cmluZ0ltcGw6OmZpbmRJZ25vcmluZ0FTQ0lJQ2FzZShjb25zdCBTdHJpbmdJbXBs KiBtYXRjaFN0cmluZywgdW5zaWduZWQKICAgICByZXR1cm4gOjpXVEY6OmZpbmRJZ25vcmluZ0FT Q0lJQ2FzZSgqdGhpcywgKm1hdGNoU3RyaW5nLCBzdGFydE9mZnNldCk7CiB9CiAKLXNpemVfdCBT dHJpbmdJbXBsOjpmaW5kTmV4dExpbmVTdGFydCh1bnNpZ25lZCBpbmRleCkKLXsKLSAgICBpZiAo aXM4Qml0KCkpCi0gICAgICAgIHJldHVybiBXVEY6OmZpbmROZXh0TGluZVN0YXJ0KGNoYXJhY3Rl cnM4KCksIG1fbGVuZ3RoLCBpbmRleCk7Ci0gICAgcmV0dXJuIFdURjo6ZmluZE5leHRMaW5lU3Rh cnQoY2hhcmFjdGVyczE2KCksIG1fbGVuZ3RoLCBpbmRleCk7Ci19Ci0KIHNpemVfdCBTdHJpbmdJ bXBsOjpyZXZlcnNlRmluZChVQ2hhciBjLCB1bnNpZ25lZCBpbmRleCkKIHsKICAgICBpZiAoaXM4 Qml0KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IDUzNDg0ZmUuLjZiODBlZGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC03MDksOCArNzA5LDYgQEAgcHVibGljOgogICAg IFdURl9FWFBPUlRfU1RSSU5HX0FQSSBzaXplX3QgZmluZElnbm9yaW5nQVNDSUlDYXNlKGNvbnN0 IFN0cmluZ0ltcGwqKSBjb25zdDsKICAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkgc2l6ZV90IGZp bmRJZ25vcmluZ0FTQ0lJQ2FzZShjb25zdCBTdHJpbmdJbXBsKiwgdW5zaWduZWQgc3RhcnRPZmZz ZXQpIGNvbnN0OwogCi0gICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIHNpemVfdCBmaW5kTmV4dExp bmVTdGFydCh1bnNpZ25lZCBpbmRleCA9IFVJTlRfTUFYKTsKLQogICAgIFdURl9FWFBPUlRfU1RS SU5HX0FQSSBzaXplX3QgcmV2ZXJzZUZpbmQoVUNoYXIsIHVuc2lnbmVkIGluZGV4ID0gVUlOVF9N QVgpOwogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBzaXplX3QgcmV2ZXJzZUZpbmQoU3RyaW5n SW1wbCosIHVuc2lnbmVkIGluZGV4ID0gVUlOVF9NQVgpOwogICAgIFdURl9FWFBPUlRfU1RSSU5H X0FQSSBzaXplX3QgcmV2ZXJzZUZpbmRJZ25vcmluZ0Nhc2UoU3RyaW5nSW1wbCosIHVuc2lnbmVk IGluZGV4ID0gVUlOVF9NQVgpOwpAQCAtOTc1LDM3ICs5NzMsNiBAQCBpbmxpbmUgc2l6ZV90IGZp bmQoY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIGxlbmd0aCwgQ2hhcmFjdGVyTWF0 Y2hGdW5jdAogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlPgotaW5saW5lIHNp emVfdCBmaW5kTmV4dExpbmVTdGFydChjb25zdCBDaGFyYWN0ZXJUeXBlKiBjaGFyYWN0ZXJzLCB1 bnNpZ25lZCBsZW5ndGgsIHVuc2lnbmVkIGluZGV4ID0gMCkKLXsKLSAgICB3aGlsZSAoaW5kZXgg PCBsZW5ndGgpIHsKLSAgICAgICAgQ2hhcmFjdGVyVHlwZSBjID0gY2hhcmFjdGVyc1tpbmRleCsr XTsKLSAgICAgICAgaWYgKChjICE9ICdcbicpICYmIChjICE9ICdccicpKQotICAgICAgICAgICAg Y29udGludWU7Ci0KLSAgICAgICAgLy8gVGhlcmUgY2FuIG9ubHkgYmUgYSBzdGFydCBvZiBhIG5l dyBsaW5lIGlmIHRoZXJlIGFyZSBtb3JlIGNoYXJhY3RlcnMKLSAgICAgICAgLy8gYmV5b25kIHRo ZSBjdXJyZW50IGNoYXJhY3Rlci4KLSAgICAgICAgaWYgKGluZGV4IDwgbGVuZ3RoKSB7Ci0gICAg ICAgICAgICAvLyBUaGUgMyBjb21tb24gdHlwZXMgb2YgbGluZSB0ZXJtaW5hdG9ycyBhcmUgMS4g XHJcbiAoV2luZG93cyksIAotICAgICAgICAgICAgLy8gMi4gXHIgKG9sZCBNYWNPUykgYW5kIDMu IFxuIChVbml4J2VzKS4KLQotICAgICAgICAgICAgaWYgKGMgPT0gJ1xuJykKLSAgICAgICAgICAg ICAgICByZXR1cm4gaW5kZXg7IC8vIENhc2UgMzoganVzdCBcbi4KLQotICAgICAgICAgICAgQ2hh cmFjdGVyVHlwZSBjMiA9IGNoYXJhY3RlcnNbaW5kZXhdOwotICAgICAgICAgICAgaWYgKGMyICE9 ICdcbicpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGluZGV4OyAvLyBDYXNlIDI6IGp1c3QgXHIu Ci0KLSAgICAgICAgICAgIC8vIENhc2UgMTogXHJcbi4KLSAgICAgICAgICAgIC8vIEJ1dCwgdGhl cmUncyBvbmx5IGEgc3RhcnQgb2YgYSBuZXcgbGluZSBpZiB0aGVyZSBhcmUgbW9yZQotICAgICAg ICAgICAgLy8gY2hhcmFjdGVycyBiZXlvbmQgdGhlIFxyXG4uCi0gICAgICAgICAgICBpZiAoKytp bmRleCA8IGxlbmd0aCkKLSAgICAgICAgICAgICAgICByZXR1cm4gaW5kZXg7IAotICAgICAgICB9 Ci0gICAgfQotICAgIHJldHVybiBub3RGb3VuZDsKLX0KLQotdGVtcGxhdGU8dHlwZW5hbWUgQ2hh cmFjdGVyVHlwZT4KIGlubGluZSBzaXplX3QgcmV2ZXJzZUZpbmRMaW5lVGVybWluYXRvcihjb25z dCBDaGFyYWN0ZXJUeXBlKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBsZW5ndGgsIHVuc2lnbmVkIGlu ZGV4ID0gVUlOVF9NQVgpCiB7CiAgICAgaWYgKCFsZW5ndGgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcu aAppbmRleCBlODM5YmRiLi5hOTQ5MWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTIz MCw5ICsyMzAsNiBAQCBwdWJsaWM6CiAgICAgc2l6ZV90IGZpbmQoY29uc3QgTENoYXIqIHN0ciwg dW5zaWduZWQgc3RhcnQgPSAwKSBjb25zdAogICAgICAgICB7IHJldHVybiBtX2ltcGwgPyBtX2lt cGwtPmZpbmQoc3RyLCBzdGFydCkgOiBub3RGb3VuZDsgfQogCi0gICAgc2l6ZV90IGZpbmROZXh0 TGluZVN0YXJ0KHVuc2lnbmVkIHN0YXJ0ID0gMCkgY29uc3QKLSAgICAgICAgeyByZXR1cm4gbV9p bXBsID8gbV9pbXBsLT5maW5kTmV4dExpbmVTdGFydChzdGFydCkgOiBub3RGb3VuZDsgfQotCiAg ICAgLy8gRmluZCB0aGUgbGFzdCBpbnN0YW5jZSBvZiBhIHNpbmdsZSBjaGFyYWN0ZXIgb3Igc3Ry aW5nLgogICAgIHNpemVfdCByZXZlcnNlRmluZChVQ2hhciBjLCB1bnNpZ25lZCBzdGFydCA9IFVJ TlRfTUFYKSBjb25zdAogICAgICAgICB7IHJldHVybiBtX2ltcGwgPyBtX2ltcGwtPnJldmVyc2VG aW5kKGMsIHN0YXJ0KSA6IG5vdEZvdW5kOyB9Cg==