159154 2016-06-27 11:04:53 -0700 No error message when passing an invalid API version to ApplePaySession constructor 2019-07-18 16:38:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca ap arvind.tech225 commit-queue michellerodri247 mkwst writing.my.life4ever oldest_to_newest 1205619 0 andersca 2016-06-27 11:04:53 -0700 No error message when passing an invalid API version to ApplePaySession constructor 1205620 1 282143 andersca 2016-06-27 11:05:35 -0700 Created attachment 282143 Patch 1205621 2 282143 thorton 2016-06-27 11:07:05 -0700 Comment on attachment 282143 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282143&action=review > Source/WebCore/Modules/applepay/ApplePaySession.cpp:652 > + if (!version || !paymentCoordinator.supportsVersion(version)) { Why does supportsVersion not return false for version=0? 1205632 3 andersca 2016-06-27 11:26:58 -0700 (In reply to comment #2) > Comment on attachment 282143 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282143&action=review > > > Source/WebCore/Modules/applepay/ApplePaySession.cpp:652 > > + if (!version || !paymentCoordinator.supportsVersion(version)) { > > Why does supportsVersion not return false for version=0? supportsVersion throws an exception if you pass 0 since it's out of range. 1205633 4 andersca 2016-06-27 11:28:19 -0700 Committed r202499: <http://trac.webkit.org/changeset/202499> 282143 2016-06-27 11:05:35 -0700 2016-06-27 11:06:50 -0700 Patch bug-159154-20160627110519.patch text/plain 1676 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM3NGJkNGYyMjExNGYz YjQ4MTkxMjk0ZWViMjVkMjFkNDU4NTIxNy4uYzg5MTliNmE4ZTEyM2M4MThhY2JhMmYwNzE0NDgx ZjU4NzljYmRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTI3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTm8gZXJyb3IgbWVz c2FnZSB3aGVuIHBhc3NpbmcgYW4gaW52YWxpZCBBUEkgdmVyc2lvbiB0byBBcHBsZVBheVNlc3Np b24gY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1OTE1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIExvZyBhbiBlcnJvciBtZXNzYWdlIGlmIHRoZSB2ZXJzaW9uIGlzIG5vdCBzdXBwb3J0 ZWQuIEFsc28sIGNoZWNrIGZvciB2ZXJzaW9uIDAgc2luY2UgdGhhdCBpcyBhbHNvIG5vdCBzdXBw b3J0ZWQuCisKKyAgICAgICAgKiBNb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5U2Vzc2lvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBcHBsZVBheVNlc3Npb246OmNyZWF0ZSk6CisKIDIwMTYtMDYt MjcgIE1pZ3VlbCBHb21leiAgPG1hZ29tZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtF RkxdIEJ1aWxkIHdpdGggdGhyZWFkZWQgY29tcG9zaXRvciBlbmFibGVkIGlzIGJyb2tlbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Npb24u Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNlc3Npb24uY3Bw CmluZGV4IDZkZTBjM2I3OTAwNTUzYTc3MjJlNDU4MmRlNDA5Y2MzZjBhOTdjNWQuLjg3NDc5Mjkx MmQwMTZmN2Q5ZmZjNmVkNGE0NTk1MzJhYzk4NmE3YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2FwcGxlcGF5L0FwcGxlUGF5U2Vzc2lvbi5jcHAKQEAgLTY0OSw3ICs2NDks OCBAQCBSZWZQdHI8QXBwbGVQYXlTZXNzaW9uPiBBcHBsZVBheVNlc3Npb246OmNyZWF0ZShEb2N1 bWVudCYgZG9jdW1lbnQsIHVuc2lnbmVkIHZlcgogCiAgICAgYXV0byYgcGF5bWVudENvb3JkaW5h dG9yID0gZG9jdW1lbnQuZnJhbWUoKS0+bWFpbkZyYW1lKCkucGF5bWVudENvb3JkaW5hdG9yKCk7 CiAKLSAgICBpZiAoIXBheW1lbnRDb29yZGluYXRvci5zdXBwb3J0c1ZlcnNpb24odmVyc2lvbikp IHsKKyAgICBpZiAoIXZlcnNpb24gfHwgIXBheW1lbnRDb29yZGluYXRvci5zdXBwb3J0c1ZlcnNp b24odmVyc2lvbikpIHsKKyAgICAgICAgd2luZG93LnByaW50RXJyb3JNZXNzYWdlKG1ha2VTdHJp bmcoIlwiIiArIFN0cmluZzo6bnVtYmVyKHZlcnNpb24pLCAiXCIgaXMgbm90IGEgc3VwcG9ydGVk IHZlcnNpb24uIikpOwogICAgICAgICBlYyA9IElOVkFMSURfQUNDRVNTX0VSUjsKICAgICAgICAg cmV0dXJuIG51bGxwdHI7CiAgICAgfQo=