159113 2016-06-24 23:02:32 -0700 Don't keep all newly created potential custom elements alive when the feature is disabled 2016-06-27 20:26:05 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez commit-queue dbates esprehn+autocc kangil.han kling koivisto webkit-bug-importer oldest_to_newest 1205316 0 rniwa 2016-06-24 23:02:32 -0700 Custom elements spec has been updated to not upgrade all elements unless they're inserted into a document. We don't have a time to update the code fully but we should at least avoid queuing them up and keeping them all alive when the feature is disabled. 1205317 1 282047 rniwa 2016-06-24 23:10:29 -0700 Created attachment 282047 Fixes the bug 1205465 2 282047 dbates 2016-06-26 20:15:37 -0700 Comment on attachment 282047 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=282047&action=review OK > Source/WebCore/ChangeLog:9 > + The custom elements spec has also been updated to not do this but we'll implement that behavior later. Maybe a better way to say this is: Ideally we want to conform to the behavior in the Custom Elements spec. and only upgrade an element that is inserted into the document. > Source/WebCore/dom/Document.cpp:900 > + if (RuntimeEnabledFeatures::sharedFeatures().customElementsEnabled() > + && Document::validateCustomElementName(localName) == CustomElementNameValidationStatus::Valid) { Can we/would it make sense to write a test for this change? I would hope that such a test could be updated once we implement the behavior defined in the spec. 1205466 3 rniwa 2016-06-26 21:14:08 -0700 (In reply to comment #2) > Comment on attachment 282047 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282047&action=review > > > Source/WebCore/dom/Document.cpp:900 > > + if (RuntimeEnabledFeatures::sharedFeatures().customElementsEnabled() > > + && Document::validateCustomElementName(localName) == CustomElementNameValidationStatus::Valid) { > > Can we/would it make sense to write a test for this change? I would hope > that such a test could be updated once we implement the behavior defined in > the spec. It's theoretically possible with GCController.collect() but I've never been able to write a test with that successfully with JSC in the past. The test always ends up being either flaky or not functional. 1205853 4 webkit-bug-importer 2016-06-27 20:24:55 -0700 <rdar://problem/27046824> 1205854 5 rniwa 2016-06-27 20:26:05 -0700 Committed r202537: <http://trac.webkit.org/changeset/202537> 282047 2016-06-24 23:10:29 -0700 2016-06-26 20:15:37 -0700 Fixes the bug bug-159113-20160624231018.patch text/plain 1796 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjQ2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA2LTI0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERvbid0IGtlZXAgYWxsIG5ld2x5 IGNyZWF0ZWQgcG90ZW50aWFsIGN1c3RvbSBlbGVtZW50cyBhbGl2ZSB3aGVuIHRoZSBmZWF0dXJl IGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTkxMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEb24ndCBrZWVwIGFsbCBIVE1MIHVua25vd24gZWxlbWVudHMgd2hpY2ggaGFzIGEgdmFs aWQgY3VzdG9tIGVsZW1lbnQgYWxpdmUgd2hlbiB0aGUgZmVhdHVyZSBpcyB0dXJuZWQgb2ZmLgor ICAgICAgICBUaGUgY3VzdG9tIGVsZW1lbnRzIHNwZWMgaGFzIGFsc28gYmVlbiB1cGRhdGVkIHRv IG5vdCBkbyB0aGlzIGJ1dCB3ZSdsbCBpbXBsZW1lbnQgdGhhdCBiZWhhdmlvciBsYXRlci4KKwor ICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVIVE1M RWxlbWVudFdpdGhOYW1lVmFsaWRhdGlvbik6CisKIDIwMTYtMDYtMjQgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29uc2lkZXIgZXhwb3Npbmcgb3IgaGlkaW5n IGtub3dsZWRnZSBvZiBhIHJlZGlyZWN0IGZyb20gY2xpZW50cyBvZiBXZWJDb3JlTlNVUkxTZXNz aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDIwMjI2NCkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg5Niw3ICs4 OTYsOCBAQCBzdGF0aWMgUmVmUHRyPEVsZW1lbnQ+IGNyZWF0ZUhUTUxFbGVtZW50CiAgICAgUXVh bGlmaWVkTmFtZSBxdWFsaWZpZWROYW1lKG51bGxBdG9tLCBsb2NhbE5hbWUsIHhodG1sTmFtZXNw YWNlVVJJKTsKIAogI2lmIEVOQUJMRShDVVNUT01fRUxFTUVOVFMpCi0gICAgaWYgKERvY3VtZW50 Ojp2YWxpZGF0ZUN1c3RvbUVsZW1lbnROYW1lKGxvY2FsTmFtZSkgPT0gQ3VzdG9tRWxlbWVudE5h bWVWYWxpZGF0aW9uU3RhdHVzOjpWYWxpZCkgeworICAgIGlmIChSdW50aW1lRW5hYmxlZEZlYXR1 cmVzOjpzaGFyZWRGZWF0dXJlcygpLmN1c3RvbUVsZW1lbnRzRW5hYmxlZCgpCisgICAgICAgICYm IERvY3VtZW50Ojp2YWxpZGF0ZUN1c3RvbUVsZW1lbnROYW1lKGxvY2FsTmFtZSkgPT0gQ3VzdG9t RWxlbWVudE5hbWVWYWxpZGF0aW9uU3RhdHVzOjpWYWxpZCkgewogICAgICAgICBSZWY8SFRNTEVs ZW1lbnQ+IGVsZW1lbnQgPSBIVE1MRWxlbWVudDo6Y3JlYXRlKHF1YWxpZmllZE5hbWUsIGRvY3Vt ZW50KTsKICAgICAgICAgZWxlbWVudC0+c2V0SXNVbnJlc29sdmVkQ3VzdG9tRWxlbWVudCgpOwog ICAgICAgICBkb2N1bWVudC5lbnN1cmVDdXN0b21FbGVtZW50RGVmaW5pdGlvbnMoKS5hZGRVcGdy YWRlQ2FuZGlkYXRlKGVsZW1lbnQuZ2V0KCkpOwo=