159107 2016-06-24 16:41:13 -0700 MSE gets confused by in-band text tracks 2016-06-24 16:54:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble webkit-bug-importer oldest_to_newest 1205261 0 jer.noble 2016-06-24 16:41:13 -0700 MSE gets confused by in-band text tracks 1205262 1 jer.noble 2016-06-24 16:41:47 -0700 <rdar://problem/26871330> 1205263 2 webkit-bug-importer 2016-06-24 16:41:54 -0700 <rdar://problem/27007407> 1205267 3 282032 jer.noble 2016-06-24 16:46:07 -0700 Created attachment 282032 Patch 1205270 4 282032 eric.carlson 2016-06-24 16:48:25 -0700 Comment on attachment 282032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282032&action=review > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:620 > + // FIXME: Handle in-band text tracks. This should reference a bug. > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:686 > + // FIXME: We don't handle text tracks, and passing this sample up to SourceBuffer will just > + // confuse its state. Drop this sample until we can handle text tracks properly. Ditto. 1205273 5 jer.noble 2016-06-24 16:54:42 -0700 Committed r202462: <http://trac.webkit.org/changeset/202462> 282032 2016-06-24 16:46:07 -0700 2016-06-24 16:48:35 -0700 Patch bug-159107-20160624164555.patch text/plain 2594 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQzODcyYjhhNjQ5NDhm NmE3NDlkN2IyMjEyZmJkNGQxMWJiY2IyYS4uMTcyZmRmNDY4ZmYxOWY3NzUxNzBmNWU4MjUxNTJm YzQ1ZGQ3NzEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA2LTI0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE1TRSBnZXRzIGNvbmZ1c2Vk IGJ5IGluLWJhbmQgdGV4dCB0cmFja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1OTEwNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY4NzEzMzA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY2Fu J3QgY3VycmVudGx5IGhhbmRsZSB0ZXh0IHRyYWNrIHNhbXBsZXMgaW4gU291cmNlQnVmZmVyUHJp dmF0ZUFWRk9iakMsCisgICAgICAgIHNvIGRvbid0IHBhc3MgdGhlbSB1cCB0byBTb3VyY2VCdWZm ZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZl clByaXZhdGVBVkZPYmpDOjpkaWRQYXJzZVN0cmVhbURhdGFBc0Fzc2V0KToKKyAgICAgICAgKFdl YkNvcmU6OlNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjpwcm9jZXNzQ29kZWRGcmFtZSk6CisK IDIwMTYtMDYtMjEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAg Q29uc2lkZXIgZXhwb3Npbmcgb3IgaGlkaW5nIGtub3dsZWRnZSBvZiBhIHJlZGlyZWN0IGZyb20g Y2xpZW50cyBvZiBXZWJDb3JlTlNVUkxTZXNzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRl QVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDLm1tCmluZGV4IDMwMTFhMDVjNjJlZjY4 NzcyYjE2ZTdiMmM3MzEyNzUwNThlZjcwZjkuLmFhOTI3ZTMxZmY0NWIzYjY3YmNlYmVhZGI4ZjI0 OWYxZDU3MzU2ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1 ZmZlclByaXZhdGVBVkZPYmpDLm1tCkBAIC02MTYsNiArNjE2LDExIEBAIHZvaWQgU291cmNlQnVm ZmVyUHJpdmF0ZUFWRk9iakM6OmRpZFBhcnNlU3RyZWFtRGF0YUFzQXNzZXQoQVZBc3NldCogYXNz ZXQpCiAgICAgc2VnbWVudC5kdXJhdGlvbiA9IHRvTWVkaWFUaW1lKFttX2Fzc2V0IGR1cmF0aW9u XSk7CiAKICAgICBmb3IgKEFWQXNzZXRUcmFjayogdHJhY2sgaW4gW21fYXNzZXQgdHJhY2tzXSkg eworICAgICAgICBpZiAoW3RyYWNrIGhhc01lZGlhQ2hhcmFjdGVyaXN0aWM6QVZNZWRpYUNoYXJh Y3RlcmlzdGljTGVnaWJsZV0pIHsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgaW4tYmFu ZCB0ZXh0IHRyYWNrcy4KKyAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICB9CisKICAgICAg ICAgaWYgKFt0cmFjayBoYXNNZWRpYUNoYXJhY3RlcmlzdGljOkFWTWVkaWFDaGFyYWN0ZXJpc3Rp Y1Zpc3VhbF0pIHsKICAgICAgICAgICAgIFNvdXJjZUJ1ZmZlclByaXZhdGVDbGllbnQ6OkluaXRp YWxpemF0aW9uU2VnbWVudDo6VmlkZW9UcmFja0luZm9ybWF0aW9uIGluZm87CiAgICAgICAgICAg ICBSZWZQdHI8VmlkZW9UcmFja1ByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM+IHZpZGVvVHJhY2sg PSBWaWRlb1RyYWNrUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6Y3JlYXRlKHRyYWNrLCB0aGlz KTsKQEAgLTY3Niw2ICs2ODEsMTAgQEAgYm9vbCBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6 cHJvY2Vzc0NvZGVkRnJhbWUoaW50IHRyYWNrSUQsIENNU2FtcGxlQnVmZmVyUmUKICAgICAgICAg ICAgIGlmIChtX21lZGlhU291cmNlKQogICAgICAgICAgICAgICAgIG1fbWVkaWFTb3VyY2UtPnBs YXllcigpLT5zaXplQ2hhbmdlZCgpOwogICAgICAgICB9CisgICAgfSBlbHNlIGlmICghbV9hdWRp b1JlbmRlcmVycy5jb250YWlucyh0cmFja0lEKSkgeworICAgICAgICAvLyBGSVhNRTogV2UgZG9u J3QgaGFuZGxlIHRleHQgdHJhY2tzLCBhbmQgcGFzc2luZyB0aGlzIHNhbXBsZSB1cCB0byBTb3Vy Y2VCdWZmZXIgd2lsbCBqdXN0CisgICAgICAgIC8vIGNvbmZ1c2UgaXRzIHN0YXRlLiBEcm9wIHRo aXMgc2FtcGxlIHVudGlsIHdlIGNhbiBoYW5kbGUgdGV4dCB0cmFja3MgcHJvcGVybHkuCisgICAg ICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKIAo=