159104 2016-06-24 15:44:55 -0700 REGRESSION: Weak symbol warning when linking TestWebKitAPI 2016-06-25 12:08:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 158625 1 fpizlo fpizlo ddkilzer lforschler mitz oldest_to_newest 1205230 0 fpizlo 2016-06-24 15:44:55 -0700 Patch forthcoming. 1205231 1 282021 fpizlo 2016-06-24 15:45:51 -0700 Created attachment 282021 the patch 1205268 2 282021 mark.lam 2016-06-24 16:47:31 -0700 Comment on attachment 282021 the patch rs=me 1205271 3 fpizlo 2016-06-24 16:49:55 -0700 Landed in https://trac.webkit.org/changeset/202461 1205274 4 282021 mitz 2016-06-24 16:57:32 -0700 Comment on attachment 282021 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=282021&action=review > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > + OTHER_CPLUSPLUSFLAGS = ( > + "$(inherited)", > + "-ftemplate-depth=256", > + "-fvisibility=hidden", > + ); Build settings should go into TestWTFLibrary.xcconfig, not into the project file… > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > + OTHER_CPLUSPLUSFLAGS = ( > + "$(inherited)", > + "-ftemplate-depth=256", > + "-fvisibility=hidden", > + ); …so they don’t have to be repeated like this. 1205276 5 fpizlo 2016-06-24 16:58:23 -0700 (In reply to comment #4) > Comment on attachment 282021 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282021&action=review > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > > + OTHER_CPLUSPLUSFLAGS = ( > > + "$(inherited)", > > + "-ftemplate-depth=256", > > + "-fvisibility=hidden", > > + ); > > Build settings should go into TestWTFLibrary.xcconfig, not into the project > file… > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > > + OTHER_CPLUSPLUSFLAGS = ( > > + "$(inherited)", > > + "-ftemplate-depth=256", > > + "-fvisibility=hidden", > > + ); > > …so they don’t have to be repeated like this. You're right. I should have remembered this. 1205277 6 fpizlo 2016-06-24 17:01:43 -0700 (In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 282021 [details] > > the patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=282021&action=review > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > > > + OTHER_CPLUSPLUSFLAGS = ( > > > + "$(inherited)", > > > + "-ftemplate-depth=256", > > > + "-fvisibility=hidden", > > > + ); > > > > Build settings should go into TestWTFLibrary.xcconfig, not into the project > > file… > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > > > + OTHER_CPLUSPLUSFLAGS = ( > > > + "$(inherited)", > > > + "-ftemplate-depth=256", > > > + "-fvisibility=hidden", > > > + ); > > > > …so they don’t have to be repeated like this. > > You're right. I should have remembered this. Actually, it appears that everywhere else, we set this option in the project.pbxproj. But we do it differently. I'll upload a patch. 1205386 7 fpizlo 2016-06-25 11:51:30 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Comment on attachment 282021 [details] > > > the patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=282021&action=review > > > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > > > > + OTHER_CPLUSPLUSFLAGS = ( > > > > + "$(inherited)", > > > > + "-ftemplate-depth=256", > > > > + "-fvisibility=hidden", > > > > + ); > > > > > > Build settings should go into TestWTFLibrary.xcconfig, not into the project > > > file… > > > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > > > > + OTHER_CPLUSPLUSFLAGS = ( > > > > + "$(inherited)", > > > > + "-ftemplate-depth=256", > > > > + "-fvisibility=hidden", > > > > + ); > > > > > > …so they don’t have to be repeated like this. > > > > You're right. I should have remembered this. > > Actually, it appears that everywhere else, we set this option in the > project.pbxproj. But we do it differently. I'll upload a patch. Wrong again! The xcconfig option is: GCC_SYMBOLS_PRIVATE_EXTERN = YES; 1205389 8 282081 fpizlo 2016-06-25 12:03:57 -0700 Created attachment 282081 the patch 1205390 9 fpizlo 2016-06-25 12:08:09 -0700 Landed in https://trac.webkit.org/changeset/202469 282021 2016-06-24 15:45:51 -0700 2016-06-25 12:03:57 -0700 the patch blah.patch text/plain 1626 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjQ1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA2LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTjogV2VhayBzeW1ib2wgd2FybmluZyB3aGVuIGxpbmtpbmcgVGVz dFdlYktpdEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU5MTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IHRoZSB0ZXN0cyB3ZXJlIG5vdCBjb21waWxl ZCB3aXRoIC1mdmlzaWJpbGl0eT1oaWRkZW4gbGlrZSB0aGUgcmVzdCBvZgorICAgICAgICBXSy4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVj dC5wYnhwcm9qOgorCiAyMDE2LTA2LTI0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5j b20+CiAKICAgICAgICAgcGFyc2VyX3VuaXR0ZXN0cy5wbCBzaG91bGQgbm90IGhhcmRjb2RlIGxp c3Qgb2YgdGVzdHMKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29k ZXByb2ovcHJvamVjdC5wYnhwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCShyZXZpc2lvbiAyMDI0MDYp CisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagkod29ya2luZyBjb3B5KQpAQCAtMjMzMiw2ICsyMzMyLDExIEBACiAJCQlpc2EgPSBY Q0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJhc2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0gN0M4 M0UwMjcxRDBBNUI4RDAwRkVCQ0YzIC8qIFRlc3RXVEZMaWJyYXJ5LnhjY29uZmlnICovOwogCQkJ YnVpbGRTZXR0aW5ncyA9IHsKKwkJCQlPVEhFUl9DUExVU1BMVVNGTEFHUyA9ICgKKwkJCQkJIiQo aW5oZXJpdGVkKSIsCisJCQkJCSItZnRlbXBsYXRlLWRlcHRoPTI1NiIsCisJCQkJCSItZnZpc2li aWxpdHk9aGlkZGVuIiwKKwkJCQkpOwogCQkJfTsKIAkJCW5hbWUgPSBEZWJ1ZzsKIAkJfTsKQEAg LTIzMzksNiArMjM0NCwxMSBAQAogCQkJaXNhID0gWENCdWlsZENvbmZpZ3VyYXRpb247CiAJCQli YXNlQ29uZmlndXJhdGlvblJlZmVyZW5jZSA9IDdDODNFMDI3MUQwQTVCOEQwMEZFQkNGMyAvKiBU ZXN0V1RGTGlicmFyeS54Y2NvbmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7CisJCQkJT1RI RVJfQ1BMVVNQTFVTRkxBR1MgPSAoCisJCQkJCSIkKGluaGVyaXRlZCkiLAorCQkJCQkiLWZ0ZW1w bGF0ZS1kZXB0aD0yNTYiLAorCQkJCQkiLWZ2aXNpYmlsaXR5PWhpZGRlbiIsCisJCQkJKTsKIAkJ CX07CiAJCQluYW1lID0gUmVsZWFzZTsKIAkJfTsK 282081 2016-06-25 12:03:57 -0700 2016-06-25 12:05:33 -0700 the patch blah.patch text/plain 2746 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjQ2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE2LTA2LTI1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTjogV2VhayBzeW1ib2wgd2FybmluZyB3aGVuIGxpbmtpbmcgVGVz dFdlYktpdEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU5MTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBUaGlzIHVzZXMgYSBiZXR0ZXIgYXBwcm9hY2ggdG8gdHVybiBvbiAtZnZpc2ls aXR5PWhpZGRlbi4gQWxsIG9mIHRoZSBvdGhlciBwcm9qZWN0cyBzZXQKKyAgICAgICAgdGhpcyBm bGFnIGluIHhjY29uZmlnLCB1c2luZyAiR0NDX1NZTUJPTFNfUFJJVkFURV9FWFRFUk4gPSBZRVM7 Ii4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdURkxpYnJh cnkueGNjb25maWc6IFVzZSBHQ0NfU1lNQk9MU19QUklWQVRFX0VYVEVSTiBoZXJlLgorICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSUxpYnJhcnkueGNj b25maWc6IFVzZSBHQ0NfU1lNQk9MU19QUklWQVRFX0VYVEVSTiBoZXJlLgorICAgICAgICAqIFRl c3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBSZXZl cnQgcjIwMjQ2MS4KKwogMjAxNi0wNi0yNSAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dpbl0gVGhlIHRlc3QgZmFzdC9ldmVudHMvd2hlZWwtZXZlbnQt ZGVzdHJveXMtZnJhbWUuaHRtbCBpcyB0aW1pbmcgb3V0LgpJbmRleDogVG9vbHMvVGVzdFdlYktp dEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V1RGTGlicmFyeS54Y2NvbmZpZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXVEZMaWJyYXJ5LnhjY29u ZmlnCShyZXZpc2lvbiAyMDI0NjMpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRp b25zL1Rlc3RXVEZMaWJyYXJ5LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0yNywzICsyNyw0 IEBACiAKIFBST0RVQ1RfTkFNRSA9IFRlc3RXVEY7CiBTS0lQX0lOU1RBTEwgPSBZRVM7CitHQ0Nf U1lNQk9MU19QUklWQVRFX0VYVEVSTiA9IFlFUzsKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkv Q29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSUxpYnJhcnkueGNjb25maWcKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJTGlicmFy eS54Y2NvbmZpZwkocmV2aXNpb24gMjAyNDYzKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9Db25m aWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJTGlicmFyeS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpA QCAtMjcsMyArMjcsNCBAQAogCiBQUk9EVUNUX05BTUUgPSBUZXN0V2ViS2l0QVBJOwogU0tJUF9J TlNUQUxMID0gWUVTOworR0NDX1NZTUJPTFNfUFJJVkFURV9FWFRFUk4gPSBZRVM7CkluZGV4OiBU b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv ago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVw cm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24gMjAyNDYzKQorKysgVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29w eSkKQEAgLTIzMzIsMTEgKzIzMzIsNiBAQAogCQkJaXNhID0gWENCdWlsZENvbmZpZ3VyYXRpb247 CiAJCQliYXNlQ29uZmlndXJhdGlvblJlZmVyZW5jZSA9IDdDODNFMDI3MUQwQTVCOEQwMEZFQkNG MyAvKiBUZXN0V1RGTGlicmFyeS54Y2NvbmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7Ci0J CQkJT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAoCi0JCQkJCSIkKGluaGVyaXRlZCkiLAotCQkJCQki LWZ0ZW1wbGF0ZS1kZXB0aD0yNTYiLAotCQkJCQkiLWZ2aXNpYmlsaXR5PWhpZGRlbiIsCi0JCQkJ KTsKIAkJCX07CiAJCQluYW1lID0gRGVidWc7CiAJCX07CkBAIC0yMzQ0LDExICsyMzM5LDYgQEAK IAkJCWlzYSA9IFhDQnVpbGRDb25maWd1cmF0aW9uOwogCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZl cmVuY2UgPSA3QzgzRTAyNzFEMEE1QjhEMDBGRUJDRjMgLyogVGVzdFdURkxpYnJhcnkueGNjb25m aWcgKi87CiAJCQlidWlsZFNldHRpbmdzID0gewotCQkJCU9USEVSX0NQTFVTUExVU0ZMQUdTID0g KAotCQkJCQkiJChpbmhlcml0ZWQpIiwKLQkJCQkJIi1mdGVtcGxhdGUtZGVwdGg9MjU2IiwKLQkJ CQkJIi1mdmlzaWJpbGl0eT1oaWRkZW4iLAotCQkJCSk7CiAJCQl9OwogCQkJbmFtZSA9IFJlbGVh c2U7CiAJCX07Cg==